Howdy everyone!
In an attempt to continue to make it simpler for everyone to contribute, if you could please help out by filling this Contributor Experience Survey posted in make/community by Jen Mylo, it’d be appreciated.
Thanks!
Recent Updates Toggle Comment Threads | Keyboard Shortcuts
-
Mike Schroder
-
Mike Schroder
Last Week in WordPress Core
Hello there! This is Last Week in WordPress Core for the week of April 15-April 23. Happy release week, everyone! WordPress 3.9 “Smith” was released last Wednesday! Due to that, fewer commits this week. With a 3.9.1 maintenance release expected this week, changes up to tonight are included below.
Widgets
- Ensure widgets stay with themes during a theme switch. See [28124]. [28161] #27897
- Run
WP_Editors::enqueue_scripts()onadmin_print_footer_scriptspriority 1 (later), instead ofadmin_footer. Fixes incompatibility with the customizer. [28187] #27853 - Remove
create_function()from the customizer class to improve HHVM compatibility. [28143] #27805
Theme Installer
- Restore
.ziptheme installation by castingwp_count_attachments()before iterating it to avoid a notice when items exist without a mime type. [28139] #27802 - Prevent customizer header image list from listing user images twice when no theme-specified images exist. [28152] #27839
- Improved URL routing. [28141] [28147] #27055
- Proper redirection and action links post-install in multisite. [28163] #27869
TinyMCE
- Update the TinyMCE tests to 4.0.21.1. [28138] #27744
- Fix icons in IE7. [28142] #27829
- Restore
wordpress_adv_hiddeneditor parameter to enable force-showing the kitchen sink. [28181] #27963 - Shrink the font size for the selected item in “Format” dropdown so that it fits in more locales. [28180] #27903
- Fix the
activestate of the Link button when an image wrapped in a link is selected. [28185] #27847 - Don’t trigger the drag-and-drop uploader when selected test is being dragged from one window to another. [28189] #27880
- Correct positioning when adding a caption to an image that is in a paragraph with other text. [28190] #27922
- Update the “paste” plugin to the latest development version to fix: [28192] #27909 #27771
- Correct pasting of Excel tables.
- Leave TOC Anchors intact during paste.
Playlists
- Improve styling and fix RTL for playlists. [28172] [28174] #27923; [28173] #27924
- Alter the layout of the checkboxes in the modal view for Audio/Video Details to allow translations more room to breathe. [28184] #27893
- Graceful failures for TinyMCE views of video/audio playlists. [28144] #27821
- Add a compatibility layer in wp-playlist.js to avoid VM errors from MediaElement’s plugin bridge in the TinyMCE views to whitelist file types for native playback. [28171] #27892
- Refinements for asynchronous rendering in
wp.mce.media.PlaylistView. [28182] #27899 - Keep
<tracks>from being filtered out when switching between visual and text editors. [28183] #27915 - Hide extra tracks field in media modal when adding subtitles. [28169] #27915
Internals
- Avoid a PHP warning during theme background-update checks when there are multiple theme directories registered. [28137] #27815
- Properly gray out text fields when they are disabled or when they have the
disabledclass. [28179] #27906 - Avoid counting all attachments when entering the post|page edit screens. [28191] #27985
Thanks to @avryl, @azaozz, @bobbingwide, @celloexpressions, @dimadin, @feedmeastraycat, @gcorne, @helen, @jjeaton, @johnbillion, @kworthington, @lancewillett, @mcsf, @melchoyce, @nacin, @netweb, @ocean90, @SergeyBiryukov, @smashcut, @westonruter and @wonderboymusic for their help this week!
For the complete list of commits to trunk, check out the log on Trac. We started talking about 4.0 plans this week in the weekly dev meeting. Come chat next Wednesday to continue the discussion, and note if you encounter issues with the new release on trac.
-
shaunandrews
Remember the Media Grid project? It was original proposed back in the 3.7/3.8 cycle but never really took off — mainly due to our focus on The-Project-Formerly-Known-As-MP6 and the Widget team.
Since then, I’ve been working on a plugin in some spare time: http://wordpress.org/plugins/media-grid/
Its messy. Its basic. But I think there’s potential in the idea to bring the media modal’s layout to the Media Library. @helen created a GitHub repo for development: https://github.com/helenhousandi/wp-media-grid-view (Make sure you checkout the issues, especially: https://github.com/helenhousandi/wp-media-grid-view/issues/7)
I’m looking to form a team to work on this project. I think we could have something ready for 4.0, but 4.1 is a possibility as well. It all depends on you.
I’m looking for any-and-all help, but specifically 1-2 backbone-capable developers with familiarity with the Media Modal would be a huge help.
Maybe we can chat about this a bit during tomorrow’s Dev Chat. Outside of that, lets plan on meeting in #wordpress-ui this Friday, Apr 25 @ 16:00 UTC.
So, are you interested? Leave a comment below and/or join us on Friday. Thanks!
-
Casey Driscoll
I volunteer as tribute!
Not sure how I can assist, but this is my first contribution to core and I’d love to help how I can.
I’ll be there in irc Friday.
-
Jose Castaneda
I’m not too strong with BB but would love to get my feet wet and help out.
-
Jeff Chandler
Is MP6 still a requirement in order to use the plugin?
-
shaunandrews
Nope, just haven’t updated the read me.
-
-
Till Krüss
I know my way around Backbone and would love to join.
-
Justin Kopepasah
Sounds like a great project and I’d love to be involved. I’ll be in the IRC on Friday.
-
Lachlan MacPherson
The plugin looks awesome and the search is super responsive. I also love the idea of collections, and being able to tag media. The term collections sounds much better than the old folder metaphor too.
-
klihelp
I would like to be involved in this project.
-
-
Jen Mylo
GSoC students announced! http://make.wordpress.org/community/2014/04/21/gsoc-students-accepted/
(core projects are the minority this year, which is why I posted over on the community site under mentorship programs)
-
Andrew Nacin
Congratulations to @avryl and @celloexpressions.
Two very interesting projects! -
Gautam Gupta
Yay!
-
-
Andrew Nacin
Let’s have a meeting in #wordpress-dev on April 21, 2014 18:00 UTC, to discuss WordPress 3.9.1 and triage those tickets. As preparation for the meeting:
Reception has been overwhelmingly positive and, anecdotally at least, we’ve seen more issues as they relate to deliberately changed aspects (TinyMCE/editing) versus generic plugin breakage. I think we’re in pretty good shape based on the bug reports that have come in, but with automatic updates at our disposal, there’s no reason to wait three or four weeks before shipping 3.9.1.
I think we should try to fix the big, obvious stuff by Tuesday and release 3.9.1 as early as Wednesday. Some of the reported issues are pretty core to TinyMCE 4.0 and the various rewrites it triggered (like image editing), which means many of them won’t be handled by 3.9.1. That’s quite OK, especially since some of these may require some upstream fixes in TinyMCE, and since there can always be a 3.9.2 in the weeks ahead.
What I do want to do is have no “unknowns” — we should know exactly what regressed or otherwise is broken, under what circumstances, how major or minor it is, how high or low of a priority it should be, etc. That includes unit tests (if applicable) or at least clear test cases.
cc @azaozz @helen @wonderboymusic @gcorne @avryl @mcsf @ehg @jeremyfelt @ocean90 @westonruter
-
Andrew Nacin
If you’re able to look through tickets in your domain ahead of the meeting that would make it go pretty quick, and we can cover them really at any point during the day (I’ll be around all day), I just wanted to make sure the ball gets rolling.
-
Weston Ruter
-
-
Weston Ruter
Live Widget Previews: Widget Management in the Customizer in WordPress 3.9
The WordPress 3.9 release includes widget management in the Customizer: previewing changes to widget areas before publishing them live for the world to see. This feature was birthed out of the Widget Customizer plugin which started development in the 3.8 release cycle, it was formally proposed for merging into core at the start of the 3.9 release cycle, and then it was merged and followed by many changes. I wanted to follow-up here to talk through the changes to Widget Customizer since it was initially proposed (read this post for a full overview of the feature). Here is what has changed since then:
No more opt-in for theme support
The Widget Customizer plugin implemented a mechanism for doing fast live widget previews. By default, all changes made to settings in the customizer cause the preview window to do a full page refresh. This causes a lag between when you make a change and when the change appears. The customizer also supports an alternate non-refresh mechanism for previewing changes in the customizer (the postMessage transport) which you often see themes implement for live-previewing the blog name or the header color.
Implementing such immediate live-previews requires all of the logic for previewing the change to be implemented in JavaScript, in addition to the underlying PHP logic for rendering the change when the setting is saved. This is not possible for widgets, since they all use PHP to handle the sanitization of the form inputs and for rendering arbitrary content that a widget may contain. (You’ll notice that when you make a change to a widget in the customizer, it actually does an Ajax request to submit the widget form for sanitization every time.) Well, to get around having the customizer preview refresh for every widget change, we implemented an Ajax renderer for the widgets, and then used the postMessage transport to initiate this widget render request, and then the rendered widget response would get swapped out in the DOM.
Long story short, we decided to remove this feature to use postMessage for faster live previews. We have created #27355 to re-add this feature, but to generalize it so that any customizer control can take advantage of doing these partial preview refreshes. So for now, you’ll have to wait a moment for the preview to refresh when you make a change to a widget area, but now you don’t change your themes or widgets to add explicit support for Widget Customizer.
No more Update button (usually)
Widget forms on the admin page have a familiar Save button. In previous versions of Widget Customizer, we adapted the Save button to be an Update button, since it wouldn’t actually save the widget but would just update the preview with the widget’s latest state. Having to click this Update button to see the preview update, however, was a poor user experience and was unnecessary. Therefore, we implemented a means of submitting the form to update the widget’s state in the preview whenever a field in the control is updated: the Update button was hidden and the spinner appears when a change is being synced to the preview.
The logic which does this live submission of the widget form as you interact with it, depends on the fields in the widget form to be the same fields which get returned when the widget form is sanitized. This is so that the fields can be aligned for being updated with their sanitized values. We couldn’t go the route of the widget forms on the widgets admin page, which actually get fully replaced with the newly-sanitized form, because this would interfere with the user quickly inputting into these fields.
So if a widget form dynamically adds or changes which input fields are included, the live-as-you-type-them updates will stop and the Update button will re-appear. When you click this button, the form will replace itself with the sanitized version just like on the widgets admin page. We also introduced new jQuery events to help handle these form changes…
New widget-added and widget-updated jQuery events
In the widgets admin page, when you add a new widget to a widget area, a widget template element gets cloned and then inserted into the selected widget area. This widget template is cloned in a way that any event handlers initially added to the widget template do not persist on any newly-added widgets. Any widgets previously-added to the widget areas would have these event handlers attached, as well as any dynamically-created fields (e.g. jQuery Chosen), but again, newly-added widgets fail to retain these. The same problem exists, however, whenever you update a widget: since the newly-sanitized widget form replaces the old one, any dynamic elements get lost. (This is why event delegation is often required.)
The same challenges here for the widgets admin page are also challenges for widgets in the customizer. And so in #19675 and #27491, we’ve introduced
widget-addedandwidget-updatedjQuery events which pass along the widget container as the second argument for the event handler. So to initialize and re-initialize a widget’s dynamic UI, you can now use these events in something like this:jQuery( function ( $ ) { function init( widget_el, is_cloned ) { // Clean up from the clone which lost all events and data if ( is_cloned ) { widget_el.find( '.chosen-container' ).remove(); } widget_el.find( 'select.dynamic-field-chosen-select' ).chosen( { width: '100%' } ); } /** * <a href='http://profiles.wordpress.org/param' class='mention'>@param</a> {jQuery.Event} e * <a href='http://profiles.wordpress.org/param' class='mention'>@param</a> {jQuery} widget_el */ function on_form_update( e, widget_el ) { if ( 'dynamic_fields_test' === widget_el.find( 'input[name="id_base"]' ).val() ) { init( widget_el, 'widget-added' === e.type ); } } $( document ).on( 'widget-updated', on_form_update ); $( document ).on( 'widget-added', on_form_update ); $( '.widget:has(.dynamic-field-chosen-select)' ).each( function () { init( $( this ) ); } ); } );This is admittedly still not ideal, but it is much better than hacking the jQuery Ajax events to detect when a form update happens. In the future, I’m keen to see the widgets be revamped to use Backbone extensively.
Configuring widgets during a theme switch
We had a surprise late in the release (#27767) when it was reported that when you activate a new theme via the customizer, any changes made to the widget areas get lost when the theme is activated. This issue has been fixed, so now you can preview a theme and fully configure all of the widget areas before going live.
Beware of widgets and caching
We had another challenge in #27538 where widget changes previewed in the customizer would leak outside the preview and on the live site if the widget cached the output for performance. The core widgets Recent Posts and Recent Comments both cache their outputs in the object cache, and if a persistent object cache plugin is enabled (e.g. Memcached or APC) then the cache would get poisoned with the previewed widget, even though the widget’s changes weren’t saved. The same behavior would be experienced for widgets that use transients to cache the rendered output.
To help widgets do the right thing in regards to caching, we introduced a
WP_Widget::is_preview()method which widgets should always check before they interact with the cache. For example, a widget’swidget()method which caches its output should do something like this:if ( ! $this->is_preview() ) { $cached = wp_cache_get( 'foo-widget' ); if ( ! empty( $cached ) ) { echo $cached; return; } ob_start(); } extract( $args ); echo $before_widget; // ... echo $after_widget; if ( ! $this->is_preview() ) { $cached = ob_get_flush(); wp_cache_set( 'foo-widget', $cached ); }
Look forward to more improvements to widgets and the customizer in future releases!
-
PeterRKnight
Just an awesome release. The partial refresh works like magic.
-
Yiorgos Theo
How can Widget Management in the Customizer be disabled?
-
Yiorgos Theo
I mean disable it in a theme
-
Weston Ruter
@hellas1: Why would you need it to be disabled?
-
-
-
Dominik Schilling (ocean90)
Dashicons in WordPress 3.9
WordPress 3.8 has introduced an icon font for the WordPress admin, named Dashicons. Dashicons includes 167 icons until now.
WordPress 3.9 includes 30 new fresh and clean icons. Thanks to all contributors to ticket #26936, especially @melchoyce and @empireoflight.Media Icons
All media file type icons got a huge facelift, see #26936. There are also two new icons for the playlists feature.
Icon CSS Class Code dashicons-media-archivef501dashicons-media-audiof500dashicons-media-codef499dashicons-media-defaultf498dashicons-media-documentf497dashicons-media-interactivef496dashicons-media-spreadsheetf495dashicons-media-textf491dashicons-media-videof490dashicons-playlist-audiof492dashicons-playlist-videof493TinyMCE/Editor
With the update to TinyMCE 4.0 you can now use four new icons for editor related UI.
Icon CSS Class Code dashicons-editor-contractf506dashicons-editor-breakf464dashicons-editor-codef475dashicons-editor-paragraphf476Sorting
Use
dashicons-externalfor external uses or randomize a list withdashicons-randomize.Icon CSS Class Code dashicons-externalf504dashicons-randomizef503WPorg specific: Jobs, Profiles, WordCamps
We all WordCamps.
Icon CSS Class Code dashicons-universal-accessf483dashicons-universal-access-altf507dashicons-ticketsf486dashicons-nametagf484dashicons-clipboardf481dashicons-heartf487dashicons-megaphonef488dashicons-schedulef489Widgets
Have you already tried the live widget previews? You should. The following icons are created for this feature.
Icon CSS Class Code dashicons-archivef478dashicons-tagcloudf479dashicons-textf480Alerts/Notifications/Flags
The minus icon has an alternative icon, plus now too. Welcome.
Icon CSS Class Code dashicons-plus-altf502Misc/CPT
End of .
Icon CSS Class Code dashicons-microphonef482To get a complete overview of all icons please visit http://melchoyce.github.io/dashicons/.
-
Frankie Jarrett
Very nice! Great work, everyone. Was keeping my fingers crossed for a “print” icon, maybe next time
-
helgatheviking
Agree, great work! I’ll throw my 2 cents in for a “move” icon that approximates the move cursor.
-
Mel Choyce
Something like this?
-
-
Najeeb
You guys are making developers life like butterfly ;). I am flying with my team and enjoying developing themes and plugins.
-
Frank
You find also a list of dashicons and how to inside a plugin, write for developers.
https://github.com/bueltge/WordPress-Admin-Style -
Mr. Vibe
Great work, much needed Thanks !
-
sourceforge
media-text, media-document, media-spreadsheet could use a bit clear identifying marks, like say media-text can have letters ‘txt’, also dashicons-text and dash-tag-cloud, not a design guy, just something that can use little improvement, if no please safely ignore
-
Abhishek Ghosh
-
Michael Beil
Great work on these guys!
-
-
Andrew Nacin
jQuery UI and wpdialogs in WordPress 3.9
WordPress 3.9 does not use the “wpdialogs” TinyMCE plugin as part of the TinyMCE 4.0 update ( #16284, #24067), which comes with a new dialog manager. (For more, see this post and their migration guide.) This was a jQuery UI wrapper we had introduced back in WP 3.1. If you were using this in your own scripts, please be sure you are setting “wpdialogs” as a script dependency.
If you were using jQuery UI for anything on the post screen, please be sure you are setting this as a script dependency.
In both cases you may need to enqueue the “wp-jquery-ui-dialog” stylesheet, if you are using the WP UI dialog design.
-
Jeremy Felt
Multisite Changes in 3.9
Much of the bootstrap code for Multisite in ms-settings.php has been refactored in #27003 with the intent to improve how we handle the detection of domains and paths for sites and networks in core. Several other smaller enhancements and bugs have been completed in this and in other tickets.
How networks and sites are found
In the most common multisite scenario, the network finding process is the same. The constants
DOMAIN_CURRENT_SITEandPATH_CURRENT_SITEin your wp-config.php define the network to be loaded by WordPress. In the large majority of installations there is only one network.The default process for finding the requested site now goes through a new function,
get_site_by_path(). See the new functions section below for more details.If you use a sunrise file—likely through a domain mapping or multi-network plugin—and the
$current_siteand$current_blogglobals are configured there through a custom network and site detection process, the finding portions of ms-settings.php will continue to be skipped entirely. Nothing changes.In some (very) rare scenarios, multiple networks may be configured in WordPress without a sunrise file. It is here where both the site and network finding process has been altered to use new functions rather than the stream of bootstrap code.
Deprecated Functions
There are two deprecated functions that may appear in your sunrise or in plugins to watch out for. Both of these were intended for private use by core, but came in handy as helpers to hack around various bits and pieces of the load process.
wpmu_current_site()is deprecated. It was previously used to find the network and site information for a request. All functionality has been removed from this in favor of replacement functions. In its current form, it returns the $current_site global.get_current_site_name()is deprecated. It was previously used to set the site_name property on a given $current_site object. In its current form, it returns the passed $current_site object. This will likely not break anything, but any code relying on retrieving a site name using this function should be modified to use get_current_site() instead.New Functions
Three new functions have been added to ms-load.php in 3.9 development. All of these have the focus of making sites and networks easier to find. These are meant to be public replacements for the previously private and somewhat inaccessible logic that existed in the bootstrap.
wp_get_network()retrieves an object containing the network’s information from the database when passed a network ID.get_site_by_path()retrieves a site object when passed a domain and path. Two new filters are available here.get_network_by_path()retrieves a network object when passed a domain and path. Two new filters are available here as well.New Filters
Inside the new site and network finding functions are a few filters that go a long way in providing for a less hacky sunrise.php file in the future. These can be used to shape the multisite bootstrap process without entirely replacing the logic.
site_by_path_segments_countfires inget_site_by_path()and sets the number of possible path segments a site may have when we’re searching for it.pre_get_site_by_pathfires inget_site_by_path()and allows you to short-circuit core’s default logic for finding a site.network_by_path_segments_countfires inget_network_by_path()and sets the number of possible path segments a network may have when we’re searching for it.pre_get_network_by_pathfires inget_network_by_path()and allows you to short-circuit core’s default logic for finding a network.Ongoing
It’s exciting to see some of the progress we’re making around multisite. We’d like to see what can be solved or broken with the new filters. More future improvements will be made around this and we want to make sure the base is right.
Also take a look at the multisite focused tickets closed as fixed for 3.9. There are several other improvements and bug fixes that are worth taking a look at.
See #25348 for autocompleting users when adding a new site. See #20601 for proper 404 handling of non member author archives. See #24178 for past confusion with a plugin that is activated on the network and locally.
Thanks all!
-
Ryan McCue
In the most common multisite scenario, the network finding process is the same. The constants
DOMAIN_CURRENT_SITEandPATH_CURRENT_SITEin your wp-config.php define the network to be loaded by WordPress. In the large majority of installations there is only one network.It’s worth emphasising: these constants refer to your network, not the site;
get_site_by_path, however, refers to the site. (This is an artifact of the blog/site naming convention that’s being replaced with site/network.) -
bvl
Great news, although I am a little disappointed that https://core.trac.wordpress.org/ticket/19722 still isn’t fixed, maybe in the next release?
-
rclilly
Jeremy, Thanks for all work you’ve into improving multisite!
-
David
I upgraded my multisite to 3.9 and this issue has occured….http://wordpress.stackexchange.com/questions/141578/3-9-breaks-multisite.
Seems to be a bug of some sort as others are having the same issues. Looks to be a redirect issue of some sort. -
lborgman
Many thanks for all the work with multisite!
Here is however another issue that people coming here for information might be interested in:
Solved: WP Multisite Stuck in Redirect Loop After 3.9 Upgrade http://www.webhostinghero.com/wp-multisite-stuck-in-redirect-loop/
-
Ipstenu (Mika Epstein)
That’s a poor choice of fixes, when a simple .htaccess redirect to force NON www will work fine (I don’t recommend using www on a Multisite as the default in general, and WP actually suggests you not do so at all when you’re installing, so I wouldn’t think that a fix that says to use it is the best call). Not to mention that how-to didn’t change the rest of the DB, which it should for consistency across the board. If you’re not using www in your site, a much easier fix is this:
RewriteEngine On RewriteBase / RewriteCond %{HTTP_HOST} ^www\.(.*)$ [NC] RewriteRule ^(.*)$ http://%1/$1 [R=301,L]Just added that to my site and it’s better. However I made a trac for this, since www should not be treated as a subdomain. It’s special.
-
mfigrs
Thank you, Mika,
I was looking for this exact solution.
-
-
-
-
Andrew Nacin
Let’s have a meeting today, Tuesday April 15, 2014, 18:00 UTC, to make sure we have everything in place for a release. (#wordpress-dev)
klihelp, 
Reply
You must be logged in to post a comment.