WordPress.org

Make WordPress Core

Tagged: dev chat Toggle Comment Threads | Keyboard Shortcuts

  • Jeffrey Paul 9:46 pm on November 17, 2016 Permalink |
    Tags: , dev chat,   

    Dev Chat Summary: November 16 (4.7 week 13) 

    This post summarizes the dev chat meeting from November 16th (agendaSlack archive).

    Reminders

    • Dev Chat timing: Weekly chat has been moved to 21:00 UTC.
    • Schedule: Thursday, November 17th is the target for RC! RC means the list of tickets should be at zero (with the exception of the about page), as a release candidate is supposed to represent software you believe you can release. It is currently at 24.
    • Tickets:For any tickets you’ve moved into the milestone, please get these resolved in the next day.
    • Dev Notes: These should all be published this week, with a collective Field Guide forthcoming from @jorbin.

    Dev Notes / Field Guide for 4.7

    • There are a few outstanding Dev Notes, but it’s getting close. We’re waiting on the Customize summary from @celloexpressions, Media summary from @joemcgill, Starter Content from @helen, and @davidakennedy is finishing up one on Twenty Seventeen.
      • Media summary is ready to publish, was just waiting on the PDF post from Tuesday, November 15th.
      • Video Headers post could be done by @bradyvercher, but @joemcgill own making sure it happens
    • @jorbin started drafting the Field Guide, but he’s going to need to hand off finishing it off since he will be offline starting Thursday, November 17th for a week.
      • @adamsilverstein and @jbpaul17 will work to finish things up
      • @jorbin to coordinate with Adam and Jeff to sure the remaining tasks are sorted out
      • @ipstenu happy to proofread for typos and grammar.
    • @jorbin also started the discussion to ensure the email to plugin devs goes out after the Field Guide is published.  That’s a collaboration with the meta team and the pluginsrepo team.

    Release Candidate

    • @helen (thankfully) was able to move RC back from Tuesday, November 15th to Thursday, November 17th.
    • However, we’ve got 23 tickets hanging out in the report, 22 of which need to be resolved or punted in order to reach RC.
    • [Bug Scrub of remaining 4.7 tickets proceeded]
     
  • Helen Hou-Sandi 7:02 pm on November 16, 2016 Permalink |
    Tags: , , dev chat   

    Dev Chat Agenda for November 16 (4.7 week 13) 

    This is the agenda for the weekly dev meeting on November 16, 2016 at 21:00 UTC:

    • Meeting reminder: Weekly chat has been moved one hour later to 21:00UTC.
    • Schedule reminder: Tomorrow is the target for RC! RC means the list of tickets should be at zero (with the exception of the about page), as a release candidate is supposed to represent software you believe you can release. It is currently at 24.
    • Ticket reminder: For any tickets you’ve moved into the milestone, please get these resolved in the next day.
    • Dev notes:  These should all be published this week, with a collective field guide forthcoming from @aaronjorbin.
    • Getting ready for RC with a 4.7 open ticket scrub

    If you have anything to propose to add to the agenda or specific items related to the above, please leave a comment below. See you there!

     
  • Jeffrey Paul 2:30 am on November 11, 2016 Permalink |
    Tags: , dev chat,   

    Dev Chat Summary: November 9 (4.7 week 12) 

    This post summarizes the dev chat meeting from November 9th (Slack archive).

    Reminders

    • Dev Chat timing: The Chat remains at 20:00 UTC.  Daylight Savings Time means that 20:00 UTC may be a different time for you already, or it may be a different time soon. However, next week we will be at 21:00 UTC.
    • Schedule: Today is the target for Beta 3! That leaves us one week until the Release Candidate, where the list of tickets must be at zero. It is currently at 32, down from 74 last week.
    • Tickets: For any tickets you’ve moved into the milestone, please make sure these are active tickets, with some kind of activity every day.
    • Bug Scrubs: @helen is running regular scrubs this week.
    • Dev Notes:  These will be compiled into the field guide this weekend.

    Bug Scrubs

    • Would like to see near daily scrubs for now until RC of report 6 and of the “Defects Awaiting Review, reported against trunk” section of report 40
    • @helen, @jorbin, and @jbpaul17 are all trying to run scrubs just about everyday, but everyone should also be scrubbing
    • Media, REST API, and Customizer component teams are all actively running scrubs as well

    Dev Notes / Field Guide for 4.7

    Beta 3

    • Likely to go out on Thursday morning instead of today, although given time zones and such we should operate on “it’s happening today” anyway
    • We are at 32 open tickets. Would love to see us get down to 20.
    • Work/tickets that folks would ideally like to resolve for Beta 3:
      • #38522: HTTP Errors on Upload with Certain PDFs
      • #38726: REST API: `unfiltered_html` and slashing: terms
      • #38672: Custom CSS should work with existing Jetpack custom CSS
      • #38541: Allow starter content to apply in a new theme when switching from another theme containing changes
      • #38660: Customizer: Edit shortcuts buttons: consider to don’t use flexbox
      • #38700: REST API: Cannot send an empty or no-op comment update
      • #38720: REST API: Updating a comment without sending content is valid, but unsupported
      • Starter content
      • Video headers

    Release Candidate

    • Please remember that with RC comes string freeze, so if you have any strings you think need to freeze, now is the time to get them in
    • We should be closing 4-5 tickets a day in order to hit RC on Tuesday.
    • Please keep testing, and working on patches.
     
  • Jeffrey Paul 7:53 pm on November 7, 2016 Permalink |
    Tags: , dev chat,   

    Dev Chat Summary: November 2 (4.7 week 11) 

    This post summarizes the dev chat meeting from November 2nd (agendaSlack archive).

    Reminders

    • Dev Chat timing: The Chat remains at 20:00 UTC.  Daylight Savings Time means that 20:00 UTC may be a different time for you already, or it may be a different time soon.
    • Schedule: Today is the target for Beta 2! That leaves us one week until the final scheduled beta, where the list of tickets should be at zero. It is currently at 74.
    • Tickets: For any tickets you’ve moved into the milestone, please make sure these are active tickets, with some kind of activity in the last 7 days.
    • Bug Scrubs: Can you run a scrub to help ensure tickets move forward? If you have interest in helping run a scrub and ensure tickets land in 4.7, then please reach out to @jbpaul17 or @jorbin and we’ll find a time that works best for you.

    Beta 1 Testing Updates

    • Forums-wise, an unresolved Twenty Seventeen issue that may be user error, the rest were either confirmed user error or filed in Trac
    • A couple customizer defects reported, one regarding infinite refresh and another one that relates to content security policy and Firefox which needs more reporter feedback since it is not reproducible by me. Also the edit shortcuts still have unresolved issues and maybe even need some UI changes to improve discoverability.

    Remaining 4.7 Schedule

    • Beta 2 later today. Beta 3 in a week.
    • RC comes 6 days after that – the reason for RC being on a Tuesday instead of Wednesday is because of php[world] for @helen (will be keynoting).
    • The goal is for RC to be much closer to a traditional RC (i.e. something finished and polished).  This means the final Beta should be where we are at zero open tickets besides possibly the About page.
    • An RC really should represent the state in which we believe the software could be shipped
    • The week after that is US Thanksgiving – we have the option of another RC if needed, but there may be lower activity volume as people travel and have obligations, etc.
    • Note that to ship an RC we have to be at zero tickets, though, which is less than 2 weeks away.
    • Would very much like to be able to have a video ready before WCUS (@helen has vague outline, looking for help outside of the usual WP suspects)
    • Then the week after that is WCUS – again, have the option of another RC if needed, and we should hit string freeze at that time at the latest, as many people will be traveling for WCUS.
    • Then, release on December 6.

    Dev Posts / Field Guide for 4.7

    Bug Scrubs

    • Would like to see near daily scrubs for now until RC of report 6 and of the “Defects Awaiting Review, reported against trunk” section of report 40
    • It looks like 11AM and 2PM Eastern should work each day
    • Would love to see a European and/or Australian also do some during non-USA centric times
    • We should have some scheduled stuff for people to show up if they need to schedule their time, but if you’re around and going through the report, throw up a here or another bat signal and just do one ad hoc.

    Beta 2

    • What needs to be done to get this out the door?
    • Likely to go out on Thursday instead of today
    • We are at 71 open tickets. Would love to see us get down to at least 40.
    • generally there are still enhancements (polish) going in for new features.
    • Since a lot about the REST API is about developer experiences, polishing the developer experience seems like a perfectly good thing to be doing during beta.
    • Whether it’s a bug or an enhancement in your eyes is not the important criterion – it’s about whether it’s a part of what you believe a polished set of REST API endpoints should be when you ship them.
    • Tickets to folks would ideally like to resolve for Beta 2:
      • #37032: Guard against infinite reload when setting change causes premature selective refresh
      • #38543: Twenty Seventeen: Firefox 49 renders site name & description off screen.
      • #38532: Customizer: Edit shortcuts buttons: clicking does not work in Firefox
      • #29158: Customizer UI Design lacks contrast for visual hierarchy and does not match wp-admin
      • #38420: API Post status parameter does not accept multiple values
      • #38609: REST API should honor the `unfiltered_html` capability
      • GitHub Issue #2848: Avoid use of wp_filter_post_kses to prevent lossy slash handling
    • Additional items needed for Beta 2 are a news post for .org and a haiku
     
  • Aaron Jorbin 6:56 pm on November 2, 2016 Permalink |
    Tags: , , dev chat   

    Dev Chat Agenda for November 1 (4.7 week 11) 

    This is the agenda for the weekly dev meeting on November 1, 2016 at 20:00 UTC:

    • Schedule reminder:  The Chat remains at 20:00 UTC.  Day Light Savings Time means that 20:00 UTC may be a different time for you already, or it may be a different time soon.
    • Schedule reminder: Today is the target for Beta 2! That leaves us one week until the final scheduled beta, where the list of tickets should be at zero. It is currently at 74.
    • Ticket reminder: For any tickets you’ve moved into the milestone, please make sure these are active tickets, with some kind of activity in the last 7 days.
    • Call For Bug Scrubs:  Can you run a scrub to help ensure tickets move forward?
    • Dev Notes:  These should all be published this week this week
    • Beta 2:  What needs to be done to get this out the door?
    • 4.6 open ticket scrub

    If you have anything to propose to add to the agenda or specific items related to the above, please leave a comment below. See you there!

     
  • Jeffrey Paul 6:47 pm on November 2, 2016 Permalink |
    Tags: , dev chat,   

    Dev Chat Summary: October 26 (4.7 week 10) 

    This post summarizes the dev chat meeting from October 26th (Slack archive).

    Reminders

    • Schedule: Today is/tomorrow will be beta 1 day. This means: no more enhancements and feature requests open for 4.7 (this sometimes means things with initial commits become “tasks”), and then from here on out we only work on bug fixes. It should be noted that bug fixes in this context are a little broader than what you’d call a bug fix in a bug tracker – it includes polish for new features. Typically that means UI and UX polish, but of course UX includes dev UX.
    • Tickets: There are currently 83 tickets in the 4.7 milestone. This is 27 fewer than last week. 🎉However, in just 3 short weeks, this needs to be zero. For any tickets you’ve moved into the milestone, please make sure these are active tickets with some kind of activity in the last 7 days.
    • Bug Scrubs: Several scrubs have been / are planned for this week. Scrubs remaining this week are planned for Thursday, October 27th 9:30am CDT for 2.5 hours and Friday, October 28th 9:30am CDT for 2.5 hours. If you have interest in helping run a scrub and ensure tickets land in 4.7, then please reach out to @jbpaul17 or @jorbin and we’ll find a time & scrub focus that works best for you.

    Remaining Feature Requests and Enhancements

    • #27159: Removing TinyMCE buttons to improve user experience
      • Closing this as fixed. Bugs can go in new tickets.
    • #36211: TinyMCE: allow pasting in image captions
      • This is something that needs testing attention but doesn’t actually need to be open. Closing that too.
    • #38488: Twenty Seventeen: Replace remaining Genericons with Font Awesome icons
    • #38502: TwentySeventeen: unnecessary l10n variables
      • Both of these Twenty Seventeen are likely bugs, will re-classify them.
    • #38490: Add settings to the /wp/v2/settings endpoint that are in the WordPress.com api
    • #38504: Term query endpoints should use WP_Term_Query
    • #38342: Quick Draft: Leverage REST API endpoints
      • Another lingering thing around beta 1 is the request that something in core leverage the REST API – there’s some discussion around this going on in #core-restapi.
      • REST API team will put feedback on the Quick Draft ticket with our thoughts on these questions.

    Defects and Tasks

    • #26601: Inappropriate content in headings on admin screens
      • The main H1 headings in the admin screens contain stuff that shouldn’t be there (“Add New” button, search string text, in some cases even the search input field). Headings should be just headings and all that stuff should be moved out from them.
      • The latest patch a proof of concept on just 2 screens, trying to find a way to proceed step by step and (hopefully) avoid any breakage.
      • “Being able to do it one instance at a time will make it much more manageable, so that we could hopefully get it started in 4.7 and completed in 4.8.” — @joedolson
      • We need some eyes on the patch, to see if the new approach is good enough and check for any potential layout breakage.
      • We’d like to hear if there’s consensus to merge it in core now, thinking that beta is maybe the best way to test it (it can be reverted at any time). If/when merged, some testing and comments on the ticket would be very appreciated too.
    • #38378: Remove the `filter` parameter in the Post Controller
      • Exposing filter as a shim for WP_Query provided useful functionality that’s still unsupported by the “first-party” API query parameters (complex date queries for example), at the expense of a very broad back-compat surface we then need to maintain.
      • We long ago decided not to extend filter-like shims on other endpoints; for consistency we had proposed removing it everywhere. But it’s been around since < v1, and removing it will be a more breaking change for integrating developers than anything else in the 4.7 REST API.
      • So the question is: remove, or keep in and live with it?
      • This is really about supporting people who have built stuff on v2. If people were not already using it, we’d remove it and just recommend the use of the top level args like `?per_page=x`, so for me, it’s a question of supporting those existing users.
      • Agreed approach will be 1: remove filter from core; 2: make sure it’s in the plugin, and make sure the versions play well together; and 3: throw doing_it_wrong.
    • #38494: WP REST API: Stale Post Status on DELETE of Post
      • What happens when you DELETE something is pretty inconsistent. When you delete a revision, you just get true. When you delete a category or tag, you have to specify force=true or you get an error.
      • Agreement: this something we’re comfortable discussing & addressing later.
    • #38114: Make it easier to visualize where to put your content in a given theme (aka “dummy content”)
      • This is marked as a task, but really needs a first commit before beta 1.
      • No existing code yet and getting a commit before beta 1 seems like a stretch.
    • #38172: Enable Video Headers in Custom Headers
      • This is marked as a task, but really needs a first commit before beta 1.
      • Video headers is close to being ready for an initial commit, with adjustments to come in beta.
      • There are a couple of quick tweaks we can make like making them only show on the front page in the core output functions, for example.
      • The late push on video headers has been fantastic, but it needs more eyes and testing.
      • The biggest concern is file size, and increasing page file size for a large amount of users.
      • Not loading video on screens narrower than X, only showing video on the frontpage, adding classes to the output markup for themes would be quick fixes we can make right away.
      • By having it in Core, it encourages themes to do it in a preferred way. And more importantly, provides consistent UX in the Customizer for users from theme to theme.
      • @celloexpressions to work on revised patch, @joemcgill to review for commit
    • #38387: Twenty Seventeen: Keyboard navigation on Safari 10
      • We would appreciate some other testing this patch; its been tested, but could use some more eyes on it.
     
  • Jeffrey Paul 4:00 am on October 20, 2016 Permalink |
    Tags: , dev chat,   

    Dev Chat Summary: October 19 (4.7 week 9) 

    This post summarizes the dev chat meeting from October 19th (agenda, Slack archive).

    Reminders

    Dev Notes / Field Guides

    • In general, if you worked on something that needs to be called out for testing or building upon, there should be a post about it.  These are all tagged as `dev-notes` on the Make/Core site.  The target is everything written before beta 2 so we can get a field guide summarizing them and an email sent to all plugin developers while we are still in beta. In general all active components should have at least one post about what has changed.

    Final Merge Decisions

    • Twenty Seventeen (@davidakennedy)
      • Merge Proposal & Trac ticket
      • 59 contributors. Merging later today.
      • There are 34 issues left, some of which will be moved to Trac. There are 0 pull requests left.
      • A code review was performed by @aaroncampbell, and he didn’t find anything that should hold up merge.
      • Theme does not depend on any core features being merged before/at the same time, but will greatly benefit from any completed.
      • Video headers (#38172) needs consensus on the best approach and testing of functional patches
      • Merge proposal accepted. 🎉
    • REST API: Content API (@kadamwhite)
      • Merge ProposalSuccess metrics
      • 99 contributors. 25 merged PRs in the past 3 days. 27 issues left in the current milestone and a few stray PRs, which will be closed out shortly or moved to Trac.
      • Monday meeting in #core resulting in conditional merge approval
      • Conditions:
        • 1) 4.7: Press This / Quick Draft Core feature (#38343 and #38342)
        • 2) 4.7: Object / non-single level meta. @joehoyle, @jnylen and others have been working on this, tracking via GitHub.
        • 3) 4.7: Define success metrics (see link above)
        • 4) 4.7: Continuing to ensure the API forward compatibility (EVERYONE should be building things with it).
        • 5) 4.7: Review .com API settings discrepancies, determine how to resolve or where to document. @joehoyle, @jnylen and others have been working on this; Progress/documentation.
      • WP-API is code-frozen at this time; open enhancements will be ported over by @rachelbaker as appropriate.
      • Merge proposal accepted (“Let’s do it.”). 🎉

    Components and Other Enhancements

    • i18n (@swissspidy)
      • Nothing newsworthy from the i18n side which isn’t already on Make/Core.
    • Make it easier to visualize where to put your content in a given theme (aka “dummy content”)
      • If there are people out there interested in content writing and stuff like customizer integration, hit up @helen.
    • Media (@mikeschroder, @joemcgill)
      • We’re working on trying to get #31050 (Better PDF Upload Management) into shape for commit this week. Still some issues to iron out, but it’s getting close.
      • I want to call out that we’ve removed the automatic fallbacks for generating `alt` attributes from images with consultation from the a11y team to improve the user experience for screen readers. See: #34635 for details.
      • We have a few other things we’re looking at this week, but if there is anything pressing that needs eyes specifically from someone on the Media team, please reach out in #core-media.
    • Customize (@westonruter, @celloexpressions)
      • Remaining three major 4.7 feature projects merged in the last 24 hours.
      • #27403 and #38164 are our larger remaining tickets needing attention currently, with #29158 and #22058 pending final patches for review and discussion.
    • Editor (@azaozz, @iseulde)
      • TinyMCE: allow pasting in image captions (#36211) needs some more testing
        • Add an image in the editor, add a caption, then try pasting different things copied from another web page in it. This makes some assumptions of what the user expects, and what should happen, i.e. when pasting an image into a caption it should remove the image but let the text in, or keep all that is pasted but move it under the caption?
     
  • Jeffrey Paul 3:59 am on October 20, 2016 Permalink |
    Tags: , dev chat,   

    Dev Chat Summary: October 12 (4.7 week 8) 

    This post summarizes the dev chat meeting from October 12th (agenda, Slack archive).

    Reminders

    Feature Proposals for 4.7

    • REST API: Content API (@kadamwhite)
      • REST API Team Update
      • Content API endpoints have been stable for some time and now have the missing functionality established at the start of this development cycle
      • We pitched merging in the OAuth 1 server alongside those content endpoints, to simplify the process of authenticating from remote applications
      • The auth method in core right now is cookie/nonce-based, so it’s available to any code running within the same domain as the main WordPress install and leverages the existing login cookie
      • plugins and themes that utilize JS to enhance the editing experience within their admin UI have full read/write access, restricted to the capabilities of the authenticated user
      • External applications, e.g. a mobile app, desktop app or external server, would have read-only access
      • readers, aggregators, etc are possible without authentication, and more complex read-write apps can be written by installing one of the available authentication plugins, of which OAuth is but one
      • Reference for options and when/how to use
      • 90 contributors for the rest-api plugin
      • automated test coverage currently at 90.44%
      • 37 more open tickets
      • weekly meeting on Monday at 1400UTC in #core-restapi
    • Discovering and installing themes in the customizer (@celloexpressions)
      • Related Make/Design and Make/Flow posts, but best to post all feedback to the Make/Core feature proposal
      • Working through the accessibility feedback, but it’s a bit unclear what’s specific to this feature versus the customizer in general, and which issues are also present in the admin theme installer
      • Haven’t heard anything from polyglots, security (unlikely to have any issues), or docs
      • There is one known i18n concern where we’ll need a compromise until we have JS i18n in core
      • @celloexpressions to do a final iteration to pick up any remaining feedback on Thursday, then pass to @westonruter for the code review process
    • Custom CSS with live previews (@celloexpressions)
      • seems to have decent support as a feature, with the biggest question in the comments being how to store and output the CSS
      • CSS is output from the db via a style tag, use of `style` tag is key for targeting for `postMessage` live preview
      • Post-based storage allows for revisions built in (ensuring that there are hooks for a plugin that wants to write a file would alleviate many concerns)
      • CSS is theme-specific in the proposal for this, with a post object for each theme that has CSS
      • Scheduling a meeting to go through these concerns and make a decision, coordination to occur in #core-customize
    • Customize Changesets (née Transactions) (@westonruter)
      • Technical Post (audience is developers who have extended the customizer significantly, as there may be impacts to any heavy customizer integrations since changesets touches some very low-level stuff in the customizer)
      • Users will be able to bookmark a customizer session since the changeset UUID will be part of the URL
      • Theme switches will no longer result in changes being lost (no more AYS dialog)
      • a few other open questions and issues that have been noted

    Components

     
  • Helen Hou-Sandi 7:40 pm on October 19, 2016 Permalink |
    Tags: , , dev chat   

    Dev Chat Agenda for October 19 (4.7 week 9) 

    This is the agenda for the weekly dev meeting on October 19, 2016 at 20:00 UTC:

    If you have anything to propose to add to the agenda or specific items related to the above, please leave a comment below. See you there!

     
  • Helen Hou-Sandi 8:01 pm on October 12, 2016 Permalink |
    Tags: , , dev chat   

    Dev Chat Agenda for October 12 (4.7 week 8) 

    This is the agenda for the weekly dev meeting on October 12, 2016 at 20:00 UTC:

    If you have anything to propose to add to the agenda or specific items related to the above, please leave a comment below. See you there!

     
c
compose new post
j
next post/next comment
k
previous post/previous comment
r
reply
e
edit
o
show/hide comments
t
go to top
l
go to login
h
show/hide help
shift + esc
cancel
Skip to toolbar