Media Meeting Recap – February 7, 2019

Overview

The following is a summary of the weekly media component meeting that occurred on Thursday, February 7, 2019. Weekly media meetings are held every Thursday at 21:00 UTC. A full transcript can be found here in the #core-media room in the Make WordPress Slack.

Attendees: @antpb, @aaroncampbell, @mikeschroder, @designsimply, @sergeybiryukov, @pbiron, @swinterroth, @dave_navarro

Triage

The agenda today was extended ticket triage for this list.

  • #41753: _wp_get_attachment_relative_path uses hardcoded uploads directory path: noted that it affects multisite and needs testing.
  • #41816: attachment_url_to_postid() should find post_id for URLs of intermediate size images: patch was previously abandoned because the heuristic wasn’t reliable, @pbiron will dig up the gist and leave a comment. In summary: #44095 and #42437 need to be fixed before moving forward with a revised patch for #41816.
  • #41922: Gallery hard to open for edit – rtl (hebrew) version: @antpb will test and leave feedback in the ticket.
  • #42063: Media: Indicate if image is used as a site option: @mikeschroder will leave a reply. It’s already future release.
  • #42487: Avoid redundant crops for all Customizer media controls: moved to future release.
  • #42751: Can we please enqueue media-views independently? @antpb offered to move the question about how mediaelement CSS is loaded to a separate issue. No consensus on the original question, left in awaiting review.

Next meeting

The next weekly media meeting will be held on Thursday, February 14, 2019, at 21:00 UTC in the #core-media room in the Make WordPress Slack.

#media, #summary

Media Meeting Recap: January 31, 2019

The following is a summary of the weekly media component meeting that occurred on January 30, 2019. Weekly media meetings are held every Thursday at 21:00 UTC. A full transcript can be found here in the #core-media room in the Make WordPress Slack.

Attendees: @joemcgill, @antpb, @mikeschroder, @desrosj, @paaljoachim, @karmatosed, @joehills, @sergeybiryukov, @birgire, @designsimply, @garrett-eclipse, @markoheijnen.

Here are the highlights of the meeting:

Meeting Agendas and Summaries

Many components that hold regular meetings have been posting agendas and summaries more regularly to start the year. This seems to have resulted in a slight uptick in attendance for some components, and many non-attendees have expressed an appreciation for this increase of posts as it helps them stay informed of what is being worked on and discussed.

Moving forward, the media component will work to be more consistent with both agenda and summary posts. @desrosj suggested having an official note taker to write the summary post during the meeting. This approach, in his experience, greatly decreases the time it takes to compile the post.

5.1 Items

The only known remaining 5.1 task for media is for @joemcgill to write a dev note for #45707.

5.2 Priorities

Meeting attendees worked to scrub the list of media tickets currently in the 5.2 milestone with the goal of ensuring each ticket has an owner. #44675, #36661, #42826, and #43524 all met that criteria. All but #42826 were assigned owners.

An upcoming meeting will focus on 5.2 priorities more generally.

@paaljoachim called out two Gutenberg related issues to focus on (a third one mentioned has already been resolved):

Ticket Scrub

The remainder of the meeting was spent scrubbing the Awaiting Review list for the Media component.

The next weekly media meeting will be held on Thursday, February 7, 2019, at 21:00 UTC in the #core-media room in the Make WordPress Slack.

#media

Media Meeting Recap – January 17, 2019

Overview

This post is a summary of the latest weekly Media component meeting, which took place in the #core-media Slack channel, on Thursday, January 17, 2019 at 21:00 UTC. The purpose of these meetings are to move priority tasks forward, provide feedback on issues of interest, and review media focused issues.

Attendees: @joemcgill @mikeschroder @karmatosed @desrosj @antpb @aaroncampbell @designsimply

Transcript: Read on Slack

5.1.0 Triage

Earlier in the day, @aaroncampbell, @mikeschroder, and @desrosj cleared the list of tickets reported against trunk awaiting review.

During the meeting, attendees scrubbed the remaining Media tickets in the 5.1.0 milestone.

  • #40590: wp_video_shortcode always adds controls=”controls”: The team wasn’t confident in the current approach. Punted to future release.
  • #45407: Add block attributes to wp_calculate_image_sizes to allow for proper handling of sizes attribute: This doesn’t seem to be ready for 5.1 but @joemcgill will make a final determination this week.
  • #40175: Upload Validation / MIME Handling: @joemcgill uploaded a patch this week. @pento reviewed and this will likely fall out of 5.1 and be marked for early 5.2. Testing/feedback is appreciated.
  • #44563: WordPress 4.9.7 Media delete changes break plugins deleting media via stream wrappers: No movement this week, punted to future release.
  • #44760: Media library module dates filter doesn’t fully display: @mikeschroder is owning and will either commit or punt.
  • #44836: Uploaded plugin installation page: There is an extra tag messing with a link: No movement. Punted to future release.
  • #45633: finfo_file() returns text/plain for json file instead of application/json: This is punted to future release, pending #40175.
  • #43826: get_post_galleries() should return gallery blocks: This remains a blessed task for now.
  • #45707: Add parameter $real_mime to wp_check_filetype_and_ext: This might land as a relief while #40175 is pending, as long as it doesn’t introduce future compatibility challenges.

Recent Trac Bulk Edit

The team discussed how we should handle the recent bulk edit closing of tickets. Of the tickets closed, 163 are Media component tickets. The general consensus is that we shouldn’t leave them as wontfix but no final decisions were made. Next steps are for everyone to leave feedback on the original P2 about how to handle this project wide, and we will plan to make a decision about Media tickets next week.

Next meeting

The next #core-media meeting is set for Thursday, January 24, 2019, 21:00 UTC. Leave any agenda suggestions in the comments of this post. See you there!

#media, #summary

Media Meeting Recap – January 3, 2019

Overview

This post is a summary of the latest weekly Media component meeting, which took place in the #core-media Slack channel, on Thursday, January 3, 2019 at 21:00 UTC. The purpose of these meetings are to move priority tasks forward, provide feedback on issues of interest, and review media focused issues.

Attendees: @joemcgill @mikeschroder @karmatosed @desrosj @paaljoachim @tellyworth

Transcript: Read on Slack

5.0.3 Triage

  • #43826: get_post_galleries() should return gallery blocks – Patch needs refresh, @desrosj to coordinate with @tellyworth about landing this.
  • #44563: WordPress 4.9.7 Media delete changes break plugins deleting media via stream wrappers – Also needs a refresh, @joemcgill to try and validate and make a decision unless @mikeschroder beats him to it. Lower priority though, so might punt.
  • #45407: Add block attributes to wp_calculate_image_sizes to allow for proper handling of sizes attribute – Unsure if this patch is ready to land. @joemcgill to investigate and make a decision. – #45615: CSV Mime Type fails upload – @joemcgill and @tellyworth continue working on a fix for this. Might try for a small fix for 5.0.3 and a larger refactor for 5.1.
  • #45633: finfo_file() returns text/plain for json file instead of application/json – Related to the above issue. @joemcgill to investigate.

Ongoing Cruft removal

On December 21, we discussed identifying potential places to clean up cruft that has built up over the years. So far, that post includes the following possibilities:

  • Fully supporting or deprecating playlist functionality
  • Removing infinite scroll in the media library.
  • Auditing/updating supported upload file types.
  • Removing old Thickbox code (#10955).
  • Functionality deprecated when WP_Image_Editor landed.
  • Auditing oEmbed providers.

Upcoming 5.1 ticket scrub

As of the time of this meeting, there were 38 open Media tickets on the 5.1 milestone. Of those, 16 are enhancements or feature requests that would need to land before next Thursday when 5.1 hits beta in order to be included. We’ll plan to do a scrub of this list in #core-media on Slack next Tuesday, January 8, 2019 at 20:00 UTC to assign/punt as much as possible. Feel free to come join in the fun!

Next meeting

The next #core-media meeting is set for Thursday, January 10, 2019, 21:00 UTC. This next meeting will be focused on triage and 5.1 priorities. See you there!

#media, #summary

Media 5.0 Guide

The block editor in WordPress 5.0 brings a much needed refresh to how we interact with media in the editor. 5.0 has provided new features designed to make complex content easier to create, and is built in a way that is now truly “what you see is what you get”! There are some big changes to where things are, new methods of accessing `classic` functionality, as well as new features you may not even know about. Let’s highlight a few of those!

Where is the add media button?

If you are looking for the add media button for any reason, this can be found in the classic block TinyMCE toolbar labeled “add media”. This button will trigger the media modal.

Gallery Block:

We have improved the Gallery experience with a new block that gives users a truly real time interactive Gallery.

If you need to utilize dynamic galleries that are based on post ID, or if you need to use the `post_gallery` filter, this can still be achieved using the `add media` button located in the classic block TinyMCE toolbar.

Wide Alignment Theme Support:

Some blocks, such as the image block, have the ability to define a “wide” or “full” alignment in the new editor. This is accomplished by adding the `.alignwide` or `.alignfull` classes, respectively, to the image’s wrapper element. A theme can opt-in for this feature by calling: 

add_theme_support( 'align-wide' );

For more information on Wide Alignment, or if you would like to explore the potential markup of images in this context, the documentation has more details.

#5-0 #dev-notes

#media

Media Meeting Recap – March 29

Overview

This post is a summary of the latest weekly Media component meeting, which took place in the #core-media Slack channel, on Thursday,  March 29, 2018 at 1900 UTC. The purpose of these meetings are to move priority tasks forward, provide feedback on issues of interest, and review media focused tickets on Trac.

Attendees:
@joemcgill @blobfolio @audrasjb @desrosj @mikeschroder @karmatosed @antpb

Transcript: Read on Slack

Gutenberg

  • The best way to follow along with media related Gutenberg items is the media label in GitHub.
  • Repository milestones
  • @karmatosed expressed a need for media maintainers to ensure that what is being proposed for MVP/Feature complete is accurate. Issues related to this can be found using the media label or by following this link: https://github.com/WordPress/gutenberg/labels/Media
  • Add mediaelement component@antpb has updated the repo to include some bug fixes. Testing is still needed to determine the issue with loading mediaElement on the front end. Steps to creating a clone of the repo can be found at this comment.
  • Add block playlist: Currently blocked by the inclusion of the mediaElement component.
  • @desrosj asked "Are there “groups” in GitHub? Thinking something similar to @ committers in Slack that would notify a group of people?" Investigation is needed into subscribing to labels in Github. If anyone has any ideas, please comment below. RSS was mentioned as a possibility but confirmation would be much appreciated.

4.9.5 Tickets

The next part of the meeting was spent on tickets in the 4.9.5 milestone

  • #42919 – Unable to upload files with the AAC extension
    @desrosj mentioned "the ticket was specifically just for allowing a user to upload a file with .aac extension. The mime type was already allowed (when a different file extension was used), but when the file extension was explicitly .aac it would get blocked." The commit in the ticket adds support to display the .aac in an embed. @blobfolio and @desrosj did some upload testing and found that in Firefox, there were issues. @mikeschroder suggested that we should revert the extra functionality and explore embedding in a different ticket. @joemcgill concurred that he'd like to see further exploration of rendering in a cross-platform manner.

Open Floor

  • #43642 – Gallery titles and labels erasing
    @antpb mentioned this maybe being plugin territory. @desrosj mentioned a risk in the way that galleries save back to the attachment post. This may have some Gutenberg compatibility issues as well. We are going to mark this one with reporter feedback needed because there's a possibility that they want to create a gallery without any titles or they are wanting to replace the titles/labels. Seeing video/screenshots of their current workflow would be helpful.  

Next Meeting

The next #core-media meeting is set for Thursday, April 5, 2018 at 1800 UTC. See you there!

#core-media, #media, #summary

Media Meeting Recap – March 23

Overview

This post is a summary of the latest weekly Media component meeting, which took place in the #core-media Slack channel, on Thursday,  March 23, 2018 at 1900 UTC. The purpose of these meetings are to move priority tasks forward, provide feedback on issues of interest, and review media focused tickets on Trac.

Attendees:
@joemcgill @blobfolio @desrosj @mikeschroder @karmatosed @antpb @adamsilverstein

Transcript: Read on Slack

Gutenberg

4.9.5 Tickets

The next part of the meeting was spent on tickets in the 4.9.5 milestone

Tickets needing testing:

  • #42017 – Parse the creation date out of uploaded audio files
    @desrosj has reclassified this ticket as enhancement.
  • #33979 – Add filter for 'postgalleryitem'
    @desrosj is looking into adding attributes to the tag in addition to just making a class filter. We will need to investigate if this helps Gutenberg in any way. 
  • #43046has_image_size() returns false for Core image sizes
    
    @desrosj is researching this one.
  • #9257 – EXIF GPS data
    Due to GDPR compliance, decided that this should live in plugin territory for now. Lots of great work going on in the ticket, and would be a solid plugin! 

Next Meeting

The next #core-media meeting is set for Thursday, March 29, 2018 at 1800 UTC. As both the EU and US have now moved to DST, you'll note the time has been shifted one hour earlier. Hope to see you there!

#core-media, #media, #summary

Media Meeting Recap – March 8

Overview

This post is a summary of the latest weekly Media component meeting, which took place in the #core-media Slack channel, on Thursday,  March 8, 2018 at 1900 UTC. The purpose of these meetings are to move priority tasks forward, provide feedback on issues of interest, and review media focused tickets on Trac.

Attendees:
@mikeschroder @antpb @desrosj @karmatosed @postphotos @joemcgill @sergey @chetan200891 @adamsilverstein 

Transcript: Read on Slack

Gutenberg

  • The best way to follow along with media related Gutenberg items is the media label in GitHub.
  • Repository milestones
  • Add mediaelement component@antpb discussed that this is currently a blocker to building the Playlist Block. The component renders on the editor view and is enqueuing via client-assets.php but the script is not enqueuing on the front end. @antpb needs help figuring out the front end issue. Steps to creating a clone of the repo can be found at this comment.
  • Add block playlist: Currently blocked by the inclusion of the mediaelement component.

4.9.5 Tickets

The next part of the meeting was spent on tickets in the 4.9.5 milestone

Tickets needing testing:

  • #42724 – Options media page hides breaks on desktop
    Patch still needs testing.
  • #42968 – Media: Grid View: new upload, file is in the wrong position in the grid until after upload is complete
    Agreement all around that it is ready to commit.
  • #43226 – Crop setting in thumbnails never set when uploading PDF files
    Committed to trunk. It was agreed that this will be fixed in 4.9.5. @mikeschroder is working on backports.
  • #43255 – WP _Image_Editor::make_image leaves an output buffer open on failure
    This one has been open for a while but is in need of clean up. Mentioned by @mikeschroder we "want to be sure what we do doesn't break workarounds."

Tickets up for discussion:

#43123 Default captions should NOT use max-width
@joemcgill mentioned that he thinks it is worth reverting due to unintended consequences. @mikeschroder noted that "we’ll want to be sure to message folks and give a warning if we do revert."

Next Meeting

The next #core-media meeting is set for Thursday, March 15, 2018 at 1900 UTC Note: The time is maintained in UTC, so if you are in the US, this time may be different due to DST. We'll move the meeting time once EU has switched to DST in two weeks. Hope to see you there!

#core-media, #media, #summary

Media Meeting Recap – March 1

Overview

This post is a summary of the latest weekly Media component meeting, which took place in the #core-media Slack channel, on Thursday,  March 1, 2018 at 1900 UTC. The purpose of these meetings are to move priority tasks forward, provide feedback on issues of interest, and review media focused tickets on Trac.

Attendees:
@mikeschroder @antpb @desrosj @karmatosed @blobfolio @chetan200891 @jdub233

Transcript: Read on Slack

Gutenberg

  • The best way to follow along with media related Gutenberg items is the media label in GitHub.
  • Repository milestones
  • Add mediaelement component – This issue was created by @antpb in an attempt to separate the mediaelement component required to make progress on the playlist block. Included in these changes is an update to the Audio block to utilize the component. Currently the component renders on the editor view and is enqueuing via client-assets.php but the script is not enqueuing on the front end. Needs investigation.
  • Add block playlist: Currently blocked by the inclusion of the mediaelement component.

4.9.5 Tickets

The next part of the meeting was spent on tickets in the 4.9.5 milestone

Tickets needing testing:

  • #42724 – Options media page hides breaks on desktop
    • Patch still applies clean, testing needed.

Tickets up for discussion:

#43255 WP_Image_Editor::make_image leaves an output buffer open on failure

This has been committed for 5.0, but @mikeschroder mentioned some worry around changing output buffers for a minor release.

The following ticket needs a combination of code review and approval:

#43226 – Crop setting in thumbnails never set when uploading PDF

@mikeschroder is going to test #43226

5.0 Tickets

The next part of the meeting was spent on tickets in the 5.0 milestone

#9257: EXIF GPS data

#9257 is a ticket to process EXIF GPS and store it in meta, but not exposing that data unless a plugin or theme uses it for something. In WordPress' current state, the original file is not stripped of any geolocation data and anyone could potentially find that information. This sparked the question of whether the user should be informed that location data is present in an uploaded image file. #43454 was created in response to this.

#43454 – Add UI elements to make the user aware of image geo data

Some concern was expressed about the potential for a user to unknowingly exposing location data in #9257 activating a plugin or theme that utilizes it. Some ideas that were passed around to better inform the user about images containing GPS data:

  • Showing a warning when an image is uploaded that contains GPS data.
  • Showing a general notice
  • Showing a globe icon in the corner of the image thumbnail in the media library.
  • Showing the coordinates in the attachment info pane when editing an attachment (maybe with information about the data).
  • A general warning at the top of the upload screen.

Further discussion and initial patches can be found in the ticket.

Next Meeting

The next #core-media meeting is set for Thursday, March 8, 2018 at 1900 UTC. Hope to see you there!

#core-media, #media, #summary

Media Meeting Recap – February 15, 2018

Overview

This post is a summary of the latest weekly Media component meeting, which took place in the #core-media Slack channel, on Thursday, February 15, 2018 at 1900 UTC. The purpose of these meetings are to move priority tasks forward, provide feedback on issues of interest, and review media focused tickets on Trac.

Attendees:
@mikeschroder @antpb @blobfolio @flixos90 @jdub233 @sergey @desrosj @azaozz

Transcript: Read on Slack

Gutenberg

  • The best way to follow along with media related Gutenberg items is the media label in GitHub.
  • Repository milestones have been re-arranged to make it easier to see what is going on.
  • Add block playlist: A discussion took place around how mediaElement should be added to Gutenberg. The two options discussed were to include it in the npm package list or make a global instance of Core's mediaElement Library. Consensus was to go with Core's implementation. @antpb is blocked on the playlist block with lack of mediaElement component. He is working on building a mediaElement REACT component that will need to be utilized in the audio and video blocks. Before this is complete enough to merge, he'll need some help understanding how to make the Core library globally accessible in Gutenberg.

5.0 Tickets

The next part of the meeting was spent on tickets in the next major milestone (5.0).

#33979 – Add filter for 'post_gallery_item'
#38228 – Add filter to default gallery shortcode output

Discussion around how granular gallery filters should be. With #3379 we gain a filter to add  styles individually per item in the Gallery. It was discussed that we will need tickets to add more granular filters going forward for captions and other image attributes. From @desrosj : "Currently the shortcode builds the HTML string as it goes. I think if the attributes were built in an associative array, that could just be filtered, and then the element built at the end. That could allow additional attributes to be added, widths to be changed for specific images making it easier to do different grid layouts." This sparked the question above around how Gutenberg will handle backwards compatibility with filtered attributes.

The following tickets need a combination of code review and approval:

  • #33979 – Add filter for 'post_gallery_item'

Seems good to go as a first step towards more granular Gallery filters if it won’t make it more difficult for Gutenberg to provide backcompat.

Next Meeting

The next #core-media meeting is set for Thursday, February 22, 2018 at 1900 UTC. Hope to see you there!

#core-media, #media, #summary