Media Meeting Recap – September 5, 2019

The following is a summary of the weekly media component meeting that occurred on Thursday, September 5, 2019. Weekly media meetings are held every Thursday at 13:00 UTC. A full transcript can be found here in the #core-media room in the Make WordPress Slack.

Attendees: @anevins, @sergeybiryukov, @pstonier , @afercia, @francina, @mikeschroder

Media Focus Lead for 5.3

Much like the 5.0 release, 5.3 will have many designated release leads around each focus/component in the project. 5.3 is right around the corner and now is the time for a decision to be made on a release lead representing the Media component. Previously @antpb had offered to take on the role if no others were interested. In this weeks Media meeting, a volunteer emerged! @mikeschroder has graciously offered to take on this role. Thanks Mike! Mike is in the JST time zone. This brings an awesome opportunity to have global representation in the team. @antpb has offered to help with relaying information or representing where time zones do not conveniently meet for Mike.

5.3 Ticket Triage

#47135 – Drag and drop functionality unavailable to keyboard or touchscreen — It was determined by the team that this issue exists more globally in meta boxes. It was deemed appropriate to document the information from the Media focused instance of this in an existing ticket on the issue: #39074 No method to move meta boxes using keyboard which was also given the keyword wpcampus-report for tracking purposes.

#47137 Insuficient form semantics – @anevins asked “Is there a technical reason why there isn’t a form element being used around that attachments browser code? That would defeat all of the remediation advice.” @afercia had these recommendations: “Ideally it should be a form because that helps in establishing semantic relationships. However, the sidebar is not rendered in all the views, so including the select area, the attachments list and the sidebar within one form might be a bit complicated.
The list of attachments is perceived as a list of checkboxes so it makes sense to wrap it within a fieldset + legend. I’d tend to think it would need more work in the future because yes, it’s a group of checkboxes but it actually works like a mini-application with custom interaction. I’d say fieldset + legend would help, for now.”

Triage on unanswered tickets continued after the meeting closed, and can be followed here.

Feedback

If you have any feedback on the above, please feel free to leave a comment, join in #core-media for a chat, or attend the next meeting on September 12, 2019 at 1300UTC!

#core, #core-accessibility, #core-media, #media, #summary

Media Meeting Recap – August 29, 2019

The following is a summary of the weekly media component meeting that occurred on Thursday, August 29, 2019. Weekly media meetings are held every Thursday at 13:00 UTC. A full transcript can be found here in the #core-media room in the Make WordPress Slack.

Attendees: @joemcgill, @anevins, @desrosj, @horttcore, @paaljoachim, @mikeschroder

5.3 Tickets

@azaozz requested review on the latest patches in #43524, #47873, #47872, #32437. He plans to commit them before the end of the week.

Chatting About Sizes

@pierlo asked for a discussion on #43524, which is about adding an additional image size.

Folks seemed to agree that it makes sense to add another one, and that it’d be great if sizes could be backfilled in the future, but that’s likely not for 5.3.

Connected to that, there was a conversation about the direction WordPress could take with sizes in 5.4 and beyond. Things discussed included a feature like add_image_size for attachments, delivering srcset sizes based on file size, and resizing after theme change.

If that sounds interesting, you can read the whole discussion here.

Ticket Triage

  • #47215: The media that is “Unattached” is different in list mode vs grid mode — @desrosj was able to reproduce, and is going to do a bit more testing.
  • #47215: The media that is “Unattached” is different in list mode vs grid mode — @joemcgill notes that this is an intentional behavior, meant to avoid clutter in the media library due to site icons or headers. This may need to be revisited.
  • #47364: Docs: Standardise the description for image size parameters — @joemcgill agreed to review the ticket and clarify the goals.
  • #47444: Deprecate the caption field from the media modal — Folks present noted use-cases for this, and @joemcgill to leave a comment.

Triage on unanswered tickets continued after the meeting closed, and can be followed here.

Feedback

If you have any feedback on the above, please feel free to leave a comment, join in #core-media for a chat, or attend the next meeting on September 5, 2019 at 1300UTC!

#core, #core-accessibility, #core-media, #media, #summary

Media Meeting Recap – August 23, 2019

The following is a summary of the weekly media component meeting that occurred on Thursday, August 23, 2019. Weekly media meetings are held every Thursday at 13:00 UTC. A full transcript can be found here in the #core-media room in the Make WordPress Slack.

Attendees: @joemcgill, @anevins, @pbiron, @desrosj

5.2.3 Media Tickets

All relevant tickets have been closed. 🎉 Props @sergeybiryukov on back-porting bug fixes.

5.3.0 Release Media Lead

Following up on the 5.3.0 Release Schedule and Scope, we were asked to identify a Media release lead. To coordinate media related tickets.

  • @antpb has expressed interest in doing this again, but wanted to open up the opportunity to anyone else interested.
  • @joemcgill wondered if this role was redundant with @azaozz role as Core technical lead, since most of the priority Media items are ones he is already working on.

If you’re interested in volunteering for this role, feel free to comment here, in #core-media, or DM @joemcgill or @antpb directly in Slack.

5.3.0 Tickets

  • #47156: Consider a way to clear the wp.a11y.speak() live regions – @anevins followed up and noted that the Drupal a11y team have a similar issue and this might be a limitation of aria-live regions, generally. The plan is to follow up with the #core-accessibility team this week.
  • #44581: users without ‘edit_posts’ capability never get informed that their uploads succeed – @pbiron asked that this get moved into the 5.3 release for review.
  • #47872: Try to create image sub-sizes again when uploading fails with a PHP fatal error – @azaozz asked for review, noting that testing requires the client to re-try creation of image sub-sizes after uploading an image and the server “crashes” with HTTP 500 error.
  • #40439: Save progress of intermediate image creation after upload – @azaozz believes this is complete, but would like more testing before closing.
  • #47873: Introduce handling of “Big Images” – @azaozz added as a new enhancement. Feedback appreciated.
  • #40175: Upload Validation / MIME Handling – @joemcgill noted that this stalled out after 5.2 and with the focus for 5.3 being on improving handling of large image uploads, would need to be punted to a future release unless someone else wants to pick it up for 5.3.
  • #35725: Add mime-type for Webp – @joemcgill doesn’t think #40175 should be a blocker for this ticket, but wasn’t sure if it should be in core without full browser support.

#core, #media, #summary

Media Meeting Recap – August 15, 2019

Overview

The following is a summary of the weekly media component meeting that occurred on Thursday, August 15, 2019. Weekly media meetings are held every Thursday at 13:00 UTC. A full transcript can be found here in the #core-media room in the Make WordPress Slack.

Attendees: @joemcgill, @anevins, @sergey, @antpb, @adamsilverman

5.3 A11y Related Tickets

@anevins lead a triage of the a11y related tickets from the WPCampus audit for 5.3 to try and make sure everything had an owner and/or some next steps to move forward.

Now that all tickets have been triaged, @joemcgill suggested that we keep the latest information in Trac so we can use this report to track status of the a11y related tickets throughout the 5.3 cycle.

5.3 Release Media Lead

@antpb asked if anyone was interested in being the Media lead for the 5.3 release. He served in this capacity for the 5.0 release and is willing to do so again for 5.3 if needed. @joemcgill reached out to @chanthaboune in #core following the meeting to clarify what this role would be responsible for (see chat). Essentially, this person would be the primary person responsible for communicating status from the component team and gathering consensus when decisions need to be made. This person is not responsible for completing all the work themselves, but should be leaning on the rest of the component maintainers and contributors to meet our release goals.

If you’re interested in volunteering for this role, feel free to comment here or in #core-media.

5.2.3 Release Tickets

@joemcgill noted that there are several Media issues listed in @jeffpaul‘s 5.2.3 release proposal. These need to be reopened as fixed-major so they can be back ported to the minor release and the milestone needs to be updated. @joemcgill volunteered to handle this.

#media, #summary

Improve processing of uploaded images

As mentioned in dev chat on May 15 there are quite a few “stalled” tickets on Trac dealing with image processing/resizing after uploading:

All of these, and more, can be “unblocked” by: Save progress of intermediate image creation after upload #40439.

Fixing this will also enable “refreshing” of the way we do responsive images, and will enable improvements in how we generally work with images in the block editor. Then we will be able to enhance the Image block and make it “just work” regardless of the context, see Enhancement: images handling and more importantly https://github.com/WordPress/gutenberg/issues/6177#issuecomment-442953527.

In short: fixing the above tickets will greatly improve user experience especially when uploading large images or the server is slow/busy. It will also open the way for enhancing how we work with images in the editor, and let us show better fitting images on the front-end.

#media, #upload

Media Meeting Recap – February 7, 2019

Overview

The following is a summary of the weekly media component meeting that occurred on Thursday, February 7, 2019. Weekly media meetings are held every Thursday at 21:00 UTC. A full transcript can be found here in the #core-media room in the Make WordPress Slack.

Attendees: @antpb, @aaroncampbell, @mikeschroder, @designsimply, @sergeybiryukov, @pbiron, @swinterroth, @dave_navarro

Triage

The agenda today was extended ticket triage for this list.

  • #41753: _wp_get_attachment_relative_path uses hardcoded uploads directory path: noted that it affects multisite and needs testing.
  • #41816: attachment_url_to_postid() should find post_id for URLs of intermediate size images: patch was previously abandoned because the heuristic wasn’t reliable, @pbiron will dig up the gist and leave a comment. In summary: #44095 and #42437 need to be fixed before moving forward with a revised patch for #41816.
  • #41922: Gallery hard to open for edit – rtl (hebrew) version: @antpb will test and leave feedback in the ticket.
  • #42063: Media: Indicate if image is used as a site option: @mikeschroder will leave a reply. It’s already future release.
  • #42487: Avoid redundant crops for all Customizer media controls: moved to future release.
  • #42751: Can we please enqueue media-views independently? @antpb offered to move the question about how mediaelement CSS is loaded to a separate issue. No consensus on the original question, left in awaiting review.

Next meeting

The next weekly media meeting will be held on Thursday, February 14, 2019, at 21:00 UTC in the #core-media room in the Make WordPress Slack.

#media, #summary

Media Meeting Recap: January 31, 2019

The following is a summary of the weekly media component meeting that occurred on January 30, 2019. Weekly media meetings are held every Thursday at 21:00 UTC. A full transcript can be found here in the #core-media room in the Make WordPress Slack.

Attendees: @joemcgill, @antpb, @mikeschroder, @desrosj, @paaljoachim, @karmatosed, @joehills, @sergeybiryukov, @birgire, @designsimply, @garrett-eclipse, @markoheijnen.

Here are the highlights of the meeting:

Meeting Agendas and Summaries

Many components that hold regular meetings have been posting agendas and summaries more regularly to start the year. This seems to have resulted in a slight uptick in attendance for some components, and many non-attendees have expressed an appreciation for this increase of posts as it helps them stay informed of what is being worked on and discussed.

Moving forward, the media component will work to be more consistent with both agenda and summary posts. @desrosj suggested having an official note taker to write the summary post during the meeting. This approach, in his experience, greatly decreases the time it takes to compile the post.

5.1 Items

The only known remaining 5.1 task for media is for @joemcgill to write a dev note for #45707.

5.2 Priorities

Meeting attendees worked to scrub the list of media tickets currently in the 5.2 milestone with the goal of ensuring each ticket has an owner. #44675, #36661, #42826, and #43524 all met that criteria. All but #42826 were assigned owners.

An upcoming meeting will focus on 5.2 priorities more generally.

@paaljoachim called out two Gutenberg related issues to focus on (a third one mentioned has already been resolved):

Ticket Scrub

The remainder of the meeting was spent scrubbing the Awaiting Review list for the Media component.

The next weekly media meeting will be held on Thursday, February 7, 2019, at 21:00 UTC in the #core-media room in the Make WordPress Slack.

#media

Media Meeting Recap – January 17, 2019

Overview

This post is a summary of the latest weekly Media component meeting, which took place in the #core-media Slack channel, on Thursday, January 17, 2019 at 21:00 UTC. The purpose of these meetings are to move priority tasks forward, provide feedback on issues of interest, and review media focused issues.

Attendees: @joemcgill @mikeschroder @karmatosed @desrosj @antpb @aaroncampbell @designsimply

Transcript: Read on Slack

5.1.0 Triage

Earlier in the day, @aaroncampbell, @mikeschroder, and @desrosj cleared the list of tickets reported against trunk awaiting review.

During the meeting, attendees scrubbed the remaining Media tickets in the 5.1.0 milestone.

  • #40590: wp_video_shortcode always adds controls=”controls”: The team wasn’t confident in the current approach. Punted to future release.
  • #45407: Add block attributes to wp_calculate_image_sizes to allow for proper handling of sizes attribute: This doesn’t seem to be ready for 5.1 but @joemcgill will make a final determination this week.
  • #40175: Upload Validation / MIME Handling: @joemcgill uploaded a patch this week. @pento reviewed and this will likely fall out of 5.1 and be marked for early 5.2. Testing/feedback is appreciated.
  • #44563: WordPress 4.9.7 Media delete changes break plugins deleting media via stream wrappers: No movement this week, punted to future release.
  • #44760: Media library module dates filter doesn’t fully display: @mikeschroder is owning and will either commit or punt.
  • #44836: Uploaded plugin installation page: There is an extra tag messing with a link: No movement. Punted to future release.
  • #45633: finfo_file() returns text/plain for json file instead of application/json: This is punted to future release, pending #40175.
  • #43826: get_post_galleries() should return gallery blocks: This remains a blessed task for now.
  • #45707: Add parameter $real_mime to wp_check_filetype_and_ext: This might land as a relief while #40175 is pending, as long as it doesn’t introduce future compatibility challenges.

Recent Trac Bulk Edit

The team discussed how we should handle the recent bulk edit closing of tickets. Of the tickets closed, 163 are Media component tickets. The general consensus is that we shouldn’t leave them as wontfix but no final decisions were made. Next steps are for everyone to leave feedback on the original P2 about how to handle this project wide, and we will plan to make a decision about Media tickets next week.

Next meeting

The next #core-media meeting is set for Thursday, January 24, 2019, 21:00 UTC. Leave any agenda suggestions in the comments of this post. See you there!

#media, #summary

Media Meeting Recap – January 3, 2019

Overview

This post is a summary of the latest weekly Media component meeting, which took place in the #core-media Slack channel, on Thursday, January 3, 2019 at 21:00 UTC. The purpose of these meetings are to move priority tasks forward, provide feedback on issues of interest, and review media focused issues.

Attendees: @joemcgill @mikeschroder @karmatosed @desrosj @paaljoachim @tellyworth

Transcript: Read on Slack

5.0.3 Triage

  • #43826: get_post_galleries() should return gallery blocks – Patch needs refresh, @desrosj to coordinate with @tellyworth about landing this.
  • #44563: WordPress 4.9.7 Media delete changes break plugins deleting media via stream wrappers – Also needs a refresh, @joemcgill to try and validate and make a decision unless @mikeschroder beats him to it. Lower priority though, so might punt.
  • #45407: Add block attributes to wp_calculate_image_sizes to allow for proper handling of sizes attribute – Unsure if this patch is ready to land. @joemcgill to investigate and make a decision. – #45615: CSV Mime Type fails upload – @joemcgill and @tellyworth continue working on a fix for this. Might try for a small fix for 5.0.3 and a larger refactor for 5.1.
  • #45633: finfo_file() returns text/plain for json file instead of application/json – Related to the above issue. @joemcgill to investigate.

Ongoing Cruft removal

On December 21, we discussed identifying potential places to clean up cruft that has built up over the years. So far, that post includes the following possibilities:

  • Fully supporting or deprecating playlist functionality
  • Removing infinite scroll in the media library.
  • Auditing/updating supported upload file types.
  • Removing old Thickbox code (#10955).
  • Functionality deprecated when WP_Image_Editor landed.
  • Auditing oEmbed providers.

Upcoming 5.1 ticket scrub

As of the time of this meeting, there were 38 open Media tickets on the 5.1 milestone. Of those, 16 are enhancements or feature requests that would need to land before next Thursday when 5.1 hits beta in order to be included. We’ll plan to do a scrub of this list in #core-media on Slack next Tuesday, January 8, 2019 at 20:00 UTC to assign/punt as much as possible. Feel free to come join in the fun!

Next meeting

The next #core-media meeting is set for Thursday, January 10, 2019, 21:00 UTC. This next meeting will be focused on triage and 5.1 priorities. See you there!

#media, #summary

Media 5.0 Guide

The block editor in WordPress 5.0 brings a much needed refresh to how we interact with media in the editor. 5.0 has provided new features designed to make complex content easier to create, and is built in a way that is now truly “what you see is what you get”! There are some big changes to where things are, new methods of accessing `classic` functionality, as well as new features you may not even know about. Let’s highlight a few of those!

Where is the add media button?

If you are looking for the add media button for any reason, this can be found in the classic block TinyMCE toolbar labeled “add media”. This button will trigger the media modal.

Gallery Block:

We have improved the Gallery experience with a new block that gives users a truly real time interactive Gallery.

If you need to utilize dynamic galleries that are based on post ID, or if you need to use the `post_gallery` filter, this can still be achieved using the `add media` button located in the classic block TinyMCE toolbar.

Wide Alignment Theme Support:

Some blocks, such as the image block, have the ability to define a “wide” or “full” alignment in the new editor. This is accomplished by adding the `.alignwide` or `.alignfull` classes, respectively, to the image’s wrapper element. A theme can opt-in for this feature by calling: 

add_theme_support( 'align-wide' );

For more information on Wide Alignment, or if you would like to explore the potential markup of images in this context, the documentation has more details.

#5-0 #dev-notes

#media