Dev Chat Summary: 15 May

@chanthaboune served as the facilitator for discussion and a bevy of contributors participated.

Announcements

Make sure to participate in the 5.2 release retrospective!

Gutenberg Developer docs now live in DevHub!

Upcoming Releases Discussion

Point release (5.2.1)

@desrosj has offered to be the leader of this point release, assisted by @earnjam. Many emojis welcomed William to the release lead club.

The 5.2.1 milestone in trac should accurately reflect priorities. Anything not marked as high priority is “puntable”. Currently targeting RC on Thursday or Friday this week with a release on Monday or Tuesday next week.

5.2.2 remains a possibility depending on how thing shake out from 5.2.1, what the schedule for 5.3 looks like, and the tickets that remain open after 5.2.1.

Major release (5.3)

The call for 5.3 tickets is posted. It will remain open through the weekend, so team reps and/or component maintainers will have a little time.

Next week the component maintainers should review the tickets in that thread, and then a date for 5.3 will become the target.

Calls from component maintainers

@azaozz, the maintainer for “Upload” is planning to do a “refresh” there. Mostly dev tickets that can be unblocked and fixed. He’s going to come up with a list and share it.

Open Floor

The question of if it made sense to have New Contributor office hours in #core-editor. This question was largely ignored in favor of talking about open issues, but @jorbin came in at the end to say yes since the more it is easy to contribute, the more contributors there will be.

The number of open issues in the editor component was discussed with issues being somewhat fragmented between the Gutenberg GitHub and trac. @aduth suggested using one of the core-editor scrubs each week to focus on the trac tickets. @karmatosed volunteered to organize such a scrub along with @desrosj. It will take place May 24, 2019 at 17:00 UTC in #core-editor

Along the same lines, the question of how to support the classic editor was brought up. In general, no enhancements will be added to it and bugs should be tracked in trac.

#5-3, #5-2-1, #devchat, #summary

Dev Chat Summary: May 1

Announcements

Josepha (@chanthaboune) has published a 5.0 retrospective wrap up. There are two questions at the end of the post that you are encouraged to discuss in the comments. Thank you for the time and care you have put into this, Josepha! You can find this retrospective wrap up at the following post:

5.2 updates

RC2 is planned for tomorrow with the target release date ~5 days (May 7).

Josepha brought attention a few items pending:

  1. #47093 – related to the recovery mode email translations. There’s a potential solution being worked on, but it needs review.
  2. #47070 – related to the Recovery Mode Exit button. Design input and a patch is needed, and then it will also need review.
  3. #46901 – related to the About page. A final patch is incoming that will need review.

Most tasks pending for the above tickets have an owner, but it was mentioned by Jonathan (@desrosj) that particular testing and attention to #47093 – recovery mode email translations is encouraged and appreciated.

@audrasjb asked for an idea of the timing for RC 2 tomorrow. Josepha mentioned that it will likely be in the windows of between 1430-1630 UTC and again around 2030 UTC. The earlier window is preference.

5.3

It would be great to start planning scope/teams/timing etc. for 5.3. (potential agenda item for next week!) Jonathan mentioned that we may be able to start the 5.3 branch in trunk after RC2 has released.

Open Floor

WP Campus’ Accessibility audit released today

A big thank you to WP Campus for this important initiative! You can find the blog post announcing the audit here: https://wpcampus.org/2019/05/gutenberg-audit-results/

#5-2, #core-editor, #design, #devchat, #summary

Dev Chat Summary: April 24

Announcements

Josepha (@chanthaboune) is working on bringing us a 5.0 retrospective wrap up, a project digest, and a team lead interest form. She is planning to publish the retrospective wrap up this week and potentially the project digest soon after in the following week. Thank you, Josepha!

5.2 updates

#46898 WSOD Protection could use some copy review

RC1 is planned for today, with the *target release date in ~2 weeks*

Josepha brought attention a few items needing help:

There were 11 tickets open in the 5.2 milestone but that is now down to 3 as of writing this summary. @pento worked through a bunch the evening prior to devchat and @sergeybiryukov has been lending a hand today. Many of these will be moved out of the milestone, but if there are any still at this link, feel free to discuss or do the next step.

The about page outline will be ready for RC1 and will be final in the final release. Most of text should be in by RC-1 but it is not “frozen” in this time period.

Dev Notes

There are a few dev notes that are still in draft. @jeffpaul is working through the field guide and adding placeholders for those. It would be much appreciated if you’d finalize your notes so we can include them! Ideally these would release along side RC1.

Please use the following link as a list of what is pending for dev-notes: link here. If the dev note has been made, please remove the needs-dev-note keyword. 🙂

Open Floor

Influx in Forum issues/Trac Tickets

There was discussion around the continued cadence and nature of Minor/Major releases. @joyously said that she has noticed an influx in forum posts focused around bugs. Joy reminded us that directing folks to create tickets in the forums will help greatly in identifying common bugs. This also serves as a reminder that there are teams for triage in both Trac and the Gutenberg Github repo that would greatly appreciate the help. The Gutenberg triage has recently moved to a weekly cadence and the times are as follows:

Gutenberg #core-editor triage times are – Monday at 13:00 UTC

Gutenberg #design triage times are every Tuesday at 16:00 UTC

@jorbin punted #46293 as there was no decision made and there is a need to freeze strings. Many thumbs up emojis agreed. 👍

#5-2, #devchat, #summary

Dev Chat Summary: April 10

Announcements

Five days left to submit a talk for WordCamp US at WordCamp US 2019

5.2 updates

Beta 3 is Thursday, April 11th; target release is April 30, so focus is on final pushes.

Bug Scrubs

There are two planned bug scrubs prior to RC1. Check the post here for the schedule.

Dev Notes

Deadline for dev notes is this Friday, April 12.

Two were published on Make/Core; two more went up to Make/Themes but consensus was to move to Make/Core after some discussion. Three to four more are in the pipeline for Friday. A post on the new Site Health tool from @clorith will also get the dev-notes tag.

@earnjam noted the choices for what needs notes are coming from this Trac list and this Gutenberg list.

All 5.2 dev notes will go in the Field Guide, which will go live with the RC on April 17.

@jeffpaul has volunteered to help with the Field Guide.

Per the notes @williampatton wrote for Make/Themes: @chanthaboune clarified that she thought the best plan was to move all dev notes to Make/Core to keep them all together and ensure broader reach.

Gutenberg/editor

Deadline for Gutenberg changes to make 5.2 is also Friday, April 12. This is limited to bug fixes only.

Open Floor

Visibility of Dev Notes

@xkon started a discussion on the best way to surface dev notes for easiest access. He and other folks are now looking for All The Links and will comment on this post with their findings.

From there we’ll revisit the issue and use it to inform any changes to Make/Core and what we put on a proposed Core Contributor Handbook page.

WP Translation Day

@jeffpaul noted we’re just about a month out from WP Translation Day on May 11.

WCEU

@milana_cap put out a request for someone to lead the Core PHP team at WCEU Contributor Day.

Important dates

@chanthaboune closed with a list:

  • April 11 – WordPress 5.2 Beta 3 + soft string freeze
  • April 12 – Dev notes deadline
  • April 15 – WCUS Speaker application deadline
  • April 15 – Gutenberg 5.5 RC
  • April 17 – Gutenberg 5.5 Final
  • April 17 – WordPress 5.2 RC1 + hard string freeze (edited)

Props to @marybaum for writing this summary.

#5-2, #devchat, #summary

Dev Chat Summary: April 3

This post summarizes the weekly devchat meeting from April 3rd, 2019 ( Slack Archive).

Announcements

5.2 Beta 1 was released in March 27th, 2019. Please help test this development version for any issues.

5.2 updates

There are currently 116 open tickets in the 5.2 milestone on Trac. This list needs to be groomed and scrubbed to an empty state (excluding release related, blessed tasks) by RC1, which is currently scheduled for April 17, 2019.

Bug Scrubs

@audrasjb @jeffpaul will be coordinating some bug scrubs to help achieve this goal. Anyone else with contribution bandwidth is asked to focus on this list leading up to RC. If you currently own any tickets in this list, please work on those tickets and ensure they are accurate and ready.

Anyone is welcome to lead a bug scrub! If you have time and are interested in leading one during the next 13 days, please reach out to @chanthaboune, @audrasjb, @jeffpaul, or @desrosj.

Dev Notes

Please keep an eye out for 5.2 dev notes. @earnjam is coordinating these for 5.2. If you have a change that you feel warrants a dev note, please reach out to him.

Since the last dev chat, the following note was published:

Also, please refer to the most recent “What’s New in Gutenberg?” post for details on the features and changes that will be included in 5.2. The updated packages will be published to NPM and a ticket on Trac will be opened to merge them into trunk.

Component Updates

@pento noted his appreciation for the great feedback on the proposed coding standards changes. He is planning on sorting through all of the comments in the coming week.

@jorbin noted that the public announcement for the PHP minimum version bump went out on Monday. It’s happening! 🎉

@kadamwhite mentioned that the REST API and Mobile teams are collaborating on a feature plugin for JWT authentication to allow mobile apps to communicate to Gutenberg Endpoints. Those interested should check out the GitHub repository, or join the weekly REST API meetings at 18:00 UTC on Thursdays in the #core-restapi room on the Making WordPress Core Slack instance.

Open Floor

Some open floor tickets requests:

  • Design input on #46623 is needed.
  • #46076 was requested to be moved to the 5.2 milestone.
  • #44836 was mentioned.

The next Core dev chat will be held on Wednesday, April 10, 2019 @ 20:00 UTC. Please make sure to note the time as it changed this week to account for daylight savings.

These meetings are held in the #core channel in the Making WordPress Core Slack instance.

#5-2, #devchat, #summary

Dev Chat Summary: March 27

This post summarizes the weekly devchat meeting from March 27th, 2019 ( Slack Archive ).

Announcements

5.2 updates

The release did not meet original schedule for beta 1 but is back on track and beta release process will have been kicked off by the time you are reading these notes. Gary said, “There are currently 116 open tickets, which can be reasonably tackled in 3 betas.” The current goal is getting that down to 66 open tickets before beta 2. Target release for 5.2 is April 30. More info here: https://make.wordpress.org/core/5-2/

Coding standards changes up for discussion: Be on the lookout at /news for wider awareness to the update.

Calls from component maintainers

The JavaScript crew have published a post on how to build plugins that use modern JavaScript, which I’m sure they’d appreciate feedback on: https://make.wordpress.org/core/2019/03/25/building-javascript/

Editor folks have a block registration RFC that that’d love your input on:

https://github.com/WordPress/gutenberg/pull/13693

@desrosj mentioned #46195https://core.trac.wordpress.org/ticket/46195 and it was agreed the latest patch can move it forward as long as we provide dev notes on edge cases.

Open Floor

@elrae asked “Will the Classic Editor continue to disable other parts of Gutenberg as it rolls out? Specifically widgets and menu areas?” This is still to be determine but @pento mentioned, “Widgets and menu areas are much more contained, on the other hand, and can likely be made largely backwards compatible.”

@dmsnell mentioned #46199 which is a bug causing some unexpected editor crashes. We would love for someone familiar with the REST API to look into it. @pento said, “I think your patch looks like a reasonable change, but I’d like to get some input from some REST API folks before we commit it.”

@peterwilsoncc provided a very important reminder about being welcoming, “I’ve noticed a few facepalm, eye-roll and similar emoji reactions in Slack to tickets reported against long term design decisions of WP. Often these are from new contributors. Can everyone please avoid these as they can be intimidating for potential new contributors lurking in the room to get a feel for the project. I’ve experienced this feeling myself, lurking elsewhere to get the lay of the land.”


See you next Wednesday at the new Dev Chat time of 20:00 UTC. This adjustment is as a result of daylight savings time.

These meetings are held in the #core channel in the Making WordPress Slack.

#5-2 #devchat #summary

Dev Chat Summary: March 13

This post summarizes the weekly devchat meeting from March 13th, 2019 (agendaSlack archive).

  • Announcements
  • 5.2 updates
    • There’s a call for testing on the Block Manager (for languages specifically).
    • There’s a call for feedback/testing for PHP compatibility with plugin updates and activation.
    • There’s a call for copyediting on Site Health Check.
    • Devnotes have a target publish date of April 10. Flag any features that still need notes.
      • It was noted that these are published to make.wordpress.org/core, and there are publishing guidelines to get people started.
  • Calls from component maintainers
    • There are a few requests for feedback and testing from various components and focuses.
      • Open invitation to come learn more about Theme reviews! Ping @williampatton in Slack for more info.
      • Testing/review: https://core.trac.wordpress.org/ticket/44005
      • Testing (w/ Input Method Editor converters): https://core.trac.wordpress.org/ticket/45371
      • Review: https://core.trac.wordpress.org/ticket/41074
    • @chanthaboune noted that @jeffpaul is completing a fresh audit of the existing component maintainers.
  • Open Floor
    • Timing: Media has moved their meeting to13:00-14:00 UTC on Thursdays.
    • Timing: Devchat will move after European Daylight Saving Time begins (so, our Apr 3 meeting)

These meetings are held in the #core channel in the Making WordPress Slack.

#5-2 #devchat #summary

Media Meeting Recap – February 7, 2019

Overview

The following is a summary of the weekly media component meeting that occurred on Thursday, February 7, 2019. Weekly media meetings are held every Thursday at 21:00 UTC. A full transcript can be found here in the #core-media room in the Make WordPress Slack.

Attendees: @antpb, @aaroncampbell, @mikeschroder, @designsimply, @sergeybiryukov, @pbiron, @swinterroth, @dave_navarro

Triage

The agenda today was extended ticket triage for this list.

  • #41753: _wp_get_attachment_relative_path uses hardcoded uploads directory path: noted that it affects multisite and needs testing.
  • #41816: attachment_url_to_postid() should find post_id for URLs of intermediate size images: patch was previously abandoned because the heuristic wasn’t reliable, @pbiron will dig up the gist and leave a comment. In summary: #44095 and #42437 need to be fixed before moving forward with a revised patch for #41816.
  • #41922: Gallery hard to open for edit – rtl (hebrew) version: @antpb will test and leave feedback in the ticket.
  • #42063: Media: Indicate if image is used as a site option: @mikeschroder will leave a reply. It’s already future release.
  • #42487: Avoid redundant crops for all Customizer media controls: moved to future release.
  • #42751: Can we please enqueue media-views independently? @antpb offered to move the question about how mediaelement CSS is loaded to a separate issue. No consensus on the original question, left in awaiting review.

Next meeting

The next weekly media meeting will be held on Thursday, February 14, 2019, at 21:00 UTC in the #core-media room in the Make WordPress Slack.

#media, #summary

JavaScript chat summary, January 22nd, 2019

Below is a summary of the discussion from this week’s JavaScript chat (agendaSlack Transcript)

Have a topic for discussion for the next meeting? Leave a suggested edit on next week’s agenda.

Agenda: NPM Scripts

Slack Conversation

A few new commands have been proposed for addition to the @wordpress/scripts module:

  • build and start: https://github.com/WordPress/gutenberg/pull/12837
  • format: https://github.com/WordPress/gutenberg/pull/13394

The discussion around build and start focused mostly on the question how to approach default configuration for plugins and themes. We’re considering to extract parts of the Webpack config as npm package to simplify setup for plugin developers. This would also allow to provide a default config for @wordpress/scripts and proposed scripts. To provide flexibility, it was raised that an eventual Webpack config package could have 3 types of exports:

  • A full webpack config with a simple preset entries map for simple starter plugins ( front.js, admin.js, blocks.js or something like that ) to provide a simple zero-config option
  • A function that takes an entries map and outputs the full webpack config with recommended values.
  • Each part of the recommended config as their own keys.

The discussion provided good input for further iteration. Next, progress was shared on the format command, which aims to provide autoformatting functionality using Prettier and Eslint autofixers. It is still in an experimental state, but would provide a powerful tool for developers to more easily adhere to coding standards.

Agenda: Linting

Slack Conversation

We discussed the lack of ES2015+ rules in the WordPress JavaScript coding standards. A pull request was proposed on Gutenberg which makes using Object shorthand notation required for Gutenberg JavaScript. We agreed this was a desirable standard to have for ES2015+ code. For now, we decided to include the rule in the Gutenberg coding guidelines until a formal proposal to include ES2015+ rules in the WordPress JavaScript coding standards is drafted.

Agenda: E2E tests in core

Slack Conversation

Progress is being made on making Gutenberg’s e2e test functionality reusable for WordPress core and beyond. @gziolo gave the following status update:

  • Added package for Axe API integration with Jest and Puppeteer: https://github.com/WordPress/gutenberg/pull/13241. This is set of tools for accessibility static analysis which we want to integrate with e2e tests to ensure that we can catch regressions early on.
  • Extracted test utils to their own @wordpress/e2e-test-utils package: https://github.com/WordPress/gutenberg/pull/13228. It will allow some code reuse for those who would like to start writing e2e tests for their WordPress sites, plugins or themes.
  • Moved tests to their own @worpress/e2e-tests package: https://github.com/WordPress/gutenberg/pull/12465. There are now located in packages/e2e-tests/specs folder.

@gziolo plans to continue working on enabling a11y support to e2e tests in Gutenberg next. In order to start reusing the e2e setup in WordPress core, quite some configuration is still needed in WordPress core. This is tracked in https://core.trac.wordpress.org/ticket/45165. @adamsilverstein agreed to explore this further.

Agenda: PropTypes and React Doc Generation

Slack Conversation

@ajitbohra proposed to add PropTypes to components in Gutenberg, in order to allow automated documentation generating and have type checking for components.

There was interest in the idea but also some concerns were raised:

  • There is some uncertainty of PropTypes’ future, considering that Facebook doesn’t use them and there exist other type systems which supersede them (Flow, TypeScript). PropTypes seems like a good solution for what we need right now, but in terms of type system, there might be better solutions available.
  • If they’re added, we need to make sure they are added as part of a proposal which also includes how they are going to be used, ie. for auto-documentation.

For now, we decided to avoid to add complexity without clearly understanding the merit. More exploration is needed on auto-documentation and the benefits of strong typing.

#core-js, #javascript, #meeting-notes, #summary

Media Meeting Recap – January 17, 2019

Overview

This post is a summary of the latest weekly Media component meeting, which took place in the #core-media Slack channel, on Thursday, January 17, 2019 at 21:00 UTC. The purpose of these meetings are to move priority tasks forward, provide feedback on issues of interest, and review media focused issues.

Attendees: @joemcgill @mikeschroder @karmatosed @desrosj @antpb @aaroncampbell @designsimply

Transcript: Read on Slack

5.1.0 Triage

Earlier in the day, @aaroncampbell, @mikeschroder, and @desrosj cleared the list of tickets reported against trunk awaiting review.

During the meeting, attendees scrubbed the remaining Media tickets in the 5.1.0 milestone.

  • #40590: wp_video_shortcode always adds controls=”controls”: The team wasn’t confident in the current approach. Punted to future release.
  • #45407: Add block attributes to wp_calculate_image_sizes to allow for proper handling of sizes attribute: This doesn’t seem to be ready for 5.1 but @joemcgill will make a final determination this week.
  • #40175: Upload Validation / MIME Handling: @joemcgill uploaded a patch this week. @pento reviewed and this will likely fall out of 5.1 and be marked for early 5.2. Testing/feedback is appreciated.
  • #44563: WordPress 4.9.7 Media delete changes break plugins deleting media via stream wrappers: No movement this week, punted to future release.
  • #44760: Media library module dates filter doesn’t fully display: @mikeschroder is owning and will either commit or punt.
  • #44836: Uploaded plugin installation page: There is an extra tag messing with a link: No movement. Punted to future release.
  • #45633: finfo_file() returns text/plain for json file instead of application/json: This is punted to future release, pending #40175.
  • #43826: get_post_galleries() should return gallery blocks: This remains a blessed task for now.
  • #45707: Add parameter $real_mime to wp_check_filetype_and_ext: This might land as a relief while #40175 is pending, as long as it doesn’t introduce future compatibility challenges.

Recent Trac Bulk Edit

The team discussed how we should handle the recent bulk edit closing of tickets. Of the tickets closed, 163 are Media component tickets. The general consensus is that we shouldn’t leave them as wontfix but no final decisions were made. Next steps are for everyone to leave feedback on the original P2 about how to handle this project wide, and we will plan to make a decision about Media tickets next week.

Next meeting

The next #core-media meeting is set for Thursday, January 24, 2019, 21:00 UTC. Leave any agenda suggestions in the comments of this post. See you there!

#media, #summary