Dev Chat Summary: January 10th (4.9.2 week 6)

This post summarizes the dev chat meeting from January 10th (agenda, Slack archive).

4.9.2 planning

  • Tentative release timing of 1/16 for beta, 1/23 for RC, and 1/30 for release
  • 57 tickets currently on the milestone, @sergey will be reviewing them during a bug scrub on Friday (Jan 12th) at 19:00 UTC
  • Bug scrubs for future weeks will be scheduled around 19:00 UTC on Mondays, Wednesdays, and/or Fridays by @sergey and @desrosj

Updates from focus leads and component maintainers

  • Design team would like to check in with the other teams and see if anyone has projects they need designers for in the next couple months. If you have needs then please reach out in the #design channel.
  • REST API team would like to know if your work would be aided by API improvements or is blocked by API issues; if so, please come see them in #core-restapi.
  • Media and PHP teams have posted their meeting recaps from the past week for review.

Servehappy project

  • @schlessera: posted a Servehappy project overview
  • Our goal is to have a positive impact on PHP version distributions, to get a higher percentage of servers to run on supported PHP versions.
  • We have 3 main building blocks right now:
    • 1. information page about PHP, its versions, and upgrading them (see: draft)
    • 2. admin notices letting site owners know they run an old version
    • 3. plugin/theme requirements that prevent installation/updates when PHP version requirements are not met
  • @flixos90: Regarding #1, we have a Trac ticket in place. The page itself has two goals: Convince site owners that it's worth their time to take action, and then explain how they can proceed.
  • How and who do we approach to get it on wordpress.org infrastructure? Should it be hosted as an area inside .org or as a separate site with separate domain (if yes, which one)?
  • Plan to collaborate with Tide, in terms of preparing the PHP upgrade as users could check for their plugins and themes compatibility.
  • @stevenkword: We are also considering making the PHP Compatibility Checker plugin a consumer of Tide when it's production ready. Leveraging the cached results would really speed it up. We're pushing an update for 5.2 support this afternoon, and it will contain 7.1 and 7.2 checks
  • Anyone who's interested in helping out, please join our weekly meetings on Monday 16:00 UTC, and of course feel free to review what we currently have.

General announcements

  • @jorbin: I want to draw some early attention to a ticket that has the potential to impact all core contributions, especially related to JavaScript. Please take a read of #43055 and after reading it all, comment with any thoughts or concerns.
  • @audrasjb: when will we have a chance to know WP 5.0 delivery roadmap?
    • @jbpaul17: I’m not aware of any pending updates, so I’d suggest for now joining the conversation in #core-editor and helping with Gutenberg as any roadmap or timeline will come from the progress of development there.

Next meeting

The next meeting will take place on January 17, 2018 at 21:00 UTC / January 17, 2018 at 21:00 UTC in the #core Slack channel. Please feel free to drop in with any updates or questions. If you have items to discuss but cannot make the meeting, please leave a comment on this post so that we can take them into account.

#4-9-2, #core, #core-media, #core-php, #core-restapi, #design, #dev-chat, #servehappy, #summary

Media meeting recap – December 14, 2017

Overview

This post is a summary of the latest weekly Media component meeting, which took place in the #core-media Slack channel, on Thursday, December 14, 2017 at 1800 UTC. The purpose of these meetings are to move priority tasks forward, provide feedback on issues of interest, and review media focused tickets on Trac.

Attendees:
@sergey @desrosj @blobfolio @adamsilverstein @mikeschroder

Transcript: Read on Slack

4.9.2 review

The following tickets assigned to the upcoming 4.9.2 milestone were reviewed:

  • #39859 – wp.media.view.Modal jumps when you open it
  • #42225 – Whitelist Flac Files

Both tickets are looking to be in good shape for commit. Because #42225 is an enhancement, whether it ships in 4.9.2 will be up to the lead.

Media Formats

The majority of this meeting focused on various media and file-type expansions for WordPress.

#42775 – Support uploading files in HEIF and HEVC formats

Browser and PHP support for these new formats does not yet exist. There was disagreement as to whether the file types should be added to upload_mimes, and discussion will continue in the ticket.

#42017 – Parse the creation date out of uploaded audio files

@desrosj noticed that aac is not part of the upload_mimes list, though many additional media types which make use of aac are.  Opened #42919 to address this.

#35725 – Add mime-type for Webp

@blobfolio uploaded a more comprehensive patch that adds full backend support for WebP images, including GD and ImageMagick integration.

<PICTURE> Support

There was discussion on how fallback support could be handled if WordPress supported media types with less browser support, like `HEVC` or `WebP`. The HTML5 <picture> element could be used for this task, however to avoid unintended compatibility issues with existing themes, @desrosj suggested this be hidden behind add_theme_support()

Other Tickets

@mikeschroder and @adamsilverstein to review #30155 (Fix crop image functionality within edit flow) and potentially retarget for 4.9.2.

Holiday Schedule

In anticipation of busy travel schedules, the next core-media meeting is set for Thursday, January 4, 2018 at 1800 UTC. Please join us then for discussion!

Thanks much to @blobfolio for writing up the meeting notes!

#core-media, #summary

Media meeting recap – October 5, 2017

Overview

This post is a summary of the latest weekly Media component meeting, which took place in the #core-media Slack channel, on Thursday, October 5, 2017, 18:00 UTC. The purpose of these meetings are to move priority tasks forward, provide feedback on issues of interest, and review media focused tickets on Trac.

Attendees:
@joemcgill, @karmatosed, @blobfolio, @mikeschroder.

Transcript: Read on Slack

4.9 beta 1 review

First of all, I want to thank everyone who helped work on tickets the past few weeks. We were able to ship all of the enhancements that were still on the milestone before the deadline 🙌🏻.

Here are the relevant tickets with commits from this week:

  • #33981 – Default Captions Should Use max-width
  • #21819 – Reduce duplicated custom header crops int he Customizer
  • #35218 – Parse the creation date out of uploaded videos
  • #41629 – Default to “custom URL” in the image widget
  • #40894 – Use Webpack instead of Browserify for build process

Please continue testing these and provide feedback as you notice anything.

Priority tickets for the coming week (beta 2)

There are two MEJS issues, both which are close to commit:

  • #41787 – Media: JS error when removing a video/audio sourced
  • #42071 – MediaElement upgrade causing JS errors when certain languages are in use

Other high priority tickets for this week:

  • #21819 – Use an image size for custom headers instead of duplicating an attachment – @joemcgill to continue iterating here, feedback and testing welcome.
  • #37750 – Cropping custom logo should preserve attachment properties – This is closely related to #21819.
  • #41973 – HTTP Error when uploading images on PHP 7.1.9 (needs confirmation) – @mikeschroder tested and left a comment. Seems like a configuration issue but we’ll continue tracking throughout beta to see if we can help resolve on our end.
  • #40175 – Upload Validation / MIME Handling – @blobfolio refreshed the patch, which needs further testing and review.

Tickets with no owner in the 4.9 milestone:

  • #40921 – Inconsistent Handling of mp4 by Audio Widget – @toddhalfpenny since volunteered to continue working on it, just needs review.
  • #41844 – Media: audio players overflow playlist containers – @celloexpressions and @melchoyce have been working on this one.

Our next meeting is scheduled for Thursday, October 12, 2017, 18:00 UTC and will be lead by @karmatosed.

#core-media, #media

Media meeting recap – Sept 14, 2017

Overview

This post is a summary of the latest weekly Media component meeting, which took place in #core-media on Slack, on Thursday, September 14, 2017, 18:00 PM UTC. The purpose of these meetings are to move priority tasks forward, provide feedback on issues of interest, and review media focused tickets on Trac.

Attendees:
@joemcgill, @desrosj, @brainfork, @blobfolio, @jdub233, @tokyobiyori, @presskopp, @nosilver4u.

Transcript: Read on Slack

Tickets Reviewed

  • #41629: Widgets: Default to “custom URL” in the image widget – @desrosj to investigate.
  • #21819: Use an image size for custom headers instead of duplicating an attachment – The main challenge is deciding on how data should be handled so that custom crops of images are associated with the original image but do not clutter up the main media library. @joemcgill to continue working on an approach.
  • #35218: Parse the creation date out of uploaded videos – @mikeschroder did some initial testing and found some concerns with creation date parsing. Needs further investigation.
  • #33981: Default Captions Should Use max-width – Patch is ready, needs second opinion. @desrosj to look.
  • #40921: Inconsistent Handling of mp4 by Audio Widget – MP4 is not in the list of extensions returned by wp_get_audio_extensions(). Patch looks good.
  • #41844: Media: audio players overflow playlist containers – Patch looks good. Needs review.
  • #38264: Tests: Uploads aren’t deleted after running individual tests – Initial approach is on the ticket. Needs review.
  • #41704: Use a consistent title for “Add Media” button and “Insert Media” window – Assigned to @sergeybiryukov for a decision.
  • #41787: Media: JS error when removing a video/audio sourced – There’s a PR for this on GitHub which needs to be reviewed.
  • #40175: Upload Validation / MIME Handling – Added to the milestone for review/commit.
  • #40774: Refine error message when embedding invalid Video (URL) – Patch on the ticket updates the error string with a more accurate message.

Next Meeting

Next meeting will take place on Thursday, September, 21 in #core-media on Slack. The agenda will once again focus on reviewing priority tickets for 4.9.

#core-media, #media

Media meeting recap – Aug 3, 2017

Overview

This post is a summary of the latest weekly Media component meeting, which took place in #core-media on Slack, on Thursday, Aug 3 at 18:00 UTC. The purpose of these meetings are to move priority tasks forward, provide feedback on issues of interest, and review media focused tickets on Trac.

Attendees:
@joemcgill, @mikeschroder, @adamsilverstein, @desrosj, @karmatosed, @blobfolio, @flixos90, @paaljoachim.

Transcript: Read on Slack

Media + Gutenberg

@karmatosed shared the need for more help on media related tickets in the Gutenberg project. She’s prioritized high priority items, which can be viewed in this report. We discussed a few specific issues:

WordPress 4.9 Release

Now that the 4.9 release schedule is announced, we can better plan priorities for the release. While helping Gutenberg is certainly a high priority, we plan to review tickets to add to the milestone during the meeting next week.

Bug Scrubs + Call for volunteers

Over the past few weeks, @desrosj has run separate bug scrubs focussed on unanswered tickets for the Media component. The next media scrub is planned for Thursday, Aug 10 at 16:00 UTC. We’d like to alternate times of these extra scrubs so it’s easier for people in different timezones to participate. If you’re interested in contributing, look out for a survey in the #core-media room to give feedback on times that work for you for bug scrubs.

We also are looking for volunteers who are willing to help type up recap notes from these scrubs and our weekly meetings, which is a great way to get involved and learn more about the Media component. If you’re interested in helping with any of these efforts, please contact @desrosj or @joemcgill on Slack.

#media, #weekly-update

Dev Chat Summary: July 26th (4.8.1 week 6)

This post summarizes the dev chat meeting from July 26th (agendaSlack archive).

4.8.1 RC feedback & release timing

  • No issues on the widgets front
  • Those who reported breakage from 4.8 widget changes and have tested RC have said the fixes work
  • @westonruter to write a dev note
  • @westonruter and @obenland to work on 4.8.1 release on Tuesday, August 1st as per previous plan
  • @obenland to work with @pento or @azaozz on walk thru for releasing a minor version
  • Post-4.8.1 release action item: get more committers access & training on releasing / Mission Control

Editor / Gutenberg media intricacies

  • Last Fridays’ release of 0.6 slipped due to vacations, working to push it out as soon as feasible
  • Several media intricacies that could use help / discussion, especially Issue#1986
  • 100 PRs open that could use help in reviewing/testing
  • Gutenberg part of weekly agenda of #core-media meeting (Thursdays at 18:00 UTC)

General announcements

#4-8, #4-8-1, #core-editor, #dev-chat, #gutenberg, #summary

Media meeting recap – June 29, 2017

Overview

This post is a summary of the latest weekly Media component meeting, which took place in #core-media on Slack, on Thursday, June 29 at 18:00 UTC. The purpose of these meetings are to move priority tasks forward, provide feedback on issues of interest, and review media focused tickets on Trac.

Attendees:
@joemcgill, @sergeybiryukov, @mikeschroder, @adamsilverstein, @desrosj, @azaozz, @karmatosed, @matias, @youknowriad, @mkaz, @joen.

Transcript: https://wordpress.slack.com/archives/C02SX62S6/p1498759231771175

Media + Gutenberg

Our agenda this week focussed on getting a better understanding of the current product vision for working with media in Gutenberg in order to coordinate priorities and ensure future improvements to the media component align with the needs of the new editor experience.

The major takeaway from this conversation was that Gutenberg intends to handle the UI flows for editing media within post content inside the editor itself rather than relying on the wp.media.frame modal for these actions. The image gallery block in Gutenberg is a good example of this change.

Editing gallery settings in the current media modal

The current screen in the media modal for editing gallery settings

 

Editing gallery settings in the Gutenberg sidebar

A preview of editing image gallery settings in the Gutenberg sidebar

By handling post-level setting in the editor, people can immediately preview changes in the editor. This change reduces the burden of the current media modal to act primarily as media library, and as a way to manage media information that applies site-wide. This should also make it more clear when changes will affect a media item site-wide, which is a nice UX win.

Some next steps

To prepare for this shift, we need to document the current flows that will need to be adjusted in order to support this separation between managing post-level data and site-wide media library data.

Additionally, the Gutenberg team asked for help creating blocks for additional media elements like video, audio, etc. The Gutenberg GitHub repo now contains a “media” label for collecting issues that relate to the media component.

Other housekeeping items

Earlier this week, @desrosj ran a separate bug scrub focussed on new tickets on the Media component. We plan on running separate scrubs throughout the 4.9 release cycle. If you’re interested in helping with that effort, please contact @desrosj or @joemcgill on Slack.

#gutenberg, #media, #media-library, #media-modal

Media meeting recap – June 22, 2017

Overview

This post is a summary of the latest weekly Media component meeting, which took place in #core-media on Slack, on Thursday, June 22 at 18:00 UTC. The purpose of these meetings are to move priority tasks forward, provide feedback on issues of interest, and review media focused tickets on Trac.

Agenda:

  1. Media Priorities for 4.9
  2. Preparing for Gutenberg
  3. Improving bug triage/review

Attendees:
@joemcgill, @omarreiss, @adamsilverstein, @karmatosed, @mikeschroder, @mapk, @desrosj, @sergeybiryukov, @blobfolio, @afercia, @saracannon.

Transcript: https://wordpress.slack.com/archives/C02SX62S6/p1498154451224688

Media Priorities for 4.9

We spent the first part of the meeting collecting possible priority tickets for the WP 4.9 release cycle. Here are the list of tickets that were identified (in order of suggestion), but if you have additional tickets to nominate, please leave a comment on this post. Note that tickets that line up with the focuses of improving editing, site customization, and the REST API are more likely to get attention.

  • #39647: Make media upload “HTTP error.” more user-helpful
  • #40439: Save progress of intermediate image creation after upload
  • #37840: Optimize full size images
  • #30634: Media: Image cropping on mobile devices does not work
  • #17247: Crop tool is automatically selected when editing an image
  • #30155: Fix crop image functionality within edit flow
  • #39553: Use REST API endpoints for Plupload backend

Preparing for Gutenberg

During the WordPress Community Summit, several of us began having early conversations about what comes next for the wp.media UI once Gutenberg is released. Gutenberg is currently making use of the existing media flows. In coming months, there will no doubt be more conversations about how to improve the experience of publishing/editing media in WordPress, and we should start intentionally planning for how those improvements might be made.

While this process will most likely have technical implications, we should begin with research and design to make sure we understand and account for actual user needs before jumping into the code. @karmatosed has volunteered to lead that effort, starting by reaching out to the Gutenberg team about joining us during the next meeting, Thursday, June 29, at 18:00 UTC.

Improving bug triage/review

In order to facilitate conversations about larger priority efforts, we’re going to begin experimenting with running Media focused bug scrubs separately from the weekly component meetings. @desrosj graciously volunteered to head up the first few, starting next Tuesday, June 27, at 16:00 UTC. These will focus on unanswered tickets to begin, but the focus will change as we make progress on the backlog. If you’re interested in volunteering to lead a bug scrub yourself, get in touch with me (@joemcgill) or @desrosj in Slack for details.

#4-9, #core-media

Removal of core embedding support for WMV and WMA file formats

With the introduction of the video widget (#39994) and audio widget (#39995) it was discovered that the WMV and WMA file formats are no longer supported by MediaElement.js as of v3. While core is currently shipping with MediaElement.js v2.22, these file formats only play if the Silverlight plugin is installed, something which is less and less common since the plugin is no longer supported as of Chrome 45 and as of Firefox 52. So with the planned upgrade of MediaElement.js from 2.22 to 4.x (see #39686), it is a good time with the WP 4.8 major release to remove support for the formats. This has been done in [40813] for #40819.

Plugins may continue to add embedding support for these file formats by re-adding them via the wp_video_extensions and wp_audio_extensions filters, for example:

function add_wmv_to_wp_video_extensions( $extensions ) {
    $extensions[] = 'wmv';
    return $extensions;
}
add_filter( 'wp_video_extensions', 'add_wmv_to_wp_video_extensions' );

function add_wma_to_wp_audio_extensions( $extensions ) {
    $extensions[] = 'wma';
    return $extensions;
}
add_filter( 'wp_audio_extensions', 'add_wma_to_wp_audio_extensions' );

Plugins would also need to implement fallback rendering routines via the wp_video_shortcode_override and wp_audio_shortcode_override filters, or else use a different library than MediaElement.js altogether via the wp_video_shortcode_library and wp_audio_shortcode_library filters.

Note that there is no functional difference before and after the removal of WMA and WMV support. When MediaElement.js doesn’t support a format, it displays a download link. Before and after [40813], the following is ho  the audio and video shortcodes look like with WMA and WMV files respectively:

In the admin, the functional difference is that these formats are not listed as being available for selection in the Video and Audio widgets. Additionally, when you Add Media in the post editor, there is now no option to embed the player for these formats; only a link to the media will be provided, just as when attempting to add non-media files to content.

#4-8, #core-media, #dev-notes, #mediaelement

Media Weekly Meeting Recap (March 2, 2017)

This post is a summary of the latest weekly Media component meeting, which took place in #core-media on Slack, on March 2, 2017 19:00 UTC. The purpose of these meetings are to move priority tasks forward, provide feedback on issues of interest, and review media focused tickets on Trac.

Attendees: @joemcgill, @sergeybiryukov, @blobfolio, @adamsilverstein, @mikeschroder, @melchoyce, @karmatosed, @desrosj, @azaozz.

Prioritizing 4.8 tickets

With all Media tickets for 4.7.3 clear, we spent this meeting looking forward at our priorities for 4.8, which already included 12 tickets at the time of the meeting. With the focus for 4.8 being on the editor, customization, and the REST API, we discussed additional tickets that contribute to the goals of those projects or which may prepare for future enhancements in those areas. Here are a list of tickets mentioned during the meeting:

  • #39647: Make media upload “HTTP error.” more user-helpful
  • #15311 and #21295: Which are related to the previous ticket, in that decoupling the intermediate size generation from the upload process will probably be necessary.
  • #36191, #36442, and #21455: all relate to improving responsive/retina image support in the customizer.
  • #39993, #39994, and #39995: Splitting the media widget project into three separate widgets for image, video, and audio. @melchoyce mentioned that image is the priority.
  • #36581: Customizer Header Image Control should extend the cropped image control
  • #21819: Use an image size for custom headers instead of duplicating an attachment
  • #37840: Optimize full size images
  • #24251: Reconsider SVG inclusion to `get_allowed_mime_types` – @blobfolio and @enshrined have renewed interest in working on this. If you’re interested, take a look at this repo and provide testing/feedback.
  • #39963: MIME Alias Handling
  • #39883: Code hooking on `image_downsize` can no longer assume the file is an image (related: #39980). This one is a priority for the next minor release.

In the upcoming weeks, we plan to prioritize these and assign ownership to contributors in order to help people focus efforts and to help new contributors know where to get involved. This list is large, so if you’re interested in helping out, please feel free to jump in on the tickets themselves, ping in #core-media, or leave a comment below.

If there is something you feel should be prioritized that is not included on this list or already on the 4.8 milestone, please leave a comment on this post or bring it up in the #core-media channel on Slack. As always, important bug fixes will be considered as they are presented.

Next Meeting

Due to conference travel, we’ll be skipping next week’s meeting, with the next one scheduled for March 16, 2017 19:00 UTC.

#core-media, #media, #weekly-update