Media Meeting Recap – April 5

Overview

This post is a summary of the latest weekly Media component meeting, which took place in the #core-media Slack channel, on Thursday,  April 5, 2018 at 1900 UTC. The purpose of these meetings are to move priority tasks forward, provide feedback on issues of interest, and review media focused tickets on Trac.

Attendees:
@joemcgill @blobfolio @audrasjb @desrosj @mikeschroder @karmatosed @antpb

Transcript: Read on Slack

Media Meeting Time Changes

To better accommodate all the usual attendees, the team has decided to move the meeting time to one hour later, at 2000 UTC. If this is a problem for anyone who would like to attend, please comment on the post or in #core-media!

Gutenberg

This meeting was primarily focused around Gutenberg Media Triage using this filter as the reference. 

  • The best way to follow along with media related Gutenberg items is the media label in GitHub.
  • Repository milestones
  • 5240  mediaelement component needed for audio and video blocks –  discussion took place around the desired experience for a v1 of the audio/video features. It was decided best to continue on the path to getting the audio block and mediaElement component finished out on this one. @joemcgill agreed to help test. 
  • 5209 Fix Image Alignment@joemcgill mentioned some backwards compatibility concerns and expressed them in this comment on the issue
  • 4914  Enhancement: Inspector interface for setting pixel dimensions of image – This sparked a conversation around a need for contributors to share any media flow discrepancies. In the case of the discussion our concerns were around things like the edit image modal looking different from core’s implementation.
  • 4612   Media Library doesn’t update after dragging image onto Image block@antpb and @joemcgill to do testing on this one to verify the media-upload button is working.
  • 4491  Gallery block: editing a gallery uses “Insert gallery” button –  @antpb to investigate. This is another example of workflows needing to be tested to identify these problems.
  • 3945 Right-align small images pinned to top-left of boxblock – This is likely a CSS issue. @antpb mentioned it may also be the block adopting the formatting bar’s width causing the weirdness. 

Next Meeting

The next #core-media meeting is set for Thursday, April 12, 2018 at 1900 UTC. See you there!

Media Meeting Recap – March 29

Overview

This post is a summary of the latest weekly Media component meeting, which took place in the #core-media Slack channel, on Thursday,  March 29, 2018 at 1900 UTC. The purpose of these meetings are to move priority tasks forward, provide feedback on issues of interest, and review media focused tickets on Trac.

Attendees:
@joemcgill @blobfolio @audrasjb @desrosj @mikeschroder @karmatosed @antpb

Transcript: Read on Slack

Gutenberg

  • The best way to follow along with media related Gutenberg items is the media label in GitHub.
  • Repository milestones
  • @karmatosed expressed a need for media maintainers to ensure that what is being proposed for MVP/Feature complete is accurate. Issues related to this can be found using the media label or by following this link: https://github.com/WordPress/gutenberg/labels/Media
  • Add mediaelement component@antpb has updated the repo to include some bug fixes. Testing is still needed to determine the issue with loading mediaElement on the front end. Steps to creating a clone of the repo can be found at this comment.
  • Add block playlist: Currently blocked by the inclusion of the mediaElement component.
  • @desrosj asked "Are there “groups” in GitHub? Thinking something similar to @ committers in Slack that would notify a group of people?" Investigation is needed into subscribing to labels in Github. If anyone has any ideas, please comment below. RSS was mentioned as a possibility but confirmation would be much appreciated.

4.9.5 Tickets

The next part of the meeting was spent on tickets in the 4.9.5 milestone

  • #42919 – Unable to upload files with the AAC extension
    @desrosj mentioned "the ticket was specifically just for allowing a user to upload a file with .aac extension. The mime type was already allowed (when a different file extension was used), but when the file extension was explicitly .aac it would get blocked." The commit in the ticket adds support to display the .aac in an embed. @blobfolio and @desrosj did some upload testing and found that in Firefox, there were issues. @mikeschroder suggested that we should revert the extra functionality and explore embedding in a different ticket. @joemcgill concurred that he'd like to see further exploration of rendering in a cross-platform manner.

Open Floor

  • #43642 – Gallery titles and labels erasing
    @antpb mentioned this maybe being plugin territory. @desrosj mentioned a risk in the way that galleries save back to the attachment post. This may have some Gutenberg compatibility issues as well. We are going to mark this one with reporter feedback needed because there's a possibility that they want to create a gallery without any titles or they are wanting to replace the titles/labels. Seeing video/screenshots of their current workflow would be helpful.  

Next Meeting

The next #core-media meeting is set for Thursday, April 5, 2018 at 1800 UTC. See you there!

#core-media, #media, #summary

Media Meeting Recap – March 23

Overview

This post is a summary of the latest weekly Media component meeting, which took place in the #core-media Slack channel, on Thursday,  March 23, 2018 at 1900 UTC. The purpose of these meetings are to move priority tasks forward, provide feedback on issues of interest, and review media focused tickets on Trac.

Attendees:
@joemcgill @blobfolio @desrosj @mikeschroder @karmatosed @antpb @adamsilverstein

Transcript: Read on Slack

Gutenberg

4.9.5 Tickets

The next part of the meeting was spent on tickets in the 4.9.5 milestone

Tickets needing testing:

  • #42017 – Parse the creation date out of uploaded audio files
    @desrosj has reclassified this ticket as enhancement.
  • #33979 – Add filter for 'postgalleryitem'
    @desrosj is looking into adding attributes to the tag in addition to just making a class filter. We will need to investigate if this helps Gutenberg in any way. 
  • #43046has_image_size() returns false for Core image sizes
    
    @desrosj is researching this one.
  • #9257 – EXIF GPS data
    Due to GDPR compliance, decided that this should live in plugin territory for now. Lots of great work going on in the ticket, and would be a solid plugin! 

Next Meeting

The next #core-media meeting is set for Thursday, March 29, 2018 at 1800 UTC. As both the EU and US have now moved to DST, you'll note the time has been shifted one hour earlier. Hope to see you there!

#core-media, #media, #summary

Media Meeting Recap – March 8

Overview

This post is a summary of the latest weekly Media component meeting, which took place in the #core-media Slack channel, on Thursday,  March 8, 2018 at 1900 UTC. The purpose of these meetings are to move priority tasks forward, provide feedback on issues of interest, and review media focused tickets on Trac.

Attendees:
@mikeschroder @antpb @desrosj @karmatosed @postphotos @joemcgill @sergey @chetan200891 @adamsilverstein 

Transcript: Read on Slack

Gutenberg

  • The best way to follow along with media related Gutenberg items is the media label in GitHub.
  • Repository milestones
  • Add mediaelement component@antpb discussed that this is currently a blocker to building the Playlist Block. The component renders on the editor view and is enqueuing via client-assets.php but the script is not enqueuing on the front end. @antpb needs help figuring out the front end issue. Steps to creating a clone of the repo can be found at this comment.
  • Add block playlist: Currently blocked by the inclusion of the mediaelement component.

4.9.5 Tickets

The next part of the meeting was spent on tickets in the 4.9.5 milestone

Tickets needing testing:

  • #42724 – Options media page hides breaks on desktop
    Patch still needs testing.
  • #42968 – Media: Grid View: new upload, file is in the wrong position in the grid until after upload is complete
    Agreement all around that it is ready to commit.
  • #43226 – Crop setting in thumbnails never set when uploading PDF files
    Committed to trunk. It was agreed that this will be fixed in 4.9.5. @mikeschroder is working on backports.
  • #43255 – WP _Image_Editor::make_image leaves an output buffer open on failure
    This one has been open for a while but is in need of clean up. Mentioned by @mikeschroder we "want to be sure what we do doesn't break workarounds."

Tickets up for discussion:

#43123 Default captions should NOT use max-width
@joemcgill mentioned that he thinks it is worth reverting due to unintended consequences. @mikeschroder noted that "we’ll want to be sure to message folks and give a warning if we do revert."

Next Meeting

The next #core-media meeting is set for Thursday, March 15, 2018 at 1900 UTC Note: The time is maintained in UTC, so if you are in the US, this time may be different due to DST. We'll move the meeting time once EU has switched to DST in two weeks. Hope to see you there!

#core-media, #media, #summary

Media Meeting Recap – March 1

Overview

This post is a summary of the latest weekly Media component meeting, which took place in the #core-media Slack channel, on Thursday,  March 1, 2018 at 1900 UTC. The purpose of these meetings are to move priority tasks forward, provide feedback on issues of interest, and review media focused tickets on Trac.

Attendees:
@mikeschroder @antpb @desrosj @karmatosed @blobfolio @chetan200891 @jdub233

Transcript: Read on Slack

Gutenberg

  • The best way to follow along with media related Gutenberg items is the media label in GitHub.
  • Repository milestones
  • Add mediaelement component – This issue was created by @antpb in an attempt to separate the mediaelement component required to make progress on the playlist block. Included in these changes is an update to the Audio block to utilize the component. Currently the component renders on the editor view and is enqueuing via client-assets.php but the script is not enqueuing on the front end. Needs investigation.
  • Add block playlist: Currently blocked by the inclusion of the mediaelement component.

4.9.5 Tickets

The next part of the meeting was spent on tickets in the 4.9.5 milestone

Tickets needing testing:

  • #42724 – Options media page hides breaks on desktop
    • Patch still applies clean, testing needed.

Tickets up for discussion:

#43255 WP_Image_Editor::make_image leaves an output buffer open on failure

This has been committed for 5.0, but @mikeschroder mentioned some worry around changing output buffers for a minor release.

The following ticket needs a combination of code review and approval:

#43226 – Crop setting in thumbnails never set when uploading PDF

@mikeschroder is going to test #43226

5.0 Tickets

The next part of the meeting was spent on tickets in the 5.0 milestone

#9257: EXIF GPS data

#9257 is a ticket to process EXIF GPS and store it in meta, but not exposing that data unless a plugin or theme uses it for something. In WordPress' current state, the original file is not stripped of any geolocation data and anyone could potentially find that information. This sparked the question of whether the user should be informed that location data is present in an uploaded image file. #43454 was created in response to this.

#43454 – Add UI elements to make the user aware of image geo data

Some concern was expressed about the potential for a user to unknowingly exposing location data in #9257 activating a plugin or theme that utilizes it. Some ideas that were passed around to better inform the user about images containing GPS data:

  • Showing a warning when an image is uploaded that contains GPS data.
  • Showing a general notice
  • Showing a globe icon in the corner of the image thumbnail in the media library.
  • Showing the coordinates in the attachment info pane when editing an attachment (maybe with information about the data).
  • A general warning at the top of the upload screen.

Further discussion and initial patches can be found in the ticket.

Next Meeting

The next #core-media meeting is set for Thursday, March 8, 2018 at 1900 UTC. Hope to see you there!

#core-media, #media, #summary

Media Meeting Recap – February 15, 2018

Overview

This post is a summary of the latest weekly Media component meeting, which took place in the #core-media Slack channel, on Thursday, February 15, 2018 at 1900 UTC. The purpose of these meetings are to move priority tasks forward, provide feedback on issues of interest, and review media focused tickets on Trac.

Attendees:
@mikeschroder @antpb @blobfolio @flixos90 @jdub233 @sergey @desrosj @azaozz

Transcript: Read on Slack

Gutenberg

  • The best way to follow along with media related Gutenberg items is the media label in GitHub.
  • Repository milestones have been re-arranged to make it easier to see what is going on.
  • Add block playlist: A discussion took place around how mediaElement should be added to Gutenberg. The two options discussed were to include it in the npm package list or make a global instance of Core's mediaElement Library. Consensus was to go with Core's implementation. @antpb is blocked on the playlist block with lack of mediaElement component. He is working on building a mediaElement REACT component that will need to be utilized in the audio and video blocks. Before this is complete enough to merge, he'll need some help understanding how to make the Core library globally accessible in Gutenberg.

5.0 Tickets

The next part of the meeting was spent on tickets in the next major milestone (5.0).

#33979 – Add filter for 'post_gallery_item'
#38228 – Add filter to default gallery shortcode output

Discussion around how granular gallery filters should be. With #3379 we gain a filter to add  styles individually per item in the Gallery. It was discussed that we will need tickets to add more granular filters going forward for captions and other image attributes. From @desrosj : "Currently the shortcode builds the HTML string as it goes. I think if the attributes were built in an associative array, that could just be filtered, and then the element built at the end. That could allow additional attributes to be added, widths to be changed for specific images making it easier to do different grid layouts." This sparked the question above around how Gutenberg will handle backwards compatibility with filtered attributes.

The following tickets need a combination of code review and approval:

  • #33979 – Add filter for 'post_gallery_item'

Seems good to go as a first step towards more granular Gallery filters if it won’t make it more difficult for Gutenberg to provide backcompat.

Next Meeting

The next #core-media meeting is set for Thursday, February 22, 2018 at 1900 UTC. Hope to see you there!

#core-media, #media, #summary

Media Meeting Recap – February 1, 2018

Overview

This post is a summary of the latest weekly Media component meeting, which took place in the #core-media Slack channel, on Thursday, February 1, 2018 at 1900 UTC. The purpose of these meetings are to move priority tasks forward, provide feedback on issues of interest, and review media focused tickets on Trac.

Attendees:
@antpb @blobfolio @desrosj @karmatosed @mikeschroder @postphotos

Transcript: Read on Slack

Gutenberg

  • The best way to follow along with media related Gutenberg items is the media label in GitHub.
  • Repository milestones have been re-arranged to make it easier to see what is going on.
  • Milestone #33 is coming up. There are two media issues, but the primary focus is: Add block playlist. A decision was reached to punt this issue to 2.3. @antpb needs some background on the mediaElementobject is used for the media player.

4.9.4 (now 4.9.5) Tickets

The next portion of the meeting was dedicated to going through blessed tickets in the next minor milestone. All three were deemed in a good place with good direction.

  • #42968 – Media: Grid View: new upload, file is in the wrong position in the grid until after upload is complete
  • #43201 – PHP Warning: count(): Parameter must be an array or an object that implements Countable in /wp-includes/media.php on line 1206
  • #42724 – Options Media page hides breaks on desktop

5.0 Tickets

The next part of the meeting was spent on blessed tickets in the next major milestone (5.0).

#42919 – Unable to upload files with the AAC extension

Discussion around whether AAC files could be embedded lead to the realization that AAC also needs to be added to `wp_get_audio_extensions()`. Firefox appears to have a few issues with AAC. Some testing needs to be done to see if this can be done in the same ticket, or if a new one is more appropriate. @desrosj will do some digging.

The following tickets need a combination of code review and approval:

  • #40921 – Inconsistent Handling of mp4 by Audio Widget
  • #42463: Poor Description of add_image_size Params
  • #42017: Parse the creation date out of uploaded audio files

5.0 Suggested Tickets

#9257 – EXIF GPS data

Has good direction, but needs some feedback to make any adjustments. #42479 was closed as a duplicate on the premise that there is no GPS information in audio/video besides any in the associated image. In his initial testing, @desrosj remembers there being some GPS information on video files, but more testing is needed before it can be re-opened. Files from popular devices would need to be provided as well.

#43046has_image_size() returns false for Core image sizes

Backwards compatibility issues need to be fully explored for this ticket. At minimum, the inline documentation should be updated to more accurately reflect what is happening in the function. At maximum, a new boolean parameter could be added indicating whether core image sizes should be included in the list checked against. An example of where this may be very useful is preventing issues when a plugin or theme removes a core image size (if this is possible – needs research).

Next Meeting

The next #core-media meeting is set for Thursday, February 8, 2018 at 1900 UTC. Hope to see you there!

#core-media, #media, #summary

Media meeting recap – December 14, 2017

Overview

This post is a summary of the latest weekly Media component meeting, which took place in the #core-media Slack channel, on Thursday, December 14, 2017 at 1800 UTC. The purpose of these meetings are to move priority tasks forward, provide feedback on issues of interest, and review media focused tickets on Trac.

Attendees:
@sergey @desrosj @blobfolio @adamsilverstein @mikeschroder

Transcript: Read on Slack

4.9.2 review

The following tickets assigned to the upcoming 4.9.2 milestone were reviewed:

  • #39859 – wp.media.view.Modal jumps when you open it
  • #42225 – Whitelist Flac Files

Both tickets are looking to be in good shape for commit. Because #42225 is an enhancement, whether it ships in 4.9.2 will be up to the lead.

Media Formats

The majority of this meeting focused on various media and file-type expansions for WordPress.

#42775 – Support uploading files in HEIF and HEVC formats

Browser and PHP support for these new formats does not yet exist. There was disagreement as to whether the file types should be added to upload_mimes, and discussion will continue in the ticket.

#42017 – Parse the creation date out of uploaded audio files

@desrosj noticed that aac is not part of the upload_mimes list, though many additional media types which make use of aac are.  Opened #42919 to address this.

#35725 – Add mime-type for Webp

@blobfolio uploaded a more comprehensive patch that adds full backend support for WebP images, including GD and ImageMagick integration.

<PICTURE> Support

There was discussion on how fallback support could be handled if WordPress supported media types with less browser support, like `HEVC` or `WebP`. The HTML5 <picture> element could be used for this task, however to avoid unintended compatibility issues with existing themes, @desrosj suggested this be hidden behind add_theme_support()

Other Tickets

@mikeschroder and @adamsilverstein to review #30155 (Fix crop image functionality within edit flow) and potentially retarget for 4.9.2.

Holiday Schedule

In anticipation of busy travel schedules, the next core-media meeting is set for Thursday, January 4, 2018 at 1800 UTC. Please join us then for discussion!

Thanks much to @blobfolio for writing up the meeting notes!

#core-media, #media, #summary

Media meeting recap – October 5, 2017

Overview

This post is a summary of the latest weekly Media component meeting, which took place in the #core-media Slack channel, on Thursday, October 5, 2017, 18:00 UTC. The purpose of these meetings are to move priority tasks forward, provide feedback on issues of interest, and review media focused tickets on Trac.

Attendees:
@joemcgill, @karmatosed, @blobfolio, @mikeschroder.

Transcript: Read on Slack

4.9 beta 1 review

First of all, I want to thank everyone who helped work on tickets the past few weeks. We were able to ship all of the enhancements that were still on the milestone before the deadline 🙌🏻.

Here are the relevant tickets with commits from this week:

  • #33981 – Default Captions Should Use max-width
  • #21819 – Reduce duplicated custom header crops int he Customizer
  • #35218 – Parse the creation date out of uploaded videos
  • #41629 – Default to “custom URL” in the image widget
  • #40894 – Use Webpack instead of Browserify for build process

Please continue testing these and provide feedback as you notice anything.

Priority tickets for the coming week (beta 2)

There are two MEJS issues, both which are close to commit:

  • #41787 – Media: JS error when removing a video/audio sourced
  • #42071 – MediaElement upgrade causing JS errors when certain languages are in use

Other high priority tickets for this week:

  • #21819 – Use an image size for custom headers instead of duplicating an attachment – @joemcgill to continue iterating here, feedback and testing welcome.
  • #37750 – Cropping custom logo should preserve attachment properties – This is closely related to #21819.
  • #41973 – HTTP Error when uploading images on PHP 7.1.9 (needs confirmation) – @mikeschroder tested and left a comment. Seems like a configuration issue but we’ll continue tracking throughout beta to see if we can help resolve on our end.
  • #40175 – Upload Validation / MIME Handling – @blobfolio refreshed the patch, which needs further testing and review.

Tickets with no owner in the 4.9 milestone:

  • #40921 – Inconsistent Handling of mp4 by Audio Widget – @toddhalfpenny since volunteered to continue working on it, just needs review.
  • #41844 – Media: audio players overflow playlist containers – @celloexpressions and @melchoyce have been working on this one.

Our next meeting is scheduled for Thursday, October 12, 2017, 18:00 UTC and will be lead by @karmatosed.

#core-media, #media

Media meeting recap – Sept 14, 2017

Overview

This post is a summary of the latest weekly Media component meeting, which took place in #core-media on Slack, on Thursday, September 14, 2017, 18:00 PM UTC. The purpose of these meetings are to move priority tasks forward, provide feedback on issues of interest, and review media focused tickets on Trac.

Attendees:
@joemcgill, @desrosj, @brainfork, @blobfolio, @jdub233, @tokyobiyori, @presskopp, @nosilver4u.

Transcript: Read on Slack

Tickets Reviewed

  • #41629: Widgets: Default to “custom URL” in the image widget – @desrosj to investigate.
  • #21819: Use an image size for custom headers instead of duplicating an attachment – The main challenge is deciding on how data should be handled so that custom crops of images are associated with the original image but do not clutter up the main media library. @joemcgill to continue working on an approach.
  • #35218: Parse the creation date out of uploaded videos – @mikeschroder did some initial testing and found some concerns with creation date parsing. Needs further investigation.
  • #33981: Default Captions Should Use max-width – Patch is ready, needs second opinion. @desrosj to look.
  • #40921: Inconsistent Handling of mp4 by Audio Widget – MP4 is not in the list of extensions returned by wp_get_audio_extensions(). Patch looks good.
  • #41844: Media: audio players overflow playlist containers – Patch looks good. Needs review.
  • #38264: Tests: Uploads aren’t deleted after running individual tests – Initial approach is on the ticket. Needs review.
  • #41704: Use a consistent title for “Add Media” button and “Insert Media” window – Assigned to @sergeybiryukov for a decision.
  • #41787: Media: JS error when removing a video/audio sourced – There’s a PR for this on GitHub which needs to be reviewed.
  • #40175: Upload Validation / MIME Handling – Added to the milestone for review/commit.
  • #40774: Refine error message when embedding invalid Video (URL) – Patch on the ticket updates the error string with a more accurate message.

Next Meeting

Next meeting will take place on Thursday, September, 21 in #core-media on Slack. The agenda will once again focus on reviewing priority tickets for 4.9.

#core-media, #media