Media Meeting Recap – January 17, 2019

Overview

This post is a summary of the latest weekly Media component meeting, which took place in the #core-media Slack channel, on Thursday, January 17, 2019 at 21:00 UTC. The purpose of these meetings are to move priority tasks forward, provide feedback on issues of interest, and review media focused issues.

Attendees: @joemcgill @mikeschroder @karmatosed @desrosj @antpb @aaroncampbell @designsimply

Transcript: Read on Slack

5.1.0 Triage

Earlier in the day, @aaroncampbell, @mikeschroder, and @desrosj cleared the list of tickets reported against trunk awaiting review.

During the meeting, attendees scrubbed the remaining Media tickets in the 5.1.0 milestone.

  • #40590: wp_video_shortcode always adds controls=”controls”: The team wasn’t confident in the current approach. Punted to future release.
  • #45407: Add block attributes to wp_calculate_image_sizes to allow for proper handling of sizes attribute: This doesn’t seem to be ready for 5.1 but @joemcgill will make a final determination this week.
  • #40175: Upload Validation / MIME Handling: @joemcgill uploaded a patch this week. @pento reviewed and this will likely fall out of 5.1 and be marked for early 5.2. Testing/feedback is appreciated.
  • #44563: WordPress 4.9.7 Media delete changes break plugins deleting media via stream wrappers: No movement this week, punted to future release.
  • #44760: Media library module dates filter doesn’t fully display: @mikeschroder is owning and will either commit or punt.
  • #44836: Uploaded plugin installation page: There is an extra tag messing with a link: No movement. Punted to future release.
  • #45633: finfo_file() returns text/plain for json file instead of application/json: This is punted to future release, pending #40175.
  • #43826: get_post_galleries() should return gallery blocks: This remains a blessed task for now.
  • #45707: Add parameter $real_mime to wp_check_filetype_and_ext: This might land as a relief while #40175 is pending, as long as it doesn’t introduce future compatibility challenges.

Recent Trac Bulk Edit

The team discussed how we should handle the recent bulk edit closing of tickets. Of the tickets closed, 163 are Media component tickets. The general consensus is that we shouldn’t leave them as wontfix but no final decisions were made. Next steps are for everyone to leave feedback on the original P2 about how to handle this project wide, and we will plan to make a decision about Media tickets next week.

Next meeting

The next #core-media meeting is set for Thursday, January 24, 2019, 21:00 UTC. Leave any agenda suggestions in the comments of this post. See you there!

#media, #summary

Media Meeting Recap – January 3, 2019

Overview

This post is a summary of the latest weekly Media component meeting, which took place in the #core-media Slack channel, on Thursday, January 3, 2019 at 21:00 UTC. The purpose of these meetings are to move priority tasks forward, provide feedback on issues of interest, and review media focused issues.

Attendees: @joemcgill @mikeschroder @karmatosed @desrosj @paaljoachim @tellyworth

Transcript: Read on Slack

5.0.3 Triage

  • #43826: get_post_galleries() should return gallery blocks – Patch needs refresh, @desrosj to coordinate with @tellyworth about landing this.
  • #44563: WordPress 4.9.7 Media delete changes break plugins deleting media via stream wrappers – Also needs a refresh, @joemcgill to try and validate and make a decision unless @mikeschroder beats him to it. Lower priority though, so might punt.
  • #45407: Add block attributes to wp_calculate_image_sizes to allow for proper handling of sizes attribute – Unsure if this patch is ready to land. @joemcgill to investigate and make a decision. – #45615: CSV Mime Type fails upload – @joemcgill and @tellyworth continue working on a fix for this. Might try for a small fix for 5.0.3 and a larger refactor for 5.1.
  • #45633: finfo_file() returns text/plain for json file instead of application/json – Related to the above issue. @joemcgill to investigate.

Ongoing Cruft removal

On December 21, we discussed identifying potential places to clean up cruft that has built up over the years. So far, that post includes the following possibilities:

  • Fully supporting or deprecating playlist functionality
  • Removing infinite scroll in the media library.
  • Auditing/updating supported upload file types.
  • Removing old Thickbox code (#10955).
  • Functionality deprecated when WP_Image_Editor landed.
  • Auditing oEmbed providers.

Upcoming 5.1 ticket scrub

As of the time of this meeting, there were 38 open Media tickets on the 5.1 milestone. Of those, 16 are enhancements or feature requests that would need to land before next Thursday when 5.1 hits beta in order to be included. We’ll plan to do a scrub of this list in #core-media on Slack next Tuesday, January 8, 2019 at 20:00 UTC to assign/punt as much as possible. Feel free to come join in the fun!

Next meeting

The next #core-media meeting is set for Thursday, January 10, 2019, 21:00 UTC. This next meeting will be focused on triage and 5.1 priorities. See you there!

#media, #summary

Dev Chat Summary: November 28th (5.0 Week 9)

This post summarizes the dev chat meeting from November 28th (agenda, Slack archive).

5.0 Planning and Updates

  • We started with a reminder that RC1 is out and moved quickly into a lively discussion about remaining blockers, timing, and general logistics. I’ve summarized them the best I could below.
    • There was a request for review on one outstanding item in the default theme.
    • There were requests for consideration on 11973, 6177, and 45407 in media. These tickets are largely about how to best handle responsive images, specifically some nuance around the sizes attribute.
    • There are no automated tests for expected vs actual behavior
    • This affects only new posts, or newly edited posts.
    • It’s related to full-width images in the new editor and further complicated by the lack of any way to filter for block alignment width.
    • There are concerns about high data usage and negative impacts on search engines (esp for mobile)
    • Q: If we fix this in 5.0.x, what happens to content published in between 5.0 and 5.0.x? Will content need to be updated to correct? It was suggested that fixing the insertion of full size images in content and incorrect width attributes would let us ship and then iterate. Insertion is already fixed, so it’s just the second one!
    • Q: What would need to be fixed or added to content to allow it to be fixed post-release? Ensure we have correct default height and width attributes on inserted img elements.
    • We started running low on time, but additional clarifications were offered in #core-media. Additional discussion can take place on https://github.com/WordPress/gutenberg/issues/6177
  • There were a number of questions that got interjected during the discussion, that I’ve collected the best I could below.
    • Are we proceeding with the January slip date as identified in the launch post?
      • A January date was seconded by the docs team and a collection of others.
      • Many mentioned concerns around predictability and user trust.
      • Data is still being gathered about how RC1 is being received, and once enough is available, a Core P2 post will be made to help people plan. RC2 is next on the horizon.
      • How much time will there be between the announcement of the release date and the actual release date?
    • Are there any dev notes that need to be posted prior to release? And if so, is there a list? And how can we help?
    • Should we prep a 4.9.9 in order to be prepared for PHP7.3 support?
    • There were multiple offers to help gather necessary data to determine how close we are to a release date.

Component and Focus Updates

  • The PHP team shared last week’s meeting recap which included some discussion of Tide, whether to expose PHP compat on plugins/themes, and best ways to identify those with compatibility concerns. https://make.wordpress.org/core/2018/11/26/php-meeting-recap-november-19th/
  • The JavaScript team shared this week’s meeting recap which included discussion of Contributor Day at WordCamp US, work on docs parsing for devhub, and ESLint configurations. https://make.wordpress.org/core/2018/11/27/javascript-chat-summary-november-27-2018/
  • Design has a new research channel in the works. A lot of their initial work will be around user research for Phase 2+ of Gutenberg. Not much going on, but worth knowing about for sure. 🙂 https://make.wordpress.org/design/2018/11/19/two-ways-to-get-involved-in-gutenberg-user-research/

Next meeting

The next meeting will take place on Wednesday, December 5 21:00 UTC in the #core Slack channel. Please feel free to drop in with any updates or questions. If you have items to discuss but cannot make the meeting, please leave a comment on the upcoming agenda post so that we can take them into account.

#5-0#a11y#core#core-editor#core-js#core-media#core-php#core-restapi#dev-chat#gutenberg#summary#team-reps

Dev Chat Summary: October 10 (5.0 Week 2)

This post summarizes the dev chat meeting from October 10th (agenda, Slack archive).

5.0 planning

  • See @pento’s WordPress 5.0 for Contributors and Committers post:
    • “If you’re an experienced contributor or committer who has time available during the WordPress 5.0 release cycle, and want to be able to make meaningful contributions towards making WordPress 5.0 awesome” … “Please reply to this post with information about your availability, what components of WordPress you have experience in, and (if you haven’t got involved with Gutenberg yet) what you feel has been getting in the way.”
    • In that post are some direct actions you can take to help contribute to 5.0, otherwise please review and comment if you’ll be around during the 5.0 release cycle… thanks!
  • Also see review @pento‘s 5.0 commit/branch details if you plan to contribute during the 5.0 release cycle
  • @pento: if you have time to help, please review tickets in the 5.0 milestone to determine whether to keep it in 5.0 (Gutenberg-related), or move to 5.0.1 (other bug fix) or 5.1 (other feature)
  • @kadamwhiterequest for help testing Lazily Evaluate Translation Strings (#41305) with input requested by the end of this working week to help remove the blocker to further Gutenberg localization work
  • Plans for an updated readme.html to be committed with contributions open until RC
  • @chanthaboune: collecting blocker items and dates across team reps, will post listing to Make/Core, if you have items to add to the listing please ping @chanthaboune directly
    • @matt: 5.0 baseline and goal is 4.9.8 + Gutenberg, thus a lot of things that may have been considered blockers in past major releases are probably going to be reclassified as “nice to have”
  • @matveb: last JS package included in the Gutenberg 4.0 RC, on track and could be ready for end of the week

Updates from focus leads and component maintainers

General announcements

  • See @matt‘s post for details on the Gutenberg Phase 2 Leads, @alexislloyd (design and product) and @youknowriad (technical)
    • Phase 2 is about thinking outside the box, namely the post and page box, to allow Gutenberg to handle entire-site layouts. We will replace widgets with blocks, so any block will be able to be used in any registered “sidebar” for legacy themes, and we will upgrade “menus” to a navigation block.
    • Phases 3 and 4 of Gutenberg at WordCamp US in December.
  • @audrasjb: a11y team reorganizing, will discuss during next week’s meeting
  • @chanthaboune: as teams identify new/updated team reps, please follow notes on team rep orientation

Next meeting

The next meeting will take place on October 17, 2018 at 20:00 UTC in the #core Slack channel. Please feel free to drop in with any updates or questions. If you have items to discuss but cannot make the meeting, please leave a comment on this post so that we can take them into account.

#5-0, #a11y, #core, #core-editor, #core-js, #core-media, #core-php, #core-restapi, #dev-chat, #gutenberg, #summary, #team-reps

Media Meeting Recap – October 4

Overview

This post is a summary of the latest weekly Media component meeting, which took place in the #core-media Slack channel, on Thursday, October 4, 2018 at 18:00 UTC The purpose of these meetings are to move priority tasks forward, provide feedback on issues of interest, and review media focused issues.

Attendees:
@joemcgill @danielbachhuber @mikeschroder @sergeybiryukov @pfiled @antpb

Transcript: Read on Slack

WordPress 5.0

This meeting focused entirely on the WordPress 5.0 milestone Gutenberg Issues. We reviewed each of the 18 remaining issues to determine:

  • is the issue a must have for 5.0?
  • what are next steps to getting the issue solved?

Things are looking good! This meeting resulted in remaining 5.0 issues being brought from 18 down to 11. We will focus work in the next week on Gallery backwards compatibility and Media Tabs which will help solve out more of the 5.0 milestone issues. Let’s get right into the issues discussed!

Featured Image dialogue missing “Mine”, “Uploaded to this post”, “Unattached” filters

It was agreed that this was a nice-to-have bugfix.


Consider feature parity for “Image Details” TinyMCE functionality

`attachment_fields_to_edit` filter is not respected in the image fields in the media modal in GB. Which means if you need to add in a required field to an image, it won’t show up in the Gutenblock sidebar. Since this ticket is focused around everything missing from Image Details, it would be great to get someone with agency/build experience to help. Any feedback would be much appreciated. 


Insert Link to image needs “open in new tab” option

There is already a fix ready to go. Just needs a refresh and we can merge. @antpb has tested the PR and all is working well. Currently getting Design final feedback and will get a second review on the code : https://github.com/WordPress/gutenberg/pull/9520


Support for existing Media tabs

Crucial to 5.0. There are some challenges…

As @joemcgill stated in the meeting: “The old media button opened a modal using the `wp.media.view.MediaFrame.Post` frame, which provided workflows for any kind of media you wanted to embed from a single modal. In Gutenberg, we are opening specific frames using `wp.media.view.MediaFrame.Select` which are optimized to the type of block you’re inserting. So it wouldn’t make any sense to include an extra menu item for an image source within the video block, for example. The `Select` frame doesn’t include the same menu area by default anyway. IMO, this is all a good thing, but what we need to do is provide either

a) a way for third parties to register their content area based on media type, which we then display in the modals for the correct blocks.

b) assume that integrators will provide their own block interfaces that are specific to the media source.

The former would be my preference.”


Uploading messages for media shouldn’t stack

@joemcgill said “I agree with the approach on the ticket. Nice to have, not a blocker.”
We are removing the 5.0 milestone so we can stay focused on the major blockers. We can circle back to these as we finish the merge critical tasks.


Gallery Block doesn’t apply the ‘post_gallery’ filter, causing incompatibility with WP Gallery Custom Links

Gallery: figure out way to fallback to shortcode

Both of the above issues could be solved with ServerSideRender. We could have a theme support option that can fallback to ServerSideRender. This would ensure that we hit the post_gallery filter. We could communicate out to developers that the option is available and their way to get Gutenberg ready would be to set the option. We can keep gallery as is and depend on the theme support to set the type.

@danielbachhuber mentioned “Just to drop another idea: we could fall back to `ServerSideRender` _only_ if a `post_gallery` callback was detected.”

Daniel’s suggestion seems to be the best path forward. @antpb will be working on these in the coming week.


Media Library doesn’t update after dragging image onto Image block

This seems high priority for 5.0 as the drag and drop feature breaks after first use. I’d need to do some digging into drag/drop events to really understand how to fix this. Any thoughts around?

@joemcgill said “Yup. So, this is a result of the main drag/drop interface using totally different plumbing that the media modal.
The dropzone and file uploader use the REST API, whereas the media modal uses the old ajax-action.
When you upload a new file through the media library, the attachment gets added to the backbone collection that the library uses and the library persists. We need to either always fetch a fresh collection when opening the media modal or listen for other upload events and refresh the collection passively.”

Agreed all around that this is a need to be fixed.


Images → Gallery transform fails for ID-less images

This will be moved out of the 5.0 milestone as it is not a blocker.
@joemcgill mentioned “I don’t think that the gallery block supports external images at all, unless I’m wrong. So that would be an enhancement (IMO). In the mean time, I wonder if we can add some logic that only supports that transform _if_ all selected images include IDs. That would at least eliminate the bad UX” We can circle back to this issues after merge critical issues are cleared.


“upload_files” capability and Image relative blocks

This is a must have: Seems the bulk of the work is being done here: https://github.com/WordPress/gutenberg/pull/9301. This PR is in need of a refresh. @antpb will finish this one out


Image Block: when using a small image enlarged pixelated version is flashed on page load/refresh

This issue was no longer valid. Closed.


Image block needs to handle variety of sources

This was recently given the low priority tag, so we should remove it from the 5.0 milestone as it is not a blocker. We can circle back later.


<img/> tags missing attribute filter

@joemcgill stated “Gutenberg uses a different markup structure entirely with a different filtering process. I think we would be better off writing upgrade notes that explains how to do this correctly going forward, but am open to solutions that allow back-compat of the previous filter if we can come up with an approach.” It was agreed that this was the best path forward. We are certainly open to discussion around the decision.


Insert from URL missing when adding an image

@joemcgill said “I didn’t realize that both cases were being addressed (this and the upload_files caps check) in the same PR.
Not sure about the approach there, but I do think we should try and support inserting from URL if we can.” We’ll need to see if this can be split in two tasks.


Images alt attribute in an editing context

This seems pretty important. It should be fairly simple to set a default alt if none is passed back from the media modal.

@joemcgill said “Yup. Let’s keep it as a must have. I’m happy to work on that one.”


Gallery: choosing thumbnail size

@joemcgill said “This is similar to the other image enhancements we were looking into. It’s quite important for responsive images that we’re selecting the best image size for the layout. If the gallery block is still inserting “full” size images, then this is really bad for page speed performance and should be addressed.
I’m less concerned about choosing explicit intermediate sizes (e.g., medium, large, etc) but we shouldn’t be using full unnecessarily.
Related: I think we need to go through https://github.com/WordPress/gutenberg/issues/6177 and break it into distinct actionable issues and see what could be milestoned. That issue contains too many items, IMO.”


Next Meeting

The next #core-media meeting is set for Thursday, October 11, 2018 at 18:00 UTC See you there!

#core-media, #media, #summary

#core-media

Media Meeting Recap – April 5

Overview

This post is a summary of the latest weekly Media component meeting, which took place in the #core-media Slack channel, on Thursday,  April 5, 2018 at 1900 UTC. The purpose of these meetings are to move priority tasks forward, provide feedback on issues of interest, and review media focused tickets on Trac.

Attendees:
@joemcgill @blobfolio @audrasjb @desrosj @mikeschroder @karmatosed @antpb

Transcript: Read on Slack

Media Meeting Time Changes

To better accommodate all the usual attendees, the team has decided to move the meeting time to one hour later, at 2000 UTC. If this is a problem for anyone who would like to attend, please comment on the post or in #core-media!

Gutenberg

This meeting was primarily focused around Gutenberg Media Triage using this filter as the reference. 

  • The best way to follow along with media related Gutenberg items is the media label in GitHub.
  • Repository milestones
  • 5240  mediaelement component needed for audio and video blocks –  discussion took place around the desired experience for a v1 of the audio/video features. It was decided best to continue on the path to getting the audio block and mediaElement component finished out on this one. @joemcgill agreed to help test. 
  • 5209 Fix Image Alignment@joemcgill mentioned some backwards compatibility concerns and expressed them in this comment on the issue
  • 4914  Enhancement: Inspector interface for setting pixel dimensions of image – This sparked a conversation around a need for contributors to share any media flow discrepancies. In the case of the discussion our concerns were around things like the edit image modal looking different from core’s implementation.
  • 4612   Media Library doesn’t update after dragging image onto Image block@antpb and @joemcgill to do testing on this one to verify the media-upload button is working.
  • 4491  Gallery block: editing a gallery uses “Insert gallery” button –  @antpb to investigate. This is another example of workflows needing to be tested to identify these problems.
  • 3945 Right-align small images pinned to top-left of boxblock – This is likely a CSS issue. @antpb mentioned it may also be the block adopting the formatting bar’s width causing the weirdness. 

Next Meeting

The next #core-media meeting is set for Thursday, April 12, 2018 at 1900 UTC. See you there!

Media Meeting Recap – March 29

Overview

This post is a summary of the latest weekly Media component meeting, which took place in the #core-media Slack channel, on Thursday,  March 29, 2018 at 1900 UTC. The purpose of these meetings are to move priority tasks forward, provide feedback on issues of interest, and review media focused tickets on Trac.

Attendees:
@joemcgill @blobfolio @audrasjb @desrosj @mikeschroder @karmatosed @antpb

Transcript: Read on Slack

Gutenberg

  • The best way to follow along with media related Gutenberg items is the media label in GitHub.
  • Repository milestones
  • @karmatosed expressed a need for media maintainers to ensure that what is being proposed for MVP/Feature complete is accurate. Issues related to this can be found using the media label or by following this link: https://github.com/WordPress/gutenberg/labels/Media
  • Add mediaelement component@antpb has updated the repo to include some bug fixes. Testing is still needed to determine the issue with loading mediaElement on the front end. Steps to creating a clone of the repo can be found at this comment.
  • Add block playlist: Currently blocked by the inclusion of the mediaElement component.
  • @desrosj asked "Are there “groups” in GitHub? Thinking something similar to @ committers in Slack that would notify a group of people?" Investigation is needed into subscribing to labels in Github. If anyone has any ideas, please comment below. RSS was mentioned as a possibility but confirmation would be much appreciated.

4.9.5 Tickets

The next part of the meeting was spent on tickets in the 4.9.5 milestone

  • #42919 – Unable to upload files with the AAC extension
    @desrosj mentioned "the ticket was specifically just for allowing a user to upload a file with .aac extension. The mime type was already allowed (when a different file extension was used), but when the file extension was explicitly .aac it would get blocked." The commit in the ticket adds support to display the .aac in an embed. @blobfolio and @desrosj did some upload testing and found that in Firefox, there were issues. @mikeschroder suggested that we should revert the extra functionality and explore embedding in a different ticket. @joemcgill concurred that he'd like to see further exploration of rendering in a cross-platform manner.

Open Floor

  • #43642 – Gallery titles and labels erasing
    @antpb mentioned this maybe being plugin territory. @desrosj mentioned a risk in the way that galleries save back to the attachment post. This may have some Gutenberg compatibility issues as well. We are going to mark this one with reporter feedback needed because there's a possibility that they want to create a gallery without any titles or they are wanting to replace the titles/labels. Seeing video/screenshots of their current workflow would be helpful.  

Next Meeting

The next #core-media meeting is set for Thursday, April 5, 2018 at 1800 UTC. See you there!

#core-media, #media, #summary

Media Meeting Recap – March 23

Overview

This post is a summary of the latest weekly Media component meeting, which took place in the #core-media Slack channel, on Thursday,  March 23, 2018 at 1900 UTC. The purpose of these meetings are to move priority tasks forward, provide feedback on issues of interest, and review media focused tickets on Trac.

Attendees:
@joemcgill @blobfolio @desrosj @mikeschroder @karmatosed @antpb @adamsilverstein

Transcript: Read on Slack

Gutenberg

4.9.5 Tickets

The next part of the meeting was spent on tickets in the 4.9.5 milestone

Tickets needing testing:

  • #42017 – Parse the creation date out of uploaded audio files
    @desrosj has reclassified this ticket as enhancement.
  • #33979 – Add filter for 'postgalleryitem'
    @desrosj is looking into adding attributes to the tag in addition to just making a class filter. We will need to investigate if this helps Gutenberg in any way. 
  • #43046has_image_size() returns false for Core image sizes
    
    @desrosj is researching this one.
  • #9257 – EXIF GPS data
    Due to GDPR compliance, decided that this should live in plugin territory for now. Lots of great work going on in the ticket, and would be a solid plugin! 

Next Meeting

The next #core-media meeting is set for Thursday, March 29, 2018 at 1800 UTC. As both the EU and US have now moved to DST, you'll note the time has been shifted one hour earlier. Hope to see you there!

#core-media, #media, #summary

Media Meeting Recap – March 8

Overview

This post is a summary of the latest weekly Media component meeting, which took place in the #core-media Slack channel, on Thursday,  March 8, 2018 at 1900 UTC. The purpose of these meetings are to move priority tasks forward, provide feedback on issues of interest, and review media focused tickets on Trac.

Attendees:
@mikeschroder @antpb @desrosj @karmatosed @postphotos @joemcgill @sergey @chetan200891 @adamsilverstein 

Transcript: Read on Slack

Gutenberg

  • The best way to follow along with media related Gutenberg items is the media label in GitHub.
  • Repository milestones
  • Add mediaelement component@antpb discussed that this is currently a blocker to building the Playlist Block. The component renders on the editor view and is enqueuing via client-assets.php but the script is not enqueuing on the front end. @antpb needs help figuring out the front end issue. Steps to creating a clone of the repo can be found at this comment.
  • Add block playlist: Currently blocked by the inclusion of the mediaelement component.

4.9.5 Tickets

The next part of the meeting was spent on tickets in the 4.9.5 milestone

Tickets needing testing:

  • #42724 – Options media page hides breaks on desktop
    Patch still needs testing.
  • #42968 – Media: Grid View: new upload, file is in the wrong position in the grid until after upload is complete
    Agreement all around that it is ready to commit.
  • #43226 – Crop setting in thumbnails never set when uploading PDF files
    Committed to trunk. It was agreed that this will be fixed in 4.9.5. @mikeschroder is working on backports.
  • #43255 – WP _Image_Editor::make_image leaves an output buffer open on failure
    This one has been open for a while but is in need of clean up. Mentioned by @mikeschroder we "want to be sure what we do doesn't break workarounds."

Tickets up for discussion:

#43123 Default captions should NOT use max-width
@joemcgill mentioned that he thinks it is worth reverting due to unintended consequences. @mikeschroder noted that "we’ll want to be sure to message folks and give a warning if we do revert."

Next Meeting

The next #core-media meeting is set for Thursday, March 15, 2018 at 1900 UTC Note: The time is maintained in UTC, so if you are in the US, this time may be different due to DST. We'll move the meeting time once EU has switched to DST in two weeks. Hope to see you there!

#core-media, #media, #summary

Media Meeting Recap – March 1

Overview

This post is a summary of the latest weekly Media component meeting, which took place in the #core-media Slack channel, on Thursday,  March 1, 2018 at 1900 UTC. The purpose of these meetings are to move priority tasks forward, provide feedback on issues of interest, and review media focused tickets on Trac.

Attendees:
@mikeschroder @antpb @desrosj @karmatosed @blobfolio @chetan200891 @jdub233

Transcript: Read on Slack

Gutenberg

  • The best way to follow along with media related Gutenberg items is the media label in GitHub.
  • Repository milestones
  • Add mediaelement component – This issue was created by @antpb in an attempt to separate the mediaelement component required to make progress on the playlist block. Included in these changes is an update to the Audio block to utilize the component. Currently the component renders on the editor view and is enqueuing via client-assets.php but the script is not enqueuing on the front end. Needs investigation.
  • Add block playlist: Currently blocked by the inclusion of the mediaelement component.

4.9.5 Tickets

The next part of the meeting was spent on tickets in the 4.9.5 milestone

Tickets needing testing:

  • #42724 – Options media page hides breaks on desktop
    • Patch still applies clean, testing needed.

Tickets up for discussion:

#43255 WP_Image_Editor::make_image leaves an output buffer open on failure

This has been committed for 5.0, but @mikeschroder mentioned some worry around changing output buffers for a minor release.

The following ticket needs a combination of code review and approval:

#43226 – Crop setting in thumbnails never set when uploading PDF

@mikeschroder is going to test #43226

5.0 Tickets

The next part of the meeting was spent on tickets in the 5.0 milestone

#9257: EXIF GPS data

#9257 is a ticket to process EXIF GPS and store it in meta, but not exposing that data unless a plugin or theme uses it for something. In WordPress' current state, the original file is not stripped of any geolocation data and anyone could potentially find that information. This sparked the question of whether the user should be informed that location data is present in an uploaded image file. #43454 was created in response to this.

#43454 – Add UI elements to make the user aware of image geo data

Some concern was expressed about the potential for a user to unknowingly exposing location data in #9257 activating a plugin or theme that utilizes it. Some ideas that were passed around to better inform the user about images containing GPS data:

  • Showing a warning when an image is uploaded that contains GPS data.
  • Showing a general notice
  • Showing a globe icon in the corner of the image thumbnail in the media library.
  • Showing the coordinates in the attachment info pane when editing an attachment (maybe with information about the data).
  • A general warning at the top of the upload screen.

Further discussion and initial patches can be found in the ticket.

Next Meeting

The next #core-media meeting is set for Thursday, March 8, 2018 at 1900 UTC. Hope to see you there!

#core-media, #media, #summary