Theme Review Team Meeting Agenda for December 10

First, apologies for not posting meeting notes for November 26.

In case anyone missed it, we also had an extra meeting on December 4.

Theme review team (TRT) conducts a meeting on the second and fourth Tuesday of the month. Along with the fixed agendas, we have open floor meeting at the end where you can ask or share anything related to themes.

We encourage all members and anyone interested to attend.

Channel: #themereview | Time: Tuesday, 10th December 2019, 17:00 UTC

Meeting Agenda

  1. Weekly Updates
    • Featured themes- no news to report.
    • Theme Review Team Badges -no news to report.
    • Suspensions -There is still a large backlog of reports.
  2. Fonts: Privacy related to google fonts, and enqueuing variable fonts.
  3. Recap of the future of themes meeting. Status report on our two current tasks regarding the blockBlock Block is the abstract term used to describe units of markup that, composed together, form the content or layout of a webpage using the WordPress editor. The idea combines concepts of what in the past may have achieved with shortcodes, custom HTML, and embed discovery into a single consistent API and user experience. editor:
    • Get a list of things that are in discussion and relates to themes
    • Get a list of blocks that are missing for themes
  4. Do not contact reviewers outside official channels

#meeting, #trt

Do Not Contact Reviewers Outside of the WordPress.org System About your Review

You should not contact people about your review outside of the predefined systems. Do not contact a reviewer in a way they have not invited you do contact them on.

A reviewer should never be worried about the messages they receive outside of the reviewing system.

Additionally, it is never going to be OK to offer someone an incentive to help ‘speed things up’. The best way for you to speed up the process is to get involved and help review other themes – and for themes to be ready when they are uploaded so that long review times are not required.

Ways To Contact Your Reviewer or Discuss your Review

If you have a reviewer assigned to your theme or you want to discuss something about the theme then these are the places and ways you can do that.

  • In your theme ticket on trac.
  • In the slackSlack Slack is a Collaborative Group Chat Platform https://slack.com/. The WordPress community has its own Slack Channel at https://make.wordpress.org/chat/. ThemeReview channel.
  • Sometimes a DM on slack is allowable but if someone does not respond to it take that as a sign they do not have the time to respond or that they do not welcome such messages.

Ways Not To Contact A Reviewer

You should never contact a reviewer outside of the above-mentioned channels without first being invited to do so by that person. This is often called a follow home and is not acceptable.

Do not contact anyone by:

  • Reaching out to them on Twitter.
  • Sending them a message through a contact form on their personal sites.
  • Sending emails to their work addresses.
  • Finding them on Facebook.
  • etc, etc…

Basically, if it’s not on tracTrac Trac is the place where contributors create issues for bugs or feature requests much like GitHub.https://core.trac.wordpress.org/. or in the related slack channels then don’t expect that people want to receive messages there.

Questions about the Future of Themes

This week we held a meeting at the last minute in the #themereview slackSlack Slack is a Collaborative Group Chat Platform https://slack.com/. The WordPress community has its own Slack Channel at https://make.wordpress.org/chat/. channel (you’ll need an account to see it). The goal of the meeting was to discuss where themes are going in the future.

We (the TRT reps) do not have all the answers but we do think this discussion is important to have and to keep open going forward.

We had a handful of questions that we wanted to get an answer on:

  • Is it time to allow theme authors to use what is available from the editor?
  • How can theme authors be more involved with the editor building experience and influence where it is going so that it is going where they need it?
  • In what ways does future editor plans affect themes?

How can we, as the people that build themes, influence the direction the editor is going in if the destination has already been decided?

William Patton

Matías Ventura offered up specifically these 2 things which we can help with that are not yet decided.

We made a proposal to the Theme Review Team and are seeking opinions from the team and from theme authors:

My proposal is firstly about allowing blockBlock Block is the abstract term used to describe units of markup that, composed together, form the content or layout of a webpage using the WordPress editor. The idea combines concepts of what in the past may have achieved with shortcodes, custom HTML, and embed discovery into a single consistent API and user experience. templates into themes. Secondly it is about the pros/cons of including custom blocks directly.

William Patton

Ultimately we want to allow theme authors the ability to make use of all the features the editor can offer. Even the experimental ones, we think it’s important that experiments are done by real people to solve real-world problems.

The issue highlighted with allowing all themes to do this is that it results in a type of lock-in which we generally want to avoid at all costs. We also don’t want to have things exposed to end-users that may break in the future.

For experimental themes what was suggested is that instead of standard theme submissions and the queue authors could test these things and place them on GitHubGitHub GitHub is a website that offers online implementation of git repositories that can can easily be shared, copied and modified by other developers. Public repositories are free to host, private repositories require a paid subscription. GitHub introduced the concept of the ‘pull request’ where code changes done in branches by contributors can be reviewed and discussed before being merged be the repository owner. https://github.com/ for us to check out. I think this is a good idea and something we will try to make happen.

We had 2 final points we wanted to get across to act as open-ended questions we can work on in the coming weeks and months. Please feel free to ponder these and share in the comments any insights you may have.

  • Theme authors: We propose we allow themes to experiment with current and future features. We will tag them as experimental . What are the thoughts on this?
    • Sidenote: this is likely best done not in the standard review system but instead on GitHub or similar.
  • Editor builders: How best can we help if we do not yet know ReactReact React is a JavaScript library that makes it easy to reason about, construct, and maintain stateless and stateful user interfaces. https://reactjs.org/. or have the time to look through the thousands of issues on GitHub.

As for ways to help out there is work ongoing to create a demo space here: https://github.com/WordPress/gutenberg/blob/master/lib/demo-block-templates/index.html

As for a few action points here is what we need to do before we have another discussion about this.

  1. Get a list of things that are in discussion and relates to themes (Josepha has kindly offered to get us the inside scoop on this.)
  2. Get a list of blocks that are missing for themes right now (TRT and theme authors are in a good position to tell people what they are missing and any sticking points they have.)

Thanks to everyone who attended the meeting for this. It was very short notice so if anyone wants to bring anything up that was not discussed or considered in advance feel free to pop by #themereview channel and let us know.

Theme Review Team Meeting Agenda for November 26, 2019

November 26th is the 4th Tuesday of the month. The Theme Review Team (TRT) has a meeting at 17:00 UTC. We encourage all members and anyone interested to attend.

We usually have a fixed agenda to discuss. However, this week we don’t have anything special to discuss with the team. So we would like to request all members to comment below if you want to discuss any theme-related topics.

We will start our meeting with the updates that happened since the last meeting and what TRT leads are doing and working on. After that, we will go through the proposed topics and the meeting will end with the open floor where we can discuss various theme-related topics.

Meetings usually last around 60 minutes. Attend and share your valuable feedback and suggestions.

Channel: #themereview  Time: Tuesday, 26th November 2019, 17:00 UTC

#meeting

#announcements, #meeting

Meeting Notes for Tuesday 12th November 2019

A meeting was held with the proposed agenda.

The following is the recap of the meeting, you can read the meeting transcript in the slack archives (a Slack account is required).

Updates

In the past seven days:

  • 352 tickets were opened
  • 354 tickets were closed:
    • 333 tickets were made live
      • 5 new Themes were made live
      • 328 Theme updates were made live
      • 3 more were approved but are waiting to be made live
    • 21 tickets were not-approved
    • 0 tickets were closed-newer-version-uploaded

Suspended themes submission

It was agreed that if the authors’ theme was suspended you cannot submit it again with a different name and account.

Theme Review Team Badge Assignment

We got the access to the badges so we are calling people to comment if they did the review so that we may give them the badges 🙂

They need to reply to the pinned slack message, and we’ll look at the reviews and decide: if someone did a poor, incomplete review, that we had to reopen for very basic issues, then no badges will be rewarded.

We need to check the review quality and dedication. A complete review is necessary in order to get the badge.

Get Ready for WordPress 5.3

Theme authors should get ready for the upcoming WP 5.3. You can read more in the make post.

If there will be any problems we encourage theme authors to contact us on slackSlack Slack is a Collaborative Group Chat Platform https://slack.com/. The WordPress community has its own Slack Channel at https://make.wordpress.org/chat/..

Open floor

The ticket for the core to read the PHPPHP PHP (recursive acronym for PHP: Hypertext Preprocessor) is a widely-used open source general-purpose scripting language that is especially suited for web development and can be embedded into HTML. http://php.net/manual/en/intro-whatis.php. version for themes was opened (and closed shortly after). The coreCore Core is the set of software required to run WordPress. The Core Development Team builds WordPress. themes were updated to move required fields to style.css instead of readme.txt.

The fields the theme authors should have in the style.css are

Requires PHP and Requires at least.

Core won’t be affected if those fields are in the style.css but your theme will benefit from having them, so we recommend authors adding them.

@aristath recommended using the code from Justin Tadlock’s theme for handling graceful failures: https://github.com/justintadlock/mythic/blob/master/functions.php

The Theme SnifferTheme Sniffer Theme Sniffer is a plugin utilizing custom sniffs for PHP_CodeSniffer that statically analyzes your theme and ensures that it adheres to WordPress coding conventions, as well as checking your code against PHP version compatibility. The plugin is available from the plugin directory and Github. Themes are not required to pass the Theme Sniffer scan without warnings or errors to be included in the theme directory. is undergoing some updates and the releaseRelease A release is the distribution of the final version of an application. A software release may be either public or private and generally constitutes the initial or new generation of a new or upgraded application. A release is preceded by the distribution of alpha and then beta versions of the software. will be out soon. One of the changes will be the above validation – readme.txt will no longer be checked, only style.css will be checked.

#meeting, #meeting-notes, #trt