Review statistics

These statistics should be taken with a pinch of salt, since the numbers does not assure statistical accuracy for the entire theme directory.

While we can follow the graph and even search live themes, that won’t tell us what the reviews contain, so this was done manually, human errors included.

Out of 531 themes that were closed as not approved between December and February, I looked closer at 100 tickets. Out of 100 tickets, 21 tickets were closed because the themes were copies of a theme that is already in the directory.

  • 14 tickets where closed because the author did not reply within 7 days.
  • 9 tickets where closed on author request.
  • 9 tickets where closed because the author already had an open ticket (the one theme rule).

The reviewer did not complete the review and the ticket had to be returned to the queue on 8 occasions (Not necessarily 8 separate themes).

The most common problems mentioned by the reviewers were:

  • Missing escaping or using the wrong functions: 23 themes
  • Text that is not translation ready: 21 themes
  • Missing prefix: 20 themes
  • Scripts or styles are not enqueued: 18 themes
  • PHP notices, errors or warnings: 12 themes
  • Style tags does not correspond with theme functionality, or are deprecated: 10 themes

You can find the numbers for the not approved themes here.

 

In an attempt to compare the results of the two categories, I also looked at 100 out of 177 new themes that went live between December and February.

The reviewer did not complete the review and the ticket had to be returned to the queue on 45 occasions (Not necessarily 45 separate themes).

37 of the tickets were reopened as a second reviewer found additional problems.

One of  the more alarming results was that in 51 out of 100 tickets, the reviewer pointed out that escaping was either missing, or the wrong functions were used. 

 

The most common problems mentioned by the reviewers were:

  • Missing escaping or using the wrong functions: 51 Themes
  • Text that is not translation ready: 44 Themes
  • Missing prefix: 39 Themes
  • Missing license or copyright information for included assets: 34 Themes
  • Unused code or files: 25 Themes
  • PHP notices, errors or warnings: 20 Themes
  • Missing sanitization, or using the wrong functions: 18 Themes
  • Options in the customizer that are not working: 18 Themes

On 15 occasions, the reviewer asked the author to remove demo content.

On 12 occasions, the reviewer asked the author to remove or reduce content creation.

Compared to the themes that were not approved, only 11 themes had scripts or styles that were not enqueued.

In a couple of tickets, the reviewer asked the author to replace the following custom functionality and use WordPress functions instead:

  • Logo: 11 Themes
  • Custom CSS: 10 Themes
  • Custom excerpt: 8 Themes
  • Custom pagination: 6 Themes

You can find the numbers for the live themes here.

I also wrote down how long it took for the themes to go live:

Live after 13 months: 1
Live after 12 months: 1
Live after 11 months: 4
Live after 10 months: 8
Live after 9 months: 9
Live after 8 months: 17
Live after 7 months: 23
Live after 6 months: 22
Live after 5 months: 11
Live after 4 months: 3
Live after 3 months: 1

 

We will be able to repeat this in a few months, to make sure that these numbers are going down.

Requirements project March 23

Our next project meeting will be on Thursday at 19:00

Channel: #themereview

We have a few more short term fixes to discuss:

  • Child theme names
  • Theme URI and  footer credit links
  • Admin bar menu items
  • Screenshot

There is also one recommendation that perhaps should be removed:
Themes may optionally unregister core Widgets. This is allowed, but is it recommended?

As a reminder, we also have the Trello board.

 

Those who have time after the meeting are welcome to continue,  with the purpose of defining what a “Letting users decide” approach would be for the team. We need to define it before we can continue any productive discussion on the topic.

 

Child themes should not include the name of the parent theme.

Suggestion: Child themes may only use the parent theme name if both themes are made by the same author.

Suggestion 2: Remove it (again).

If the theme adds a footer credit link, there should only be one (link to WordPress.org does not count).

Suggestion: There can only be a single footer credit link, which is either the the Theme URI or Author URI (link to WordPress.org does not count).

Theme URI:

Using WordPress.org as theme URI is reserved for official themes.

This was brought up on slack this weekend:
“The purpose of the Theme URI is to point the user to a page specifically about the theme that we are hosting here on WordPress.org. That means that the majority of the info on that page should about the theme that we’re hosting.”
“Theme URI needs to be a) under a domain you control, not “wordpress.org”, and b) unique to the theme. Not unique to the theme and version number or anything else, just unique to the theme. ”

Themes are not allowed to add a menu item to the WordPress admin bar.

I believe this is used in practice but it is not currently listed on the requirement page. Is this something that we want to add or is it something that we would consider allowing?

The screenshot should be of the actual theme as it appears with default options, not a logo or mockup.

Suggestion: The screenshot should be of the theme, not a logo or mockup. The screenshot may optionally show plugins, settings and templates. The user should be able to make the theme look like the screenshot.

Agenda for 2017 March 7

The Theme Review Team holds a meeting weekly and we encourage all members to attend.

Channel: #themereview | Time: Tuesday at 18:00 UTC 18:00 UTC

Topics:

This week we do not have any topics so it will be more of an informal meeting this week.

Community Summit 2017

I have posted a comment the Community Summit post with the list of topics and list of people who could attend. If there is someone who thinks they could attend let me know and I will have a look to see if we can them too.

If you have any topics, then please reply to this post and include the topic, along with a brief description of what you would like to discuss.

Agenda for 2017 February 28

The Theme Review Team holds a meeting weekly and we encourage all members to attend.

Channel: #themereview | Time: Tuesday at 18:00 UTC 18:00 UTC

Topics:

Team Representatives

Matt has asked us to choose three representatives from the Theme Review Team to meet with him to discuss the future of the theme directory. He wants to make sure the tech changes for the plugin / theme directories are in line with what the moderation plans are.

We would like to suggest that @greenshady, @poena and @grapplerulrich would be the three representatives.

Let us know if there are any objections.

Community Summit 2017

In the last meeting we started to discuss topics for the community summit. A list of topics can be found below. The list of topics may change as we get nearer to the event.

  • How we improve the leadership of the TRT team? For example the forums team has one or two team reps and then moderators who have access to further moderations tools.
  • How can we encourage and enable more people to lead new projects?
  • What is the vision and goals of the team?
  • What is the future of the theme review team, can we change it to become the Theme Team and be more involved in theme related activities like improving the theme directory or the theme developers handbook?
  • A set of good slides on the introduction to theme reviewing that can be used for contributor days
  • Improving the documentation so that it is clearer and easier to understand
  • Work on improving the theme author and reviewer experience by analysing the whole theme review process.
  • Improving the review process and focus on quality and good codes
  • How we can encourage creative designs and how to stop more of copy themes which can just be child theme.
  • Future of the theme review theme and making it smoother and faster

Now the question is who should/can attend the community summit. Please post in the comments below if you can and would like to attend to the community summit. Not everyone can attend because of the size limit of the venue.

Current Projects

If you have any topics, then please reply to this post and include the topic, along with a brief description of what you would like to discuss.

New Project: Rewriting the requirements

Project description

Purpose

Making the requirements clear, easy to follow and easy to check.

Prerequisites

This project will not be starting with a blank slate, but make the best of what we have.

Tasks

In no particular order:

  • Review whether current requirements and recommendations are valid
  • Add new requirements when necessary
  • Reorganize requirements and topics
  • Rewrite requirements to make them easier to understand

 

Project format, mandate, timeline and meeting times

Suggested format

A smaller project group with a separate meeting time is preferred, that way the Theme Review Team can still hold the regular meetings on Tuesdays to discuss other topics.

Mandate

The group should have a mandate to change the wording of the requirements and examples with some exceptions:

Project leads/key reviewers should have access to making changes to the actual documents.

Major changes like completely removing a requirement should still be brought up during a Theme Review meeting.

Suggested meeting times

Every other Thursday at 19:00 CET,  alternating with the automation project meeting.

The Theme Review shindigs on the first Saturday of each month could also be used for longer meetings.

Timeline

The project would need to decide on partial goals, for example monthly or bi monthly milestones to ensure that the project moves forward.

Suggestions:

  • March 4 shindig: Requirements that have been voted on but not added,  should be added to the current requirements page.
  • In june, all requirements that are checked by the new Theme Check plugin should be separated from the rest of the requirements.

 


Our first meeting will be on Thursday, February 23 at 19:00 CET.

Agenda

  • Introduction
    • Let’s see who are interested in helping out.
  • How can we work on the requirements together?
    • How do we record and share our work in progress? Do we need any external tools?
    • Decide who our target audience is to be able to set a “tone” of our content and level of difficulty for the examples.
    • In what format do we present the requirements, keeping time limits and milestones in mind?
  • Decide priorities for march-april
    • Missing requirements (band-aids)
    • Reordering and regrouping current requirements

March 4 Shindig

Requirements that have been voted on but not added should be added to the current requirements page.


Our second meeting will be on Thursday, March 9 at 19:00 CET.

Agenda

  • Continue discussing any previous topics that were not finished during the last meeting.
  • Reordering and regrouping requirements
    • Is the requirement under the correct topic or does it need to be moved or placed under a new topic? We also have topics with only a few requirements that perhaps could be combined into one, like Naming and Screenshot.
    • Are there recommendations that should be moved to the required list? For example the Theme and Author URI.

#guidelines