Meeting notes from September 10th, 2019

A meeting was held with the proposed agenda.

The following is the recap of the meeting, you can read the meeting transcript in the slack archives (a Slack account is required).

Updates

In the past seven days:

  • 399 tickets were opened
  • 374 tickets were closed:
    • 357 tickets were made live
      • 7 new Themes were made live
      • 350 Theme updates were made live
      • 5 more were approved but are waiting to be made live
    • 17 tickets were not-approved
    • 0 tickets were closed-newer-version-uploaded

Proposal: Revive monthly review shindigs

@djrmom Suggested that we revive the monthly review shindigs (https://make.wordpress.org/themes/2016/12/05/december-shindig-recap/)

For those who don’t know:

Every first weekend of the month we do a queue push where we try to review as many themes as we can. Please keep in mind that it is not just about numbers but we want to focus on quality reviews as well so don’t feel like you have to do 10 themes over the weekend.

Jose Castaneda (https://make.wordpress.org/themes/2016/11/04/november-review-shindig/)

It was agreed that we should schedule it, and see how it works.

Plan for the next team leads

@joyously wanted to know when was the last time since new leads were elected. Current team lead @williampatton had an announcement that we’ll share here

I have been acting as lead and dealing with various duties for a long time. An awful lot longer than I ever expected.

This month marks the 18 month point. Originally the intention was that a term should last 6 months only.

With uncertainty about what GutenbergGutenberg The Gutenberg project is the new Editor Interface for WordPress. The editor improves the process and experience of creating new content, making writing rich content much simpler. It uses ‘blocks’ to add richness rather than shortcodes, custom HTML etc. https://wordpress.org/gutenberg/ would hold and the future for themes I felt lead transitions would be highly disruptive and I wanted to avoid that. Perhaps it was not my place to make such a decision however I have done what I thought best at all times.

There will never be a perfect time to do lead transitions and with that being said: now is as good a time as any.

Please think about who you want to be leading TRT going forward and decide how best to guide them the direction the Team wants to go in. As is always the case I am available through transition to assist where that may be needed or useful. I’m not going anywhere, just stepping aside to let someone else have their turn.

Let’s try to have the transition process underway by the end of this month at the latest.

For me now is the right time for 2 reasons.

1. First and foremost it is time for someone else to have a turn at this. Being a team lead has been an incredibly rewarding experience which has allowed me to grow as a developer and feel like a very welcome part of our amazing WordPress community. Someone else deserves to be able to have that experience as well.
2. Secondly, I cannot guarantee availability as-and-when needed in the same way that I used to be able to. The more limited time I have here I want to be able to spend on things other than admin or management tasks. I have projects in mind I want to pursue but have not had the time to do it.

William Patton

It was proposed that an election for the new position is held. Anybody that is interested should directly message @kafleg, he will consult with the senior and key reviewers and will try to sort out the list of names for the election.

William mentioned that he would like to have a Theme Review Team reps instead of leads.
There are many people here with lots of various skills but have issues with the time commitment. Nobody really has a guarantee on how much time they can manage.

@poena mentioned that reps should be people who know what they do best and do that.

In the end, it was decided that a list of possible rep roles will be made and proposed rep leads in those areas.

Some questions remained unanswered and will be covered in the next meeting, such as a decision about ‘starter themes’ in the repo, impact of skip links and keyboard navigation requirements and the existing themes in the repo.

Triage meeting reminder

And in the end a small reminder about the Theme Review Triage meeting that will be held tomorrow.

#meeting, #meeting-notes, #trt

Theme Review Team Meeting Agenda for September 10, 2019

Theme review team conducts a meeting on the second and fourth Tuesday of the month. We usually have fixed agendas for the fourth Tuesday meeting. We have a few agenda and open floor discussion this week.

We encourage all members and anyone interested to attend.

Channel: #themereview | Time: Tuesday, 10th September 2019, 17:00 UTC

Agenda for Discussion

  1. Weekly Updates
  2. Open floor.

Meetings usually last around 60 minutes. If anyone wants anything else to add on the existing agenda comment below and we will try to fit it in.

Discussion can be held in the comments below.

#agenda #meeting#trt

#meeting, #trt

Theme review team triage meeting

Triage, as described in the test handbook, is a process of sorting, labeling, and closing issues on the TracTrac Trac is the place where contributors create issues for bugs or feature requests much like GitHub.https://core.trac.wordpress.org/. or GithubGitHub GitHub is a website that offers online implementation of git repositories that can can easily be shared, copied and modified by other developers. Public repositories are free to host, private repositories require a paid subscription. GitHub introduced the concept of the ‘pull request’ where code changes done in branches by contributors can be reviewed and discussed before being merged be the repository owner. https://github.com/. In the context of the Theme Review Team (TRT), the triage encompasses several things:

The idea is to go through the tickets/issues and see which can be closed, change the priority (if needed), and finding ‘champions’ who will be responsible for handling the issues.

The first meeting will be held on the #themereview slackSlack Slack is a Collaborative Group Chat Platform https://slack.com/. The WordPress community has its own Slack Channel at https://make.wordpress.org/chat/. channel on Wednesday, 11th September 2019, at 17:00 UTC

Triage workflow

Since we didn’t have a triage in TRT for a long time (or ever?), the first meeting will just focus on going through the issues, closing the ones that can be closed and prioritizing other issues. If the time allows we’ll try to assign a champion to the issues with the highest priority. Some tickets/issues already have priority on them, but we need to see if these priorities need to be changed.

We’ll have one triage meeting in a month (for start) so that we have enough time to actually work on the issues (seeing how most of us volunteer and can work on these issues in our free time).

Championing the ticket/issue/PR/patch

Championing means being the person who is responsible for seeing that the issue is worked on. Ideally, champions are people who have some coding knowledge and can work on the issues. But they can also be people who are good at managing a project and finding people willing to work on the issue and seeing the issue is resolved within a sensible time frame.

For the metaMeta Meta is a term that refers to the inside workings of a group. For us, this is the team that works on internal WordPress sites like WordCamp Central and Make WordPress. tickets, we need people who are comfortable with working on the meta repository alongside meta contributors.
For some of these issues, we depend on the meta team who can change how things work on the theme directory. Other issues should have either a good proposal with a clear way of solving them or need input from the meta team. Hopefully, once we show some initiative on them we’ll have good feedback and will be able to sort them out.

For the WPThemeReview and Theme SnifferTheme Sniffer Theme Sniffer is a plugin utilizing custom sniffs for PHP_CodeSniffer that statically analyzes your theme and ensures that it adheres to WordPress coding conventions, as well as checking your code against PHP version compatibility. The plugin is available from the plugin directory and Github. Themes are not required to pass the Theme Sniffer scan without warnings or errors to be included in the theme directory. issues, we need people who will work on providing code examples (in the case of the standards) or are willing to learn how to write sniffs and how to fix issues on the Theme Sniffer pluginPlugin A plugin is a piece of software containing a group of functions that can be added to a WordPress website. They can extend functionality or add new features to your WordPress websites. WordPress plugins are written in the PHP programming language and integrate seamlessly with WordPress. These can be free in the WordPress.org Plugin Directory https://wordpress.org/plugins/ or can be cost-based plugin from a third-party.
We also need to reach some conclusion on the open issues in the coding standards so that sniffs can be written for them.
Once we have the prioritization fixed we can schedule additional meetings for discussion on working on these projects (I’ll be happy to have a meeting for people who are interested in helping out).

I’ve put the Theme Check issues as optional because we don’t have access to this repo and so far the response on accepting the PRs have been a bit low. We can prioritize issues and PRs we’d like to have implemented but unfortunately, we are dependant on one person that can act on this.

Resources

I’ve created an google docs sheet that is used as a reference for the meta related issues. Issues form the other projects will be added as the time passes so that we have it in one place and can reference it in the next triage meeting.

Triage sheet

Contributing to WPThemeReview

Contributing to Theme Sniffer

#announcements, #triage

X-post: Introducing Twenty Twenty

X-comment from +make.wordpress.org/core: Comment on Introducing Twenty Twenty

X-post: Component Maintainers in 5.3

X-comment from +make.wordpress.org/core: Comment on Component Maintainers in 5.3