WordPress.org

Theme Review Team

Welcome to the Theme Review team.

We are a group of volunteers who review and approve themes submitted to be included in the official WordPress Theme directory.

The Theme Review team maintains the official Theme Review Requirements, the Theme Unit Test Data, and the Theme Check Plugin.

We also engage and educate the WordPress Theme community regarding best practices for themes.

Interested in joining the Theme Reviewers team?

Great! The team is open to anyone who wants to help out, and the process is simple. To find out more just visit the Join The Team page.

Want to know more? There is a more information in the Theme Review Team’s Handbook and the Review itself.

Once you get a theme to review, you will also get a mentor to help you on the road to becoming a theme reviewer.

Weekly meetings

We use Slack for real-time communication. As contributors live all over the world, there are discussions happening at all hours of the day.

We have a project meeting every Tuesday at 18:00 UTC in the #themereview channel on Slack. The next one will be at Tuesday at 18:00 UTC.

Recent Updates Toggle Comment Threads | Keyboard Shortcuts

  • Jose Castaneda 8:27 pm on August 29, 2016 Permalink |  

    Agenda for August 30, 2016 

    The Theme Review Team holds a meeting weekly and we encourage all members to attend.

    Channel: #themereview | Time: Tuesday at 18:00 UTC 18:00 UTC

    The meetings typically last 30 minutes. If time permits, additional topics may be discussed.

    If you have any topics, then please reply to this post and include the topic, along with a brief description of what you would like to discuss.

     
  • Jose Castaneda 8:56 pm on August 23, 2016 Permalink |  

    Meeting summary 2016-23-08 

    Items discussed

    Closing tickets should be done for 5 or more distinct issues. Examples:

    • Theme has multiple places where text strings are not translatable – group these into 1 distinct issue
    • Using custom functions instead of core functions such as the_posts_pagination, the_archive_title, the_excerpt – group into 1 issue

    When closing a ticket, please be sure to use something a long the lines of the following. We don’t want to close tickets, rather we want to encourage growth and knowledge for the author.

    As part of the new theme directory guidelines, reviewers are now allowed to close tickets if a theme has 5 or more issues.  You can read more about this change here: [https://make.wordpress.org/themes].
    
    Don't get discouraged a closed ticket is not the end.  We want you to resubmit your theme.  We do ask that you spend a bit more time making sure that your theme meets all the requirements before we make it live. [https://make.wordpress.org/themes/handbook/review/required/]
    
    If you need help with anything or want me to explain further, don't hesitate to post here in this ticket.  I'm happy to answer any questions you have.  Or, feel free to post over on our [https://make.wordpress.org/chat/ Slack] [https://wordpress.slack.com/messages/themereview channel]."
    
     
    • Turker YILDIRIM 11:12 pm on August 23, 2016 Permalink | Log in to Reply

      May be it’d be better to send an email to all authors about this change before taking any action.

    • Jose Castaneda 11:53 pm on August 26, 2016 Permalink | Log in to Reply

      Something I’ve been thinking about is the predefined response we use. I do like it but it can be something we can iterate and make a little better:

      I am sorry but because the following five errors are present I am closing this ticket.

      • #issue1
      • #issue2
      • #issue3
      • #issue4
      • #issue5

      Do not get discouraged a closed ticket is not the end. We want you to resubmit your theme. We do ask that you spend a bit more time making sure that your theme meets all [https://make.wordpress.org/themes/handbook/review/required/ the requirements] before we make it live.

      If you need help with anything or want me to explain further, don’t hesitate to post here in this ticket. I’m happy to answer any questions you have. Or, feel free to post over on our [https://make.wordpress.org/chat/ Slack] [https://wordpress.slack.com/messages/themereview channel].

      • Justin Tadlock 3:08 pm on August 28, 2016 Permalink | Log in to Reply

        Small correction:

        I am sorry but because the following five errors are present I am closing this ticket.

        • #issue1
        • #issue2
        • #issue3
        • #issue4
        • #issue5

        Do not get discouraged. A closed ticket is not the end. We want you to resubmit your theme. We do ask that you spend a bit more time making sure that your theme meets all [https://make.wordpress.org/themes/handbook/review/required/ the requirements] before we make it live.

        If you need help with anything or want me to explain further, don’t hesitate to post here in this ticket. I’m happy to answer any questions you have. Or, feel free to post over on our [https://make.wordpress.org/chat/ Slack] [https://wordpress.slack.com/messages/themereview channel].

  • Ulrich 11:32 pm on August 20, 2016 Permalink |  

    Agenda for 2016 August 23 

    The Theme Review Team holds a meeting weekly and we encourage all members to attend.

    Channel: #themereview | Time: Tuesday at 18:00 UTC 18:00 UTC

    The meetings typically last 30 minutes. If time permits, additional topics may be discussed.

    If you have any topics, then please reply to this post and include the topic, along with a brief description of what you would like to discuss.

     
    • Jose Castaneda 11:37 pm on August 20, 2016 Permalink | Log in to Reply

      The multiple screenshots was mentioned in Slack ( https://wordpress.slack.com/archives/themereview/p1471619247003107 ) and in core’s post ( https://make.wordpress.org/core/2016/08/17/wordpress-4-7-whats-on-your-mind/ ). Both @grapplerulrich and I both mentioned it on there.

      I think we can get at least some ideas together by Tuesday. I agree with @celloexpressions in that the bigger question is:

      https://wordpress.slack.com/archives/themereview/p1471653541003154
      I think the biggest question is what multiple screenshots should show

    • Nilambar Sharma 12:46 am on August 21, 2016 Permalink | Log in to Reply

      I have seen some Github issues with tag decision needed. If time allows, we can discuss those also.

      https://github.com/WPTRT/WordPress-Coding-Standards/issues?q=is%3Aissue+is%3Aopen+label%3A%22decision+needed%22

    • ThinkUpThemes 8:23 am on August 21, 2016 Permalink | Log in to Reply

      I personally am not a big fan of imposing a restriction on uploads per theme author. I think it’s another attempt to tackle the issue of long queue, without tackling the underlying cause of the problem. The problem is that many authors submit themes that are far from meeting the required standards.

      I’d like to see more focus on how we can educate authors to develop to the required standards. One of the best ways is to review, but obviously we can’t force authors to review real themes as this will result in poor reviews. My idea is that we require new authors to review the “doing it wrong” theme before submitting a theme. How we go about implementing this, I don’t know just yet.

      If we are to implement a restriction on uploads per author. I’d like to see a staggered approach moving towards the ultimate restriction of 1. So for example, start at 3 (average of TF’s), then see it’s effectiveness after 6 months and adjust accordingly at that time (possibly to 1).

      If we start the restriction by imposing it at 1 theme per author, then we don’t have any leeway to tighten it up further in future.

    • Rinku Y 4:45 am on August 22, 2016 Permalink | Log in to Reply

      Author upload limit 1 is very good idea !! if author has submitted a theme, he need to wait for it to become live or close. this will decrease queue and also will very much helpful for new theme author. Next time author will not make same mistakes.

    • Edward Caissie 1:18 pm on August 22, 2016 Permalink | Log in to Reply

      If I’m understanding the upload limit premise it is mostly directed at new theme authors (possibly new themes) more so than anything else and from that perspective I can understand a limitation; but, if it is directed at theme authors in general I do not … for those theme authors that have multiple active/live themes in the repository they have likely gone through the review process at least a few times and as such should be familiar with the guidelines.

      If themes existing themes (current/”known” theme authors) are being affected by this restriction then it could become something very detrimental and I would not recommend it.

      Given these ideas, is it possible to implement this idea so that it only affects “new” authors and/or “new” themes but does not affect any theme updates?

    • Carolina Nymark 7:19 am on August 23, 2016 Permalink | Log in to Reply

      If there is time, can we discuss the suggestion about closing tickets with 5 errors?

  • Justin Tadlock 6:50 pm on July 26, 2016 Permalink |  

    Meeting notes for 2016 July 26 

    We had a solid discussion based on this week’s agenda.

    Read the meeting transcript in the Slack archives. (A Slack account is required)

    Removing exception to hardcoded scripts guideline

    The first item was to discuss the removal of an exception to one of our existing guidelines when WordPress 4.6 is released:

    No hard coding of scripts and styles unless a browser workaround script.

    We will no longer be allowing browser workaround scripts to be hardcoded. The new guideline would be rewritten to become:

    No hard coding of scripts and styles.

    The reason to remove the exception is because WordPress has the wp_script_add_data() function for handling this. When WP 4.6 rolls out, that’ll be more than 3 versions for back-compatibility.

    So, it’s time to update your code if you have any hardcoded scripts remaining. You can find an example in the TwentySixteen theme.

    UX considerations for the feature filter

    @celloexpressions brought up the idea of making the “subjects” in the feature filter a drop-down. We’d like to see user testing and give time for the new subjects list to be used first.

    In our next tags iteration (next January), we want to consider overall improvements to the entire feature filter box and what can be done to make this better for users.

    Adding the review baseline to the handbook

    @sakinshrestha is getting his first project as a key reviewer.

    He’ll begin work on adding the review baseline to the handbook. This is to make sure theme authors are aware of how our new review flow works.

     
  • Ulrich 6:58 am on July 25, 2016 Permalink |  

    Agenda for 2016 July 26 

    The Theme Review Team holds a meeting weekly and we encourage all members to attend.

    Channel: #themereview | Time: Tuesday at 18:00 UTC 18:00 UTC

    Topic : Open discussion

    • We currently have an exception for enqueuing browser workaround script. Since WordPress 4.2, wp_script_add_data() exists, and browser workaround scripts now can be enqueued (see TwentySixteen). I would like to remove this exception once WordPress 4.6 is released which is planned for the middle of August.

    No hard coding of scripts and styles unless a browser workaround script.

    The meetings typically last 30 minutes. If time permits, additional topics may be discussed.

    If you have any topics, then please reply to this post and include the topic, along with a brief description of what you would like to discuss.

     
c
compose new post
j
next post/next comment
k
previous post/previous comment
r
reply
e
edit
o
show/hide comments
t
go to top
l
go to login
h
show/hide help
shift + esc
cancel
Skip to toolbar