WordPress.org

Theme Review Team

Recent Updates Page 2 Toggle Comment Threads | Keyboard Shortcuts

  • Tammie 10:58 am on August 24, 2015 Permalink |  

    Weekly meeting agenda

    Our weekly meeting is on Tuesday at 18:00 UTC in #themereview. What shall we talk about?

    It’s good to every now and then have an open meeting so we can talk about anything that people want to. Lets do that this week. There is no set agenda so please add what you’d like to talk about in the comments.

     
    • Maria Antonietta Perna 12:38 pm on August 24, 2015 Permalink | Log in to Reply

      I’m not sure if this is an appropriate topic for a meeting, but I’d like to talk about the way themes abandoned by reviewers can be handled. As far as I understand, at the moment it’s up to a reviewer to pick a theme without any specific order. It’s possible themes stay there for months while themes added later but never abandoned by a reviewer could make it to the approved or even live themes list much sooner. This system seems to inadvertently penalize theme authors for someone else’ s actions (the reviewer’s). I’m aware it’s a difficult issue and perhaps one that will disappear once the new automated system of uploading themes is in place, but it’s affected me and a few people, so I mention it in case anyone else would like to discuss it too.

    • Nilambar Sharma 3:23 pm on August 24, 2015 Permalink | Log in to Reply

      Can we have a better `approved but not live` queue so that reviewer can give that link to developer after theme is approved? I believe Report 24 has some issues. Even after commenting or mentioning it in Slack queue order is changes which is not the expected behavior. Thanks.

      • Chip Bennett 4:37 pm on August 24, 2015 Permalink | Log in to Reply

        @Otto42 is there a way to display the timestamp of the state-change, either from “reviewing” to “approved”, or else from “open” to “closed”? I think we’d need a custom SQL query to generate a “closetime” parameter. But if we can do that, we can add it to Report 24, and sort by closetime. That would prevent the queue from changing due to new comments being added to closed tickets.

  • Justin Tadlock 9:44 pm on August 22, 2015 Permalink |
    Tags:   

    Using theme mod defaults 

    As more and more theme authors begin to make the move to the customizer, many are also making the switch to storing theme options as theme mods rather than rolling a custom database option. This is awesome because theme mods have a bit more to offer.

    One of the common mistakes I’m seeing is not making use of the $default parameter of get_theme_mod():

    get_theme_mod( $name, $default )

    That second parameter is pretty important as you’ll see below.

    Common usage

    The following is some common code I see in themes.

    $example = get_theme_mod( 'example' );
    
    if ( $example ) {
    
    	echo $example;
    
    } else {
    
    	echo 'Some default';
    }

    While that’s not technically broken, it’s kind of clunky and can be handled so much more elegantly as shown in this next bit of code.

    echo get_theme_mod( 'example', 'Some default' );

    Yep, we just cut that down to a single line. No need for an if/else check or anything like that. You can let WP handle the logic behind the scenes.

    Basically, that tells WP to output the example mod. If that mod hasn’t been saved yet, output our pre-defined default.

     
    • HooThemes 1:09 am on August 23, 2015 Permalink | Log in to Reply

      Hi, I’m using options framework 1.9.1 : https://github.com/devinsays/options-framework-theme, before uploading my theme, I have used Theme Check Plugin tested it, it passed, but when uploading it to WordPress.org, It throws the error
      `
      Results of Automated Theme Scanning: Fail

      REQUIRED: class-options-framework-admin.php. Themes should use add_theme_page() for adding admin pages.
      Line 34: add_action( ‘admin_menu’, array( $this, ‘add_custom_options_page’ ) );
      Line 110: function add_custom_options_page() {
      `
      It looks the ‘add_theme_page()’ have been used correctly, but it can not be uploaded to WordPress.org.

      Please advice.

      • Chip Bennett 2:00 pm on August 23, 2015 Permalink | Log in to Reply

        As of a few months ago, you must use the Customizer (Customize API), rather than a Theme settings page (Settings API/`add_theme_page()`), for new Themes.

  • Justin Tadlock 5:09 pm on August 20, 2015 Permalink |  

    Proposal: Better front page previews 

    The front page shown in the WordPress.org theme previewer has been a subject of much debate. There’s some movement on getting better demo content, but the front page is the first impression. We want it to look good and best represent what our themes are capable of.

    Given the prevalence of non-blog themes, there needs to be a bit of balance here. I’ve thought long and hard about what the best route would be for handling this. The following is my proposal. I’d like to get all of your feedback as well as check in with @otto42 on the feasibility of it before creating a ticket.

    Let me know your thoughts.

    How the front page should be shown

    I wanted to keep this simple and make sure that it works with both regular blog themes and themes that have a custom front-page.php.

    The previewer should have some code that checks:

    • If front-page.php exists, override front page setting to show a page.
    • Else, show regular blog posts.

    The idea in code

    Note: This is potential code for the previewer to better describe my idea. It’s not something to put in your themes.

    The following bit of code is a rough draft of how I think a feature should work.

    <?php
    
    add_filter( 'pre_option_show_on_front', 'wptrt_show_on_front' );
    add_filter( 'pre_option_page_on_front', 'wptrt_page_on_front' );
    
    function wptrt_show_on_front( $show ) {
    
    	return wptrt_has_front_page() ? 'page' : $show;
    }
    
    function wptrt_page_on_front( $page ) {
    
    	// 100 is the page ID to show.
    	return wptrt_has_front_page() ? 100 : $page;
    }
    
    function wptrt_has_front_page() {
    
    	// Need a check to see if the current theme being previewed 
    	// has a front-page.php template. If it does, return TRUE.
    	// Else, return FALSE.
    
    	return false;
    }
     
    • Samuel Wood (Otto) 5:12 pm on August 20, 2015 Permalink | Log in to Reply

      Something similar to this was my plan, actually. The problems I encountered were not with faking it out like this, but mainly with getting the stupid previewer to work the way I want. That will take more effort than I expected, but now with 4.3, it might be a bit simpler.

      • Justin Tadlock 5:36 pm on August 20, 2015 Permalink | Log in to Reply

        Sounds good. I’m glad we’re kind of thinking the same thing or similar here.

        • Samuel Wood (Otto) 12:29 am on August 21, 2015 Permalink | Log in to Reply

          Yeah, basically, the idea is to use every effort possible to showcase every theme in an “optimal” setup, with fake content. Faking out the preview ain’t hard. Getting the customizer to work safely is really annoying. Everything I wrote, I was able to easily hack. That gets old after a while. :-)

          Also, we can adjust later for rare cases we missed. I have a half assed plugin to do it. It’s terrible, but a starting point.

        • Samuel Wood (Otto) 12:33 am on August 21, 2015 Permalink | Log in to Reply

          Note: i might push back the customizer code to later in order to create a better preview system now. Not perfect, but, hey. Gimme a couple weeks.

    • Emil Uzelac 5:24 pm on August 20, 2015 Permalink | Log in to Reply

      This is turning into something great!

    • codeinwp 6:10 pm on August 20, 2015 Permalink | Log in to Reply

      Sounds like a good idea for me.

  • Tammie 9:46 pm on August 18, 2015 Permalink |  

    Theme review team weekly meeting notes

    The logs are here:
    https://wordpress.slack.com/archives/themereview/p1439920746000487

    • We have a suggested flow for the uploading of themes to the directory and a post will be coming.
    • @greenshady has created a meta ticket for adding, removing and modifications for tags. You can find it here, please have your input if you would like to see anything done with it:

    https://meta.trac.wordpress.org/ticket/1187

     
  • Jose Castaneda 12:34 pm on August 17, 2015 Permalink |  

    Meeting Agenda August 18 

    House-cleaning

    • Scheduled 4.3 release! Brace for updates
    • pinging/CC’ing

    Topics:

    • meta tickets
    • upsell links and such
     
    • Tammie 12:58 pm on August 17, 2015 Permalink | Log in to Reply

      As we discussed in the meeting last week, our plans were a little different. We don’t really need to do any house-cleaning, lets focus on the flows and then generating meta from that. I’m unaware of people asking about upsell and such. I think it’s important we have a meeting perhaps on the flows and meta as a primary focus. The upsell is probably suitable in another meeting and with some direction on talking points, it has a tendency to grow as a subject.

    • dragonflyfla 5:07 pm on August 17, 2015 Permalink | Log in to Reply

      Hi –

      I would like to request a policy review if that is possible? I just had someone try to help me out and in order to see what the issue was he needed admin access. Obviously there is a policy out there that does not allow this. I believe this should be changed to a warning – and not a control issue on wordpress.org part. Not all of us are newbies and totally na├»ve to allowing admin access to developers. Please also take into consideration that there are more than just blogs and portfolios out there. There are also businesses and fixing issues is never quick enough.

      Thanks.

      ~Joy

      • Chip Bennett 12:18 pm on August 18, 2015 Permalink | Log in to Reply

        I don’t think that this request is within the purview of the Theme Review Team. It is really not relevant to anything that we do. You may want to check the forum support slack channel?

    • Jose Castaneda 9:02 pm on August 17, 2015 Permalink | Log in to Reply

      I just had someone try to help me out and in order to see what the issue was he needed admin access.

      If this was in the forums, there is a small note on the forum welcome under the bad stuff. It is the third listed item. There is a reason for not allowing this.

      fixing issues is never quick enough.

      Please keep in mind WordPress.org is all volunteer. You are always more than welcome to hire somebody if it requires immediate attention. As much as I hate saying it but you do get what you pay for.

c
compose new post
j
next post/next comment
k
previous post/previous comment
r
reply
e
edit
o
show/hide comments
t
go to top
l
go to login
h
show/hide help
shift + esc
cancel