New additions to the Screenshots and Featured Images requirements

We added new requirements for screenshots and featured images, make sure you follow them.

Screenshot

Do not use subjective words like brilliant, amazing, best, trusted, etc. These words describe your opinion rather than what the theme actually is. Also, displaying theme statistics in screenshots is forbidden, e.g: top 100, most downloaded, 5 stars, etc. These can’t be verified with certainty and are temporary.

Featured Images

Placeholder/default images for posts without defined featured images need to follow these rules:

  • be generic (solid color, gradient or patterns)
  • they can’t display logos
  • they can’t display text, only accepted form would be displaying the image size, `400x300px`
  • icons are allowed as long as they are not logos. A good example is a `photo camera` icon.
  • they need to be bundled within the theme, don’t use third party placeholder services directly (e.g: `placeholder.com`).

Small Trusted Authors change

As of right now, the Trusted Authors waiting time is 1 week. If you are a TA, you’ll be able to submit a new theme once a week instead of once every two weeks.

This change is intended in part to make being a TA more attractive so all authors up their game.

So, if you’re waiting to upload a new theme, subtract 7 days from your waiting time and submit 🙂

Thank you!

Recap of the Theme Review Coding Standards Meeting

We had a productive meeting today. Juliette Reinders Folmer, William Patton, Ulrich Pogson and I went through all open pull requests and issues of the Theme Review Coding Standards repository. The meeting resulted in closing a lot of pull requests that couldn’t be implemented using Code Sniffer, identifying those that could be quickly rebased and updated to work with PHPCS 3.x, and merging several that were ready to be merged.

We also went through the open issues and closed some, while others were labeled appropriately. On some issues we need a second opinion or more information to crystallize what actually needs to be sniffed for, so be sure to leave a comment.

As development in the WordPress Coding Standards project has been plenty active in the past year, several new WPCS sniffs were identified which we can use for the TRTCS ruleset, so those will be added in the coming weeks.

The authors of the pull requests that need to be updated were notified, and we decided to give them until Monday to respond whether they would like to continue work on the PR or not. After that Juliette will probably update them since she has the most knowledge about writing sniffs.

The way people can contribute, besides writing sniffs (which can be a bit daunting to someone who never wrote one), is to post code examples in the issues or in the pull requests that would correspond to the issue/sniff in question. This really helps with unit testing the sniff as clear specifications make writing the sniff that much easier.

As for Theme sniffer, I’ve written a way to circumvent a possible bottleneck of code sniffer – minified files. This will need to be tested of course. In addition to that, the way files are sniffed will have to be changed – sniffing in batch, instead of the current way of sniffing files one by one. I’ll try to fix that as soon as possible so that you can test it and report possible issues.

Theme Review Coding Standards Meeting on 31st of May 2018

With WordCamp Europe coming closer every day, Juliette Reinders Folmer from the WordPress Coding Standards team and I decided to have a chat about the status of the current Theme coding standards and the Theme Sniffer plugin.

The current focus is bringing the Theme coding standards up to date with the PHP_CodeSniffer (v 3.x) and WordPress Coding Standards (0.14.1) (open PR #145) and finishing up the rewrite of the Theme Sniffer plugin so that it can be used during the Contributors day on WordCamp Europe.

I’ve written about the meeting in the slack channel, you can check that out here.

A meeting will be held on Thursday 31st, 09:00 AM CET via hangouts. You can add the google calendar events to your calendar by clicking these links meeting part 1meeting part 2, the hangouts link is added in the events, but we’ll provide one during the meeting on the theme review slack channel. Be sure you are logged in with google account, so that we can use built-in hangouts functionality like chat, if needed.

The proposed agenda will be:

  • Talk through the PR to update to WPCS 0.14.1 / PHPCS 3.x & merge. #145
  • Go through all open PRs: PRs
    • some will need updating for PHPCS 3.x
    • some will need updating for WPCS
    • some will need reviewing
    • some might be mergeable (after rebase)
  • Go through all open issues: issues
    • create PRs for those where upstream activity has made it an easy fix
    • determine priority and action for the rest
  • Go through the upstream WPCS issue Add sniffs for theme checks to see:
    • what’s still relevant what with the developments in TRT-land
    • what can be fixed easily what with new sniffs having been added to WPCS + PHPCS
    • open issues in WPTRT-CS repo for what remains
  • Go through all WPCS sniffs to see which if any of the new sniffs added should also be added to TRTCS
  • Browse through upstream PHPCS sniffs to see if there are (new) sniffs we should include.

There is still a lot of work to be done, so we would very much like to welcome people to contribute to this project. Contributors can really help us a lot by testing the new Theme Sniffer plugin. Testing sniffs and contributing by writing sniffs is also very welcome. I hope all who are interested and want to contribute will be there so that we can finish this before the WCEU Contributors day.

#contributors

X-post: Changes that Affect Theme Authors in WordPress 4.9.6

X-comment from +make.wordpress.org/core: Comment on Changes that Affect Theme Authors in WordPress 4.9.6