Request for feedback: Training Contributor badge requirements for code contributions

Welcome

The WordPress Training Team helps people learn to use, extend, and contribute to WordPress through learn.wordpress.org.

Are you new to the team?

Getting Started – Join the team through this self-guided onboarding program.

Current Focus Areas – What we’re currently focusing on.

Goals for 2024– the goals include the team’s vision, values, and a quarterly breakdown of project milestones.

Already onboarded and ready to get involved?

See How we use GitHub to get started on one of our 6 project boards

Meetings (Calendar)

Weekly Global team meeting: Thursdays 00:00 UTC

Dev-squad GitHubGitHub GitHub is a website that offers online implementation of git repositories that can easily be shared, copied and modified by other developers. Public repositories are free to host, private repositories require a paid subscription. GitHub introduced the concept of the ‘pull request’ where code changes done in branches by contributors can be reviewed and discussed before being merged be the repository owner. https://github.com/ triage: Biweekly on Thursdays 07:00 UTC

See Meeting Details for more information.

It has been brought to my attention by the Training Team Reps that the requirements for achieving a Training Contributor Badge for code contributions to the Learn WordPress codebase are rather vague:

You should significantly contribute to the Learn website by adding or modifying features. This would include writing a feature enhancement or fixing a bug.

I would like to suggest that we update those guidelines so that it is clearer what the requirements are to achieve the badge specifically for code contributions.

I propose we update the guidelines as follows:

You have created or reviewed at least 3 pull requests, either bug fixes or enhancements, to be merged into the Learn WordPress codebase. These pull requests need to have also been reviewed and approved by at least one member of the Training Team Faculty or the WordPress MetaMeta Meta is a term that refers to the inside workings of a group. For us, this is the team that works on internal WordPress sites like WordCamp Central and Make WordPress. team.

By replacing significantly contribute with at least 3 pull requests, we make the goal clearer and easier to understand.
By including the requirement of a second review from either a member of the Training Faculty or the WordPress Meta team (which we work closely with to deployDeploy Launching code from a local development environment to the production web server, so that it's available to visitors. Learn WordPress changes and updates), we can ensure that pull requests are reviewed correctly.

Updating code contribution documentation to align with these changes.

It has also been brought to my attention that we have two Handbook page that relate to contributing code to Learn WordPress:

I suggest that we merge the Code contributions page into the Developing Learn WordPress page (possibly replacing the Contributing code section, adding a section on the suggested code review process, and a note on achieving the Training Contributor Badge.

Call for feedback.

What do you think of the suggested updates? Please leave your thoughts on this post by Friday, 26 January 2023.

Nick Diego 9:16 pm on January 9, 2024

I think all these suggestions sound reasonable and would help clarify the ambiguity around achieving a contributor badge through code contributions.
SierraTR 5:02 pm on January 16, 2024

I agree with Johnathan and Nick – the clarification is needed and the proposed changes are very reasonable. Merging the two handbook pages is a very good idea – another application of the DRY principle.
Benjamin Evans 5:15 am on January 19, 2024

These proposals all look great, and will also assist team reps when processing badge requests. Thanks!
Jonathan Bossenger 10:10 am on January 30, 2024

Thanks everyone for the feedback. The contributor badge guidelines have been updated, and the Code contributions page has been merged into the Developing Learn WordPress page. I also updated the readme in the GitHubGitHub GitHub is a website that offers online implementation of git repositories that can easily be shared, copied and modified by other developers. Public repositories are free to host, private repositories require a paid subscription. GitHub introduced the concept of the ‘pull request’ where code changes done in branches by contributors can be reviewed and discussed before being merged be the repository owner. https://github.com/ repo to link back to the relevant page in the handbook.

Comments are closed.

Welcome

Meetings (Calendar)

Updating code contribution documentation to align with these changes.

Call for feedback.

Share this: