Meeting notes from August 13th, 2019

A meeting was held with the proposed agenda.

The following is the recap of the meeting, you can read the meeting transcript in the slack archives (a Slack account is required).

Weekly Updates

Some authors asked their themes to be closed, which was done. If you need your existing tickets closed you can pingPing The act of sending a very small amount of data to an end point. Ping is used in computer science to illicit a response from a target server to test it’s connection. Ping is also a term used by Slack users to @ someone or send them a direct message (DM). Users might say something along the lines of “Ping me when the meeting starts.” the leads.

In the past seven days:

  • 246 tickets were opened
  • 233 tickets were closed
  • 103 new tickets are waiting for review
  • 4 tickets are older than 4 weeks
  • 53 tickets are older than 2 weeks
  • 76 tickets are older than 1 week
  • 97 tickets are older than 3 days

Trusted Authors (TA) announcement

From today, the TA program is closed.

The program did not fulfil the intended plan and has ultimately caused more problems than solving.

Some reasons for removal of the program include:

  • Entry criteria was difficult to set, it was hard to maintain consistency.
  • Management of the queue required separate reports in tracTrac Trac is the place where contributors create issues for bugs or feature requests much like GitHub.https://core.trac.wordpress.org/. to be modified via SQL – that was unsustainable.
  • Being TA has benefits unavailable for other authors – how fair this is for everyone has been commented on a loads of times. 

The leads will make a blog post describing the reasoning behind removal of the TA program.

Open floor

A discussion was held about the removal of the TA. One issue that came up during the discussion, was the fairness of the admin queue. And of the review process in general, since some authors may get an experienced reviewer, and others may get a novice reviewer, which will require another inspection to see if they did a good job.

There were proposals to fix these issues, such as pairing new with experienced reviewers.

#meeting, #meeting-notes, #trt

Meeting notes from July 23rd, 2019

A meeting was held with the proposed agenda.

The following is the recap of the meeting, you can read the meeting transcript in the slack archives (a Slack account is required).

Updates

We got positive and supportive feedback about the skip links (accessibilityAccessibility Accessibility (commonly shortened to a11y) refers to the design of products, devices, services, or environments for people with disabilities. The concept of accessible design ensures both “direct access” (i.e. unassisted) and “indirect access” meaning compatibility with a person’s assistive technology (for example, computer screen readers). (https://en.wikipedia.org/wiki/Accessibility)). Even though it is simple to implement, the authors were confused. But we have a post explaining what they are and how to implement them.

Authors are starting to change the admin notices, according to the guidelines.

Promoting other themes from within popular themes isn’t allowed. Few authors were caught doing this and they changed it upon request. Ignoring the request to remove the promotions will result in theme suspension.

After meeting with the documentation team, @acalfieri was selected as a representative from the Theme review team to update the theme developer handbook.

A new version of Theme Sniffer and WPThemeReview coding standards was released.

In the past seven days:

  • 449 tickets were opened
  • 463 tickets were closed
  • 416 tickets were set live
  • 25 new Themes were set live
  • 391 Theme updates were set live
  • 10 more were approved but are waiting to be set live
  • 39 tickets were not-approved
  • 8 tickets were closed-newer-version-uploaded

An automatic way of notifying theme authors

It was proposed that all the theme authors get automatically subscribed to the TRT blog so that they can be made aware of the announcements when they are made.

Another proposal was to send mass emails to all theme authors to make sure their themes are compliant with the newest requirements. Those whose email bounced would get suspended or changed to reviewing status.

An agreement was not reached. It was agreed that the TRT will reach out to other teams so that we can see how they are dealing with this issue, and if this can be solved on a more global basis.

Looking for good examples of keyboard navigation

A team needs a good example for keyboard navigation, especially for menus, so that we can provide an example for theme authors, as this is going to be the next a11yAccessibility Accessibility (commonly shortened to a11y) refers to the design of products, devices, services, or environments for people with disabilities. The concept of accessible design ensures both “direct access” (i.e. unassisted) and “indirect access” meaning compatibility with a person’s assistive technology (for example, computer screen readers). (https://en.wikipedia.org/wiki/Accessibility) measure that will be implemented.

Currently, we don’t have an agreement to what is the best way to move forward with this so any contribution is welcomed.

Open floor discussion

The feature packages project needs active contributors, so if you are interested in contributing to the TRT open-source projects check out the official TRT Github repository.

#meeting, #meeting-notes, #trt

Meeting notes from the 9th of July 2019

The meeting started with a quick round of updates. There is still no resolution about the trusted authors (TA) issues.
After that we started discussing the proposed meeting agendas.

The following is the recap of the meeting, you can read the meeting transcript in the slack archives (a Slack account is required).

Docs team discussion about the theme developer handbook

There was a discussion on the #docs slackSlack Slack is a Collaborative Group Chat Platform https://slack.com/. The WordPress community has its own Slack Channel at https://make.wordpress.org/chat/. channel about handover of the theme developer handbook to the TRT.
The idea is to have a single responsible person from the TRT team that will take care of the developer handbook for the themes. This means updating it with new requirements and keeping it up to date in general.

It was agreed that the person in charge of the theme developer handbook will be @acalfieri, who is an experienced reviewer and has been an active member of TRT for a long time.
Of course, if there will be interested volunteers to help you can always ask in the slack channel.

AccessibilityAccessibility Accessibility (commonly shortened to a11y) refers to the design of products, devices, services, or environments for people with disabilities. The concept of accessible design ensures both “direct access” (i.e. unassisted) and “indirect access” meaning compatibility with a person’s assistive technology (for example, computer screen readers). (https://en.wikipedia.org/wiki/Accessibility) (a11yAccessibility Accessibility (commonly shortened to a11y) refers to the design of products, devices, services, or environments for people with disabilities. The concept of accessible design ensures both “direct access” (i.e. unassisted) and “indirect access” meaning compatibility with a person’s assistive technology (for example, computer screen readers). (https://en.wikipedia.org/wiki/Accessibility)) requirements

In the accessibility team meeting it was proposed to add some of the requirements from the themes which use accessibility-ready tag to standard themes in the repository.

The emphasis is on making the themes easier to use, especially for the people with certain types of disabilities.
The proposal included incorporating the keyboard navigation, control, skip link, and form labelling requirements from the existing accessibility-ready requirements.

This is the first step in making all themes in wordpress.orgWordPress.org The community site where WordPress code is created and shared by the users. This is where you can download the source code for WordPress core, plugins and themes as well as the central location for community conversations and organization. https://wordpress.org/ repository accessible.

The changed requirement wouldn’t encompass all the accessibility-ready requirements to be present on the standard themes, nor would it automatically make them accessibility-ready, but by incorporating one by one requirements, through longer time period, the idea is to encourage theme authors to write accessible themes out of the box.

It was agreed that the skip links requirement from the accessibility part will be moved to the required section of the review handbook, and that the team will implement new a11y requirement every two months. This will give theme authors enough time to make their themes more accessible.

Removing Demo Content from the theme

It was already agreed with removing demo content files (xml, json or some other format) from the themes. But there needs to be alternative to that.

It was agreed that the requirement should be updated with following to make it more clear:

Importing or Downloading:


Themes are not allowed to import content to a user’s site.
Themes are not allowed to link directly to an XML, JSONJSON JSON, or JavaScript Object Notation, is a minimal, readable format for structuring data. It is used primarily to transmit data between a server and web application, as an alternative to XML., ZIP, or other file for direct download or import.
Themes are not allowed to bundle demo content via an XML, JSON, ZIP, or other file.

Also, a meeting will be held in the #design slack channel about updating the wordpress.org previewer content which can then be used as a starting content for the developers to develop their themes.

Theme generated notices

All the notifications generated by a theme should use the admin_notices APIAPI An API or Application Programming Interface is a software intermediary that allows programs to interact with each other and share data in limited, clearly defined ways. and follow the CoreCore Core is the set of software required to run WordPress. The Core Development Team builds WordPress. design pattern. They must be dismissible. Everything wrapped in the admin notice needs to follow Core UIUI UI is an acronym for User Interface - the layout of the page the user interacts with. Think ‘how are they doing that’ and less about what they are doing. design for the notices.

This will be a requirement on all the themes.

Open floor discussions

There was a mention of the tool that can help reviewers review a theme – WPTRT-Cloud-Launcher. It’s a Chrome extension that launches a cloud instance that comes pre-configured with the theme and theme snifferTheme Sniffer Theme Sniffer is a plugin utilizing custom sniffs for PHP_CodeSniffer that statically analyzes your theme and ensures that it adheres to WordPress coding conventions, as well as checking your code against PHP version compatibility. The plugin is available from the plugin directory and Github. Themes are not required to pass the Theme Sniffer scan without warnings or errors to be included in the theme directory./check plugins installed.

#meeting, #meeting-notes, #trt

Meeting notes from the 25th of June 2019

The meeting started with a quick round of updates, mostly about the WCEU recap. After that we started discussing the proposed meeting agendas.

The following is the recap of the meeting, you can read the meeting transcript in the slack archives (a Slack account is required).

Trusted Authors (TA) issues

First on the agenda was the discussion of the TA issues. There was a question of the quantifiable improvements from the TA program.
TA started on 30th of April last year, so having some data about it would be useful way to base decisions on.
Besides shorter queue, and more themes being set live (in the TA queue), the quality of code hasn’t really improved (that we know of). As mentioned by one of the leads

The improvements I have seen so far are faster throughput for SOME authors and slower for others. Code quality of non-TA has remained consistent. Code quality of TA has remained consistent too (but functionality and originality dropped).

There was a good point raised during the meeting, about pushing the authors to do more, but not better, since the program focuses on the quantity of themes, rather the quality. This can impact the originality and quality of the themes.

Underlying issue is that the review process in it self is too complicated, which affects the queue length.

Also there is no data to support either closing the TA or not. The discussion mostly went back and forth about what are pros and cons of the TA program without any conclusion

CustomizerCustomizer Tool built into WordPress core that hooks into most modern themes. You can use it to preview and modify many of your site’s appearance settings. upsell status

The repository with the customize section button was created and is currently being worked on – it’s working as is, there are some possible improvements in the build process that could be added.
This repository example doesn’t have to be used for upeslls exclusively. The 1.0.0 version should be out this week.
What we need is a code review to make sure everything is ok to be used in themes.

Another project that was started was the PHP autoloader for the people not using Composer to be able to use the customize section button in their themes.

Some members were worried how to use the above code without the use of Composer, but it was explained that the code can be copy/pasted – authors can download the ZIP, use GitGit Git is a free and open source distributed version control system designed to handle everything from small to very large projects with speed and efficiency. Git is easy to learn and has a tiny footprint with lightning fast performance. Most modern plugin and theme development is being done with this version control system. https://git-scm.com/. clone, Git sub-module, or Composer dependency in their themes.

Removing child themeChild theme A Child Theme is a customized theme based upon a Parent Theme. It’s considered best practice to create a child theme if you want to modify the CSS of your theme. https://developer.wordpress.org/themes/advanced-topics/child-themes/. queue

The advantage of the child theme queue is that those themes get set live pretty fast, and this makes authors submit more child themes.

A lot of people were for removing the child theme queue, as the requirements regarding them are not clear enough, and it makes the regular queue longer.

The conclusion to close it wasn’t reached, and the leads mentioned that they will reach a conclusion based on the provided discussion.

Final remarks

In the end, one of the theme review leads recommended that we try halting the TA queue until the final queue gets cleaned, because if only TA themes get set live, this puts the non TA authors in a bad position.

We will try the idea that if final queue has more than 50 themes then TA approvals are halted.

#meeting, #meeting-notes, #trt

Meeting notes from the 11th of June 2019

Yesterdays meeting had a lot of agendas, and it lasted for an hour and a half. A lot was discussed, and some conclusions were made. The following is the recap of the meeting, you can read the meeting transcript in the slack archives (a Slack account is required).

Legacy readme files issue

Some older themes didn’t update their readme.txt file to make it compliant with the proposed unification of the readme format (sample readme).
The idea is to have the readme file similar or same as the plugins have, so that we can maybe work towards making the themes preview more similar to that of the plugins.

Punishing the theme authors seems too harsh so it was agreed to fall back to style.css to keep the backwards compatibility in place, as well as notifying the authors in bulk to update their readme.

Removing the TA program

A big discussion was held whether we should keep or remove the trusted authors (TA) program. One side was adamant that it serves to game the system, as the authors in the TA program get to publish their themes more quickly than the authors not in it. In addition to this argument, another one was that it adds more work for admins who already have a lot on their plate.
Another side said that this keeps the quality of the themes up, and is a good incentive to maintain that quality. Plus, with the new rule that TA must review one theme a month if they wish to have their themes reviewed in the TA queue, the review queue could benefit from it (this is something that we need data to substantiate).

No conclusion was made as to what is the solution for the TA issues, and it was agreed that another discussion should be had regarding this issue.

Removing closed theme tickets to make the names available

A proposal was made to remove closed tickets in order to free up the names in the directory, since once a theme is in the system, the name of that theme is used and cannot be used again (because that could cause conflicts).

Since themes cannot be removed (at least not in a simple way) from the SVNSVN Apache Subversion (often abbreviated SVN, after its command name svn) is a software versioning and revision control system. Software developers use Subversion to maintain current and historical versions of files such as source code, web pages, and documentation. Its goal is to be a mostly compatible successor to the widely used Concurrent Versions System (CVS). WordPress core and the wordpress.org released code are all centrally managed through SVN. https://subversion.apache.org/., and it would cause more work with no real benefits, it was decided that no themes would be removed and that they will remain in the repository.

Limiting links in a theme to Theme URI and Author URI

In an effort to make a directory a better place and make some things like upsells better handled in the themes Justin Tadlock created a repository with a reusable component that will handle customizerCustomizer Tool built into WordPress core that hooks into most modern themes. You can use it to preview and modify many of your site’s appearance settings. upsells.

The idea is to add more such components that would solve some common issues found in the themes, and to provide examples how to use them.

Another repository already exists where some code snippets could be added that would showcase how to correctly program certain parts of the themes.

Volunteers are encouraged to contribute to both of those.

Rule about overly obtrusive upselling is still in effect.

Fully functional themes in the themes repository

Recently there were cases where themes landed in the repository which either had no styling (starter themes), or which required premium plugins to work properly.

It was agreed that this won’t be allowed and those themes will be removed from the repository. Themes should be fully functional without the use of the third party plugins.

Removing .xml files from themes

Some themes provide .xml demo content that can be imported to provide the layout that the theme author created. While this can help users with recreating the layout issue, it opens up a security issue. One such issue is the possibility of an XML External Entities (XXE) attack.
Also, there was a theme which held spammy links inside their .xml file.

In order to prevent that, it was agreed that the themes shouldn’t bundle the .xml files in the theme, but they can link to the .xml file from their site.

This will also encourage theme authors to start looking into utilising starter content for their themes.

Some useful links for starter content can be found below:

How to use starter content in WordPress themes
Using and customizing WordPress Starter content

Creating council/group to judge offences and issues regarding themes

A proposal was made to have a separate council for handling any theme offences. The majority agreed that this is not needed and that the team leads/reps should handle these cases (like they have been doing so far).

Team lead interest

Since current team leads have been running the team for over a year now, new leads should be selected.
Any interested parties for this position should comment on the post by Josepha Haden.

#meeting, #meeting-notes, #trt