Meeting notes for 2018 April 24

Meeting [ link ]. A Slack account is needed to view the archives.

Items discussed:

  • acosmin and williampatton will be joining the current Leads team (rabmalin and thinkupthemes) for the next tenure. Welcome acosmin and williampatton 🙂
  • After Changes in Theme Review Process, review queue has been significantly reduced to 2-3 weeks.
  • Reviewer badge has been assigned for new reviewers.
  • There was brief discussion about incentive program but no decision has been made.
  • Confusion around max 1 theme per month rule was discussed.

#meeting-notes

Meeting notes for 2018 March 13

Meeting [ link ]. A Slack account is needed to view the archives.

Items discussed:

  • Reducing rules to “essential”: There was intense discussion regarding the change in guidelines. Proposal was to reduce list to 3 essential points: licensing; security and egregious issues. Even though several attendees gave input regarding the agenda, no decision has been made.
  • For:
    • This would reduce queue time drastically.
    • This would move some burden from reviewer to theme author.
    • If theme does something wrong, author will be affected by user’s rating, so author would be more careful.
    • At we can run an experiment, for say 1 months and see how it goes
  • Against:
    • This would let pass themes with some currently critical issues like content creation, prefixing, translation ready, etc.
    • It is hard to trust theme authors as we have seen several examples with breaking of trust.
    • If theme passes with issues and later asked to be fixed by reviewer then user will suffer.
    • Even if we run this experiment for some period, we should first set some target and parameters to check after the experiment to decide whether continue or revert this change.

#meeting-notes

Meeting notes for 2018 February 13

Meeting [ link ]. A Slack account is needed to view the archives.

Items discussed:

  • Update for child handbook page
    • Forum team are planning to update the child themes page in the handbook.
    • Those interested in helping can leave comments in a gdoc here: https://docs.google.com/document/d/1-DO9kAWigalNvV2eFsoCVliGeQ4bzkvAgHUmCj2_GaY/edit.
  • Preventing users removing footer copyright messages
    • Authors should not make it excessively difficult for users to remove footer messages.
    • Please see comment: https://wordpress.slack.com/archives/C02RP4Y3K/p1517936627000097
  • Admin pointers
    • Use of admin pointers was originally disallowed as it was expected that stable Admin Pointer API would be in core.
    • As there’s no clear indication of whether this feature will soon be in core, we discussed allowing the use of admin pointers in themes.
    • The main objections to allowing these was their use in upselling, and also excessive use therefore cluttering the admin area.
    • Discussed allowing the use of admin pointers, initially with no rules. A vote during the meeting showed 10 in favour of this, and 1 against. Vote results.
    • Additional guidelines governing the use of admin pointers would be made at a later date once authors begin adopting this feature.
    • Team leads have decided to allow admin pointers. The situation will be monitored and new rules added in future if needed.
  • Gutenberg
    • A separate post will soon be published to allow everyone to share their opinions.
    • This will give an opportunity for other teams and the wider WP theme dev community to also share in the conversation.
    • The topic will be discussed at a later meeting.
  • Dealing with theme breaking guidelines
    • Themes that violate the most serious guidelines (e.g. security) are subject to suspension. This has always been the case.
    • If a theme is breaking the guidelines, first comment in-ticket requesting the author address the issues quickly.
    • If an author fails, or refuses, to fix issues in a timely manner they may be warned to fix issues within 7 days or the theme may be suspended.

#meeting-notes, #themereview

Meeting notes for 2017 November 28

Meeting [ link ]. A Slack account is needed to view the archives.

Items discussed:

  • Seasonal Themes: Seasonal/holiday themes are now given priority in the queue. Theme authors are still allowed to submit seasonal themes even if his/her another theme is in the queue.
  • Report button for themes: Possibility for implementation of report button was discussed. Since plugin team has already shelved the reporting system for plugins due to complexity, it would be difficult to implement reporting system for themes in near future.
  • Onboarding library: Onboarding script integrated in themes could be very useful for users for theme setup. Current hot library MerlinWP was mentioned. Everyone is encouraged to try and review the library and check if it is compatible with TRT guidelines.
  • Accessibility review: Currently we have very few Accessibility reviewers. To ease the Accessibility review for new reviewers @poena has published a blog post Getting ready to do accessibility reviews.

#meeting-notes

Meeting notes for 2017 November 14

Meeting [ link ]. A Slack account is needed to view the archives.
This weeks meeting would usually be open floor however there were several announcement to be made at this meeting as well. Changes detailed in the announcements are effective immediately.

Announcements:

  • New team lead hand-off has officially happened with @rabmalin and @thinkupthemes taking the position as the new team leads. Official handover date as November 1 2017.
  • Planned review weekend 18-19th November 2017
  • As a test run seasonal themes can be given priority in the queue as they require reviews in a timely fashion.

Following changes have been made to the review process:

  • Tickets can now be closed when 3+ distinct issues are identified.
  • Reviewers can now select themes to review from the top 5 positions of either queue 2 (parent themes) or queue 7 (child themes). Child themes will no longer appear in queue 2.
  • Authors are permitted to submit a maximum of 1 theme per month. This doesn’t change the 1 theme rule limit, authors are still only allowed to have 1 theme in the queue at any given time (i.e. child or parent). This is to prevent child theme authors from taking advantage of the likely future short wait times in queue 7.

Discussions:

  • At the end of the meeting some quick discussions took place about a few topics.
    Incentive reviewing – @acosmin provided a proposal on how this could be handled along with several suggested rules. At the moment no move is being taken regarding incentive reviewing.
  • Escaping – Attempts will be made to improve documentation surrounding escaping, why it’s necessary and what functions to use where.
  • Changes to featured themes tab in the directory – No changes were decided on but some people expressed that a better algorithm would be preferable on this tab.

#meeting-notes, #themereview