Meeting notes for 2017 November 28

Meeting [ link ]. A Slack account is needed to view the archives.

Items discussed:

  • Seasonal Themes: Seasonal/holiday themes are now given priority in the queue. Theme authors are still allowed to submit seasonal themes even if his/her another theme is in the queue.
  • Report button for themes: Possibility for implementation of report button was discussed. Since plugin team has already shelved the reporting system for plugins due to complexity, it would be difficult to implement reporting system for themes in near future.
  • Onboarding library: Onboarding script integrated in themes could be very useful for users for theme setup. Current hot library MerlinWP was mentioned. Everyone is encouraged to try and review the library and check if it is compatible with TRT guidelines.
  • Accessibility review: Currently we have very few Accessibility reviewers. To ease the Accessibility review for new reviewers @poena has published a blog post Getting ready to do accessibility reviews.

#meeting-notes

Meeting notes for 2017 November 14

Meeting [ link ]. A Slack account is needed to view the archives.
This weeks meeting would usually be open floor however there were several announcement to be made at this meeting as well. Changes detailed in the announcements are effective immediately.

Announcements:

  • New team lead hand-off has officially happened with @rabmalin and @thinkupthemes taking the position as the new team leads. Official handover date as November 1 2017.
  • Planned review weekend 18-19th November 2017
  • As a test run seasonal themes can be given priority in the queue as they require reviews in a timely fashion.

Following changes have been made to the review process:

  • Tickets can now be closed when 3+ distinct issues are identified.
  • Reviewers can now select themes to review from the top 5 positions of either queue 2 (parent themes) or queue 7 (child themes). Child themes will no longer appear in queue 2.
  • Authors are permitted to submit a maximum of 1 theme per month. This doesn’t change the 1 theme rule limit, authors are still only allowed to have 1 theme in the queue at any given time (i.e. child or parent). This is to prevent child theme authors from taking advantage of the likely future short wait times in queue 7.

Discussions:

  • At the end of the meeting some quick discussions took place about a few topics.
    Incentive reviewing – @acosmin provided a proposal on how this could be handled along with several suggested rules. At the moment no move is being taken regarding incentive reviewing.
  • Escaping – Attempts will be made to improve documentation surrounding escaping, why it’s necessary and what functions to use where.
  • Changes to featured themes tab in the directory – No changes were decided on but some people expressed that a better algorithm would be preferable on this tab.

#meeting-notes, #themereview

Meeting notes for 2017 October 24

Meeting [ link ]. A Slack account is needed to view the archives.

Items discussed:

  • Workflow suggestion to improve the review process.
    • Possibility of allowing new reviewers to focus purely on the more basic guidelines, and approve once these are completed.
    • All other checks will be completed by a moderator in the final review.
    • A list of the basic checks proposed can be found here.
    • No conclusion was reached as to whether this should be adopted as yet or not.
  • Review of open Theme Trac meta tickets.
    • Tickets should still continue to be progressed and raised as normal.
    • It was originally expected that Trac would be replaced with a new system to align with the plugin review process by December.
    • As yet there is no definitive timeframe on when Trac will be replaced.
  • Allow theme demo content bundled with the theme.
    • Themes are now allowed to bundle a sample XML file.
  • Image guidelines where children are shown.
    • Images which show children with recognizable facial or body features are not permitted.
  • Limit reviewers to only select themes from the top of queue (or top 5).
    • Reviewers are only allowed to select themes from the top 5 position to review, effective immediately.
    • This applies to both the new (2) and approved (24) queue.

#meeting-notes, #themereview

Meeting notes for 2017 October 10

Meeting [ link ]. A Slack account is needed to view the archives.

Items discussed:

  • Use of Pixabay images.
    • Pixabay images can now be used with themes, and are viewed no differently than all other CC0 licensed images.
    • Pixabay terms prevent mass copying of the images to create a competing service, this is not relevant to themes.
    • Pixabay terms do not affect the license of individual images, all of which are still CC0 licensed.
  • Appropriate images.
    • Images which show people (particularly children) may no longer be allowed. This will be discussed further during the meeting on October 24th.
  • Theme Sniffer.
    • @grapplerulrich continues to make progress.
    • Anyone who is interested and able to assist please get involved in the project.
  • Ideas for new experiments.
    • @poena suggested removing the “review a theme” button, and instead require new reviewers to request a theme via the blog. In addition new reviewers may want to review the doingitwrong theme before tackling a theme from the queue.

#meeting-notes, #themereview

Meeting notes for 2017 September 26

Meeting [ link ]. A Slack account is needed to view the archives.

Items discussed:

  • New team leads.
    • @rabmalin and @thinkupthemes have been chosen by current leads to be the next team leads.
    • Current team leads will be stepping down sometime in October. Exact date to be confirmed.
    • Plan is for the new leads to remain in place for 6 months. Future succession plans will be decided in future.
  • Core ticket #37661-core. Potential removal of featured section and changes to tags.
    • Plans to improve customizer experience to allow users to install themes from the directory directly from within the customizer.
    • Core have proposed removing themes featured section in the admin area of the users website.
    • Possibility that this will in time lead to the removal of the featured themes section on wordpress.org also.
  • Content creation. (Can themes have content creation if the content is saved).
    • Proposal for an approach which allows for content to be retained by users following a theme switch was presented. This relates to content that would otherwise usually be created via a companion theme specific plugin.
    • The content would be available to the user, presented in the post content of a page following theme switch, allowing the user to easily continue to use the content in future.
    • No changes have been made to the content creation guidelines following the outcome of the discussion.
  • Progress update on adding Theme Sniffer to theme upload page.
    • Next steps are to update the Theme Sniffer to the latest version of PHPCS which is 3.0.1 and PHPCs 0.13.0.
    • New version of Theme Sniffer plugin planned for release once all existing Pull Requests and Issues have been addressed.
    • Outstanding issues can be found here: https://github.com/WPTRT/WordPress-Coding-Standards/issues

 

 

#meeting-notes, #themereview