New Theme Review Team Structure

This meeting we had an announcement about the new team structure as well as discussions about the future and the team’s purpose.

Team no longer has leads – the team now has respresentatives and it is a flat team structure with loosely defined roles and responsibilities where individuals can contribute in ways that they feel strongly about.

The Theme Review Team Members page was updated accordingly.

Team Goal:

There were discussions about what the Theme Review team’s purpose was. It is important to have a single collective goal and vision so that everyone is helping to reach it. A possible statement that felt fitting was:

To ensure best practices are followed in themes and that guidelines exist to prevent bad things being a problem users need to face themselves.

@williampatton

The Plugins team statement was shared as well for inspiration.

Ultimately, we need to decide on a goal and focus our efforts achieving it, so that we can keep the team moving forward.

#announcements, #team-reps

Theme review team triage meeting

Triage, as described in the test handbook, is a process of sorting, labeling, and closing issues on the TracTrac Trac is the place where contributors create issues for bugs or feature requests much like GitHub.https://core.trac.wordpress.org/. or GithubGitHub GitHub is a website that offers online implementation of git repositories that can can easily be shared, copied and modified by other developers. Public repositories are free to host, private repositories require a paid subscription. GitHub introduced the concept of the ‘pull request’ where code changes done in branches by contributors can be reviewed and discussed before being merged be the repository owner. https://github.com/. In the context of the Theme Review Team (TRT), the triage encompasses several things:

The idea is to go through the tickets/issues and see which can be closed, change the priority (if needed), and finding ‘champions’ who will be responsible for handling the issues.

The first meeting will be held on the #themereview slackSlack Slack is a Collaborative Group Chat Platform https://slack.com/. The WordPress community has its own Slack Channel at https://make.wordpress.org/chat/. channel on Wednesday, 11th September 2019, at 17:00 UTC

Triage workflow

Since we didn’t have a triage in TRT for a long time (or ever?), the first meeting will just focus on going through the issues, closing the ones that can be closed and prioritizing other issues. If the time allows we’ll try to assign a champion to the issues with the highest priority. Some tickets/issues already have priority on them, but we need to see if these priorities need to be changed.

We’ll have one triage meeting in a month (for start) so that we have enough time to actually work on the issues (seeing how most of us volunteer and can work on these issues in our free time).

Championing the ticket/issue/PR/patch

Championing means being the person who is responsible for seeing that the issue is worked on. Ideally, champions are people who have some coding knowledge and can work on the issues. But they can also be people who are good at managing a project and finding people willing to work on the issue and seeing the issue is resolved within a sensible time frame.

For the metaMeta Meta is a term that refers to the inside workings of a group. For us, this is the team that works on internal WordPress sites like WordCamp Central and Make WordPress. tickets, we need people who are comfortable with working on the meta repository alongside meta contributors.
For some of these issues, we depend on the meta team who can change how things work on the theme directory. Other issues should have either a good proposal with a clear way of solving them or need input from the meta team. Hopefully, once we show some initiative on them we’ll have good feedback and will be able to sort them out.

For the WPThemeReview and Theme SnifferTheme Sniffer Theme Sniffer is a plugin utilizing custom sniffs for PHP_CodeSniffer that statically analyzes your theme and ensures that it adheres to WordPress coding conventions, as well as checking your code against PHP version compatibility. The plugin is available from the plugin directory and Github. Themes are not required to pass the Theme Sniffer scan without warnings or errors to be included in the theme directory. issues, we need people who will work on providing code examples (in the case of the standards) or are willing to learn how to write sniffs and how to fix issues on the Theme Sniffer pluginPlugin A plugin is a piece of software containing a group of functions that can be added to a WordPress website. They can extend functionality or add new features to your WordPress websites. WordPress plugins are written in the PHP programming language and integrate seamlessly with WordPress. These can be free in the WordPress.org Plugin Directory https://wordpress.org/plugins/ or can be cost-based plugin from a third-party.
We also need to reach some conclusion on the open issues in the coding standards so that sniffs can be written for them.
Once we have the prioritization fixed we can schedule additional meetings for discussion on working on these projects (I’ll be happy to have a meeting for people who are interested in helping out).

I’ve put the Theme Check issues as optional because we don’t have access to this repo and so far the response on accepting the PRs have been a bit low. We can prioritize issues and PRs we’d like to have implemented but unfortunately, we are dependant on one person that can act on this.

Resources

I’ve created an google docs sheet that is used as a reference for the meta related issues. Issues form the other projects will be added as the time passes so that we have it in one place and can reference it in the next triage meeting.

Triage sheet

Contributing to WPThemeReview

Contributing to Theme Sniffer

#announcements, #triage