Theme Review Team

Recent Updates Page 3 Toggle Comment Threads | Keyboard Shortcuts

  • Jose Castaneda 9:29 pm on October 6, 2015 Permalink |  

    Screenshot clarification update 

    In our meeting today we talked about screenshot size. They are fun aren’t they? The last time this was shared was back in January – of 2013 in order to clarify a little more about the requirement. Things have changed since then and we have increased sizes accordingly. At one point we did state the allowable maximum was 880 by 660. Our reasoning was to support HiDPI and retina screens. ( Yes, I did search the mail-list for this information )

    It appears that some documentation was not updated. This was also brought up in a meeting back in March ( this year ) but appears no action was taken. Any documentation should now be fixed, if you see any that were missed, please let us know.

    The key take away from this is that the aspect ratio should be 4:3 and a maximum of 1200 by 900 pixels.


  • Emil Uzelac 9:10 pm on September 25, 2015 Permalink |  

    comment_form changes in WordPress 4.4 

    Crossposting Changes to fields output by comment_form in WordPress 4.4

  • Tammie 10:42 am on September 21, 2015 Permalink |  

    Weekly chat agenda

    We’ve got our usual weekly chat at 18:00 UTC in #themereview tomorrow (Tuesday). What shall we talk about?

    It would be great to check in on: https://make.wordpress.org/themes/2015/09/17/theme-submission-review-approval-update-report-workflow/. What do we need to add to this? Is it clear enough to get built?

    After that we can have an open floor for discussions, depending on time availability.

  • Chip Bennett 2:30 pm on September 17, 2015 Permalink |
    Tags: workflow   

    Theme Submission, Review, Approval, Update, Report Workflow 

    During this week’s meeting, we discussed modifying our workflows, both to add a “Report Theme” workflow, and to add an auto-approval workflow for updates to approved, live Themes. As adding these elements will essentially require a complete rewrite of the Theme Review process workflows, we decided that now would be a good time to review/discuss both our existing workflow, and the proposed additions. The thinking is that, if we’re going to start from scratch, we might as well make sure that we’re building the best possible workflow, rather than continue to “bolt on” pieces to a system that already resembles something created by Dr. Frankenstein.

    To that end, I have roughed-out a workflow diagram that shows both our current workflows, and the new/proposed additional workflows. To help make the workflow more understandable, the various actions are sub-divided. At the top are user/developer actions that set things in motion. After that are a series of system actions that lead to the tickets. After that are the actions of the Theme Review Team that process the tickets. And finally, there are the system actions that make Themes live in the directory.

    Note that the existing workflow is in black-line, and the new/proposed workflows are in red-line. The “Report Theme” button that we discussed during the meeting would fall under the “Live Theme Reported” box in the upper right corner:

    Current and proposed workflows for Theme submission, review, approval, update, and reporting

    Current and proposed workflows for Theme submission, review, approval, update, and reporting

    So, please review and discuss. Do the proposed workflows make sense? Are there ways that we can improve them? While we welcome feedback on our existing workflows (in particular: does the diagram accurately reflect our current workflows), at this point, we are primarily looking for feedback on the proposed workflows for the new functionality: the Theme reporting functionality, and the auto-approval of updates to live Themes.


    • Konstantin Obenland 2:59 pm on September 17, 2015 Permalink | Log in to Reply

      In case it’s a live theme update, would commenting on the most recent ticket work as well, like we currently do with theme updates that have open tickets? Creating new tickets only to immediately close them again feels odd.

      • Chip Bennett 3:10 pm on September 17, 2015 Permalink | Log in to Reply

        If it’s a live Theme update, there won’t be any open tickets, generally speaking. I’m fine with opening/closing tickets. It creates an audit trail for activity for that Theme. It’s little different from what we do now: ticket is opened, reviewer does a quick diff-review, then closes the ticket as “approved”.

      • Michael Beil 10:36 pm on September 21, 2015 Permalink | Log in to Reply

        That could be a good way to go with theme updates.

    • kevinhaig 3:41 pm on September 17, 2015 Permalink | Log in to Reply

      Great Job Chip! Brings back memories :)

      I thought that at some point down the road TRT was planning to allow new theme uploads to go live as well. Perhaps this could be accounted for in the workflow and coding now, with a switch to turn it on in the future?

      • Chip Bennett 5:42 pm on September 17, 2015 Permalink | Log in to Reply

        I like the idea, Kevin. However, for now, we’re merely testing/experimenting with the auto-approval, so I don’t think we want to build it in to the workflow yet for New Themes. Perhaps Otto can chime in here, but I’m guessing that, after he rebuilds the workflow, if we later decide to use auto-approval for New Themes, it should be easy enough to add a flag/switch to allow it at that time.

      • Tammie 7:05 pm on September 17, 2015 Permalink | Log in to Reply

        The new side is something we have talked about, but this is going to be our experiment potentially leading to more. There’s a lot more to think about for new themes, that’s why we’re having to take things bit by bit.

      • kevinhaig 2:39 am on September 18, 2015 Permalink | Log in to Reply

        Yeah I hear you, as long as Otto knows it is a possibility down the road.

    • kevinhaig 5:19 am on September 19, 2015 Permalink | Log in to Reply

      One last thought, will all themes have a report button, or just the ones updated and set live with no review?

      • Chip Bennett 8:49 pm on September 21, 2015 Permalink | Log in to Reply

        That’s a detail for the next step of the definition process; but my understanding is that all Themes in the directory will have a “Report” button.

  • Tammie 7:11 pm on September 15, 2015 Permalink |  

    Theme review team weekly meeting notes

    The logs are here:

    We talked about:
    It was decided we need to create a diagram for this illustrating every step. @Chipbennett will kick this off with me and then we’re going to bring it into a post here.

    We then moved onto:
    This is trickier. This will involve a core ticket also:
    This is something we should have as a subject during the summit perhaps. It needs to look at getting the team behind language packs involved if they are willing. @greenshady is going to follow up.

    There is going to be a new version of theme check coming up soon. If you would like to see anything added please bring it up here:

compose new post
next post/next comment
previous post/previous comment
show/hide comments
go to top
go to login
show/hide help
shift + esc