WordPress.org

Theme Review Team

Recent Updates Page 3 Toggle Comment Threads | Keyboard Shortcuts

  • Jose Castaneda 10:00 am on April 25, 2016 Permalink |  

    Review videos 

    We all learn in different ways. Learning to do a proper theme review can go a long way – not only for you but for others as well. I know this was the case when I first began reviewing themes. I learned a lot by reading previous theme reviews and whatever documentation was available. Often it was the codex but now we have our handbook.

    Over the last two years we began a small project. The doing_it_wrong themeΒ in order to help out some new reviewers and perhaps in a workshop. We put out a call for things and some of you answered with great things to include in our theme. We made some changes and progress along the way and yes, we are always looking for more things to include. This can be something as a random action that isn’t hooked properly.

    I will throw this out there as well, if you haven’t already, give your input on our most recent poll. This will give not only me but us more information as to how we can truly improve our resources for current and future theme reviewers. The reason I bring this up is because to many of us are seeing a lot of common things being missed. This wouldn’t be the first time it has been mentioned. We are always happy to learn more and share that with you all.

    The last couple of weeks I have been trying to record some helpful videos in hopes that many of you will learn a little more about conducting a theme review. We urge you all to please take your time and do the best you can with one full review at a time. Yes, I know it is not an easy thing to do but the key here is making sure that the communication between author and reviewers is not lost. Keep all conversation in ticket and making sure you communicate as much as possible. This does mean even posting some thing like, “Hey, sorry got a little busy but was able to look over the includes folder. I will try to get to it once I get home.”

    The list can be found here.

     
    • Maria Antonietta Perna 12:39 pm on April 25, 2016 Permalink | Log in to Reply

      Looking forward to the videos, it’s a fantastic idea. Thank you!

    • @mercime 4:29 pm on April 26, 2016 Permalink | Log in to Reply

      @jcastaneda Thanks for taking the time to make videos of your theme review process! +1 for Brackets πŸ™‚

      re: many of us are seeing a lot of common things being missed

      I would recommend a one-page “Quick Start” or “Theme Review Cheat Sheet” with links to the different pages within the handbook/blog posts here as a guide for first-time reviewers and even theme developers. It would be similar to the old Codex pages which helped me get through my first theme review years ago and where I learned a lot during the process. Otherwise, new reviewers would have to go through each page of the theme review handbookand all the blog posts here – quite time-consuming tasks already – in order to conduct a full and thorough review. Just my two cents πŸ™‚

      • Jose Castaneda 8:31 pm on April 26, 2016 Permalink | Log in to Reply

        I like that idea of a “cheat sheet.”

        the old Codex pages which helped me get through my first theme review years ago and where I learned a lot during the process

        I know that feeling as well! I still remember looking up a lot of the things on the Codex. Oh, memories!

    • ThinkUpThemes 8:17 pm on April 26, 2016 Permalink | Log in to Reply

      Hello Jose,

      I am a big fan of videos but must admit the one major downside is the time it takes to record a video and update it. Do you have a list of videos your planning to record? If not I can put together a list and send over my thoughts.

      What I find particularly useful are instructions with screenshot images. These are usually so much faster to produce than videos and easier to update. What are your thoughts on mixing and matching between videos and articles with images?

      • Jose Castaneda 8:27 pm on April 26, 2016 Permalink | Log in to Reply

        Don’t have a list yet. I did mention it in Slack as well because it was brought up.

        I do agree it can take time to update but they are more about the process of reviewing a theme and not about the requirements themselves as they can change over time. πŸ™‚

    • ThinkUpThemes 12:16 pm on April 28, 2016 Permalink | Log in to Reply

      That makes sense. It would a nightmare to redo videos on requirements, given that requirements can change. But the actual process remains the change. A constant in the ever changing world of theme reviews. πŸ™‚

      Are you imagining that there would a different video for setting up the review environment. For instance, setting up in a live site, local with wamp, etc… I notice you’ve done a video on VVV. Is there a video you’re keen on getting done? Maybe I could have a go at recording it. If it’s an area I’m comfortable with I’ll be happy to give it a go.

  • Jose Castaneda 9:21 pm on April 24, 2016 Permalink |  

    Agenda for 2016 April 26 

    The Theme Review Team holds a meeting weekly and we encourage all members to attend.

    Channel: #themereview | Time: Tuesday at 18:00 UTC 18:00 UTC

    Topic :Β Open Discussion

    The meetings typically last 30 minutes. If time permits, additional topics may be discussed.

    If you have any topics, then please reply to this post and include the topic, along with a brief description of what you would like to discuss.

     
    • Justin Tadlock 12:07 am on April 26, 2016 Permalink | Log in to Reply

      Two items related to theme tags:

      1) The new theme tags were proposed prior to the custom logo feature that was added to WP 4.5. We should consider the custom-logo tag for parity with the custom-background and custom-header tag.

      2) Maybe we should spend a minute or two on having an ongoing process for adding and removing tags in the future. We really have no formal process. I fear that we’ll eventually be doing a huge overhaul in another 5+ years as times change.

      • Ulrich 8:27 am on April 26, 2016 Permalink | Log in to Reply

        Two very good points. An idea would be to relook at the tags once a year or even at the start of every release.

        What about a tag for the favicon feature?

        • Chip Bennett 11:23 am on April 26, 2016 Permalink | Log in to Reply

          Well, Favicons are a core/functionality/site identify feature, not a Theme feature. Themes need only properly support `wp_title` – which they’ve long been required to do – in order to support core Favicons.

        • Justin Tadlock 5:58 pm on April 26, 2016 Permalink | Log in to Reply

          I like the idea of a yearly review.

    • Ulrich 8:28 am on April 26, 2016 Permalink | Log in to Reply

      If I can make it to the meeting I would like to give a quick update on the theme check status.

  • Jose Castaneda 9:16 pm on April 24, 2016 Permalink |  

    Recognizing contributors 

    The only person who is educated is the one who has learned how to learn and change. Carl Rogers

    This week we had a lot of people reviewing multiple themes. I wanted to take the time to thank those that reviewed one or more themes this past week. Please, do give the following people a huge thanks for contributing their time to learn and share their WordPress knowledge one theme at a time!

    @AbdulWahab610, @Alobaidi, @Blair-jersyer, @Dejan-Batanjac, @Kenshino, @KostasNi, @Litonice13, @ThemeZee, @WEN-Solutions, @WPDevHQ, @acmethemes, @akhlesh-nagar, @andrescifuentesr, @andtrev, @benlumia007, @burhandodhy, @catchthemes, @codeger, @cristiano.zanca, @cstan, @davide_entratici, @dinhtungdu, @ecommercethemes, @electricwp, @fashblogger, @galaxytheme, @hardeepasrani, @holger1411, @imon-Hasan, @imranaliweb, @ishulev, @jcplus, @jessiesincosa, @juhise, @k_mehdei, @kafleg, @lyrathemes, @mebishalnapit, @mercime, @mh212, @mikeselander, @monikarao, @nicola.bavaro, @oBBo, @octavianus, @oleksandr87, @priyanshu.mittal, @psdtohtmlguru, @ptasker, @rabmalin, @ranjanrakesh, @rinkuyadav999, @rmdiaconu, @robciucioan, @robertacausin, @rodicaelena, @rubel_miah, @sebd86, @smartcat, @softer, @stevekamn, @sunielk, @sushil-adhikari, @suvanno, @tadaimushi, @thelukemcdonald, @tskk

     
  • Chip Bennett 5:56 pm on April 21, 2016 Permalink |  

    Theme Reviewer Poll: Code Review 

    Reviewers, please take a minute to complete the following poll:

    Please add any comments or questions, after you respond to the poll.

     
    • Ulrich 6:53 pm on April 21, 2016 Permalink | Log in to Reply

      I normally I review that code and then install the theme to do a visual review. The reason for not running the Theme Check is that it is run when the theme is uploaded. A nice additional would to post the results from the theme check in the ticket so that the reviewer would not need to run the theme check and see the info and warnings straight away.

    • WPDevHQ 8:07 pm on April 21, 2016 Permalink | Log in to Reply

      My review process is to..
      1) Check that the licence details check out – theme and all resources.
      2) Check code thoroughly to make sure there are no dodgy bits and its up to par with requirements
      3) Install and run theme check – just incase I missed something πŸ™‚
      4) Verify presentation does not break design – not a requirement but used to point things that can improve end user experience.

    • ashiquzzaman 6:20 pm on April 22, 2016 Permalink | Log in to Reply

      You’re gonna have “Last. I review the code after I install the Theme/run Theme Check” getting most of the votes that’s what most people ( especially the new reviewers like me would do). Manually checking code at first meaning you’re wasting time finding certain type of errors theme check would find in a second. I do theme check scan and then “Theme Mentor” plugin scan and then start manually checking files.

    • Nilambar Sharma 4:33 am on April 25, 2016 Permalink | Log in to Reply

      I use Theme Check at first. There are several decisions in meeting which takes time to be reflected in TC. In some cases, TC mentions it as INFO/RECOMMENDED but which meeting already decide as REQUIRED. Some examples, `title-tag` support is actually required but TC says it is RECOMMENDED.

  • Justin Tadlock 6:52 pm on April 19, 2016 Permalink |  

    19th April Team Meeting 

    Overall, we had a pretty good discussion in the meeting today. Read the meeting transcript in the Slack archives. (A Slack account is required)

    Thanks to everyone who participated.

    Admin notices

    The primary focus of the meeting was on admin notices, particularly whether themes could display a delayed notice to users to ask for a review. The result of this discussion is that this is currently OK if the code follows all existing guidelines (e.g., correct capability check, make sure the notice can be dismissed, and anything else that would fall under the requirements).

    The biggest takeaway from the discussion is, perhaps, that we should all continue to focus on making a great user experience. Whenever you add something to a theme, it should be for the user’s benefit. Keep that in mind when creating themes.

    Following up on reopened tickets

    Both the original reviewer and the admin who reopens a ticket should follow through with the items that an admin notes. The admin queue can quickly get backed up when we’re not doing this.

    Additionally, admins who reopen a ticket should make sure to set tickets back to the “reviewing” state. Do this by entering the original reviewers username as the reviewer after reopening.

    Duplicate readme.txt and readme.md files

    There was an issue brought forth over whether these two files are both needed when they have the exact same content. This didn’t seem to be of much concern to the team and is probably not something we should focus on.

     
c
compose new post
j
next post/next comment
k
previous post/previous comment
r
reply
e
edit
o
show/hide comments
t
go to top
l
go to login
h
show/hide help
shift + esc
cancel
Skip to toolbar