Automation Meeting November 10

The last meeting was on October 27, we discussed the following items.

  • A number of sniffs were merged in: Check that the <title> tag is not used, that favicons are not used, add a warning if people are using include, restrict a list of plugin territory functions and add escaping and sanitization warnings, disallow the use of the backtick operator (shell commands).
  • I have made further progress with the pull request to modularise the restricted functions upstream in WPCS. There was a travis test issue which has been fixed in the mean time.
  • @jrf has been helping reviewing the open pull requests to get the ready to be merged and getting utility functions merged upstream so that it will make live easier for us.
  • @miyauchi has started to develop A WP-CLI theme test system. This should allow theme developers to have a way to test their theme automatically with something like travis. https://github.com/miya0001/wp-cli-scaffold-theme-tests
  • @frankklein has the scaffolding to parse the theme, and run some checks, and print a report. The big item he is working on now if modifying the parser logic to focus on the functions used inside custom functions and methods. He is using the same code as the one that creates the data on https://developer.wordpress.org/reference/

Channel: #themereview | Time: Thursday at 14:00 UTC 14:00 UTC

The goal of the bi-weekly meeting is keep other informed on the progress of the project and discuss any issues.

The agenda for the 10th November will be

  • Short update from the contributors what they have worked on.
  • Define goals for the next meeting.
  • Discuss any open issues and/or pull requests that need attention.

Pinging @poena, @frankklein, @pross, @jrf, @shinichin, @miyauchi

If I have missed any usernames, it’s not on purpose and do consider yourself invited to the meeting.

The next meeting is on Thursday, November 10.

Shindig Recap

Over the weekend we had our Review Shindig and livecast. If you missed the livecast the video is available below.

Stats

Statistics are for the 48 hours the event took place

  • 110 tickets were  modified
  • 48 reviewers were involved
  • 13 themes were set live
  • 28 tickets were not-approved

Many thanks to those who contributed on the weekend.

November Review Shindig

Let’s get pumped and psyched for our upcoming Review Shindig. If you are not familiar with this let’s get some background for you, yeah?

Every first weekend of the month we do a queue push where we try to review as many themes as we can. Please keep in mind that it is not just about numbers but we want to focus on quality reviews as well so don’t feel like you have to do 10 themes over the weekend.

There will be a livecast on the first day. This livecast is organized by @jcastaneda, @thinkupthemes, and @cristiano.zanca; this month’s livecast will focus around translation. The livecast is scheduled for November 5, 2016 1300UTC so set a reminder if you want to watch.

If you want to be a part of it there are somethings you may need.

We look forward to those who want to partake on this and welcome all on our #themereview channel.

The reviewer flow current and future

We all know that the reviewer flow has a number of hitches in it currently. But, what does it currently look like and how can we start to fix this? In order to answer this, I started by laying out the current flow visually. Here it is:

It’s overwhelming when you view it like that. So, what can we do about this?

Suggestions

In thinking about a future path of reviewing I thought how we could improve things now, not thinking about automation or other things that are longer term at this point. We need to fix things sooner as there are long queues and a giant work load mixed into a lengthy process isn’t good for anyone.

Here is a starting point to see what we could do:

What is being suggested?

  • We simplify the uploading process to just be a single page that also has the agreement. We can use conditional loading of content make sure for users they don’t go down a multiple page tunnel just to upload a theme.
  • Only on signing the agreement do you upload. We discussed this before and it is worth us doing.
  • New wording and content for the uploading page – iterating on work already done.
  • Review what emails are sent and their content. We currently have a lot of information gaps for themers.
  • If a reviewer has had 6 or more themes successfully reviewed and made live, they then can make themes live. This is a big change but important one as removes the key reviewers queue for those who know how to review. Key reviewers will still be observant and the ability to make live can and will be removed if standards fall. This will initially be done as a month long experiment, if it is successful then it will be made permanent.

This is just the start though lets aim for getting this all in by the end of the year and then see what else we can do.

Get involved

One person alone won’t make this happen, this is also just some ideas to help start us improving – we can do a lot more. How about we discuss this during our weekly meeting on  Tuesday at 18:00 UTC in #themereview on Slack? We can then discuss things work out who wants to help make this happen and discuss the ideas.

Automation Meeting October 27

In the last meeting on October 14 not everyone was able to attend who are contributing. Here are the belated meeting notes from the last meeting.

  • There was an issue in WPCS that was causing the travis tests to fail when we used PHPCS master branch, This has been fixed and we have merged the latest into the TRT/WPCS develop branch. All travis tests should be passing again.
  • I have made progress with the pull request to modularise the restricted functions upstream in WPCS. Hopefully it will get merged till the next meeting in two weeks.
  • I have started rebasing Kevin’s pull requests and making updates to the inline docs and making changes from the code reviews.
  • We had a few questions but no major discussions.

Channel: #themereview | Time: Thursday at 14:00 UTC 14:00 UTC

The goal of the bi-weekly meeting is keep other informed on the progress of the project and discuss any issues.

The agenda for the 27th October will be

  • Short update from the contributors what they have worked on.
  • Define goals for the next meeting.
  • Discuss any open issues and/or pull requests that need attention.

Pinging @poena, @frankklein, @pross, @jrf, @shinichin, @miyauchi

If I have missed any usernames, it’s not on purpose and do consider yourself invited to the meeting.

The next meeting is on Thursday, November 10.