Review statistics

These statistics should be taken with a pinch of salt, since the numbers does not assure statistical accuracy for the entire theme directory.

While we can follow the graph and even search live themes, that won’t tell us what the reviews contain, so this was done manually, human errors included.

Out of 531 themes that were closed as not approved between December and February, I looked closer at 100 tickets. Out of 100 tickets, 21 tickets were closed because the themes were copies of a theme that is already in the directory.

  • 14 tickets where closed because the author did not reply within 7 days.
  • 9 tickets where closed on author request.
  • 9 tickets where closed because the author already had an open ticket (the one theme rule).

The reviewer did not complete the review and the ticket had to be returned to the queue on 8 occasions (Not necessarily 8 separate themes).

The most common problems mentioned by the reviewers were:

  • Missing escaping or using the wrong functions: 23 themes
  • Text that is not translation ready: 21 themes
  • Missing prefix: 20 themes
  • Scripts or styles are not enqueued: 18 themes
  • PHPPHP PHP (recursive acronym for PHP: Hypertext Preprocessor) is a widely-used open source general-purpose scripting language that is especially suited for web development and can be embedded into HTML. http://php.net/manual/en/intro-whatis.php. notices, errors or warnings: 12 themes
  • Style tags does not correspond with theme functionality, or are deprecated: 10 themes

You can find the numbers for the not approved themes here.

 

In an attempt to compare the results of the two categories, I also looked at 100 out of 177 new themes that went live between December and February.

The reviewer did not complete the review and the ticket had to be returned to the queue on 45 occasions (Not necessarily 45 separate themes).

37 of the tickets were reopened as a second reviewer found additional problems.

One of  the more alarming results was that in 51 out of 100 tickets, the reviewer pointed out that escaping was either missing, or the wrong functions were used. 

 

The most common problems mentioned by the reviewers were:

  • Missing escaping or using the wrong functions: 51 Themes
  • Text that is not translation ready: 44 Themes
  • Missing prefix: 39 Themes
  • Missing license or copyright information for included assets: 34 Themes
  • Unused code or files: 25 Themes
  • PHP notices, errors or warnings: 20 Themes
  • Missing sanitization, or using the wrong functions: 18 Themes
  • Options in the customizerCustomizer Tool built into WordPress core that hooks into most modern themes. You can use it to preview and modify many of your site’s appearance settings. that are not working: 18 Themes

On 15 occasions, the reviewer asked the author to remove demo content.

On 12 occasions, the reviewer asked the author to remove or reduce content creation.

Compared to the themes that were not approved, only 11 themes had scripts or styles that were not enqueued.

In a couple of tickets, the reviewer asked the author to replace the following custom functionality and use WordPress functions instead:

  • Logo: 11 Themes
  • Custom CSSCSS CSS is an acronym for cascading style sheets. This is what controls the design or look and feel of a site.: 10 Themes
  • Custom excerptExcerpt An excerpt is the description of the blog post or page that will by default show on the blog archive page, in search results (SERPs), and on social media. With an SEO plugin, the excerpt may also be in that plugin’s metabox.: 8 Themes
  • Custom pagination: 6 Themes

You can find the numbers for the live themes here.

I also wrote down how long it took for the themes to go live:

Live after 13 months: 1
Live after 12 months: 1
Live after 11 months: 4
Live after 10 months: 8
Live after 9 months: 9
Live after 8 months: 17
Live after 7 months: 23
Live after 6 months: 22
Live after 5 months: 11
Live after 4 months: 3
Live after 3 months: 1

 

We will be able to repeat this in a few months, to make sure that these numbers are going down.

A revised readme

In our meeting we talked about the addition of a changelog. The consensus was including it in the readme.txt file like plugins do. To quote Otto:

If we had it in the readme.txt, we’d expose the data to coreCore Core is the set of software required to run WordPress. The Core Development Team builds WordPress. via the APIAPI An API or Application Programming Interface is a software intermediary that allows programs to interact with each other and share data in limited, clearly defined ways., same as we already do with plugins

In order to make this happen we need to determine what – from the pluginPlugin A plugin is a piece of software containing a group of functions that can be added to a WordPress website. They can extend functionality or add new features to your WordPress websites. WordPress plugins are written in the PHP programming language and integrate seamlessly with WordPress. These can be free in the WordPress.org Plugin Directory https://wordpress.org/plugins/ or can be cost-based plugin from a third-party’s readme – we can use, create a sample file and have all theme authors adopt it. @greenshady provided a sample one and @grapplerulrich even added in about a dedicated license section – which I think we can do.

Below is a revised version of Justin’s and includes Ulrich’s idea of the bundled resources section.

=== Theme Name ===
Contributors: (this should be a list of wordpress.org userid's)
Tags: left-sidebar, fixed-width, custom-background
Requires at least: 4.0
Tested up to: 4.3-alpha
Stable tag: 1.0.3
License: GPLv2 or later
License URI: http://www.gnu.org/licenses/gpl-2.0.html

Short description. No more than 150 chars.

== Description ==
Theme desc.

== Frequently Asked Questions ==

= A question that someone might have =

An answer to that question.

== Changelog ==

= 1.0 =
* Added new option

= 0.5 =
* Security bug addressed
* Changed thumbnail size

== Upgrade Notice ==

= 1.0 =
* Upgrade notices describe the reason a user should upgrade.  No more than 300 characters.

= 0.5 =

* This version fixes a security related bug.  Upgrade immediately.

== Resources ==
* magnify.jpg © 2014 Jane Doe, CC0
* supermenu.js © 2013-2015 James Today, MIT 

Chime in and discuss!

Theme Review Team Meeting Agenda for November 26, 2019

November 26th is the 4th Tuesday of the month. The Theme Review Team (TRT) has a meeting at 17:00 UTC. We encourage all members and anyone interested to attend.

We usually have a fixed agenda to discuss. However, this week we don’t have anything special to discuss with the team. So we would like to request all members to comment below if you want to discuss any theme-related topics.

We will start our meeting with the updates that happened since the last meeting and what TRT leads are doing and working on. After that, we will go through the proposed topics and the meeting will end with the open floor where we can discuss various theme-related topics.

Meetings usually last around 60 minutes. Attend and share your valuable feedback and suggestions.

Channel: #themereview  Time: Tuesday, 26th November 2019, 17:00 UTC

#meeting

#announcements, #meeting

Theme Review Team Meeting Agenda for October 15, 2019

Theme review team (TRT) conducts a meeting on the second and fourth Tuesday of the month. Along with the fixed agendas, we have open floor meeting at the end where you can ask or share anything related to themes.

We encourage all members and anyone interested to attend.

Channel: #themereview | Time: Tuesday, 15th October 2019, 17:00 UTC

Meeting Agenda

  1. Weekly Updates
  2. Handbook update regarding child themes (link to issue)
  3. Next review shindig planning
  4. Featured page issue – proposals for solving it
  5. Open floor

Meetings usually last around 60 minutes.

The discussion about the meeting agenda can be held in the comments below. You are encouraged to propose the topic for the agenda.

#meeting, #trt

Review weekend

On Saturday October 5th we will have our first review weekend in a long time. The plan is then to have a review shindig on the first Saturday of every month.

The goal of the review weekend is to get together and do as many quality reviews as possible.

We will have a short meeting to get us started at  Saturday at 10:00 UTC. Experienced reviewers will be available on Slack to answer questions through out the day.

We will then review themes from the top of the new and approved queues.

Authors with themes in the queue are also encouraged to participate with reviews and to submit their theme updates if needed.

-We would like to remind everyone that you do not need to be assigned to a ticket to do a review.
When you select a theme, remember to leave a note in the ticket to show that you are reviewing the theme.

At ca  Saturday 13.00 UTC we hope to have a live presentation or Q&A on Zoom. We will share the link to join in the Theme Review SlackSlack Slack is a Collaborative Group Chat Platform https://slack.com/. The WordPress community has its own Slack Channel at https://make.wordpress.org/chat/. channel before we start.

You can suggest topics in the comments below. Example topics may be:

  • How to review licensing
  • How to review themes with the Theme SnifferTheme Sniffer Theme Sniffer is a plugin utilizing custom sniffs for PHP_CodeSniffer that statically analyzes your theme and ensures that it adheres to WordPress coding conventions, as well as checking your code against PHP version compatibility. The plugin is available from the plugin directory and Github. Themes are not required to pass the Theme Sniffer scan without warnings or errors to be included in the theme directory. pluginPlugin A plugin is a piece of software containing a group of functions that can be added to a WordPress website. They can extend functionality or add new features to your WordPress websites. WordPress plugins are written in the PHP programming language and integrate seamlessly with WordPress. These can be free in the WordPress.org Plugin Directory https://wordpress.org/plugins/ or can be cost-based plugin from a third-party
  • How to review skip links and keyboard navigation

If you are interested in holding a presentation, or would like to lead a live chat session to introduce new theme reviewers, please let us know.

If you wish to participate and this is your first time reviewing themes, we recommend the following guides:

#reviews, #shindig