Most Common Admin Review Issues

To speed up the final admin review process, I have the short list of the items that I found to be the most common. Surprisingly they’re just the basics, but we still need them to be properly done.


Things that should be prefixed are function names, class names, global variables, action/filterFilter Filters are one of the two types of Hooks They provide a way for functions to modify data of other functions. They are the counterpart to Actions. Unlike Actions, filters are meant to work in an isolated manner, and should never have side effects such as affecting global variables and output. hooksHooks In WordPress theme and development, hooks are functions that can be applied to an action or a Filter in WordPress. Actions are functions performed when a certain event occurs in WordPress. Filters allow you to modify certain functions. Arguments used to hook both filters and actions look the same., script handles, style handles and image size names.

Additionally: To avoid double loading, don’t prefix third-party scripts and styles.

Loading Files:

Theme needs to properly load files, but also to be consistent as well.

get_template_directory(): Returns the absolute template directory path.

get_template_directory_uri(): Returns the template directory URI.

get_stylesheet_directory(): Returns the absolute stylesheet directory path.

get_stylesheet_directory_uri(): Returns the stylesheet directory URI.

Loading Scripts and Styles:

All scripts and styles should be added from functions file and hooked with wp_enqueue_*, don’t hardcode them or include directly, like in header.php, footer.php, etc.

Hardcoding Document Title:

Themes should not hardcode the title let WordPress handle it instead via add_theme_support( 'title-tag' );.



Weekly meetings: The Roadmap Etc.

Today, we had a nice 30+ minutes meeting.

The following subjects have been discussed:

  1. Report Button – (The report button would put a theme in a queue for reviewers to check. Basically, a user could report something like a fatal error, for example. Reviewers would then review the theme for issues.)
  2. AccessibilityAccessibility Accessibility (commonly shortened to a11y) refers to the design of products, devices, services, or environments for people with disabilities. The concept of accessible design ensures both “direct access” (i.e. unassisted) and “indirect access” meaning compatibility with a person’s assistive technology (for example, computer screen readers). ( Review – (Users who look for accessibility-ready themes get themes that are legitimately accessible.)
  3. Theme Checkhome_url() vs. site_url() (To add INFO notice)

Justin already added a report here.

Thank you!

Creative Commons Licenses in the Theme Directory

This applies for themes too: Crossposting Creative Commons Licenses in the Plugin Directory

Automation here we come!

As a step towards automation we are going to approve all updates at least once a week. 

If you guys have any questions, please don’t hesitate to post below!

comment_form changes in WordPress 4.4

Crossposting Changes to fields output by comment_form in WordPress 4.4