To speed up the final admin review process, I have the short list of the items that I found to be the most common. Surprisingly they’re just the basics, but we still need them to be properly done.
Things that should be prefixed are function names, class names, global variables, action/filter hooks, script handles, style handles and image size names.
Additionally: To avoid double loading, don’t prefix third-party scripts and styles.
Theme needs to properly load files, but also to be consistent as well.
get_template_directory(): Returns the absolute template directory path.
get_template_directory_uri(): Returns the template directory URI.
get_stylesheet_directory(): Returns the absolute stylesheet directory path.
get_stylesheet_directory_uri(): Returns the stylesheet directory URI.
Loading Scripts and Styles:
All scripts and styles should be added from functions file and hooked with
wp_enqueue_*, don’t hardcode them or include directly, like in header.php, footer.php, etc.
Hardcoding Document Title:
Themes should not hardcode the title let WordPress handle it instead via
add_theme_support( 'title-tag' );.
Today, we had a nice 30+ minutes meeting.
The following subjects have been discussed:
Report Button – (The report button would put a theme in a queue for reviewers to check. Basically, a user could report something like a fatal error, for example. Reviewers would then review the theme for issues.)
Accessibility Review – (Users who look for accessibility-ready themes get themes that are legitimately accessible.)
Theme Check –
site_url() (To add INFO notice)
Justin already added a report here.
As a step towards automation we are going to approve all updates at least once a week.
If you guys have any questions, please don’t hesitate to post below!