Emil Uzelac

Welcome to the Themes team!

We are a group of volunteers who review and approve themes submitted to be included in the official WordPress Theme directory.

We do license, security, and code quality reviews.

We help build and maintain default themes.

The primary focus of the team is to help theme authors transition to blockBlock Block is the abstract term used to describe units of markup that, composed together, form the content or layout of a webpage using the WordPress editor. The idea combines concepts of what in the past may have achieved with shortcodes, custom HTML, and embed discovery into a single consistent API and user experience.-based themes.

If this sounds interesting, read more about the team here. Check out our guide for new reviewers and the frequently asked questions.

Handbooks and review requirements

The team maintains the official Theme Review Requirements, the Theme Unit Test Data, and helps the documentation team with the Theme Developer Handbook.

Coding standards and plugins

We maintain the WPThemeReview Standard for PHP_CodeSniffer, the Theme Sniffer plugin and Theme Check

Code Packages

We have code packages for themes available for use on Github and Packagist

Communication

Meet us in the #themereview SlackSlack Slack is a Collaborative Group Chat Platform https://slack.com/. The WordPress community has its own Slack Channel at https://make.wordpress.org/chat/. channel.

Meetings:

Twice monthly at Tuesday @ 15:00 UTC.

#themereview

To speed up the final admin review process, I have the short list of the items that I found to be the most common. Surprisingly they’re just the basics, but we still need them to be properly done.

Prefixing:

Things that should be prefixed are function names, class names, global variables, action/filterFilter Filters are one of the two types of Hooks https://codex.wordpress.org/Plugin_API/Hooks. They provide a way for functions to modify data of other functions. They are the counterpart to Actions. Unlike Actions, filters are meant to work in an isolated manner, and should never have side effects such as affecting global variables and output. hooksHooks In WordPress theme and development, hooks are functions that can be applied to an action or a Filter in WordPress. Actions are functions performed when a certain event occurs in WordPress. Filters allow you to modify certain functions. Arguments used to hook both filters and actions look the same., script handles, style handles and image size names.

Additionally: To avoid double loading, don’t prefix third-party scripts and styles.

Loading Files:

Theme needs to properly load files, but also to be consistent as well.

get_template_directory(): Returns the absolute template directory path.

get_template_directory_uri(): Returns the template directory URI.

get_stylesheet_directory(): Returns the absolute stylesheet directory path.

get_stylesheet_directory_uri(): Returns the stylesheet directory URI.

Loading Scripts and Styles:

All scripts and styles should be added from functions file and hooked with wp_enqueue_*, don’t hardcode them or include directly, like in header.php, footer.php, etc.

Hardcoding Document Title:

Themes should not hardcode the title let WordPress handle it instead via add_theme_support( 'title-tag' );.

Resources:

http://themereview.co/prefix-all-the-things/
http://justintadlock.com/archives/2010/11/17/how-to-load-files-within-wordpress-themes
https://github.com/Automattic/_s/blob/master/functions.php#L113-L127
https://make.wordpress.org/core/2014/10/29/title-tags-in-4-1/

Today, we had a nice 30+ minutes meeting.

The following subjects have been discussed:

Report Button – (The report button would put a theme in a queue for reviewers to check. Basically, a user could report something like a fatal error, for example. Reviewers would then review the theme for issues.)
AccessibilityAccessibility Accessibility (commonly shortened to a11y) refers to the design of products, devices, services, or environments for people with disabilities. The concept of accessible design ensures both “direct access” (i.e. unassisted) and “indirect access” meaning compatibility with a person’s assistive technology (for example, computer screen readers). (https://en.wikipedia.org/wiki/Accessibility) Review – (Users who look for accessibility-ready themes get themes that are legitimately accessible.)
Theme Check – home_url() vs. site_url() (To add INFO notice)

Justin already added a report here.

Thank you!

This applies for themes too: Crossposting Creative Commons Licenses in the Plugin Directory

As a step towards automation we are going to approve all updates at least once a week.

If you guys have any questions, please don’t hesitate to post below!

Welcome to the Themes team!

Handbooks and review requirements

Coding standards and plugins

Code Packages

Communication

Author Archives: Emil Uzelac

Most Common Admin Review Issues

Prefixing:

Loading Files:

Loading Scripts and Styles:

Hardcoding Document Title:

Resources:

Weekly meetings: The Roadmap Etc.

Creative Commons Licenses in the Theme Directory

Automation here we come!

comment_form changes in WordPress 4.4