Theme tools and requirements recap

Earlier this year, representatives from the themes team and metaMeta Meta is a term that refers to the inside workings of a group. For us, this is the team that works on internal WordPress sites like WordCamp Central and Make WordPress. team had a call together with Matt and Josepha. This set a new goal and action points for improving the theme submission process.

Meeting notes February 24, 2021

Next steps on themes and reviews

Overarching goal

Increase the number of installed themes that originate from the WordPress.orgWordPress.org The community site where WordPress code is created and shared by the users. This is where you can download the source code for WordPress core, plugins and themes as well as the central location for community conversations and organization. https://wordpress.org/ theme directory.

Action points

Reduce requirements.
Improve automated tools.
Move the manual review step to after a theme is added to the theme directory.
Add user facing flags for theme quality based on the result of the automated checks.
Add a new algorithm for the theme directory that prioritizes themes based on the flags.
A local development environment with the theme directory to make it easier to contribute.
Make it easier to submit themes.

Summary of what has been achieved so far

During quarter three (Q3), the focus has been on automated tools and reducing requirements.

As of October 4, the review process still includes a manual step before a theme is added to the theme directory. Before the manual review can be moved, an automated license check must be implemented, and the security checks must be analyzed.

The requirements have been reduced to a list of 13 items. This list will be reduced further when the order of the review process is updated.

Theme Review Action has been implemented on the themes TracTrac Trac is the place where contributors create issues for bugs or feature requests much like GitHub.https://core.trac.wordpress.org/. and is used to present results from e2e and integration tests of the theme.
Theme Check pluginPlugin A plugin is a piece of software containing a group of functions that can be added to a WordPress website. They can extend functionality or add new features to your WordPress websites. WordPress plugins are written in the PHP programming language and integrate seamlessly with WordPress. These can be free in the WordPress.org Plugin Directory https://wordpress.org/plugins/ or can be cost-based plugin from a third-party (which is also used on the themes Trac) has been updated to reduce the requirements and improve error messages.
A local environment for the theme directory is available at https://github.com/WordPress/theme-directory-env
A plan for allowing themes to be submitted via SVNSVN Apache Subversion (often abbreviated SVN, after its command name svn) is a software versioning and revision control system. Software developers use Subversion to maintain current and historical versions of files such as source code, web pages, and documentation. Its goal is to be a mostly compatible successor to the widely used Concurrent Versions System (CVS). WordPress core and the wordpress.org released code are all centrally managed through SVN. https://subversion.apache.org/. has been published.
Work on the user-facing badges or flags, and the new algorithm has not started.

Further reducing requirements and improving automated tools

One goal, with reducing the requirements and improve the automated tools, is to reach the point where authors can safely add themes to the directory without manual review.

The current review process

In short:

A logged-in user submits a zip file.
Automated review.
Manual review.
The theme is added to the theme directory manually.

What we aim to change the process to

A logged-in user submits a zip file or uploads a theme via SVN.
Automated review.
The theme is added to the directory automatically.
Results of the remaining automated tests are presented as flags or badges.
Manual review after user reports, spot-checking.

The automated review at step 2 is proposed to make sure that:

The theme is secure.
The theme is GPLGPL GPL is an acronym for GNU Public License. It is the standard license WordPress uses for Open Source licensing https://wordpress.org/about/license/. The GPL is a ‘copyleft’ license https://www.gnu.org/licenses/copyleft.en.html. This means that derivative work can only be distributed under the same license terms. This is in distinction to permissive free software licenses, of which the BSD license and the MIT License are widely used examples. compatible.
The WordPress trademark is respected.
The theme does not break the theme directory or theme previewer.

Requirements

Because engagement is understandably low because of covid, I decided to list the easy, or if you prefer, low conflict and non-controversial requirements first, publish a proposal from that and then iterate.

To decide which requirements to remove, I used the list of guard rails and looked at the impact of removing the requirement on the theme directory itself and theme quality.

I used a public GitHub repository to create an overview of the requirements and to present suggestions of requirements that could be removed. There was no engagement besides those directly involved in the project.

A proposal for reduced requirements and request for feedback was published on the Themes team Make blog on July 20. The team had a zoom call with theme authors to discuss the changes.
With the result of the request for feedback, two more requirements were reduced.

@dd32 created a new SlackSlack Slack is a Collaborative Group Chat Platform https://slack.com/. The WordPress community has its own Slack Channel at https://make.wordpress.org/chat/. channel called #themereview-firehose to help the themes team representatives keep track of which requirements are preventing themes from being uploaded. This type of statistics was not available before.

Automated tools

There are two main tools:

Theme Check plugin, which does basic static code review
Theme Review Action, which creates a WordPress environment and runs tests on the installed theme including the front end

Theme Review Action uses Theme Check, and results from both tools are presented to the theme author and reviewer.

GitHubGitHub GitHub is a website that offers online implementation of git repositories that can easily be shared, copied and modified by other developers. Public repositories are free to host, private repositories require a paid subscription. GitHub introduced the concept of the ‘pull request’ where code changes done in branches by contributors can be reviewed and discussed before being merged be the repository owner. https://github.com/ was used to document what is actually checked by the automated tools, compared to what was listed on the theme requirements page on WordPress.org.
Besides the work on updating and creating new checks and tests, time was put into removing discrepancies.

@dufresnesteven created an improved table that lists the requirements in different categories. This helped us gain a better overview of the requirement as they were iterated on. We are using the table to list which tool is used to check which requirement.

Next steps

I would like to add that I expect the requirements to be reduced further if the themes team can find a way to engage more people in the conversation.

To help theme authors adjust to the new less restrictive requirements, I propose that the themes team publishes more in-depth articles to clarify the changes.

My analysis is that three more steps are needed to reach the point where authors can safely add themes to the directory without manual review:

Determine if the security checks are enough, and if not, learn what still needs to be added.
GPL license confirmation
The PHP error check in Theme Review Action must prevent theme upload, to prevent the theme previewer from breaking.

#themes-team

Results of Automated Theme Scanning: Fail WARNING: Could not find a copyright notice for the theme. A copyright notice is needed if your theme is licenced as GPL. Learn how to add a copyright notice (opens in a new window). REQUIRED: No reference to add_theme_support( "title-tag" ) was found in the theme. REQUIRED: Could not find the file index.php in the theme. REQUIRED: Could not find wp_link_pages. See: wp_link_pages <?php wp_link_pages( $args ); ?> REQUIRED: Could not find wp_head. See: wp_head <?php wp_head(); ?> REQUIRED: Could not find wp_footer. See: wp_footer <?php wp_footer(); ?> REQUIRED: Could not find wp_body_open action or function call at the very top of the body just after the opening body tag. See: wp_body_open <?php wp_body_open(); ?> REQUIRED: Could not find post_class. See: post_class <div id="post-<?php the_ID(); ?>" <?php post_class(); ?>> REQUIRED: Could not find language_attributes. See: language_attributes <html <?php language_attributes(); ?> REQUIRED: Could not find charset. There must be a charset defined in the Content-Type or the meta charset tag in the head. REQUIRED: Could not find body_class call in body tag. See: body_class <?php body_class( $class ); ?> REQUIRED: Could not find add_theme_support( 'automatic-feed-links' ). See: add_theme_support <?php add_theme_support( $feature ); ?> REQUIRED: Could not find DOCTYPE. See: https://codex.wordpress.org/HTML_to_XHTML <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd"?> RECOMMENDED: This theme doesn't seem to support the standard avatar functions. Use get_avatar or wp_list_comments to add this support. RECOMMENDED: The theme doesn't have comment pagination code in it. Use paginate_comments_links() or the_comments_navigation or the_comments_pagination or next_comments_link() and previous_comments_link() to add comment pagination. RECOMMENDED: No reference to register_block_style was found in the theme. Theme authors are encouraged to implement new block styles as a transition to block themes. RECOMMENDED: No reference to register_block_pattern was found in the theme. Theme authors are encouraged to implement custom block patterns as a transition to block themes. RECOMMENDED: No reference to add_theme_support( "wp-block-styles" ) was found in the theme. It is recommended that the theme implement this functionality. RECOMMENDED: No reference to add_theme_support( "responsive-embeds" ) was found in the theme. It is recommended that the theme implement this functionality. RECOMMENDED: No reference to add_theme_support( "html5", $args ) was found in the theme. It is strongly recommended that the theme implement this functionality. RECOMMENDED: No reference to add_theme_support( "custom-logo", $args ) was found in the theme. It is recommended that the theme implement this functionality. RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header. RECOMMENDED: No reference to add_theme_support( "custom-background", $args ) was found in the theme. If the theme uses background images or solid colors for the background, then it is recommended that the theme implement this functionality. RECOMMENDED: No reference to add_theme_support( "align-wide" ) was found in the theme. It is recommended that the theme implement this functionality. RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience. RECOMMENDED: Could not find the comment-reply script enqueued. RECOMMENDED: Could not find wp_list_comments. See: wp_list_comments <?php wp_list_comments( $args ); ?> RECOMMENDED: Could not find comments_template. See: comments_template <?php comments_template( $file, $separate_comments ); ?> RECOMMENDED: Could not find comment_form. See: comment_form <?php comment_form(); ?> RECOMMENDED This theme doesn't seem to display tags. Modify it to display tags in appropriate locations. RECOMMENDED This theme contains no sidebars/widget areas. See Widgets API RECOMMENDED The theme doesn't have post pagination code in it. Use posts_nav_link() or paginate_links() or the_posts_pagination() or the_posts_navigation() or next_posts_link() and previous_posts_link() to add post pagination. RECOMMENDED No reference to post-thumbnails was found in the theme. If the theme has a thumbnail like functionality, it should be implemented with add_theme_support( "post-thumbnails" ) in the functions.php file. RECOMMENDED No reference to the_post_thumbnail() was found in the theme. It is recommended that the theme implement this functionality instead of using custom fields for thumbnails. RECOMMENDED .wp-caption css class is recommended in your theme css. RECOMMENDED .wp-caption-text css class is recommended in your theme css. RECOMMENDED .sticky css class is recommended in your theme css. RECOMMENDED .gallery-caption css class is recommended in your theme css. RECOMMENDED .bypostauthor css class is recommended in your theme css. RECOMMENDED .alignright css class is recommended in your theme css. RECOMMENDED .alignleft css class is recommended in your theme css. RECOMMENDED .aligncenter css class is recommended in your theme css. INFO: Only one text-domain is being used in this theme. Make sure it matches the theme's slug correctly so that the theme will be compatible with WordPress.org language packs. The domain found is exs-boxed. INFO .screen-reader-text CSS class is generated by WordPress and needs to be styled with your theme CSS. See the Codex for an example implementation.

Hello, Carolina!
Thanks for sharing this!

There are tones of notes, warnings and errors with automated tools when uploading any child themeChild theme A Child Theme is a customized theme based upon a Parent Theme. It’s considered best practice to create a child theme if you want to modify the CSS of your theme. https://developer.wordpress.org/themes/advanced-topics/child-themes/..

Here is an example:

Is there any plans to manage these errors?

Many thanks!

Josepha 12:01 am on October 27, 2021
To make sure I understand, these are the requirements that are being suggested:
- The theme is secure.
- The theme is GPLGPL GPL is an acronym for GNU Public License. It is the standard license WordPress uses for Open Source licensing https://wordpress.org/about/license/. The GPL is a ‘copyleft’ license https://www.gnu.org/licenses/copyleft.en.html. This means that derivative work can only be distributed under the same license terms. This is in distinction to permissive free software licenses, of which the BSD license and the MIT License are widely used examples. compatible.
- The WordPress trademark is respected.
- The theme does not break the theme directory or theme previewer.
Those look correct to me!

Welcome to the Themes team!

Handbooks and review requirements

Coding standards and plugins

Code Packages

Communication

Theme tools and requirements recap

Overarching goal

Action points

Summary of what has been achieved so far

Further reducing requirements and improving automated tools

The current review process

What we aim to change the process to

Requirements

Automated tools

Next steps

Welcome to the Themes team!

Handbooks and review requirements

Coding standards and plugins

Code Packages

Communication

Overarching goal

Action points

Summary of what has been achieved so far

Further reducing requirements and improving automated tools

The current review process

What we aim to change the process to

Requirements

Automated tools

Next steps

Share this: