Theme Review Coding Standards Meeting on 31st of May 2018

With WordCamp Europe coming closer every day, Juliette Reinders Folmer from the WordPress Coding Standards team and I decided to have a chat about the status of the current Theme coding standards and the Theme Sniffer plugin.

The current focus is bringing the Theme coding standards up to date with the PHP_CodeSniffer (v 3.x) and WordPress Coding Standards (0.14.1) (open PR #145) and finishing up the rewrite of the Theme Sniffer plugin so that it can be used during the Contributors day on WordCamp Europe.

I’ve written about the meeting in the slack channel, you can check that out here.

A meeting will be held on Thursday 31st, 09:00 AM CET via hangouts. You can add the google calendar events to your calendar by clicking these links meeting part 1meeting part 2, the hangouts link is added in the events, but we’ll provide one during the meeting on the theme review slack channel. Be sure you are logged in with google account, so that we can use built-in hangouts functionality like chat, if needed.

The proposed agenda will be:

  • Talk through the PR to update to WPCS 0.14.1 / PHPCS 3.x & merge. #145
  • Go through all open PRs: PRs
    • some will need updating for PHPCS 3.x
    • some will need updating for WPCS
    • some will need reviewing
    • some might be mergeable (after rebase)
  • Go through all open issues: issues
    • create PRs for those where upstream activity has made it an easy fix
    • determine priority and action for the rest
  • Go through the upstream WPCS issue Add sniffs for theme checks to see:
    • what’s still relevant what with the developments in TRT-land
    • what can be fixed easily what with new sniffs having been added to WPCS + PHPCS
    • open issues in WPTRT-CS repo for what remains
  • Go through all WPCS sniffs to see which if any of the new sniffs added should also be added to TRTCS
  • Browse through upstream PHPCS sniffs to see if there are (new) sniffs we should include.

There is still a lot of work to be done, so we would very much like to welcome people to contribute to this project. Contributors can really help us a lot by testing the new Theme Sniffer plugin. Testing sniffs and contributing by writing sniffs is also very welcome. I hope all who are interested and want to contribute will be there so that we can finish this before the WCEU Contributors day.

#contributors