Agenda for 2017 February 14

The Theme Review Team holds a meeting weekly and we encourage all members to attend.

Channel: #themereview | Time: Tuesday at 18:00 UTC 18:00 UTC

Topics:

WordPress Stackoverflow Community Promotion Ads

After discussing the idea last week @smartcat has created an image that we can use:

The click through url would be: https://make.wordpress.org/themes/ and the tagline “Join the Theme Review Team”.

Prohibit overriding WordPress globals

Recently we added a new check to the new Theme Check to check for overriding WordPress globals. The check will also pick up code like the following.

global $post;
$post = get_post( '10' );
setup_postdata( $post );
// do something.
wp_reset_postdata();

Is this valid code for a theme or should it be using WP_Query instead?

For example:
// WP_Query arguments.
$args = array(
'page_id' => $id,
'no_found_rows' => true,
'update_post_meta_cache' => false,
'update_post_term_cache' => false,
);
// The Query.
$query = new WP_Query( $args );

// The Loop.
if ( $query->have_posts() ) {
while ( $query->have_posts() ) {
$query->the_post();
get_template_part( 'template-parts/page/content', 'front-page-panels' );
}
}
// Restore original Post Data.
wp_reset_postdata();

Iframes

The proposal is to only allow iframes with URLs from the whitelist. In most cases wp_oembed_get() can be used instead.

Whitelist:

  • google.com/maps
  • player.vimeo.com/video
  • fast.wistia.com/embed/iframe
  • youtube.com/embed
  • freemius.com

The whitelist can be always updated in the future to support

General Improvements

There are have been two improvements to the Theme Directory and the Theme Trac.

  1. There is a link in the Theme Directory that links to all of the tickets for the current theme.
  2. New trac tickets will have a link to https://themes.trac.wordpress.org/browser making it easier to see the code.

Priority queue

We pausing on the priority queue as there are a few issues with it. We will relook it at a later date.

  • We were undecided who should review the themes in the priority queue; assigned when clicking the review button, experienced reviewers or key reviewers.
  • We were also unsure about any negative effects this would have like allowing theme authors on the priority queue to release more themes quicker.

If you have any topics, then please reply to this post and include the topic, along with a brief description of what you would like to discuss.