Agenda for 2016 October 4

The Theme Review Team holds a meeting weekly and we encourage all members to attend.

Channel: #themereview | Time: Tuesday at 18:00 UTC 18:00 UTC

Topics:

I created an issue on Twenty Seventeen to remove the prefix for the third party scripts and standardize the script/style handles. @davidakennedy would like a official recommendation from the Theme Review Team as it is not documented. Do we document this as a recommendation or requirement? Related to this. https://github.com/grappler/wp-standard-handles/ Possible guidline “Third party library scripts and styles should not be prefix with the theme slug to prevent the assets being loaded twice. The words should be sperated using a dash (-). Assets that are dependant on additional libraries should be prefixed with that library slug e.g. “jquery-fitvids”.”
To be able to automate the checking of the text domains used in the theme the recommended solution was to create a whitelist of second text domains that would be allowed. This would allow us to check if the text domain really belongs to a framework and allow us to review which text domains get added to the whitelist. A good requirement to be added to the would be that the framework has it’s own translations. @greenshady started a list. Is the whitelist complete are there any other domains that need to added? Related to https://github.com/WPTRT/WordPress-Coding-Standards/issues/35
There are two points in the escaping sniff from WPCS need to be discussed. This needs to be discussed in multiple meetings. We need to deceide what to do with the two points. Related ticket: https://github.com/WPTRT/WordPress-Coding-Standards/pull/38
- The escaping sniffsniff A module for PHP Code Sniffer that analyzes code for a specific problem. Multiple stiffs are combined to create a PHPCS standard. The term is named because it detects code smells, similar to how a dog would "sniff" out food. from WPCSWordPress Community Support A public benefit corporation and a subsidiary of the WordPress Foundation, established in 2016. requires that all translations are escaped. If we require all themes to escape their translation it will make automation easier.
- The escaping sniff checks every variable if it is being escaped before it is echoed. This will logically create a number of false positives. The false possitives can be disabled by using an inline comment // xss ok . How do we inform the theme authors that they can use this inline comment to mark false possitives? We could add a warning when the code comment is used so to check that it is not being abused.
Feedback from the Review shindig/session on 1st/2nd October

Related Information from other teams

Please read up on the new multi-panel feature to pages through add_theme_support ( CoreCore Core is the set of software required to run WordPress. The Core Development Team builds WordPress. ticket #core-37974 )

If time permits, additional topics may be discussed.

If you have any topics, then please reply to this post and include the topic, along with a brief description of what you would like to discuss.

Edward Caissie 4:40 pm on October 1, 2016

Related to this. https://github.com/grappler/wp-standard-handles/ Possible guidline “Third party library scripts and styles should not be prefix with the theme slug to prevent the assets being loaded twice.

… for this to really gain traction you will have to have pluginPlugin A plugin is a piece of software containing a group of functions that can be added to a WordPress website. They can extend functionality or add new features to your WordPress websites. WordPress plugins are written in the PHP programming language and integrate seamlessly with WordPress. These can be free in the WordPress.org Plugin Directory https://wordpress.org/plugins/ or can be cost-based plugin from a third-party authors (and the plugin review team?!) to buy into following this sort of “standard”. It’s a great idea but it also looks like it asks for too many cooks in the kitchen.

—

The `// xss ok` (is this case sensitive; and, does it require single line comment only or can `/** css ok */` also work?) is a great idea because I’ve been looking at all of the false positives that this (or similar sniffssniff A module for PHP Code Sniffer that analyzes code for a specific problem. Multiple stiffs are combined to create a PHPCS standard. The term is named because it detects code smells, similar to how a dog would "sniff" out food.?) are generating and it really can bog down development if you tend to be OCD on the matter 😉

—

PS: The meeting time slot is not great for me so these comments are likely the only feedback on the agenda topics I’ll be able to give at the moment.
- Ulrich 11:22 pm on October 1, 2016
  
  Thank you Edward for your comments.
  
  —
  
  Getting the pluginPlugin A plugin is a piece of software containing a group of functions that can be added to a WordPress website. They can extend functionality or add new features to your WordPress websites. WordPress plugins are written in the PHP programming language and integrate seamlessly with WordPress. These can be free in the WordPress.org Plugin Directory https://wordpress.org/plugins/ or can be cost-based plugin from a third-party review team involved would be a good idea. If as a team we decide we want to push for this we can create a sniffsniff A module for PHP Code Sniffer that analyzes code for a specific problem. Multiple stiffs are combined to create a PHPCS standard. The term is named because it detects code smells, similar to how a dog would "sniff" out food. that would help with automation and also contact the plugin review team to get their feedback. Looking at the plugin guidelines there seems to be no code requirements. https://developer.wordpress.org/plugins/wordpress-org/detailed-plugin-guidelines/
  
  —
  
  Here is the documentation on the whitelisting comments. The check is case insensitive.
  https://github.com/WordPress-Coding-Standards/WordPress-Coding-Standards/wiki/Whitelisting-code-which-flags-errors
  
  —
  
  I can’t make the meeting too as it is at 3am in the morning.

Welcome to the Themes team!

Handbooks and review requirements

Coding standards and plugins

Code Packages

Communication