Title: Theme Reviewer Poll: Code Review Author: Chip Bennett Published: April 21, 2016 --- [ ](https://profiles.wordpress.org/chipbennett/) [Chip Bennett](https://profiles.wordpress.org/chipbennett/) 5:56 pm _on_ April 21, 2016   # Theme Reviewer Poll: Code Review Reviewers, please take a minute to complete the following poll: [Take Our Poll](https://polldaddy.com/p/9393432) Please add any comments or questions, after you respond to the poll. ### Share this: * [ Threads ](https://make.wordpress.org/themes/2016/04/21/theme-reviewer-poll-code-review/?share=threads) * [ Mastodon ](https://make.wordpress.org/themes/2016/04/21/theme-reviewer-poll-code-review/?share=mastodon) * [ Bluesky ](https://make.wordpress.org/themes/2016/04/21/theme-reviewer-poll-code-review/?share=bluesky) * [ Facebook ](https://make.wordpress.org/themes/2016/04/21/theme-reviewer-poll-code-review/?share=facebook) * [ X ](https://make.wordpress.org/themes/2016/04/21/theme-reviewer-poll-code-review/?share=x) * [ LinkedIn ](https://make.wordpress.org/themes/2016/04/21/theme-reviewer-poll-code-review/?share=linkedin) * [Login to Reply](https://login.wordpress.org/?redirect_to=https%3A%2F%2Fmake.wordpress.org%2Fthemes%2F2016%2F04%2F21%2Ftheme-reviewer-poll-code-review%2F%23respond&locale=en_US) 1. ![](https://secure.gravatar.com/avatar/eae9b03fdf1750ad9ecddf610003712fb406bce09006a0c4596071960057ea0e? s=32&d=mm&r=g) 2. [Ulrich](https://profiles.wordpress.org/grapplerulrich/) 6:53 pm _on_ April 21, 2016 3. I normally I review that code and then install the theme to do a visual review. The reason for not running the Theme Check is that it is run when the theme is uploaded. A nice additional would to post the results from the theme check in the ticket so that the reviewer would not need to run the theme check and see the info and warnings straight away. 4. ![](https://secure.gravatar.com/avatar/015463b5898653ffbefec90328d251831d77937353ee92bfaec2283815ebc6a3? s=32&d=mm&r=g) 5. [WPDevHQ](https://profiles.wordpress.org/wpdevhq/) 8:07 pm _on_ April 21, 2016 6. My review process is to.. 1) Check that the licence details check out – theme and all resources. 2) Check code thoroughly to make sure there are no dodgy bits and its up to par with requirements 3) Install and run theme check – just incase I missed something 🙂 4) Verify presentation does not break design – not a requirement but used to point things that can improve end user experience. 7. ![](https://secure.gravatar.com/avatar/625d8076bccadd98602e7e0099c070656d968b5d58ce30d7d58b04bdb4a73fdf? s=32&d=mm&r=g) 8. [ashiquzzaman](https://profiles.wordpress.org/ashiquzzaman/) 6:20 pm _on_ April 22, 2016 9. You’re gonna have “Last. I review the code after I install the Theme/run Theme Check” getting most of the votes that’s what most people ( especially the new reviewers like me would do). Manually checking code at first meaning you’re wasting time finding certain type of errors theme check would find in a second. I do theme check scan and then “Theme Mentor” pluginPlugin A plugin is a piece of software containing a group of functions that can be added to a WordPress website. They can extend functionality or add new features to your WordPress websites. WordPress plugins are written in the PHP programming language and integrate seamlessly with WordPress. These can be free in the WordPress.org Plugin Directory [https://wordpress.org/plugins/](https://wordpress.org/plugins/) or can be cost-based plugin from a third-party. scan and then start manually checking files. 10. ![](https://secure.gravatar.com/avatar/18976976723d48b71e04b7e6d11d65ef2e4b065cd410b27b803e0d2b823c88e3? s=32&d=mm&r=g) 11. [Nilambar Sharma](https://profiles.wordpress.org/rabmalin/) 4:33 am _on_ April 25, 2016 12. I use Theme Check at first. There are several decisions in meeting which takes time to be reflected in TC. In some cases, TC mentions it as INFO/RECOMMENDED but which meeting already decide as REQUIRED. Some examples, `title-tag` support is actually required but TC says it is RECOMMENDED. 13. * ![](https://secure.gravatar.com/avatar/eae9b03fdf1750ad9ecddf610003712fb406bce09006a0c4596071960057ea0e? s=32&d=mm&r=g) * [Ulrich](https://profiles.wordpress.org/grapplerulrich/) 12:03 pm _on_ April 25, 2016 * Thank you for mentioning that I will look to update the theme check with a pull request. You can always report these issues on GitHubGitHub GitHub is a website that offers online implementation of git repositories that can easily be shared, copied and modified by other developers. Public repositories are free to host, private repositories require a paid subscription. GitHub introduced the concept of the ‘pull request’ where code changes done in branches by contributors can be reviewed and discussed before being merged by the repository owner. [https://github.com/](https://github.com/). [https://github.com/Otto42/theme-check](https://github.com/Otto42/theme-check) ### Leave a Reply 󠀁[Cancel reply](https://make.wordpress.org/themes/2016/04/21/theme-reviewer-poll-code-review/?output_format=md#respond)󠁿 You must be [logged in](https://login.wordpress.org/?redirect_to=https%3A%2F%2Fmake.wordpress.org%2Fthemes%2F2016%2F04%2F21%2Ftheme-reviewer-poll-code-review%2F&locale=en_US) to post a comment. This site uses Akismet to reduce spam. [Learn how your comment data is processed.](https://akismet.com/privacy/) # Post navigation [← 19th April Team Meeting](https://make.wordpress.org/themes/2016/04/19/19th-march-team-meeting/) [Recognizing contributors →](https://make.wordpress.org/themes/2016/04/24/recognizing-contributors/)