Theme Reviewer Poll: Code Review

Welcome to the Themes team!

We are a group of volunteers who review and approve themes submitted to be included in the official WordPress Theme directory.

We do license, security, and code quality reviews.

We help build and maintain default themes.

The primary focus of the team is to help theme authors transition to blockBlock Block is the abstract term used to describe units of markup that, composed together, form the content or layout of a webpage using the WordPress editor. The idea combines concepts of what in the past may have achieved with shortcodes, custom HTML, and embed discovery into a single consistent API and user experience.-based themes.

If this sounds interesting, read more about the team here. Check out our guide for new reviewers and the frequently asked questions.

Handbooks and review requirements

The team maintains the official Theme Review Requirements, the Theme Unit Test Data, and helps the documentation team with the Theme Developer Handbook.

Coding standards and plugins

We maintain the WPThemeReview Standard for PHP_CodeSniffer, the Theme Sniffer plugin and Theme Check

Code Packages

We have code packages for themes available for use on Github and Packagist

Communication

Meet us in the #themereview SlackSlack Slack is a Collaborative Group Chat Platform https://slack.com/. The WordPress community has its own Slack Channel at https://make.wordpress.org/chat/. channel.

Meetings:

Twice monthly at Tuesday @ 15:00 UTC.

#themereview

Ulrich 6:53 pm on April 21, 2016

I normally I review that code and then install the theme to do a visual review. The reason for not running the Theme Check is that it is run when the theme is uploaded. A nice additional would to post the results from the theme check in the ticket so that the reviewer would not need to run the theme check and see the info and warnings straight away.
WPDevHQ 8:07 pm on April 21, 2016

My review process is to..
1) Check that the licence details check out – theme and all resources.
2) Check code thoroughly to make sure there are no dodgy bits and its up to par with requirements
3) Install and run theme check – just incase I missed something 🙂
4) Verify presentation does not break design – not a requirement but used to point things that can improve end user experience.
ashiquzzaman 6:20 pm on April 22, 2016

You’re gonna have “Last. I review the code after I install the Theme/run Theme Check” getting most of the votes that’s what most people ( especially the new reviewers like me would do). Manually checking code at first meaning you’re wasting time finding certain type of errors theme check would find in a second. I do theme check scan and then “Theme Mentor” pluginPlugin A plugin is a piece of software containing a group of functions that can be added to a WordPress website. They can extend functionality or add new features to your WordPress websites. WordPress plugins are written in the PHP programming language and integrate seamlessly with WordPress. These can be free in the WordPress.org Plugin Directory https://wordpress.org/plugins/ or can be cost-based plugin from a third-party scan and then start manually checking files.
Nilambar Sharma 4:33 am on April 25, 2016

I use Theme Check at first. There are several decisions in meeting which takes time to be reflected in TC. In some cases, TC mentions it as INFO/RECOMMENDED but which meeting already decide as REQUIRED. Some examples, `title-tag` support is actually required but TC says it is RECOMMENDED.
- Ulrich 12:03 pm on April 25, 2016
  
  Thank you for mentioning that I will look to update the theme check with a pull request. You can always report these issues on GitHubGitHub GitHub is a website that offers online implementation of git repositories that can easily be shared, copied and modified by other developers. Public repositories are free to host, private repositories require a paid subscription. GitHub introduced the concept of the ‘pull request’ where code changes done in branches by contributors can be reviewed and discussed before being merged be the repository owner. https://github.com/. https://github.com/Otto42/theme-check

Welcome to the Themes team!

Handbooks and review requirements

Coding standards and plugins

Code Packages

Communication

Share this: