Make WordPress Systems

Tagged: plugins svn Toggle Comment Threads | Keyboard Shortcuts

  • Dion Hulse 6:05 am on March 14, 2016 Permalink | | Unresolved
    • Dion Hulse marked this unresolved
      6:05 am on March 14, 2016

    Tags: plugins svn,   

    Removing the PHP 5.4 plugin directory linting

    The plugin directory has linting against PHP 5.4 for quite some time now. It used to be a feature to prevent accidental bad commits, but today it’s now regarded by many as a bug.

    We need to do one or more of the following:

    1. Upgrade the PHP linting to PHP-latest-stable (7.0)
    2. Upgrade the PHP linting to PHP 5.6 with a plan to move to PHP 7.0 (latest stable) and keep up with future releases
    3. Switch PHP linting to being a warning instead of a block
    4. Remove the linting all together

    Simply upgrading the linting to PHP 5.6 only kicks the can down the road, and still blocks people from using PHP 7 syntaxes in plugins (which is totally okay, if the plugin specifies that as a requirement).
    Removing the linting seems like a bad idea, as I believe authors should still be notified they’re committing code that may not be compatible (Unfortunately we currently don’t do php fatal error prevention checks on plugin upgrades, so I’d like to retain it to prevent an unexpected WSOD).

    So, I personally feel we should leave the linting at PHP 5.4 (which is what the majority of WordPress sites run today) and make it a warning, not a block.

    In order to warn instead of outright blocking, the linting needs to be moved from the pre-commit hook to the post-commit hook and the script exiting with a error-level code, STDERR will then be sent to the client after the commit is made.

    • Dion Hulse 6:09 am on March 14, 2016 Permalink | Log in to Reply

      I’ve posted a diff to Slack for #3 for review (posted there, as it contains not-public-items). I’ve partially tested it on a local SVN repo, but I don’t have all the same structures as the plugin directory.

      Ideally we should also remove the PHP 5.4-requirement for dotorg and meta SVN’s at the same time, or switch those to using PHP 5.6 / whatever is running web requests at the time.

    • Ipstenu (Mika Epstein) 9:53 pm on March 14, 2016 Permalink | Log in to Reply

      I know we email devs when they’ve uploaded a new version. Can this lint result be included in that email?

      I only ask because I want to be sure people get notified when they use various GUIs that are remarkably good at supressing/hiding alerts.

      • Dion Hulse 11:43 pm on March 14, 2016 Permalink | Log in to Reply

        I guess you mean the commit notifications?
        I’ve not tested any GUI tools, but do they really suppress the errors?

        It would be possible to email the lint failures to plugin devs, although it’d probably be a separate email.
        I’d also like to include a link to a FAQ or something explaining what it means for them, but I didn’t get that far.

        • Ipstenu (Mika Epstein) 6:54 pm on March 15, 2016 Permalink | Log in to Reply

          Having had to walk a few people through committing via the CLI in order to see the errors, yeah, they do :/ Or people just click ‘whatever’ and ignore… Both are issues. A separate email would be good. We can get to the FAQ. 🙂

    • Barry 4:51 pm on April 6, 2016 Permalink | Log in to Reply

      Sure 🙂 Whatever you think should be done sounds fine.

  • stankea 8:08 pm on October 29, 2012 Permalink | | Flag unresolved

      Tags: plugins svn   

      @nbachiyski asked to add a pre-commit hook to plugins.svn to check for php syntax. I have enabled it. Please let us know if anything gets broken 🙂

      • Andrew Nacin 7:22 pm on November 3, 2012 Permalink | Log in to Reply

        Eventually, someone will complain that PHP 5.4 syntax is being blocked by the 5.3 hook. This is not something we need to worry about for at least a year, but something to eventually think about.

    • Barry 4:18 pm on July 18, 2012 Permalink | | Resolved

        Tags: opengrok, plugins svn   

        Do you think we could get OpenGrok working reliably for plugins.svn.wordpress.org?

      • Matt Mullenweg 7:24 pm on July 17, 2012 Permalink | | Resolved

          Tags: network, plugins svn   

          Daniel Convissor is having trouble reaching plugins.svn.wordpress.org, here’s a traceroute:


          Is this a broader issue?

          Will give his email to @barry on Skype if any more info is needed.

          • Barry 8:04 pm on July 17, 2012 Permalink | Log in to Reply

            I emailed Daniel. There are some UDP filters upstream which is why the traceroute doesn’t work. This should not affect HTTP/HTTPS traffic. I asked him for more details about what exactly he is having trouble with.

        compose new post
        next post/next comment
        previous post/previous comment
        show/hide comments
        go to top
        go to login
        show/hide help
        shift + esc
        Skip to toolbar