Kathryn Presner has notified us that she is not receiving some emails from Themes Trac. I’ve been investigating this issue and found that the emails do get sent out, but they are sometimes broken – they are sometimes missing the ‘To’ header.
I’ve tried to find the root cause of this, but with no luck. Our trac install has plenty of custom modules, and a few local patches. One of them does modify the notification.py file, but i couldn’t locate any code that could cause this issue.
I’ve looked through the themes mailbox for automattic user, and found around ~1100 emails since 2014 that did not contain the To header (and were from themes trac), which is quite a big number as there’s not that many emails coming from themes trac.
Can somebody who has worked with customising / writing patches for wporg Trac have a look at this issue? I know @nacin did some, not sure who else.
An example comment for which the To header was missing is this one. I can find more if needed.
Example raw content of a broken email:
Return-Path: <firstname.lastname@example.org> X-Original-To: email@example.com Delivered-To: firstname.lastname@example.org Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp1.lax.automattic.com (Postfix) with ESMTP id 4D01C16C605A; Tue, 3 Jan 2017 20:25:43 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at wordpress.com X-Spam-Flag: NO X-Spam-Score: 0.072 X-Spam-Level: X-Spam-Status: No, score=0.072 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, MISSING_HEADERS=1.021, REPLYTO_WITHOUT_TO_CC=1.552, RP_MATCHES_RCVD=-0.5, SPF_PASS=-0.001] autolearn=no Authentication-Results: smtp1.lax.automattic.com (amavisd-new); dkim=pass (1024-bit key) header.d=wordpress.org; domainkeys=pass (1024-bit key) email@example.com header.d=wordpress.org Received: from smtp1.lax.automattic.com ([127.0.0.1]) by localhost (smtp1.lax.automattic.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id mji5gHMhfkVq; Tue, 3 Jan 2017 20:25:42 +0000 (UTC) Received: from mail.wordpress.org (lb2.lax.wordpress.org [188.8.131.52]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp1.lax.automattic.com (Postfix) with ESMTPS id D818016C6094 for <firstname.lastname@example.org>; Tue, 3 Jan 2017 20:25:42 +0000 (UTC) Received: from mail.wordpress.org (localhost.localdomain [127.0.0.1]) by mail.wordpress.org (Postfix) with ESMTP id BA70D214159; Tue, 3 Jan 2017 20:25:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=wordpress.org; h= mime-version:content-type:content-transfer-encoding:from:date :reply-to:subject:message-id:references:in-reply-to; s=wp1; bh=4 RMdfkSspyf94FiOiv44TS+QOpY=; b=fsqVz4XlXzJl4vkCdss1hxBmnUmhe1PDr nUq22LBvQ06Wf8P7hg410wP3lj9lAseMa408lEIapTpr/RV2MeQu9FC5JPtrXQNV qtR0j6ziwKPBAKEO4T3ELRL0p5N6DuOv0Fi2XaJjhOh/1ZP8BuNyQURQ317wu1bB G+vuLirP18= DomainKey-Signature: a=rsa-sha1; c=nofws; d=wordpress.org; h= mime-version:content-type:content-transfer-encoding:from:date :reply-to:subject:message-id:references:in-reply-to; q=dns; s= wp1; b=aAJpRBd8dOO1D4a/Gj1/kPKkmz+VU71wx8qkx2xwxg6f10x4MjKgVStOF vUJvK4AYXWnOWJypHIFOsSCdLsOhllcocSZR0kvCvjlHod8mgppfIWM8qexOh2xV EW5qlb/Y66t51MCNSzPol8AjY1XCoYsSkczkk1zd6ScTR/DT9U= MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 From: "WordPress Themes" <email@example.com> X-Trac-Version: 1.0.1 Precedence: bulk Auto-Submitted: auto-generated X-Mailer: Trac 1.0.1, by Edgewall Software X-Trac-Project: WordPress Themes Date: Tue, 03 Jan 2017 20:25:13 -0000 Reply-To: firstname.lastname@example.org X-URL: https://themes.trac.wordpress.org/ Subject: =?utf-8?b?UmU6IFtXb3JkUHJlc3MgVGhlbWVzXSAjMzQ0NzY6IFRIRU1FOiBS?= =?utf-8?b?ZWJhbGFuY2Ug4oCTIDEuMS4y?= X-Trac-Ticket-URL: https://themes.trac.wordpress.org/ticket/34476#comment:7 Message-ID: <email@example.com> References: <firstname.lastname@example.org> X-Trac-Ticket-ID: 34476 In-Reply-To: <email@example.com> IzM0NDc2OiBUSEVNRTogUmViYWxhbmNlIOKAkyAxLjEuMgotLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tKy0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQpSZXBvcnRlcjogIGF1dG9tYXR0aWMgICAg ICAgfCAgICAgICBPd25lcjogIGFjb3NtaW4KICAgIFR5cGU6ICB0aGVtZSAgICAgICAgICAgIHwg ICAgICBTdGF0dXM6ICByZXZpZXdpbmcKUHJpb3JpdHk6ICBuZXcgdGhlbWUgICAgICAgIHwgIFJl c29sdXRpb246CktleXdvcmRzOiAgdGhlbWUtcmViYWxhbmNlICB8Ci0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0rLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tCgpDb21tZW50IChieSBncmFwcGxl cnVscmljaCk6CgogQGthcm1hdG9zZWQgQ2FuIHlvdSBjaGVjayB0aGF0IGFuIHVwZGF0ZSBpcyB1 cGxvYWRlZCBub3cgdGhhdCBob2xpZGF5cyBhcmUKIG92ZXI/IFRoZXJlIGFyZSB0d28gb3RoZXIg dGhlbWVzIHRoYXQgbmVlZCB1cGRhdGVzIHRvby4KCi0tClRpY2tldCBVUkw6IDxodHRwczovL3Ro ZW1lcy50cmFjLndvcmRwcmVzcy5vcmcvdGlja2V0LzM0NDc2I2NvbW1lbnQ6Nz4KV29yZFByZXNz IFRoZW1lcyA8aHR0cHM6Ly90aGVtZXMudHJhYy53b3JkcHJlc3Mub3JnLz4KV29yZFByZXNzLm9y ZyBUaGVtZSBEaXJlY3RvcnkgUmV2aWV3cwo=