Make WordPress Systems

Recent Updates Toggle Comment Threads | Keyboard Shortcuts

  • Andrew Nacin 10:19 pm on January 22, 2015 Permalink | | Unresolved


      I have an nginx fix for a fun issue that’s breaking Jetpack integration.

      https://make.wordpress.org/support/xmlrpc.php isn’t being rewritten to /xmlrpc.php because /support/xmlrpc.php exists (it’s a bbPress file). /support/ is a physical directory that is bypassed for all subdomains, which means we end up rewriting it to index.php and thus a 404 results.

      The simple fix appears to be this:

      	# make.wordpress.org/support/xmlrpc.php needs to hit /xmlrpc.php.
      	# Without this, it targets /support/xmlrpc.php (a bbPress file)
      	# which is then denied and we end up with a 404.
      	location ~ /xmlrpc\.php(?:/|$) {
      		include conf.d/php-config;
      		rewrite ^ /xmlrpc.php break;

      This should go into conf.d/wporg-make.wordpress.org around line 60. I’m happy to commit this but I wanted review first.

      • seanosh 1:58 am on February 5, 2015 Permalink | Log in to Reply

        I’m OK with this (barring any other objections). Let me know if you need help rolling it out.

      • Andrew Nacin 5:53 am on February 5, 2015 Permalink | Log in to Reply

        I’m not positive the include conf.d/php-config.php + rewrite is correct, whether anything is missing, etc. It works and I can’t find side effects, but this is a bit out of my area of expertise.

      • Barry 7:39 pm on February 11, 2015 Permalink | Log in to Reply

        Maybe @pyhhak can take a look at this.

      • pyhhak 9:59 pm on February 11, 2015 Permalink | Log in to Reply

        You don’t need the php-config, just need to use normal rewrite (without break). Also your regex location would rewrite /whatever/xmlrpc.php to /xmlrpc.php, which is useless and more of a pain to maintain in future.

        If you only need /support/xmlrpc.php my suggestion is this:

        location = /support/xmlrpc.php {
        	rewrite ^ /xmlrpc.php;

        I sort of tested it, and it seemed to work. Can you run your tests and commit it?

    • Andrew Nacin 6:15 pm on June 19, 2014 Permalink | | Unresolved


        What can we do to improve the speed and reliability of Trac? I am seeing two issues in particular: it is terribly slow to complete a request, and web service gets restarted often due to the box maxing out memory.

        Possible ideas:

        • We could move from prefork back to threaded mpm to improve memory usage, but then mysql connections become blocking. What’s a possible solution for this?
        • Move Trac from Apache to nginx or using nginx as a frontend proxy, which would include a short-lived cache for reports and for users who aren’t logged in. Or, could we configure the existing load balancers in front of it?

        I’m most interested in nginx as a frontend proxy through the existing load balancers, as it seems like it’d be the easiest to set up and give us a decent benefit.

        • Barry 3:41 am on July 24, 2014 Permalink | Log in to Reply

          I don’t think it makes sense to utilize nginx on the LBs to do this but just install nginx on the SVN/Trac hosts and utilize uwsgi and caching.

      • Andrew Nacin 9:16 pm on June 3, 2013 Permalink | | Unresolved

          Priority: Low

          We can safely remove bbpress/public_html from web nodes, deploy scripts, etc. Everything is now in buddypress/public_html. Nothing uses it and nothing is in it except for download archive mount, which can go away. (The old releases still sit in SVN if we ever need them.)

          • Andrew Nacin 9:38 pm on June 3, 2013 Permalink | Log in to Reply

            I started this with r4723-deploy and r4724-deploy. Actually removing it from existing sandboxes and production would need a global command.

            It looks like the wporg-nfs-server role will need updates (and contains a lot of old release scripts we no longer need, as bbPress goes through the plugins directory for everything). That should be it, I gather.

          • Barry 6:28 am on December 11, 2014 Permalink | Log in to Reply

            NFS mounts removed.

        compose new post
        next post/next comment
        previous post/previous comment
        show/hide comments
        go to top
        go to login
        show/hide help
        shift + esc
        Skip to toolbar