Sergey Biryukov 1:56 pm on March 20, 2020
Tags: prio3 ( 77 )

Build SVN access for SergeyBiryukov

When WordPress is in RCRelease Candidate A beta version of software with the potential to be a final product, which is ready to release unless significant bugs emerge. stage and a new version of Akismet is released, the svn:externals property has to be updated on the build repo (core.svn.wordpress.org).

For the upcoming WordPress 5.4 release this is already handled in https://core.trac.wordpress.org/ticket/49662#comment:2, so we’re good for now 🙂

Would it be possible for me (SergeyBiryukov) to get write access to core.svn.wordpress.org so I could help with these tasks in the future?

#prio3

@dd32 12:17 am on March 21, 2020

It’s probably best that we automate this instead, make it part of the build script to always bump the externals to the latest version of akismet for trunk + latest branch.

I’d prefer to have the access for those of us removed rather than expand it (nacin, helen, dd32, ocean90, pento)
chadworthman 2:06 pm on November 2, 2021

Howdy @dd32,

We can help with this. Please confirm how you’d like to proceed and we’ll assist.

Should akismet be bumped only at a desired time in the release cycle or should it be bumped continuously as part of the regular sync? Also, what is the desired behaviour for akismet versions on old WordPress branches? Keep the old version or update to the most recent?

Thanks.
- Dion Hulse 2:53 am on November 4, 2021
  
  Thanks @chadworthman
  
  Should akismet be bumped only at a desired time in the release cycle or should it be bumped continuously as part of the regular sync?
  
  Every sync is fine, there’s no need for it to have a dedicated commit or to be noted in any way in the commit logs.
  However, If doing it as a dedicated commit on a regular cron task or as it’s own commit after a sync is simpler, that’s also fine. Basically whatever you want 🙂
  
  Currently the bumps include a CoreCore Core is the set of software required to run WordPress. The Core Development Team builds WordPress. tracTrac Trac is the place where contributors create issues for bugs or feature requests much like GitHub.https://core.trac.wordpress.org/. ticket reference, this is also not required. Simply Bump Akismet to X.Y.Z. as a commit message would be fine if done as dedicated commits.
  
  One thing to note – I believe it may need to be in two separate commits, as I think combining it into trunk+branch in the same commit might break the svn -> git sync.. I’m not 100% positive on that.
  
  Also, what is the desired behaviour for akismet versions on old WordPress branches? Keep the old version or update to the most recent?
  
  The only branches we really care about are Trunk and the latest release branch. See https://core.trac.wordpress.org/ticket/54004 for where the bumps for the 5.8 cycle have been.
  
  For simplicity, it’s best we don’t bump it on anything other than trunk+latest branch, as newer versions of Akismet are not always compatible with older versions of WordPress or meet the lower PHPPHP PHP (recursive acronym for PHP: Hypertext Preprocessor) is a widely-used open source general-purpose scripting language that is especially suited for web development and can be embedded into HTML. http://php.net/manual/en/intro-whatis.php. requirements of those branches.
  
  The latest version of Akismet can be accessed from https://api.wordpress.org/plugins/info/1.0/akismet.json – The .version field should always be the latest SVNSVN Apache Subversion (often abbreviated SVN, after its command name svn) is a software versioning and revision control system. Software developers use Subversion to maintain current and historical versions of files such as source code, web pages, and documentation. Its goal is to be a mostly compatible successor to the widely used Concurrent Versions System (CVS). WordPress core and the wordpress.org released code are all centrally managed through SVN. https://subversion.apache.org/. tag.
  
  If it helps, the latest SVN branch is always going to be the X.Y of the final line of https://api.wordpress.org/core/version-check/1.1/ or of .offers[0].version of https://api.wordpress.org/core/version-check/1.7/ or even whatever is marked as “latest” in https://api.wordpress.org/core/stable-check/1.0/.
  - Dion Hulse 3:00 am on November 4, 2021
    I’d also be happy to setup a dedicated APIAPI An API or Application Programming Interface is a software intermediary that allows programs to interact with each other and share data in limited, clearly defined ways. endpoint for this if preferred that can update dynamically when a new Akismet release is made?
    
    For example, something like…
    
    $ curl -s https://api.wordpress.org/core/svn-externals/?path=/trunk/.... akismet https://plugins.svn.wordpress.org/akismet/tags/4.2.1/ $ curl -s https://api.wordpress.org/core/svn-externals/?path=/branches/5.8/.... akismet https://plugins.svn.wordpress.org/akismet/tags/4.2.1/ $ curl -s https://api.wordpress.org/core/svn-externals/?path=/branches/5.7/.... HTTP/1.0 404 NOT FOUND
    
    Return the svn:external content for branches where it should be updated, nothing/404 for anywhere that shouldn’t get touched / existing content kept-as-is?
chadworthman 11:53 pm on November 4, 2021

Thanks @dd32,

I’ve leveraged the existing develop-core-svn-sync.sh script to do the svn:externals update. I will use the akismet.json version field to acquire the akismet version to use, , so I don’t think there is any need for an additional dedicated APIAPI An API or Application Programming Interface is a software intermediary that allows programs to interact with each other and share data in limited, clearly defined ways. endpoint, but thanks for the offer.

I also used your version-check/1.7 link to determine the latest SVNSVN Apache Subversion (often abbreviated SVN, after its command name svn) is a software versioning and revision control system. Software developers use Subversion to maintain current and historical versions of files such as source code, web pages, and documentation. Its goal is to be a mostly compatible successor to the widely used Concurrent Versions System (CVS). WordPress core and the wordpress.org released code are all centrally managed through SVN. https://subversion.apache.org/. branch.

I verified the most recent commit worked as expected. Please keep an eye out for the next akismet version and let me know if the script doesn’t work as expected. I’ll be keeping an eye out too. I won’t mark the request as completed until we confirm the auto-bump is working.
- Dion Hulse 12:46 am on November 5, 2021
  
  Thanks @chadworthman!
  
  Having reviewed the commit, my only minor concern is the use of syncError rather than just skipping setting the externals, if the APIAPI An API or Application Programming Interface is a software intermediary that allows programs to interact with each other and share data in limited, clearly defined ways. ever fails to return valid it’ll lock until a sysadmin clears the error lock.
  Let’s see if that actually ever happens though, as the chances of there being an API outage and a coreCore Core is the set of software required to run WordPress. The Core Development Team builds WordPress. commit syncing at the same time seems unlikely.
  
  In order to speed up the testing of this (Because I don’t want to leave this untested for too long), I added some whitespace to the existing trunk external in https://build.trac.wordpress.org/changeset/51607 so that the next trunk commit will update it.
  - Dion Hulse 3:09 am on November 5, 2021
    
    Looks good to me, It was updated in https://build.trac.wordpress.org/changeset/51608 to be the non-whitespace version.
    
    I trust that it’ll work when Akismet is updated next, so I’m going to mark this as fixed/closed.
    - chadworthman 2:24 pm on November 5, 2021
      
      Thanks for the confirmation!
Dion Hulse 3:08 am on February 1, 2022
@chadworthman Unfortunately during the 5.9 release an edge-case was discovered, and I had to manually do bump a branch.

Akismet made a release during the time between branches/5.9 being created, and the 5.9 release. This time frame is usually pretty small (1-2 weeks), but can sometimes be long (6-8 weeks).

trunk was updated, branches/5.8 would’ve been updated with the next commit (It’s what the version-check/1.7 would’ve returned), but branches/5.9 didn’t get automatically updated. branches/5.8 didn’t technically need to be updated that time around, but it might need to be in the future (ie. if a Security release was made in this timeframe).

See https://core.trac.wordpress.org/ticket/54004#comment:14

I’ve thrown together an internal APIAPI An API or Application Programming Interface is a software intermediary that allows programs to interact with each other and share data in limited, clearly defined ways. for this purpose, https://meta.trac.wordpress.org/browser/sites/trunk/api.wordpress.org/public_html/dotorg/svn/active-core-branches.php

Example:
```
$ curl -s https://api.wordpress.org/dotorg/svn/active-core-branches.php | jq -r '.[]'
trunk
branches/5.9

$ curl -s https://api.wordpress.org/dotorg/svn/active-core-branches.php | jq -r '.|join(" ")'
trunk branches/5.9
```
It would’ve returned the below output in the above edge-case:
```
$ curl -s https://api.wordpress.org/dotorg/svn/active-core-branches.php | jq -r '.[]'
trunk
branches/5.8
branches/5.9

$ curl -s https://api.wordpress.org/dotorg/svn/active-core-branches.php | jq -r '.[]'
trunk branches/5.8 branches/5.9
```
Can we update the svn:externals to use that API instead for which branches to update? I figured space separated or newline separated would be easy to iterate.
chadworthman 2:26 pm on February 1, 2022

Hi there @dd32. Thanks for the information. I’ll take a look and get back to you.
chadworthman 3:08 pm on February 3, 2022
Hi @dd32

Can we update the svn:externals to use that APIAPI An API or Application Programming Interface is a software intermediary that allows programs to interact with each other and share data in limited, clearly defined ways. instead for which branches to update?

I chose the space separated output and added a loopLoop The Loop is PHP code used by WordPress to display posts. Using The Loop, WordPress processes each post to be displayed on the current page, and formats it according to how it matches specified criteria within The Loop tags. Any HTML or PHP code in the Loop will be processed on each post. https://codex.wordpress.org/The_Loop. to update any branches returned by the new API endpoint.
```
    BRANCHES_TO_UPDATE=$( set -o pipefail && curl -s https://api.wordpress.org/dotorg/svn/active-core-branches.php | jq -r '.[]' )
    if [ $? -ne 0 ]; then
        syncError "Error retrieving branches requiring akismet bump."
    fi
    for BRANCH_X in $BRANCHES_TO_UPDATE; do
        svn propset svn:externals "akismet $PLUGINS_URL$LATEST_AKISMET_VERSION/" $CORE_CO/$BRANCH_X/wp-content/plugins
    done
```
Please let me know if you need anything else.
- Dion Hulse 3:13 am on February 4, 2022
  
  Thank you @chadworthman!
  
  (Untested on production, but testing locally indicates it works, will monitor for future Akismet releases)