Ian Dunn 10:32 pm on July 3, 2019
Tags: prio2 ( 100 )

plugins.svn is very slow

This is a known issue, but it seems like it’s gotten significantly worse in the past ~6 months, to the point where it’s disruptive to workflows, and would delay promptly recovering from bad deploys.

Here are some timings from my WordCamp.org sandbox using, using themes.svn as a baseline.

/wp-content/themes ( 10 svn:externals to themes.svn )
$ time svnup
…
real 0m0.313s

wp-content/plugins ( 27 svn:externals to plugins.svn items, 1 to meta.svn )
$ time svnup
…
real 3m29.532s

$ time deployDeploy Launching code from a local development environment to the production web server, so that it's available to visitors.-wordcamp.sh
…
real 4m44.074s

With a deploy taking almost 5 minutes, there’ll be a lot of extra/unnecessary downtime if we ever need to revert a bad commit and re-deploy.

#prio-2

#prio2

Dion Hulse 9:01 am on July 5, 2019

Thanks for bringing this up – It’s something I’ve been noticing too lately.

It’s starting to impact the scanning speed of the PluginPlugin A plugin is a piece of software containing a group of functions that can be added to a WordPress website. They can extend functionality or add new features to your WordPress websites. WordPress plugins are written in the PHP programming language and integrate seamlessly with WordPress. These can be free in the WordPress.org Plugin Directory https://wordpress.org/plugins/ or can be cost-based plugin from a third-party Directory SVNSVN Apache Subversion (often abbreviated SVN, after its command name svn) is a software versioning and revision control system. Software developers use Subversion to maintain current and historical versions of files such as source code, web pages, and documentation. Its goal is to be a mostly compatible successor to the widely used Concurrent Versions System (CVS). WordPress core and the wordpress.org released code are all centrally managed through SVN. https://subversion.apache.org/. importer too, although I don’t have any solid data there, it’s taking much longer per change now.

It’s also negatively impacting WordPress.orgWordPress.org The community site where WordPress code is created and shared by the users. This is where you can download the source code for WordPress core, plugins and themes as well as the central location for community conversations and organization. https://wordpress.org/ deploys significantly – 5m37.749s for a test deployDeploy Launching code from a local development environment to the production web server, so that it's available to visitors..
WordPress.org is a bad example due to the significant number of externals, however svn up wp-content/plugins takes 4m21.133s alone – split up into2.3s for 43 meta.svn externals and ~4m5s for the 25 plugins.svn (Timed separately, so going to vary..)

It looks like svnadmin pack might need to be run – it’s recommended to be run reguarly and doesn’t blockBlock Block is the abstract term used to describe units of markup that, composed together, form the content or layout of a webpage using the WordPress editor. The idea combines concepts of what in the past may have achieved with shortcodes, custom HTML, and embed discovery into a single consistent API and user experience. commits – assuming we upgraded to Format 7 with the SVN 1.9 upgrade.
- abbe 4:45 am on July 7, 2019
  
  Slowness comes from reading/parsing SubversionSVN Apache Subversion (often abbreviated SVN, after its command name svn) is a software versioning and revision control system. Software developers use Subversion to maintain current and historical versions of files such as source code, web pages, and documentation. Its goal is to be a mostly compatible successor to the widely used Concurrent Versions System (CVS). WordPress core and the wordpress.org released code are all centrally managed through SVN. https://subversion.apache.org/. authorization file on every request which is around ~260000 lines in size.
- abbe 5:08 am on July 7, 2019
  
  Made some configuration changes, and things should be much better now.
  
  HTH
  - Dion Hulse 12:08 am on July 8, 2019
    
    Thanks for looking into it! Muuuch faster now!
  - Jake Spurlock 10:48 pm on July 30, 2019
    
    /me wonders what you did…
    - Ian Dunn 11:59 pm on July 30, 2019
      
      https://wordpress.slack.com/archives/G02QCEMRY/p1562475911050000
      - Ian Dunn 12:00 am on July 31, 2019
        
        Oh, you may not be in that channel.
        
        DeployDeploy Launching code from a local development environment to the production web server, so that it's available to visitors. commit r8822
        wporg-svn: Enable keep-alives for reverse proxying to httpd, reuses connection to httpd, as mod_authz_svn can cache authorization db for the duration of TCP connection. See https://make.wordpress.org/systems/2019/07/03/plugins-svn-is-very-slow/#comment-1576
        
        Deploy commit r8823
        wporg-svn: While here bump MaxKeepAliveRequests from the default
Ipstenu (Mika Epstein) 6:12 pm on July 5, 2019

Would this also be why approvals of new plugins are taking longer? There’s a noticeable lag from when I press approve to when the page finishes loading.
- Dion Hulse 12:08 am on July 8, 2019
  
  That would’ve been part of the time – Creating the new folder in SVNSVN Apache Subversion (often abbreviated SVN, after its command name svn) is a software versioning and revision control system. Software developers use Subversion to maintain current and historical versions of files such as source code, web pages, and documentation. Its goal is to be a mostly compatible successor to the widely used Concurrent Versions System (CVS). WordPress core and the wordpress.org released code are all centrally managed through SVN. https://subversion.apache.org/. was taking multiple seconds rather than the previous milliseconds.
Ian Dunn 3:46 pm on July 8, 2019

Thanks! It’s almost instantaneous now 🙂
wp-content/plugins ( 27 svn:externals to plugins.svn items, 1 to meta.svn )
> $ time svnup
> …
> real 0m1.367s