Dominik Schilling 8:41 am on June 26, 2019
Tags: announcement ( 114 ), wceu ( 8 )

Proposal for handling PTE requests

At WCEU, @petya, @nao, @casiepa, and @ocean90 have discussed the future of PTEProject Translation Editor A Project Translation Editor (often referred to as PTE) is a person, who has access to validate strings on a specific project (for example BuddyPress, WooCommerce or Twenty Fourteen) for one specific locale. A project translation editor can approve strings that are added by translation contributors. Per project translation, editors are appointed by a general translation editor after a request by the project author or by the contributors themselves. requests.
The goal is to move them in a separated place (but still on this p2p2 "p2" is the name of the theme that blogs at make.wordpress.org use (and o2 is the accompanying plugin). When asked to post something "on the p2" by a member of the Polyglots team, that usually means you're asked to post on the team blog https://make.wordpress.org/polyglots/. site) and have the data of each request in a more structured format available.

Here are the notes:

Form to collect the data

Instead of the free form textarea we ask for the data via a form:

Maybe: Ask if pluginPlugin A plugin is a piece of software containing a group of functions that can be added to a WordPress website. They can extend functionality or add new features to your WordPress websites. WordPress plugins are written in the PHP programming language and integrate seamlessly with WordPress. These can be free in the WordPress.org Plugin Directory https://wordpress.org/plugins/ or can be cost-based plugin from a third-party/author or translators
Select plugin/theme slugs (autocomplete)
Select LocaleLocale Locale = language version, often a combination of a language code and a region code, for instance es_MX denotes Spanish as it’s used in Mexico. A list of all locales supported by WordPress in https://make.wordpress.org/polyglots/teams/(s)
List contributor(s) per locale
Form can be submitted by the theme/plugin author but also contributors
Request can include many projects/localesLocale Locale = language version, often a combination of a language code and a region code, for instance es_MX denotes Spanish as it’s used in Mexico. A list of all locales supported by WordPress in https://make.wordpress.org/polyglots/teams//contributors

Validate the data

Does the contributor exist? (error)
Are the locales correct? (error)
Are the plugins/themes available?
Pre-requirements
- Does the contributor have submitted at least 5? translations for the requested projects in the locale? (warning)
- Check number of requested locales, maybe CLPTECross-locale Project Translation Editor A Cross-Locale Project Translation Editor is an account owned by a plugin or theme author (or the authoring organization), which uses professional translators to localize their product. The cross-locale project translation editor can import/validate strings on a specific project for more than one locale. This role has the same capabilities as a Project Translation Editor over multiple locales instead of one. Cross-Locale Project Translation Editors need to meet a set of criteria before being appointed by General Translation Editors.? (warning)
Is the contributor already an approved PTE? => Make they automatically a PTE for the new project?

Store the data in a custom post typeCustom Post Type WordPress can hold and display many different types of content. A single item of such a content is generally called a post, although post is also a specific post type. Custom Post Types gives your site the ability to have templated posts, to simplify the concept.

Benefit: Removes the requests from the index page of the polyglots p2

Output of requests

Table to list all requests, similar to teams page
Split requests into locales
Filterable by locale, date, …
Notifications to all GTEs
Link to the project on translate.w.org with active user filterFilter Filters are one of the two types of Hooks https://codex.wordpress.org/Plugin_API/Hooks. They provide a way for functions to modify data of other functions. They are the counterpart to Actions. Unlike Actions, filters are meant to work in an isolated manner, and should never have side effects such as affecting global variables and output.
Tell the GTEGeneral Translation Editor A General Translation Editor (often referred to as GTE) is a person, who has global access to validate strings on all projects for a specific locale. whether the user is already a PTE
Approve button for GTE without visiting the wp-admin for all GTEs
Show some stats about the user
Send reminder about requests that are two weeks old, automatically approve a week after the reminder?
Post request on the team p2 or just summary/activity log
Show comments from team p2 at the global requests (depends on previous point, discussions need to be in English)
Show the “Resources for translation contributors” in the request (automated comment, see French, …)
Reject with feedback only with predefined reasons (grammar, punctuations, typos, style guide)

(Nice to have) Activity log for each new PTE (user x by user y/automatically) on date)

Open TracTrac Trac is the place where contributors create issues for bugs or feature requests much like GitHub.https://core.trac.wordpress.org/. tickets

https://meta.trac.wordpress.org/ticket/3423

Next steps

Please let us know what you think about this proposal. Do you have any suggestions or can you provide some mockups for how a list of requests or a detail page of a request can look like? What would be a good minimum viable productMinimum Viable Product "A minimum viable product (MVP) is a product with just enough features to satisfy early customers, and to provide feedback for future product development." - WikiPedia (MVPMinimum Viable Product "A minimum viable product (MVP) is a product with just enough features to satisfy early customers, and to provide feedback for future product development." - WikiPedia), what are the must haves for a first version?
Are you a developer and can help us with the implementation?

Whatever you have, please let us know in the comments. Thank you!

#announcement, #wceu

Pascal Casier 9:04 am on June 26, 2019

Some extra’s I thought of for the FORM:
1. For the form, if we can ask the first question if you are ‘contributor’ or ‘author’, then ‘List contributor(s) per localeLocale Locale = language version, often a combination of a language code and a region code, for instance es_MX denotes Spanish as it’s used in Mexico. A list of all locales supported by WordPress in https://make.wordpress.org/polyglots/teams/’ is not needed in case the answer was ‘contributor’
2. If ‘author’ on the form, only show their projects?
- Dominik Schilling 4:30 pm on June 26, 2019
  
  Good suggestions! The second point makes it easier to provide an autocomplete for the pluginPlugin A plugin is a piece of software containing a group of functions that can be added to a WordPress website. They can extend functionality or add new features to your WordPress websites. WordPress plugins are written in the PHP programming language and integrate seamlessly with WordPress. These can be free in the WordPress.org Plugin Directory https://wordpress.org/plugins/ or can be cost-based plugin from a third-party/theme names.
Pascal Casier 9:05 am on June 26, 2019

For the VALIDATION:
At least 5(?) stringsString A string is a translatable part of the software. A translation consists of a multitude of localized strings. and at least 5% of the total strings? (both need to be fulfilled?)
Not sure about the ‘5’, comments welcome 🙂
- Chris Trynkiewicz (Sukces Strony) 9:42 am on June 26, 2019
  
  5 seems not high enough in my opinion. 100 stringsString A string is a translatable part of the software. A translation consists of a multitude of localized strings. seems ok OR 100% project completion (can be completed together with other contributors) if the project’s stable branch has less than 100 strings.
- aliceorru 10:36 am on June 26, 2019
  
  I agree, 5 translated stringsString A string is a translatable part of the software. A translation consists of a multitude of localized strings. are not enough to assess the quality of the translator. I think the idea of having a % of the total strings translated would be more efficient (at least 10% of the project, imo); @eclare ‘s proposition of 100 strings or 100% completion for smaller project is also a good alternative.
- Dominik Schilling 4:32 pm on June 26, 2019
  
  The number of 5 stringsString A string is a translatable part of the software. A translation consists of a multitude of localized strings. was based on pluginPlugin A plugin is a piece of software containing a group of functions that can be added to a WordPress website. They can extend functionality or add new features to your WordPress websites. WordPress plugins are written in the PHP programming language and integrate seamlessly with WordPress. These can be free in the WordPress.org Plugin Directory https://wordpress.org/plugins/ or can be cost-based plugin from a third-party/theme headerHeader The header of your site is typically the first thing people will experience. The masthead or header art located across the top of your page is part of the look and feel of your website. It can influence a visitor’s opinion about your content and you/ your organization’s brand. It may also look different on different screen sizes. data like plugin name, description, etc.. I can also imagine a threshold based on a percent value.
Pascal Casier 9:05 am on June 26, 2019

For the CPT:
As we have a CPT, it might be handy to expose also something in an APIAPI An API or Application Programming Interface is a software intermediary that allows programs to interact with each other and share data in limited, clearly defined ways. (like https://api.endpoints.stream/polyglots/openrequests that I’ve setup as a test) so it can be used in different systems.
- Dominik Schilling 4:33 pm on June 26, 2019
  
  For the first version an APIAPI An API or Application Programming Interface is a software intermediary that allows programs to interact with each other and share data in limited, clearly defined ways. is probably a low priority item as it usually comes with more maintenance work.
Wolly aka Paolo Valenti 9:09 am on June 26, 2019

Maybe the automatic PTEs managed per localeLocale Locale = language version, often a combination of a language code and a region code, for instance es_MX denotes Spanish as it’s used in Mexico. A list of all locales supported by WordPress in https://make.wordpress.org/polyglots/teams/.

I think that it’s not enough to be a PTEProject Translation Editor A Project Translation Editor (often referred to as PTE) is a person, who has access to validate strings on a specific project (for example BuddyPress, WooCommerce or Twenty Fourteen) for one specific locale. A project translation editor can approve strings that are added by translation contributors. Per project translation, editors are appointed by a general translation editor after a request by the project author or by the contributors themselves. as sometimes a PTE is not active on his projects.
- Pascal Casier 9:38 am on June 26, 2019
  
  Hi @wolly, a first step was done in https://meta.trac.wordpress.org/ticket/2320#comment:11 where current and past Contributors were split. I agree a view on active PTEs is needed, something like ‘if stringsString A string is a translatable part of the software. A translation consists of a multitude of localized strings. waiting for approval are not validated after x time OR new strings arrived and are not being translated, consider the PTEProject Translation Editor A Project Translation Editor (often referred to as PTE) is a person, who has access to validate strings on a specific project (for example BuddyPress, WooCommerce or Twenty Fourteen) for one specific locale. A project translation editor can approve strings that are added by translation contributors. Per project translation, editors are appointed by a general translation editor after a request by the project author or by the contributors themselves. not active and send a warning’.
  I would say, let’s do the workflow for the new requests as per proposal above and then see other opportunities.
  - Wolly aka Paolo Valenti 9:44 am on June 26, 2019
    
    I think it’s an important information for GTEs.
    
    It will be much more easy to keep updated the major projects as it will be possible to add new PTEProject Translation Editor A Project Translation Editor (often referred to as PTE) is a person, who has access to validate strings on a specific project (for example BuddyPress, WooCommerce or Twenty Fourteen) for one specific locale. A project translation editor can approve strings that are added by translation contributors. Per project translation, editors are appointed by a general translation editor after a request by the project author or by the contributors themselves. to abandoned translations of plugins or themes
Pascal Casier 9:13 am on June 26, 2019

Reject with feedback:
Some ideas of standard messages, I see it as multiple-choice as multiple reasons could be valid for rejection:
1. Grammar, punctuation are not as per style guide
2. Vocabulary is not following the localesLocale Locale = language version, often a combination of a language code and a region code, for instance es_MX denotes Spanish as it’s used in Mexico. A list of all locales supported by WordPress in https://make.wordpress.org/polyglots/teams/ glossary.
3. You did not join our local slackSlack Slack is a Collaborative Group Chat Platform https://slack.com/. The WordPress community has its own Slack Channel at https://make.wordpress.org/chat/. channel as requested
- Chris Trynkiewicz (Sukces Strony) 10:08 am on June 26, 2019
  
  4. Translation is incorrect or seems automated.
  5. Translation differs too much from the original meaning.
  6. Translation is too direct / literal and therefore hard to understand.
  - Chris Trynkiewicz (Sukces Strony) 10:34 am on June 26, 2019
    
    7. Translated stringsString A string is a translatable part of the software. A translation consists of a multitude of localized strings. are too short to judge the quality of your work.
    - Petya Raykovska 6:18 am on June 27, 2019
      
      Hey hey. Could I ask for some clarification on the word “short” here? How is a stringString A string is a translatable part of the software. A translation consists of a multitude of localized strings. too short? Do you mean they have not translated enough stringsString A string is a translatable part of the software. A translation consists of a multitude of localized strings. or do you mean the strings they’ve translated are literally too short? I know we have some strings that are just a word, but I’d like to understand better what you meant here.
      - Arnaud 11:15 am on June 27, 2019
        
        I think he means that it’s hard to judge someone’s translation and language skills on the basis of short stringsString A string is a translatable part of the software. A translation consists of a multitude of localized strings. as online translation tools would do a good job at those and therefore these do not reflect whether said person is a good translator as he might screw up longer strings later on.
- Chris Trynkiewicz (Sukces Strony) 10:23 am on June 26, 2019
  
  1st point erratum: 1. Grammar, punctuation, capitalization are not as per style guide
  - Chris Trynkiewicz (Sukces Strony) 10:24 am on June 26, 2019
    
    1st point erratum: 1. Grammar, punctuation, capitalization are not as per style guide or as in the original
Chris Trynkiewicz (Sukces Strony) 9:51 am on June 26, 2019

Is the contributor already an approved PTEProject Translation Editor A Project Translation Editor (often referred to as PTE) is a person, who has access to validate strings on a specific project (for example BuddyPress, WooCommerce or Twenty Fourteen) for one specific locale. A project translation editor can approve strings that are added by translation contributors. Per project translation, editors are appointed by a general translation editor after a request by the project author or by the contributors themselves.? => Make them automatically a PTE for the new project?

I think the threshold should be 2 PTE statuses to grant next ones automatically and none of those projects can be authored by the PTE. So that we know that someone actually had 2 PTE statuses assigned and not to his/her own projects.
- Chris Trynkiewicz (Sukces Strony) 9:56 am on June 26, 2019
  
  Output: Tell the GTEGeneral Translation Editor A General Translation Editor (often referred to as GTE) is a person, who has global access to validate strings on all projects for a specific locale. whether the user is already a PTEProject Translation Editor A Project Translation Editor (often referred to as PTE) is a person, who has access to validate strings on a specific project (for example BuddyPress, WooCommerce or Twenty Fourteen) for one specific locale. A project translation editor can approve strings that are added by translation contributors. Per project translation, editors are appointed by a general translation editor after a request by the project author or by the contributors themselves.
  
  Likewise, enumerate the number of active, not self-authored PTE statuses. But if we’re doing automatic PTE assignments, this doesn’t need to exist.
Chris Trynkiewicz (Sukces Strony) 9:59 am on June 26, 2019

Send reminder about requests that are two weeks old, automatically approve a week after the reminder?

It’s not an ideal situation, but in this scenario all GTEs are inactive for 3 weeks and PTEProject Translation Editor A Project Translation Editor (often referred to as PTE) is a person, who has access to validate strings on a specific project (for example BuddyPress, WooCommerce or Twenty Fourteen) for one specific locale. A project translation editor can approve strings that are added by translation contributors. Per project translation, editors are appointed by a general translation editor after a request by the project author or by the contributors themselves. statuses need to be assigned to keep the ball rolling. Maybe have a list of automatically assigned PTEs to review them in the future by GTEs? But let’s be honest, no one will probably review them.
- Wolly aka Paolo Valenti 10:05 am on June 26, 2019
  
  IMVHO, I think that all automatism should be managed per localeLocale Locale = language version, often a combination of a language code and a region code, for instance es_MX denotes Spanish as it’s used in Mexico. A list of all locales supported by WordPress in https://make.wordpress.org/polyglots/teams/.
  
  Italian team has some steps to follow, before grant PTEs powers and it’s not sure that someone become PTEProject Translation Editor A Project Translation Editor (often referred to as PTE) is a person, who has access to validate strings on a specific project (for example BuddyPress, WooCommerce or Twenty Fourteen) for one specific locale. A project translation editor can approve strings that are added by translation contributors. Per project translation, editors are appointed by a general translation editor after a request by the project author or by the contributors themselves..
- Dominik Schilling 4:36 pm on June 26, 2019
  
  @petya suggested to have a public activity log for the assignments:
  
  (Nice to have) Activity log for each new PTEProject Translation Editor A Project Translation Editor (often referred to as PTE) is a person, who has access to validate strings on a specific project (for example BuddyPress, WooCommerce or Twenty Fourteen) for one specific locale. A project translation editor can approve strings that are added by translation contributors. Per project translation, editors are appointed by a general translation editor after a request by the project author or by the contributors themselves. (user x by user y/automatically) on date)
  
  This would allow everyone to review the latest assignments, whether by human or automatically.
Chris Trynkiewicz (Sukces Strony) 10:00 am on June 26, 2019

Post request on the team p2p2 "p2" is the name of the theme that blogs at make.wordpress.org use (and o2 is the accompanying plugin). When asked to post something "on the p2" by a member of the Polyglots team, that usually means you're asked to post on the team blog https://make.wordpress.org/polyglots/. or just summary/activity log

I disagree, this is redundant to other notifications. The whole idea is to un-spam p2s (even the team ones). Please don’t push that to p2 in any way, shape or form.
Chris Trynkiewicz (Sukces Strony) 10:22 am on June 26, 2019

Pretty obvious, but missing from the draft: email notifications:
1. GTEs & Contributor: New PTEProject Translation Editor A Project Translation Editor (often referred to as PTE) is a person, who has access to validate strings on a specific project (for example BuddyPress, WooCommerce or Twenty Fourteen) for one specific locale. A project translation editor can approve strings that are added by translation contributors. Per project translation, editors are appointed by a general translation editor after a request by the project author or by the contributors themselves. request was posted
2. Contributor: Your PTE request was accepted / declined with feedback
3. GTEs & Contributor: No response from GTEs after 2 weeks, will wait 1 more week and assign PTE automatically (if turned on for this localeLocale Locale = language version, often a combination of a language code and a region code, for instance es_MX denotes Spanish as it’s used in Mexico. A list of all locales supported by WordPress in https://make.wordpress.org/polyglots/teams/ or at all)
4. Contributor: PTE status assigned automatically due to GTEGeneral Translation Editor A General Translation Editor (often referred to as GTE) is a person, who has global access to validate strings on all projects for a specific locale. inactivity
5. Contributor: PTE status assigned automatically because certain criteria were met.
Chris Trynkiewicz (Sukces Strony) 10:32 am on June 26, 2019

Minimum Viable ProductMinimum Viable Product "A minimum viable product (MVP) is a product with just enough features to satisfy early customers, and to provide feedback for future product development." - WikiPedia:
1. Request form which allows adding multiple projects and the same PTEProject Translation Editor A Project Translation Editor (often referred to as PTE) is a person, who has access to validate strings on a specific project (for example BuddyPress, WooCommerce or Twenty Fourteen) for one specific locale. A project translation editor can approve strings that are added by translation contributors. Per project translation, editors are appointed by a general translation editor after a request by the project author or by the contributors themselves. requests for all chosen projects.
2. Form is saved in a Custom Post TypeCustom Post Type WordPress can hold and display many different types of content. A single item of such a content is generally called a post, although post is also a specific post type. Custom Post Types gives your site the ability to have templated posts, to simplify the concept..
3. Table of currently open requests with options to accept / reject with feedback.
4. Email notifications (number 1 & 2).
Chris Trynkiewicz (Sukces Strony) 10:45 am on June 26, 2019

Request: stats of GTEs:
1. How many PTEProject Translation Editor A Project Translation Editor (often referred to as PTE) is a person, who has access to validate strings on a specific project (for example BuddyPress, WooCommerce or Twenty Fourteen) for one specific locale. A project translation editor can approve strings that are added by translation contributors. Per project translation, editors are appointed by a general translation editor after a request by the project author or by the contributors themselves. requests were tackled by each GTEGeneral Translation Editor A General Translation Editor (often referred to as GTE) is a person, who has global access to validate strings on all projects for a specific locale.
2. How many stringsString A string is a translatable part of the software. A translation consists of a multitude of localized strings. for all projects combined were moderated (rejected / approved / fuzzied) by each GTE
3. How many strings were translated for all projects combined by each GTE
4. How many posts on local RosettaRosetta The code name of the theme for the local WordPress sites (eg. bg.wordpress.org is a “Rosetta” site). All locale specific WordPress sites are referred to as “Rosetta sites.” The name was inspired from the ancient Rosetta Stone, which contained more or less the same text in three different languages. sites each GTE published
5. Separate stats for all-time and last year, for all of the above
6. Nice to have for gamification: cross-localeLocale Locale = language version, often a combination of a language code and a region code, for instance es_MX denotes Spanish as it’s used in Mexico. A list of all locales supported by WordPress in https://make.wordpress.org/polyglots/teams/ GTE activity table with all of the above

This will help in filtering out inactive GTEs and maybe would allow shining some spotlight on hard working GTEs, especially by Automattic 🙂
- Dominik Schilling 4:38 pm on June 26, 2019
  
  Interesting request but this it out of scope for this proposal.
  - Petya Raykovska 6:21 am on June 27, 2019
    
    We can maybe keep this as a separate metaMeta Meta is a term that refers to the inside workings of a group. For us, this is the team that works on internal WordPress sites like WordCamp Central and Make WordPress. tracTrac Trac is the place where contributors create issues for bugs or feature requests much like GitHub.https://core.trac.wordpress.org/. ticket and look into it after we deal with the PTEProject Translation Editor A Project Translation Editor (often referred to as PTE) is a person, who has access to validate strings on a specific project (for example BuddyPress, WooCommerce or Twenty Fourteen) for one specific locale. A project translation editor can approve strings that are added by translation contributors. Per project translation, editors are appointed by a general translation editor after a request by the project author or by the contributors themselves. requests?
Arnaud 1:31 pm on June 26, 2019

I think this is an awesome idea. I’d be glad to contribute as a developer when work is started on this project.
- Petya Raykovska 6:22 am on June 27, 2019
  
  Oh, you have no idea how happy your comment just made me 😀
  - Arnaud 11:11 am on June 27, 2019
    
    Is this where to contribute?
    https://github.com/GlotPress/GlotPress-WP/issues
    - Tor-Bjorn Fjellner 9:34 pm on June 27, 2019
      
      @arnaudbroes This will rather be development via meta.trac.wordpress.orgWordPress.org The community site where WordPress code is created and shared by the users. This is where you can download the source code for WordPress core, plugins and themes as well as the central location for community conversations and organization. https://wordpress.org/
      For instance, GlotPressGlotPress GlotPress is the translation management software that powers Translate.WordPress.org. More information is available at glotpress.org. only has one level of editor. The distinction between GTEGeneral Translation Editor A General Translation Editor (often referred to as GTE) is a person, who has global access to validate strings on all projects for a specific locale. and PTEProject Translation Editor A Project Translation Editor (often referred to as PTE) is a person, who has access to validate strings on a specific project (for example BuddyPress, WooCommerce or Twenty Fourteen) for one specific locale. A project translation editor can approve strings that are added by translation contributors. Per project translation, editors are appointed by a general translation editor after a request by the project author or by the contributors themselves. is a distinction that is maintained at wordpress.org
Angelika Reisiger 3:00 pm on June 26, 2019

I don’t know how other localesLocale Locale = language version, often a combination of a language code and a region code, for instance es_MX denotes Spanish as it’s used in Mexico. A list of all locales supported by WordPress in https://make.wordpress.org/polyglots/teams/ handle this. We (german) polyglots have global PTEs beside of “normal” PTEs and GTEs. The global PTEs also have the permission to approve/reject all Plugins and Themes.

The exceptations of permission are listed there. And global PTEs can not grant PTEProject Translation Editor A Project Translation Editor (often referred to as PTE) is a person, who has access to validate strings on a specific project (for example BuddyPress, WooCommerce or Twenty Fourteen) for one specific locale. A project translation editor can approve strings that are added by translation contributors. Per project translation, editors are appointed by a general translation editor after a request by the project author or by the contributors themselves. access.

They don’t have a special flag/label (would be great, if they would get a role global PTE or so).

However: they are also listed below every PluginPlugin A plugin is a piece of software containing a group of functions that can be added to a WordPress website. They can extend functionality or add new features to your WordPress websites. WordPress plugins are written in the PHP programming language and integrate seamlessly with WordPress. These can be free in the WordPress.org Plugin Directory https://wordpress.org/plugins/ or can be cost-based plugin from a third-party/Theme – as well as the localeLocale Locale = language version, often a combination of a language code and a region code, for instance es_MX denotes Spanish as it’s used in Mexico. A list of all locales supported by WordPress in https://make.wordpress.org/polyglots/teams/ managers are listed. In real we have 19 persons with the permission to approve/reject translated stringsString A string is a translatable part of the software. A translation consists of a multitude of localized strings..

Notifications to all GTEs

These notifications should be send to all persons listed below the plugin/theme.
- Dominik Schilling 4:40 pm on June 26, 2019
  
  Only GTEs can assign new editors so they are the primary (and only) target group for the notifications.
- Angelika Reisiger 5:02 pm on June 26, 2019
  
  Only GTEs can assign new editors so they are the primary (and only) target group for the notifications.
  
  And localeLocale Locale = language version, often a combination of a language code and a region code, for instance es_MX denotes Spanish as it’s used in Mexico. A list of all locales supported by WordPress in https://make.wordpress.org/polyglots/teams/ managers.
  
  Concerning global PTEs, yes, I mentioned this too. But before assigning new editors there are hundreds of stringsString A string is a translatable part of the software. A translation consists of a multitude of localized strings. to review and to approve or to reject.
  
  If global PTEs do also get a notification, they can review the strings and and can make a recommendation for the pte request.
Angelika Reisiger 3:10 pm on June 26, 2019

Reject with feedback only with predefined reasons (grammar, punctuations, typos, style guide)

Yes, but with batch options, please. Imagine the case you have a translation with hundreds of StringsString A string is a translatable part of the software. A translation consists of a multitude of localized strings., where always one word is spelled wrong. let’s say “adminnistrator” instead of “administrator”.
You can search for “adminnistrator” and tick all these strings and reject all together.

Reject with feedback should be a global option, in this case tick once “wrong spelling (or so)” and this will be inserted into all checked strings.

Otherwise we will have an enourmous count of more work. We can not type into every single stringString A string is a translatable part of the software. A translation consists of a multitude of localized strings. a reason, and we can not tick a reason in every single string.
- Presskopp 4:14 pm on June 26, 2019
  
  all that Angelika says!
  
  see also:
  https://github.com/GlotPress/GlotPress-WP/issues/323
  https://github.com/GlotPress/GlotPress-WP/issues/324
  https://github.com/GlotPress/GlotPress-WP/issues/804
- Dominik Schilling 4:42 pm on June 26, 2019
  
  This proposal is unrelated to translate.w.org/GlotPressGlotPress GlotPress is the translation management software that powers Translate.WordPress.org. More information is available at glotpress.org.. While named similar this is only about the rejection of a single editor request.
  - Angelika Reisiger 5:11 pm on June 26, 2019
    
    Did I understand that correctly, this thread is not about rejecting/approving stringsString A string is a translatable part of the software. A translation consists of a multitude of localized strings., but only about the PTEProject Translation Editor A Project Translation Editor (often referred to as PTE) is a person, who has access to validate strings on a specific project (for example BuddyPress, WooCommerce or Twenty Fourteen) for one specific locale. A project translation editor can approve strings that are added by translation contributors. Per project translation, editors are appointed by a general translation editor after a request by the project author or by the contributors themselves. request?
    
    Sorry, I misunderstood that. On the other hand: The processing of a PTE request is hardly possible without checking the strings.
    - Petya Raykovska 6:28 am on June 27, 2019
      
      Reject a single stringString A string is a translatable part of the software. A translation consists of a multitude of localized strings. with feedback is a separate function that will soon be available to translation editorsTranslation Editor Translation editors can approve translations for projects. The GTE (General Translation Editor) and LM (Locale Manager) roles can add new users with the "Project Translation Editor" role that can approve translations for specific projects. There are two different Translation Editor roles:
      General Translation Editor and Project Translation Editor. In this case we’re discussing PTEProject Translation Editor A Project Translation Editor (often referred to as PTE) is a person, who has access to validate strings on a specific project (for example BuddyPress, WooCommerce or Twenty Fourteen) for one specific locale. A project translation editor can approve strings that are added by translation contributors. Per project translation, editors are appointed by a general translation editor after a request by the project author or by the contributors themselves. requests and the option to approve/reject them using controls directly on the frontend. This will eliminate the need of GTEs to go to the backend of the site for user management and hopefully make the process of accepting/rejecting a lot easier.
      
      One of the ideas in the proposal is to have a direct link to the proposed user’s translated stringsString A string is a translatable part of the software. A translation consists of a multitude of localized strings. so whoever is checking them can do that with one click. For example:
      
      User X has requested to be a PTE for pluging Y for language Z: When a GTEGeneral Translation Editor A General Translation Editor (often referred to as GTE) is a person, who has global access to validate strings on all projects for a specific locale. sees the request they also see an autogenerated link to all the strings User X has already proposed. They click it and check if the strings are ok. There are controls next to the user request so based on what a GTE sees when they check the translation, they can either approve the request or reject it with feedback about the general quality of the strings the user has already proposed.
      - Arnaud 11:09 am on June 27, 2019
        
        Reject a single stringString A string is a translatable part of the software. A translation consists of a multitude of localized strings. with feedback is a separate function that will soon be available to translation editorsTranslation Editor Translation editors can approve translations for projects. The GTE (General Translation Editor) and LM (Locale Manager) roles can add new users with the "Project Translation Editor" role that can approve translations for specific projects. There are two different Translation Editor roles:
        General Translation Editor and Project Translation Editor.
        
        Eye candy!
      - Christian Sabo 7:12 am on July 3, 2019
        
        When a GTEGeneral Translation Editor A General Translation Editor (often referred to as GTE) is a person, who has global access to validate strings on all projects for a specific locale. sees the request they also see an autogenerated link to all the stringsString A string is a translatable part of the software. A translation consists of a multitude of localized strings. User X has already proposed. They click it and check if the strings are ok.
        
        Eye candy!
Tor-Bjorn Fjellner 3:14 pm on June 26, 2019

This all sounds good, but I´m a bit concerned regarding “Is the contributor already an approved PTEProject Translation Editor A Project Translation Editor (often referred to as PTE) is a person, who has access to validate strings on a specific project (for example BuddyPress, WooCommerce or Twenty Fourteen) for one specific locale. A project translation editor can approve strings that are added by translation contributors. Per project translation, editors are appointed by a general translation editor after a request by the project author or by the contributors themselves.? => Make they automatically a PTE for the new project?”

If we implement this, then making someone PTE for a single project would automatically mean that we’ve paved the way for them to promote themselves for any project.

Also, it’s probably understood between the lines, but I’d like to spell it out in clear: we should also make it much easier for a LocaleLocale Locale = language version, often a combination of a language code and a region code, for instance es_MX denotes Spanish as it’s used in Mexico. A list of all locales supported by WordPress in https://make.wordpress.org/polyglots/teams/ Manager or a GTEGeneral Translation Editor A General Translation Editor (often referred to as GTE) is a person, who has global access to validate strings on all projects for a specific locale. to approve these requests. If a contributor requests several projects, then there should be a convenient way to immediately approve all pending projects.

If a contributor submits several separate requests to the same locale, then these requests should automatically be grouped together when the GTE looks at them.

Possibility to sort/filterFilter Filters are one of the two types of Hooks https://codex.wordpress.org/Plugin_API/Hooks. They provide a way for functions to modify data of other functions. They are the counterpart to Actions. Unlike Actions, filters are meant to work in an isolated manner, and should never have side effects such as affecting global variables and output. pending requests.
Possiblity to search/filter previous history of requests.
- Dominik Schilling 4:46 pm on June 26, 2019
  
  Also, it’s probably understood between the lines, but I’d like to spell it out in clear: we should also make it much easier for a LocaleLocale Locale = language version, often a combination of a language code and a region code, for instance es_MX denotes Spanish as it’s used in Mexico. A list of all locales supported by WordPress in https://make.wordpress.org/polyglots/teams/ Manager or a GTEGeneral Translation Editor A General Translation Editor (often referred to as GTE) is a person, who has global access to validate strings on all projects for a specific locale. to approve these requests.
  
  The proposal mentions an “approve button for GTE without visiting the wp-admin” which should cover this.
Petya Raykovska 6:47 am on June 27, 2019

Thank you @ocean90 for the great writeup. I wanted to drop a quick note to say thank you to everyone participating in the discussion. There are some great ideas in the comments that we were definitely hoping for.

Features like this are complicated because of the variety of use cases and internal processes each local team has so let’s try and think how a more general, global approach that we can build relatively quickly, can then be customised to a local team’s needs.

Once again, great to see the team working towards a good solution together <3
Yui 8:29 am on June 27, 2019

Uncluttering main P2p2 "p2" is the name of the theme that blogs at make.wordpress.org use (and o2 is the accompanying plugin). When asked to post something "on the p2" by a member of the Polyglots team, that usually means you're asked to post on the team blog https://make.wordpress.org/polyglots/. will be excellent, currently its hard to find important posts like this one between countless requests.
Auto assign PTEProject Translation Editor A Project Translation Editor (often referred to as PTE) is a person, who has access to validate strings on a specific project (for example BuddyPress, WooCommerce or Twenty Fourteen) for one specific locale. A project translation editor can approve strings that are added by translation contributors. Per project translation, editors are appointed by a general translation editor after a request by the project author or by the contributors themselves. rights is worst idea, if one completes 2-3 simple plugins with just several stringsString A string is a translatable part of the software. A translation consists of a multitude of localized strings., and then gets the possibility to automatically get PTE for anything, that would be nightmare. New requests handling will be simplified, but an element of control by GTEs should be kept, so, no auto PTE, thats worse than just bad.
As for requests left unreplied, a remind notification after 2 weeks and then 2 more weeks until request autofulfillment sounds reasonable. But keep in mind that some localesLocale Locale = language version, often a combination of a language code and a region code, for instance es_MX denotes Spanish as it’s used in Mexico. A list of all locales supported by WordPress in https://make.wordpress.org/polyglots/teams/ can be added by editing initial post and no notifications are sent in this case, so request will remain unseen, autocompleting them will be not pleasant surprize.
Yui 8:39 am on June 27, 2019

PTEProject Translation Editor A Project Translation Editor (often referred to as PTE) is a person, who has access to validate strings on a specific project (for example BuddyPress, WooCommerce or Twenty Fourteen) for one specific locale. A project translation editor can approve strings that are added by translation contributors. Per project translation, editors are appointed by a general translation editor after a request by the project author or by the contributors themselves. requests are taken not only from P2p2 "p2" is the name of the theme that blogs at make.wordpress.org use (and o2 is the accompanying plugin). When asked to post something "on the p2" by a member of the Polyglots team, that usually means you're asked to post on the team blog https://make.wordpress.org/polyglots/., we accept them on slackSlack Slack is a Collaborative Group Chat Platform https://slack.com/. The WordPress community has its own Slack Channel at https://make.wordpress.org/chat/. and via forum, especially from people who are already PTE for one or several projects.
It will be nice to have possibility to easily add PTE by W.org username from pluginPlugin A plugin is a piece of software containing a group of functions that can be added to a WordPress website. They can extend functionality or add new features to your WordPress websites. WordPress plugins are written in the PHP programming language and integrate seamlessly with WordPress. These can be free in the WordPress.org Plugin Directory https://wordpress.org/plugins/ or can be cost-based plugin from a third-party translation page (without visiting /wp-admin/ backend)
i.e. from here:
https://translate.wordpress.org/locale/ru/default/wp-plugins/jetpack/
Adding buttons to existing contributors will not suffice, sometimes here are no user contribution yet for this particular project, but we still want to add him as PTE.

Activity stats are very important too. Especially for users with “extended” rights (so called global PTE), at least we want to see log of date – project name for editor activity.
- Petya Raykovska 8:56 am on June 27, 2019
  
  Buttons won’t only be added for existing contributors, they’re planned for anyone added to any PTEProject Translation Editor A Project Translation Editor (often referred to as PTE) is a person, who has access to validate strings on a specific project (for example BuddyPress, WooCommerce or Twenty Fourteen) for one specific locale. A project translation editor can approve strings that are added by translation contributors. Per project translation, editors are appointed by a general translation editor after a request by the project author or by the contributors themselves. request but they will be a part of the controls in the request itself, not on translate.wordpress.orgtranslate.wordpress.org The platform for contributing to the translation of WordPress core, themes and plugins..
  
  Adding buttons to approve PTEs from translate.wordpress.org is a functionality that’s separate from this MVPMinimum Viable Product "A minimum viable product (MVP) is a product with just enough features to satisfy early customers, and to provide feedback for future product development." - WikiPedia and needs to be added to GlotPressGlotPress GlotPress is the translation management software that powers Translate.WordPress.org. More information is available at glotpress.org., but it’s a good candidate for a separate task on the GlotPress track.
CoCoowordpress 2:45 pm on June 27, 2019

Consider adding a conditional judgment to the background:
Judge the localeLocale Locale = language version, often a combination of a language code and a region code, for instance es_MX denotes Spanish as it’s used in Mexico. A list of all locales supported by WordPress in https://make.wordpress.org/polyglots/teams/ manager’s activity.
If multiple locale managers are active.
Then tighten the rules.
Otherwise, the rules are relaxed.
So as not to dispel manager enthusiasm.
Become the world of robots…

For example:
inactive team
Does the contributor have submitted at least 5%?
automatically approve a week after the reminder?
…
active team
Does the contributor have submitted at least 20%?
automatically approve two week after the reminder?
…
super active team
Does the contributor have submitted at least 50%?
automatically approve four week after the reminder?
Naoko Takano 8:15 pm on July 9, 2019
Great to see active feedback here.
Tried summing things up so we are not losing the key points.
https://docs.google.com/spreadsheets/d/1Exbg-1dkCcNvudXB35mZq6X-zWG_2eqLlEjxXdRRi0Q/edit#gid=0

My understanding:

Form to collect the data
- We are all happy with moving to a form-based request submission
- We are on the same page in terms of what’s needed on the form
Data validation
- Pre-requirement for the amount of contribution is to be discussed
- An auto-approval feature may not be needed for the first phase
Data store
- Agreed on CPT
With the above three parts plus a simple (similar to current?) output could be an MVPMinimum Viable Product "A minimum viable product (MVP) is a product with just enough features to satisfy early customers, and to provide feedback for future product development." - WikiPedia, I think. We can use the new form for a while & refine it before moving to the next phase of more effective data output & notification.
Tomas 6:33 am on July 12, 2019

I have one more suggestion for data validation.
First of all, it should be checked if the project is translation ready.
If it’s not, then point the the pluginPlugin A plugin is a piece of software containing a group of functions that can be added to a WordPress website. They can extend functionality or add new features to your WordPress websites. WordPress plugins are written in the PHP programming language and integrate seamlessly with WordPress. These can be free in the WordPress.org Plugin Directory https://wordpress.org/plugins/ or can be cost-based plugin from a third-party author to the Plugin Handbook.
Lidia Pellizzaro 3:40 pm on July 16, 2019

Hi all. I’m very grateful to you all for bringing back this idea of handling PTEProject Translation Editor A Project Translation Editor (often referred to as PTE) is a person, who has access to validate strings on a specific project (for example BuddyPress, WooCommerce or Twenty Fourteen) for one specific locale. A project translation editor can approve strings that are added by translation contributors. Per project translation, editors are appointed by a general translation editor after a request by the project author or by the contributors themselves. request.

Some little thoughts, I don’t know if useful or not.

Form
Can be useful to ask immediately in the form (pre-requirements) if the person candidated to be PTE is a native or at least a very good speaker for the language selected?

Auto PTE assignment
I agree with no immediate auto assign for who is already a PTE.

And notification at 2 weeks + automatic approve after another 2 weeks seems good, but if there’s many mentoring going on or if there’s many simultaneously requests can some requests be delayed?
For example in the initial period what amount of requests we think can will arrive simultaneously?

Minimum number of stringsString A string is a translatable part of the software. A translation consists of a multitude of localized strings. to submit from candidate PTE
I think a number is better than a %: in my experience during my last mentoring with no translations already done, I ask not more than 30-strings blockBlock Block is the abstract term used to describe units of markup that, composed together, form the content or layout of a webpage using the WordPress editor. The idea combines concepts of what in the past may have achieved with shortcodes, custom HTML, and embed discovery into a single consistent API and user experience. of strings. So with the first tranche I can give a first feedback and the translator can learn without to have to correct a huge number of stringString A string is a translatable part of the software. A translation consists of a multitude of localized strings. already translated with the same error.
Then I ask a second tranche of 30 strings, I check the new tranche and I think if the translator is ready or not to become PTE. If not I continue with feedback and asking another block of strings.

I know that this example is a case of mentoring and I don’t know if 30 is a good number or not, but I think that minimum number of strings to submit hasn’t to be too much high, because in this way neither the translator nor the editor lost too much time to re-translate or re-check translations already done. And translators are less frustrated in case of have to correct the same issue in many strings already translated.
floorecurring 9:07 am on July 23, 2019

Hi there!

My native language is Dutch, so I would like to be able to accept Dutch (NL) translations for the following pluginPlugin A plugin is a piece of software containing a group of functions that can be added to a WordPress website. They can extend functionality or add new features to your WordPress websites. WordPress plugins are written in the PHP programming language and integrate seamlessly with WordPress. These can be free in the WordPress.org Plugin Directory https://wordpress.org/plugins/ or can be cost-based plugin from a third-party:
https://wordpress.org/plugins/woo-ecurring/

username: floorecurring

Let me know if more info is required, thanks!
- arnaudbroes 9:08 am on July 23, 2019
  
  You need to request PTEProject Translation Editor A Project Translation Editor (often referred to as PTE) is a person, who has access to validate strings on a specific project (for example BuddyPress, WooCommerce or Twenty Fourteen) for one specific locale. A project translation editor can approve strings that are added by translation contributors. Per project translation, editors are appointed by a general translation editor after a request by the project author or by the contributors themselves. access here – https://make.wordpress.org/polyglots/
Naoko Takano 3:00 pm on June 2, 2020

I made some visual aids to summarize the discussion, and move forward with more feedback.

Flowchart (with phases)

Edit (June 9): I swapped the below image with a revised version from what I posted before.

Screen with a “Request a review” button

Translation Request Form

PTEProject Translation Editor A Project Translation Editor (often referred to as PTE) is a person, who has access to validate strings on a specific project (for example BuddyPress, WooCommerce or Twenty Fourteen) for one specific locale. A project translation editor can approve strings that are added by translation contributors. Per project translation, editors are appointed by a general translation editor after a request by the project author or by the contributors themselves. assignment button

(added on June 9th)

You can leave a comment below as well, or create a copy to edit the flowchart.
https://docs.google.com/drawings/d/10RUZqsASL_8kPo6B9oUjQA7OSvIqVBfmy81DKpxoT7k/edit
- Felipe Elia 10:25 pm on June 18, 2020
  
  This is amazing, @nao, thank you very much for this.
  
  My considerations would be:
  1. For the “Translation Review Request” form, if someone accesses it directly, it would be good to enforce the need for a minimum number of stringsString A string is a translatable part of the software. A translation consists of a multitude of localized strings. suggested. Otherwise, someone could reach that screen after translating a pluginPlugin A plugin is a piece of software containing a group of functions that can be added to a WordPress website. They can extend functionality or add new features to your WordPress websites. WordPress plugins are written in the PHP programming language and integrate seamlessly with WordPress. These can be free in the WordPress.org Plugin Directory https://wordpress.org/plugins/ or can be cost-based plugin from a third-party and then ask to be PTEProject Translation Editor A Project Translation Editor (often referred to as PTE) is a person, who has access to validate strings on a specific project (for example BuddyPress, WooCommerce or Twenty Fourteen) for one specific locale. A project translation editor can approve strings that are added by translation contributors. Per project translation, editors are appointed by a general translation editor after a request by the project author or by the contributors themselves. of another one where he/she didn’t send any stringString A string is a translatable part of the software. A translation consists of a multitude of localized strings..
  2. Perhaps I’m missing some parts of the discussion (there is a lot to go through) but I don’t see the usual “back and forth” we have on some translation reviews, where the user sends some strings, we review sending them back, they suggest some others, et cetera. Sorry if I’m missing something obvious here!
  3. Regarding the threshold, I’d suggest a total strings based number. For example:
  3.1. If a plugin has only 50 strings or less, the user should submit 100%
  3.2. If a plugin has +50 strings, the user should submit at least 50 strings. How does that sound?
  
  Thank you and all the others for this effort!
  - Naoko Takano 1:42 am on June 19, 2020
    
    1. I agree that a minimum translation limit is good idea (if that’s technically feasible).
    2. Others also said the review/feedback process to come before this step.
    3. Threshold – @wordpress-tr also pointed this out in a comment to the drawing (sorry the discussion is a bit spread out…). I was thinking a similar way as your suggestion. The upper limit number can be 50 or 30, either way. Or 40 as a middle ground!
    
    1) 30 stringsString A string is a translatable part of the software. A translation consists of a multitude of localized strings. for plugins/themes for more than 40 strings
    2) 90% for 1-39 strings (so that if there is hard-to-translate stringString A string is a translatable part of the software. A translation consists of a multitude of localized strings., that can be left out)
Peter Smits 10:23 am on June 9, 2020

Hi Naoko
I have remarks regarding your proposal
1. What if a translator imports or adds a complete translation that contains more then the trashold? It would be nice if he/she could apply for PTEProject Translation Editor A Project Translation Editor (often referred to as PTE) is a person, who has access to validate strings on a specific project (for example BuddyPress, WooCommerce or Twenty Fourteen) for one specific locale. A project translation editor can approve strings that are added by translation contributors. Per project translation, editors are appointed by a general translation editor after a request by the project author or by the contributors themselves. directly, so an extra button beside “request review” would come in handy.
2. Maybe also a warning if he/she applies for checking the translations if “Fuzzy”translations are present. Indicating that those need to be resolved first!
Otherwise the GTEGeneral Translation Editor A General Translation Editor (often referred to as GTE) is a person, who has global access to validate strings on all projects for a specific locale./PTE for the pluginPlugin A plugin is a piece of software containing a group of functions that can be added to a WordPress website. They can extend functionality or add new features to your WordPress websites. WordPress plugins are written in the PHP programming language and integrate seamlessly with WordPress. These can be free in the WordPress.org Plugin Directory https://wordpress.org/plugins/ or can be cost-based plugin from a third-party need to reject or improve them.

I have no further comments at this moment, let us get this working first.
Regards,
Peter
- Naoko Takano 1:44 am on June 19, 2020
  
  Belated reply here, thanks @smile32!
  
  I agree that imported translation can be counted toward the minimum requirement. And I don’t know if imported stringString A string is a translatable part of the software. A translation consists of a multitude of localized strings. and others are distinguished in the data.
  
  Alerting to review fuzzy and warnings before submitting a request is a good idea.

Translate WordPress

Weekly Meetings

Posting here

Proposal for handling PTE requests

Form to collect the data

Validate the data

Output of requests

Open TracTrac Trac is the place where contributors create issues for bugs or feature requests much like GitHub.https://core.trac.wordpress.org/. tickets

Next steps

Translate WordPress

Weekly Meetings

Posting here

Form to collect the data

Validate the data

Output of requests

Open TracTrac Trac is the place where contributors create issues for bugs or feature requests much like GitHub.https://core.trac.wordpress.org/. tickets

Next steps

Share this: