Recap of WordCamp.org ticket scrub on August 29th

I will be AFK on 2017-09-12, so the next WordCamp.org Ticket Scrub meeting will be in four weeks, 2017-09-26 19:00 UTC, in #meta-wordcamp.

Here is a summary of this week’s discussion:

Participants: @coreymckrill @sergeybiryukov @xkon

#859-meta

The latest patch from @grapplerulrich is ready to commit. @coreymckrill will add a slight wording tweak to it to clarify the Coming Soon notification:

Coming Soon mode is enabled. Site subscribers will not receive email notifications about published posts.

#1109-meta

After the last scrub, @iandunn provided some clarification about the functionality in the current patch for this ticket:

If we don’t create menus at all, then the layout often breaks because the custom CSS assumes that they’re there. It wouldn’t make sense to add links to missing pages, though, and there aren’t any pages on the destination site yet, so it seemed like creating menus with just a Home link was the best we could do.

… I wonder if we could copy over the menu items for links that do exist on the destination site? A lot of pages like Location, Contact, etc are pre-populated, so they’ll exist. We could just skip the pages that don’t exist.

We decided it would be best to pursue the additional functionality suggested by Ian before committing, so that the menus wouldn’t just contain a “Home” link, which could be just as confusing as a broken layout.

@coreymckrill will update the ticket to see if the patch author wants to try making the update.

#1751-meta

The patches provided by @kau-boy look good. @coreymckrill will do an additional round of local testing and then commit them, and then @kau-boy can update the handbook with documentation on the new shortcode attributes.

#2907-meta

This one has an extensive patch from @xkon that has already been tested successfully on wptranslationday.org. Since it involves remote requests, it just needs a security review before we merge it into the plugin.

@xkon also mentioned a fork of Tagregator that they built that is completely PHP-based instead of having a React component:

Social Mentions

#2218-meta, #3075-meta

These two tickets will enable more flexibility for the meetings functionality on Meta sites, which will allow us to include this meeting (since it is biweekly instead of every week)!

#1109-meta, #1751-meta, #2218-meta, #2907-meta, #3075-meta

Recap of WordCamp.org Ticket Scrub for the week of July 31st

Great attendance for our first-ever WordCamp.org ticket scrub!

The next WordCamp.org Ticket Scrub meeting will be in two weeks, 2017-08-15 19:00 UTC, in #meta-wordcamp.

Here is a summary of this week’s discussion:

#2907-meta

This patch makes some significant changes to the Instagram source in the Tagregator plugin to accommodate changes to the Instagram API. The current patch submitted by @xkon uses raw cURL commands, which is not ideal for compatibility. The suggested change was to try using `wp_remote_get` or `wp_remote_post` instead. @ryelle volunteered to help test this and other Tagregator patches. (#2100-meta, #3003-meta)

#2934-meta

This ticket has a patch from @rmarks that partially addresses the issue. @coreymckrill said he would try to get that patch committed, and suggested fixes for other parts of the issue should go in a separate patch.

#859-meta

We discussed the patch for this ticket recently submitted by @grappleulrich. One aspect of the patch was to prevent users from publishing posts while Coming Soon mode is enabled, so that site subscribers wouldn’t get an email notification of a new post that might be incomplete and that they wouldn’t actually be able to access. As a group, we agreed that disabling the Publish button would actually be confusing and that there are times when you might want to publish a post while still in Coming Soon mode. Instead, we decided to change the approach so that email notifications are disabled in Coming Soon mode, and there is a warning near the Publish button to notify users that their post won’t be emailed to subscribers if they publish while still in Coming Soon mode.

#574-meta

This is an old ticket with an old patch. We agreed that the feature described would still be useful, but the patch probably needs to be updated before it will be compatible with the current version of CampTix. @coreymckrill said he would move the ticket over to the CampTix GitHub repo.

If you were unable to attend this meeting but have feedback, please share your thoughts in the comments on this post. In case there’s a need for further discussion we will ensure to make time for it in the next meeting. See you next time!

#2100-meta, #2907-meta, #2934-meta, #3003-meta