Editor chat summary: Wednesday, 9 October 2019

This post summarizes the weekly editor chat meeting on Wednesday, 9 October 2019, 14:00 WEST held in Slack.

Weekly Priorities

WordPress 5.3 is planned for next week, there are still some issues we need to fix before then:

Some of the priorities are being worked, but others are not taken yet. If you think you can help with some of these tasks, please leave a comment on the issue!

It is also essential to address some browser issues, namely on IE. People with a windows dev setup could be beneficial here.

We are getting close to the WordPress 5.3 release; testing is essential, namely on the mobile phone you use, given the wide variety of devices that exist.

Task coordination

Note: If you’re reading this summary outside of the meeting, please drop a comment if you can/want to help with something!

@youknowriad

  • Working on the Media Upload errors handling.
  • Working on a fix to the navigation mode.
  • Lots of reviews and coordination.
  • Exploring some improvements to Block nesting selection with a new Block Breadcrumb.

@get_dave

  • Continues the work on DimensionControl https://github.com/WordPress/gutenberg/pull/16791, and ResponsiveBlockControls https://github.com/WordPress/gutenberg/pull/16790 PRs.
  • Started on the implementation of a potential new Link insert/edit interface as per https://github.com/WordPress/gutenberg/issues/17557

@gziolo

  • Helped @epiqueras to land the initial version of the Components Storybook.
  • Is focused on some optimizations related to eliminating dead code (mostly for experimental features) from WordPress 5.3 release.

@jorgefilipecosta

  • Worked on some changes to the custom gradient picker. Now, it is possible to move the control points using arrow keys, and the code was reorganized. It should be ready for a more in-depth review; a11y feedback would also be valuable.
  • Focused on some 5.3 must-haves.
  • Helped (reviewed tested, or suggested commits) in navigation block (related PR’s), DimensionControl, ResponsiveBlockControl, and other smaller PR’s.
  • Will continue the work on must-haves, apply a refactor that makes media&text work on IE, and fix some generic block editor issues.

@karmatosed

@brentswisher

  • Hoping to revisit displaying a notice of some kind in the inserter when there are disabled blocks (https://github.com/WordPress/gutenberg/pull/17338).
  • Help out with any 5.3 issues that he can.
  • Will try to help get through some of the new issues, label them, and get additional attention to them if he thinks they are WordPress 5.3 must-haves.

Open floor

@jeffreycarandang asked for an updated to PR https://github.com/WordPress/gutenberg/pull/17617 and to issue https://github.com/WordPress/gutenberg/issues/17809.

Regarding PR https://github.com/WordPress/gutenberg/pull/17617 @youknowriad and @jorgefilipecosta both had some comments on the problem the PR faces. The basic idea is that when a format is applied to a rich text, the focus goes back to the rich text (e.g., when we press a “bold button” it is expected I can continue typing) this behavior was always present. Some time ago, mainly because of accessibility reasons, a change was applied to popovers that automatically closes them when the focus is outside. The two previous behaviors together have some impact on formats that are applied in a popover (the popover may close in an unexpected situation). This is a high priority very complex problem, and a solution is being worked.

Regarding issue https://github.com/WordPress/gutenberg/issues/17809, @youknowriad pointed $wp_version variable as a possible solution and provided a way to make it available in JavaScript.

@welcher asked more detailed feedback on https://github.com/WordPress/gutenberg/pull/16384 which adds a priority mechanism to the Slot&Fill pattern.

@mcsf and @youknowriad shared strong reservations.

It seems that priority and order are very visually focused, in stark contrast with how Gutenberg has tried to use SlotFill so far.

In Gutenberg, we talk about advanced settingsinspector, etc., instead of the visual element sidebar. Coming back to priority, what does it mean for SlotFill as far as selective rendering goes? how is a sequence determined semantically? etc.Why does this matter? Well, the bridging of different platforms and environments under Gutenberg is an important factor. If a codebase needs to work transparently across Web and Mobile, for example, its semantics needs to be clear and independent of a particular visual expression (e.g. Web on Desktop)

@mcsf

@mkaz had a docs related question:

How do y’ll feel about ES5 support in documentation? Most of the code and package docs are ESNext, but we show ES5 examples first in docs. I don’t have a proposal together yet, but I feel we should move people quicker to ESNext since it is what they most likely will experience everywhere.

People agreed that the default docs should be ESNext but ES5 examples should still be present.

#core-editor, #editor-chat, #meeting, #summary

Editor Chat Summary: October 2nd, 2019

This post summarizes the weekly editor chat meeting on 13:00 UTC, October 2nd, 2019 held in Slack.

The agenda can be found here.

WordPress 5.3

Slack transcript.

Gutenberg 6.6 was released and has been included in WordPress 5.3 beta 2.

Weekly Priorities

Slack Transcript.

The main current focus is still WordPress 5.3. Tasks are being tracked in this Github board. Starting work towards the content-block areas.

Task Coordination

Slack Transcript.

Open Floor

Slack Transcript.

@mikeschroder raised that WordPress 5.3 comes with an update to image uploads: if the server sends a HTTP 500 error (for example, because it couldn’t finish the thumbnail resizing) the process will be retried. This is implemented in the Media Library and Media Modal, but not in the REST API and Gutenberg yet.

@maximeculea mentioned that the mobile team is running an experiment with styled components (CSS in JS) as a way to learn whether styles can be shared between web and mobile.

@paaljoachim brough up that there is a PR that address some of Gutenberg float issues. @youknowriad and @joen noted that, currently, this falls in theme-land. We should make progress on some refactorings to the block list that are a better approach, leaving the current behavior as it is.

#core-editor, #editor-chat, #summary

Editor chat summary: 25 September 2019

This post summarizes the weekly editor chat meeting on Wednesday, 25 September 2019 at 1300 UTC held in Slack.

The agenda can be found here.

News

  • WordPress 5.3 beta 1 is out

Weekly Priorities

  • Weekly Priorities are the remaining important issues and tasks needed for WordPress 5.3: https://github.com/WordPress/gutenberg/projects/34?fullscreen=true
    • still considering the Block content areas related work as a priority for the project

Task coordination

Note: If you’re reading this summary outside of the meeting, please drop a comment if you can/want to help with something!

  • @andraganescu
    • refactored the MediaFlow component to be a drop in component nstead of a HoC. it looks kind of ready https://github.com/WordPress/gutenberg/pull/16200
    • the PR implementing a smarter block appender could use a new review https://github.com/WordPress/gutenberg/pull/16708
  • @youknowriad
    • works on the WP 5.3 board above,
    • also working on dev notes,
    • Trying to help fix bugs
    • Reviewing Block Content areas work as time allows.
  • @mapk
    • I’m watching the project board like a hawk.
    • Testing @getdave’s responsive spacing PR: https://github.com/WordPress/gutenberg/pull/16790
    • Helping with the Inserter Panel Previews. https://github.com/WordPress/gutenberg/pull/17493
    • Keeping movement on the Block Patterns: https://github.com/WordPress/gutenberg/issues/17335
  • @brentswisher
    • will be back to his PRs
  • @getdave
    • works on the DimensionControl component and needs feedback https://github.com/WordPress/gutenberg/pull/16791
    • needs feedback on ResponsiveBlockControl too https://github.com/WordPress/gutenberg/pull/16790
  • @jorgefilipecosta
    • implements the first version of custom Gradient picker
    • needs review on https://github.com/WordPress/gutenberg/pull/17154
    • also working on compiling WordPress 5.3 Gutenprops. If you have not yet associated your GitHub to your WP.org profile, please do so, to make the props work easier and to make sure props are attributed!
  • @mcsf
    • focusing back on improving remote vs. local autosaves

Open floor

  • @paaljoachim raised some issues for discussion
    • there was a discussion on an option to use text link instead of auto embed ended with needing to clarify more on the issue
    • there was a discussion on the social block features needed for it to make it in WP 5.3 resulted in not having a light version because of the risk that we’d introduce breaking changes in core
  • @desaiuditd and @youknowriad discussed about https://github.com/WordPress/gutenberg/pull/17311

The next meeting is on 02 October 2019 at 13:00 UTC.

#core-editor, #editor-chat, #summary

Editor Chat Agenda: September 25th

Note taker: @andraganescu.

This is the agenda for the weekly editor chat scheduled for September 25, 2019 at 1300 UTC.

This meeting is held in the #core-editor channel in the Making WordPress Slack.

  • WordPress 5.3
  • Weekly Priorities
  • Task Coordination
  • Open Floor

If you have anything to share for the Task Coordination section, please leave it as a comment on this post.

As always, if you have anything to propose for the agenda or other specific items related to those listed above, please leave a comment below.

#agenda, #core-editor, #editor-chat

Editor Chat Agenda: September 18th

Note taker: @mikeschroder.

This is the agenda for the weekly editor chat scheduled for September 18, 2019 at 1300 UTC.

This meeting is held in the #core-editor channel in the Making WordPress Slack.

  • Gutenberg 6.5 Release
  • Weekly Priorities
  • Task Coordination
  • Open Floor

If you have anything to share for the Task Coordination section, please leave it as a comment on this post.

As always, if you have anything to propose for the agenda or other specific items related to those listed above, please leave a comment below.

#agenda, #core-editor, #editor-chat

Editor chat summary: Wednesday, 28 August 2019

This post summarizes the weekly editor chat meeting on Wednesday, 28 August 2019, 14:00 WEST held in Slack.

Weekly Priorities

  • Inline tips #16582 was closed until #16592 gets resolved.
  • Edit MediaFlow #11952 received feedback and needs to be updated).
  • Regarding the architecture work preparing the editor to handle multiple entities, @epiqueras shared that the framework changes and everything up to the site block is done. Now we need designs for template selection/creation, and post block save flows, etc.
  • Background color for the cover block was merged and release.
  • Regarding the gradient backgrounds, @jorgefilipecosta proposed a PR implementing gradient functionality. @jorgefilipecosta shared that we need to decide if the predefined gradients created by themes should use a class or an inline style. And asked: Is there an expectation that when a theme switch happens, the gradients should change? If you have any thoughts on this subject, please share them!
  • Screen height image expand has been updated and just about to cross the finish line. 

Task coordination

Note: If you’re reading this summary outside of the meeting, please drop a comment if you can/want to help with something!

  • @swissspidy is looking at support non-consecutive block multi-selection and would like a helping hand.
  • @nadir is going to revisit some blocked PRs he has made so he can advance them.
  • @kjellr is working on:
  • @jorgefilipecosta will continue the work on gradients, continue the block style improvements (is hoping to merge theme default block styles soon), and other smaller improvements like button block styles.
  • @joen is helping PR #16897 for a new social links block.
  • @mapk is looking to:
    • Spend time triaging and reviewing PRs.
    • Create some more structured mockups for dragging and dropping blocks next to each other: #13202.
    • The PR that adds resizing image to full-height, and also the gradients PR.
  • @brentswisher worked on a demo of using a full-screen modal for publishing #17225. This week will work on moving some old PR’s along. If time allows will come up with something for PR “Block inserter doesn’t show that some blocks are disabled” (would like some help).
  • @gziolo revisited a PR which stop showing errors and warnings when blocks get successfully updated from deprecated version (#16862). Plans to update WordPress core packages and fully automate the way we maintain script dependencies.

Open floor

@paaljoachim would like some feedback on the last comment he made on PR #16682. Asked if anyone can take over PR #16490, @mcsf said he was hoping to grab the referred PR in the next days. And to conclude @paaljoachim said PR #14367 is almost ready for a final review.

@welcher would like some feedback on PR #17198 (header toolbar).

#core-editor, #editor-chat, #summary

Editor Chat Summary

This post summarizes the weekly editor chat meeting on August 21, 2019 at 1300 UTC held in the core-editor Slack channel.

The agenda can be found here.

Note: If you’re reading this summary async, please drop a comment if you can/want to help with something!

Priorities for the week

Slack transcript.

Merged:

Being worked on / Needs more work:

Task Coordination

Slack transcript.

@youknowriad Refresh to reusable blocks that closes multiple issues, triagged issues and reviewed PRs.

@karmatosed Triagged, mainly issues/PRs that need design feedback.

@kjellr Improvements to the inserter help panel (1, 2), changes to NUX tips, and tidying up animations (1, 2).

@jorgefilipecosta Explored mobile viewport in the editor (1, 2). To work on text color formatting, gradient backgrounds, cover block resizing.

@mapk Looking into improving the sibling block inserter, helping on widgets work and @retrofox on a UI solution for screen height PR.

Components package reorganization and bundle sizes

Agenda | Slack Transcript | Issue

The issue created by @nerrad sparked a conversation on how to control bundle size and offer options to bundle “what you need”:

  • The `wp_enqueue_script` model encourages people to use the whole bundle for a package, not the specific pieces you want.
  • There are concerns over creating too many packages that make discoverability difficult.
  • Overrall, this ties into how to make WordPress play nicely with dynamically loading dependencies as you need them (the SPA model).

To be discussed more in the issue and/or in future core-js chats.

e2e test and block deprecations

Agenda | Slack Transcript | Issue

  • @isabel_brison raised the issue that e2e tests fail due to block deprecations triggering a `console.warning`.
  • The restriction have been very valuable when it came to deprecate APIs, as to make sure core wasn no longer using them. It is not that useful in other contexts.
  • There is a draft PR to address the deprecation issue.

#core-editor, #editor-chat, #summary

Editor Chat Agenda: August 14th

Note taker: @andraganescu

This is the agenda for the weekly editor chat scheduled for August 14, 2019 at 1300 UTC.

This meeting is held in the #core-editor channel in the Making WordPress Slack.

  • Gutenberg 6.3
  • Tasks Coordination
  • Open Floor

If you have anything to share for the Tasks Coordination section, please leave it as a comment on this post.

As always, if you have anything to propose for the agenda or other specific items related to those listed above, please leave a comment below.

#agenda, #core-editor, #editor-chat

Editor Chat Agenda: August 7th

Note taker: @mikeschroder

This is the agenda for the weekly editor chat scheduled for August 7, 2019 at 1300 UTC.

This meeting is held in the #core-editor channel in the Making WordPress Slack.

  • Tasks Coordination
  • Open Floor

Last week it was suggested to post items for Tasks Coordination as comments on posts so that it’s easier to follow for folks that can’t attend the regular meeting.

So, let’s give it a try! If you have anything to share for the Tasks Coordination section, please leave it as a comment on this post.

As always, if you have anything to propose for the agenda or other specific items related to those listed above, please leave a comment below.

#agenda, #core-editor, #editor-chat

Editor chat summary: Wednesday, 24 July 2019

This post summarizes the weekly editor chat meeting on Wednesday, 24 July 2019, 14:00 WEST held in Slack.

The agenda followed can be found here.

The meeting started with @youknowriad noting that we postponed this week’s Gutenberg release 6.2 to the next week due to a lot of AFKs and not enough shipped features/enhancements for a proper release. Next week we will resume the regular release schedule.

Task coordination

Note: If you’re reading this summary outside of the meeting, please drop a comment if you can/want to help with something!

@tellthemachines

  • Working on the settings page. It’s not finished yet, but @tellthemachines created a PR up to get feedback: https://github.com/WordPress/gutenberg/pull/16626
  • Started working on a caption for the gallery block: https://github.com/WordPress/gutenberg/issues/9342
  • Looking at http://gutenberg.run/ and other possibilities such as https://tugboat.qa/ for setting up preview environments for our PRs.

@youknowriad

  • Worked mainly on “A11y Navigation mode” and “Live Drag and Drop experimentation”.
  • Reviewed: new PHP API to register style variations and some small reviews here and there (Gutenberg experiments settings page, Text alignments in the block heading, Improved preview component…).
  • Started thinking about Full Site Editing and what does it mean for Gutenberg to support editing the full site/page even outside post content.

@mapk

  • Working on widget screens
  • Exploring some Block Template flows
  • Reviewing PRs

@jorgefilipecosta

  • Plans to finish the work related to block style variations, some PR’s will need an update to avoid PHP anonymous functions.
  • Will submit some fix for issues opened affecting the blocks widget screen.

@karmatosed

  • Plans on reviewing anything design stuck in the backlog.
  • Has been dipping into the ‘needs testing’ label a bit to keep that moving along.

@brentswisher

  • Is working on ideas for “updating the publishing flow”. A PR https://github.com/WordPress/gutenberg/pull/16715/ is available, and feedback is welcome.

@kjellr

  • This week: Worked on improvements to the Gutenberg Starter Theme.
  • Next week: Will focus on the Patterns API + Tips.

@getdave

  • Worked on a PR to add basic spacing/dimensions controls to the Group Block. https://github.com/WordPress/gutenberg/pull/16730
  • Improved BlockPreview component:
    • Autosizing / scaling previews – https://github.com/WordPress/gutenberg/pull/16113/
    • Updating the API of the component to accept multiple blocks as arguments – https://github.com/WordPress/gutenberg/pull/16033

Growing list of open PR’s

@youknowriad made a remark saying:

The list of open PRs is growing. That’s great, I’d like to thank you all for your contributions. This also means we’re having some trouble to keep-up with reviews… I’d like to ask everyone creating PRs / working on Gutenberg to help as much as needed with PR reviews (it doesn’t matter if you think you have the required knowledge or not, all reviews are helpful and help move things forward).
So please review PRs as much as you can and again thanks all for your work/help. If you’re hesitant for any reason, my DMs are open, happy to address your uncertainty.

@karmatosed flipped the question and asked if there are any hurdles to people reviewing.

@brentswisher pointed out that his hesitation (maybe shared with other contributors) is a fear of uncertainty about what would happen after something is reviewed and made the following questions:

  • Does it just get merged?
  • Does someone with more experience look at it again before merging?
  • Am I supposed to merge it?

@karmatosed  and @youknowriad answered that since @brentswisher is a member of the Github Gutenberg team, he can merge a PR after the review or review it anyway but not merge it right away and ask for a second opinion.
Both also mentioned that maybe there is space to iterate the docs and make that more clear.

Open Floor

@paaljoachim is wondering if other have some comments on PR https://github.com/WordPress/gutenberg/pull/16557 (Try: Always collapse block alignments), for @paaljoachim the PR seems a no brainer by placing alignment into a dropdown.

@karmatosed said that she would say “yes” to the PR if discoverable, but her concern is hiding usefulness.
@mapk said he liked it, adding that we have other items that work this way already.
@paaljoachim asked for comments on the previously referred PR and PR https://github.com/WordPress/gutenberg/pull/16682 (“added alignment to the toolbar for consistency”).
@karmatosed said we could add the comments and thanked @paaljoachim for championing these PRs.

@desaiuditd asked for comments on PR https://github.com/WordPress/gutenberg/pull/16244 (“Allow changing Block attributes dynamically in InnerBlocks template”.).
@jorgefilipecosta said:

The idea of the template is to provide a set of blocks that prefill a given InnerBlocks when it is empty.
If I pass a template when a block contains a given set of attributes, and later I pass a template where blocks contain different attributes, nothing should happen because the block is not empty anymore and there is no need to prefill it.

The discussion continued on the reason why sometimes the template updates the blocks. @jorgefilipecosta explained that it only happens when templateLock=all and only for cases where blocks changed positions or were removed/added because for this locking we know the user would not have made these actions.

@chrisvanpatten and @mcsf both pointed to a PR that may bring more control to templateLock https://github.com/WordPress/gutenberg/pull/16678 (Template Locking: read-only / disable editing attributes)

@jorgefilipecosta concluded that for now if there is a need to update the attributes of a child, from the parent, the best solution is the usage of updateBlockAttributes action in the parent, and not use the template mechanism.

#core-editor, #editor-chat, #summary