Dev Chat Agenda, April 1, 2015

Here’s the agenda for Wednesday’s Dev Chat in the #core channel on Slack.

  • Beta 3 was tagged last week as scheduled and we’re heading toward tagging Beta 4 this week.
  • The soft string freeze is targeted to coincide with tagging Beta 4 this week, so we need to wrap any tickets with string changes (save for the About page).

Time/Date: Wednesday 21:00 UTC 2015:

DST reminder: The dev chat time has moved up an hour to 20:00 UTC following the European DST change.

Agenda

  1. Congrats if you got ’em for @obenland and @wonderboymusic, release leads for WordPress 4.3 and 4.4!
  2. Task/Enhancements Review [List]
  3. String Ticket Scrub [List]
    One string:
    • #29958 – collapse menu keyboard accessibility
    • #31233 – Dismissable admin notices
    • #31769 – Prevent navigating away while plugins are updating via shiny updates
    • #31836 – Press This: Clean up text on tools.php

    Two or more strings:

    • (2) #31144 – Options general screen, accessibility improvements
    • (2) #31770 – Better feedback after bulk updating plugins via shiny updates
    • (3) #31722 – Shiny Updates: the aria-label should be updated to reflect the current status

    Various string changes:

    • #26600 – Search installed themes input has no submit button – New help text, one string split into two, new strings
    • #31832 – Add an Emoji section to the Help tab on post edit screen – New help text, replaced string
    • #27115 – HTTPS links to wordpress.org – Strings adjusted for links, may not need re-translating

No Open Floor this week – Due to time constraints, we won’t be holding an open floor period during the regularly-scheduled dev chat this week. If you have a ticket on the 4.2 milestone you’d like to get dev feedback on, leave a note in the comments.

Testing Stages Progress
  • Beta 1
    • Punt/convert all non-essential enhancements to tasks
  • Beta 2 (120 tickets on Report 6)
    • Get first run of FTP credentials modal in trunk
  • Beta 3 (90 tickets on Report 6)
    • Start finishing up tickets with string changes
    • Start About page
  • Beta 4 (50 tickets on Report 6)
    • Soft string freeze (all string changes completed save for the About page)
    • Start finishing up the About page
  • RC 1 (0 tickets on Report 6)
    • About page finished
    • Hard string freeze

#4-2, #agenda

This Week in 4.2: March 30 – April 5

This is the jump-start post for the eleventh week of the WordPress 4.2 release cycle. Posted just a little bit late this week, sorry folks.

We entered the Beta 3 stage of development last week. We need to wrap up any tickets with string changes and transition to Beta 4 this week.

Thrice-weekly scrubs will continue this week on Tuesday, Wednesday, and Friday using Report 6.

Core Meetings this week:

Core meeting times have been adjusted following the DST change in Europe over the weekend. No joke!

Priorities this week:

General

  • Committers: please take a look at the list of tickets you own. Many of those tickets are simply waiting for you to follow up on commit or patch feedback and are stalled without it.
  • #31794 – Theme Switcher: Improve mobile experience – Needs a patch based on feedback

Accessibility

  • #30468 – wplink modal accessibility
  • #31722 – Shiny Updates: the aria-label should be updated to reflect the current status
  • #31233 – Dismissable admin notices
  • #26601 – Inappropriate content in headings on admin screens

Make Flow:

  • #29906 – Submenus can’t be dismissed on mobile.
  • #31611 – Scroll bleed in the attachment details modal on iOS
  • #31609 – Scroll bleed through and scroll position loss in the view plugin details modal on iOS
  • #31612 – Scroll bleed in the link modal on iOS

Recent posts seeking feedback

Notable updates from the last week:

#4-2, #jump-starts

Screen Reader Text in output of comments_popup_link

As of WordPress 4.2, the output of comments_popup_link now uses .screen-reader-text in themes using the default strings in calls to comments_popup_link. The accessibility team has put together a post on hiding text for screen readers that includes sample code to use in your themes.

I recommended that all themes include the .screen-reader-text class. This change was announced by the on the theme team blog in January. In the future, there may be more changes to output that relies upon the presence of the .screen-reader-text class.

Related Ticket:
#26553

#4-2, #dev-notes

WordPress Core Weekly

Hi Everyone!

It’s time for another run-down of what’s going on in WordPress core. This edition covers March 20, 2015 [31845] through March 28, 2015 [31915].

If you want to write the next WordPress Core Weekly summary, check out the schedule over at make/docs and get in touch in the #core-weekly-update Slack channel.

This week’s highlight is WordPress 4.2 Beta 3, which was released on Thursday. There were many accessibility and emoji improvements and bug fixes. Also, shiny installs functionality was removed.

I18N

  • Improve newly added strings for i18n. [31905] #31776
  • Remove <code> tags from translatable strings. Uncomment deprecation notice for get_bloginfo( 'text_direction' ). [31899] #30614

Customize

  • Theme Switcher: Opening themes details modal shouldn’t require two clicks on touch devices. [31914] #31794
  • Theme Switcher: Reset font size of theme names in overlay. Apply left position only to themes section. [31892] #31303
  • Theme Switcher: Don’t hide action buttons on narrow screens. [31912] #31794
  • Use proper preview URL for Live Preview links. [31911] #31782
  • Avoid SecurityErrors when the Customizer is embedded in an origin other than wp-admin. [31885] [31893] #31687
  • Use responsive button styles if screen is max-width 640px. [31913] #31794, #28784

Emoji

  • [31864] changed emoji image’s inline style from height to max-height. Unfortunately, anything using feedparser.py (for example, NewsBlur) strips out max-height, which gives us massive emoji in feeds. This re-adds height, and also reminds us why we can’t have nice things. [31909] #31719
  • When we’re replacing emoji with <img>s in email, we can only do that if the Content-Type is text/html – otherwise, they’ll show up in the email as the HTML string. [31860] #31720
  • Instead of loading the emoji JS files automatically, we now include a small JS shim in the header, to test if the user’s browser needs Twemoji. It then loads the emoji JS files only if they’re needed. [31875] [31877] [31879] #31701
  • Set the emoji image protocol with set_url_scheme(), instead of defaulting to HTTPS. [31861] #31735

Press This

  • Remove role="application" from the Categories list wrapper. This doesn’t make it work better in screen readers. [31907] #31443
  • On sites that support oEmbed, if the user has selected some text, quote it below the embed. [31894] #31763
  • Fix the links on inserted images to point to the source site. Fix inserting of images above the blockquote when the editor has not been focused. [31868] #31745

Upgrade/Install

  • Fill $plugins['upgrade'] with extra info for use in list table [31872] #31738
  • Remove Shiny Plugin Installs [31897] [31900] [31901] #31773, #29820
  • When creating a temporary working directory, strip off .tmp as well as .zip incase we end up using that directory as the items main directory. [31863] #30945

General

  • Remove ambiguity in the time display format in core, switches to using 24hr notation where am/pm isn’t specified. [31862] #31121
  • Comments List: Don’t let “Quick Edit” break on smaller screens. [31889] #31482
  • Admin menu: Revert [31720] for swipe open/closed. This is problematic on any device that uses swipe for history navigation, particularly iOS. [31910] #31187
  • Do not output empty name and id HTML attributes in get_submit_button(). [31880] #31749
  • When altering the admin URL to reflect the canonical location, keep the existing hash (if present) in the URL. [31882] #31758, #23367
  • WordPress 4.2-beta3 [31902] [31903]

Taxonomy

  • When saving post, ensure that non-hierarchical taxonomy input is defined before attempting to parse it. [31895] #30859
  • Taxonomy List Tables: On mobile devices, hide the slug column, to avoid cramping the action links into two rows. [31865] #29992
  • Supplement hook documentation for the get_terms_fields filter to more clearly explain the expected consequences of using it to modify the fields to select in a terms query. [31855] #31174

TinyMCE

  • Make sure the editor is not completely empty before checking if the user clicked above or below a wpView. [31888] #31765
  • Pad empty paragraphs with <br> in Chrome to stop it from inserting non-breaking spaces in them. [31878] #31255
  • Fix error and PHP warning when adding more than one instance in RTL mode. [31874] #31578
  • Fix the icon for the wp_code button. [31858] #31733
  • When pasting an URL, check if the node it is pasted at is empty and remove any empty inline child elements. [31856] #31158

Script Loader

  • Avoid a PHP notice in wp_enqueue_script() if $handle is an array. Calling wp_enqueue_script() with an array as the first argument is a “hidden feature” and should be avoided. Use dependencies instead. [31887] #31636, #14488

Widgets

  • Text Widget: Use !empty() for checking if the filter setting is set. [31886] #31690
  • Trigger _doing_it_wrong() if register_sidebar() is not passed an id. [31850] #31675

Login and Registration

  • Implement an aria-describedby attribute for login screen errors, and improve the “Forgot password?” anchor text. [31871] #31143

Media

  • Introduce attachment_url_to_postid filter to let plugins manage the uploads location better. [31867] #31717
  • Show filename instead of extension in the list table. [31857] #30943

Bundled Theme

  • Update editor styles to better display images and captions in small screens. [31849] #31250

Build/Test Tools

Thanks to @A5hleyRich, @afercia, @aferica, @atimmer, @azaozz, @boonebgorges, @Cheffheid, @dd32, @dkotter, @DrewAPicture, @ericlewis, @extendwings, @HarishChaudhari, @helen, @ianmjones, @iseulde, @jacklenox, @janhenckens, @johnbillion, @johneckman, @jorbin, @kraftbj, @lamosty, @lancewillett, @magicroundabout, @maimairel, @markjaquith, @mattheu, @mattwiebe, @MikeNGarrett, @nerrad, @obenland, @ocean90, @pento, @ramiy, @rianrietvel, @SergeyBiryukov, @sorich87, @stephdau, @swissspidy, @tschutter, @tyxla, @valendesign, @valendesigns, and @westonruter for their contributions!

#4-2, #week-in-core

Dev Chat Agenda, March 25, 2015

Here’s the agenda for Wednesday’s Dev Chat in the #core channel on Slack.

» Beta 2 was tagged last week as scheduled and we’re heading toward tagging Beta 3 this week.

Time/Date: March 25 2015 21:00 UTC:

Reminder for those on Daylight Saving Time – If you’re already on Daylight Saving Time, the core dev chat will be an hour later for you until next week, though still 21:00 UTC. The above time link should give you the correct time and date for your local timezone.

Agenda

  1. Decisions
    • Shiny Updates: Auto-activation behavior
    • wpLink modal: Behavior for working links lacking source text
    • Pursue or Punt: #26601 – Inappropriate content in headings on admin screens
    • About page highlights
    • Make/Core Posts – Ideas: Schema change, query class changes, TinyMCE views changes, twemoji front-end loader, update on HTML5 widgets revert, etc.
  2. Upcoming Milestones overview
    • Beta 3 (90 tickets on Report 6)
      • Start finishing up tickets with string changes
      • Start About page
    • Beta 4 (50 tickets on Report 6)
      • Soft string freeze (all string changes completed save for the About page)
      • Start finishing up the About page
    • RC 1 (0 tickets on Report 6)
      • About page finished
      • Hard string freeze
  3. Open Floor – Looking for dev feedback on a ticket? Use this part of the meeting to let us know!

#4-2, #agenda

This Week in 4.2: March 23 – 29

This is the jump-start post for the tenth week of the WordPress 4.2 release cycle.

We entered the Beta 2 stage of development last week. We should transition to Beta 3 and try to wrap up enhancements/tasks this week.

Thrice-weekly scrubs will continue this week on Tuesday, Wednesday, and Friday using Report 6.

Core Meetings this week:

4.2 Feature Chats this week:

Priority tickets this week:

Accessibility

  • #30468 – wplink modal accessibility
  • #28820 – Focus isn’t clear when previewing an oEmbed from Add Media Panel
  • #31143 – Login error handling accessibility improvements
  • #31326 – Edit comment screen: misplaced-missing labels

Mobile:

  • #29906 – Submenus can’t be dismissed on mobile
  • #29991 – Comment action links are quite cramped on small screens
  • #29993 – Media action links are cramped on small screens
  • #31609 – Scroll bleed through and scroll position loss in the view plugin details modal on iOS
  • #31610 – Scroll bleed in the session expired log in modal on iOS
  • #31611 – Scroll bleed in the attachment details modal on iOS
  • #31612 – Scroll bleed in the link modal on iOS

Notable updates from last week:

#4-2, #jump-starts

WordPress Core Weekly

Hi Everyone!

It’s time for another run-down of what’s going on in WordPress core, directly from WordCamp London. This edition covers March 13, 2015 [31765] through March 20, 2015 [31844].

If you want to write the next WordPress Core Weekly summary, check out the schedule over at make/docs and get in touch in the #core-weekly-update Slack channel.

This week’s highlight is definitely WordPress 4.2 Beta 2, which was released on Thursday. Make sure to check it out!

I18N

Bundled Themes

Canonical

  • If the URL being visited has non-breaking spaces at the end of it, they were probably inserted by an errant URL copy/paste. Instead of showing a 404 for no obvious reason, let’s just trim them. [31838] #31499

Press This

  • Check if the URL is to embeddable content on a site that supports oEmbed. Then insert only the URL in the editor. It will trigger a wpView with the embedded content. [31827] #31637
  • Prepend the site domain to root-relative URLs. Reject other relative URLs. [31818] #31645
  • Ignore site descriptions that end with an ellipsis. These are most likely auto-generated. [31810] #31639
  • Change the Publish button text to Submit for Review for contributors (like on the Edit Post screen). [31798] #31658
  • Increase the number of meta tags we check in the bookmarklet to 200. Sometimes there are empty meta tag nodes (no attributes) in some browsers. [31778] #31373
  • Simplify and restyle the categories drop-down, remove the checkboxes and use JS to get the selected categories on submitting the form. [31765] #31443

Plugins

Embeds

  • Revert stripping of tags from pasted URLs on beforeSetContent [31817] and [31819]. Clean up URLs on `pastePreProcess`. [31832] #31158
  • Small cleanup for stripping of tags from pasted URLs. See #31158. [31819] #31158
  • Strip tags from pasted URLs before testing if they are embeddable. [31817] #31158

Upgrade/Install

  • Ensure that we target the correct plugin row for update updates [31831] #31621
  • Request FTP and SSH credentials when needed during shiny updates [31811] #31528

General

  • WordPress 4.2-beta2 [31835]
  • Remove duplicate label on Add New User screen. [31777] #31131
  • Don’t try to call wp_clean_plugins_cache(); twice in wp_clean_update_cache(). [31825] #31503
  • List tables: Go back to inserting quick edit rows after, as some plugins rely on that assumption. Results are the same. [31820] #26060

Emoji

  • Move a comment to match the restructure in [31779], and add an extra comment explaining how emoji rendering support is detected. [31788] #31242
  • Fix few typos. See #31242. [31787] #31242
  • Add the styling for the replacement images to the admin CSS and revert to using .emoji as replacement image class. [31786] #31242
  • Smilies: The new smilies added in [31733] and [31745] are larger than the old smilies. By adding a little bit of inline style to them, we get pleasingly sized smilies everywhere. 🙂 [31781] #31242
  • Yet another update for Twemoji, to 1.3.2. See #31242. [31773] #31242
  • TinyMCE emoji: fix highlighting of selected replacement images in Chrome. [31822] #31628

Posts, Post Types

  • Add WP_Posts_List_Table::is_base_request() to determine if the current “view” is the “All” (default) view. [31828] #24869

Widgets

Toolbar

  • Protect against Firefox font rendering interference by themes. [31824] #30021

Taxonomy

  • Edit Terms: Show error messages actually as error messages. [31823] #31241
  • Ensure that the $exclusions parameter of list_terms_exclusions filter is always a string. [31813] #31681

Comments

  • Move HTML tags for screen reader text into translatable strings. [31821] #26553
  • Improve method consistency in WP_Comment_Query. These changes bring WP_Comment_Query syntax closer to that of WP_Query. [31793] #24826
  • Restore line breaks before comment text in comment notification emails. [31770] #31508

Filesystem API

  • Change WP_Filesystem_FTPext::exists() and WP_Filesystem_ftpsockets::exists() to return true for empty directories. [31815] #30815

Build/Test Tools

Formatting,Taxonomy

  • In wp_insert_term(), allow a term with an existing name if a unique $slug has been provided. [31792] #17689 #31328

Database

  • HHVM doesn’t support passing a DB link to mysqli_get_client_version(). While we usually pass a DB link to every ext/mysql and mysqli function call, we don’t really need to do that here, as there’s no way for the client library to change mid page load.[31783] #31644

Thanks to @abhishekfdd, @afercia, @azaozz, @boonebgorges, @cbaldelomar, @cfinke, @danielbachhuber, @DrewAPicture, @ericlewi, @ericlewis, @fhwebcs, @helen, @imath, @iseulde, @jeremyfelt, @jorbi, @jorbin, @kraftbj, @lancewillett, @mercime, @Michael-Arestad, @mordauk, @morganestes, @obenland, @ocean90, @pavelevap, @pento, @rahulbhangale, @SergeyBiryukov, @siobhan, @stephdau, @swissspidy, @TobiasBg, @valendesigns, @westonruter, and @wonderboymusic for their contributions!

#4-2, #week-in-core

Dev Chat Agenda, March 18, 2015

Here’s the agenda for Wednesday’s Dev Chat in the #core channel on Slack.

» Beta 1 was tagged last week as scheduled and we’re heading toward tagging Beta 2 this week.

Time/Date: March 18 2015 21:00 UTC:

Reminder for those on Daylight Saving Time – If you’re already on Daylight Saving Time, the core dev chat will be an hour later for you for the next few weeks, though still 21:00 UTC. The above time link should give you the correct time and date for your local timezone.

Agenda

  1. Ticket Ownership
    • New Trac report, Tickets I Own, primarily for committers
    • Review milestoning best-practices in the testing stages
  2. Bug Scrub/Commit Sprint

No Open Floor this week – Due to time constraints, we won’t be holding an open floor period during the regularly-scheduled dev chat this week. If you have a ticket on the 4.2 milestone you’d like to get dev feedback on, leave a note in the comments.

#4-2, #agenda

This Week in 4.2: March 16 – 22

This is the jump-start post for the ninth week of the WordPress 4.2 release cycle.

We entered the Beta 1 stage of development last week. We should transition to Beta 2 later this week.

Thrice-weekly scrubs will continue this week on Tuesday (bugs), Wednesday (tasks), and Friday (Report 6).

For those following the Press This feature, the Slack channel has been renamed from #feature-pressthis to #core-pressthis and will be used for general Press This component maintenance and discussion going forward.

Core Meetings this week:

4.2 Feature Chats this week:

Priority tickets this week:

Accessibility

  • #30556 – Modern widgets default wrapper
  • #31527 – Bundled themes: Add ARIA attributes to menu toggle
  • #30468 – wplink modal accessibility
  • #31546 – Press This and admin tag meta-box: use aria-describedby to improve accessibility

Mobile:

  • #31187 – Allow swiping the admin menu open and closed on touch devices
  • #29906 – Submenus can’t be dismissed on mobile
  • #31233 – Dismissable admin notices

Posts seeking your feedback:

Notable updates from last week:

#4-2, #jump-starts