WordPress.org

Make WordPress Core

Updates from May, 2015 Toggle Comment Threads | Keyboard Shortcuts

  • Jeremy Felt 3:33 am on May 27, 2015 Permalink |
    Tags:   

    Multisite Office Hours Recap (May 26, 2015) 

    Multisite office hours are held every Tuesday at 20:00 UTC in #core-multisite.

    Today’s chat log

    Overall 4.3 Release Objectives

    Last week’s objectives for dev chat:

    • Continued work on mock-ups, discussion around edit site and add site flows.
    • Android and iPad flows posted to Make/Flow.
    • Conversation around and updated `WP_Network` patch and a first attempt at `WP_Site`.

    Today’s meeting agenda:

    • Arbitrary domain/path combinations. #22383 (and now #32434)
    • `WP_Network` #31985 and `WP_Site` #32450
    • Thoughts on how to track scheme for a site. #14172
    • More flows (and tickets) needed. :)

    Topic Details:

    Arbitrary domain/path combinations in edit site:

    • Tickets: #22383, #32434, #32503
    • chat log
    • @hugubaeta explored things some more and left some good feedback on #22383. We agreed to push ahead with the single entry for scheme, domain, and path in #22383.
    • During that discussion, we started to address the question of the checkbox for updating home and siturl. This resulted in #32503. After some further discussion there, we’re going to try removing that checkbox entirely and using some logic to determine when to update home and siturl. @earnjam is working on the patch for this.
    • @ocean90 is working on updating a patch for #32434 after discussion there and in #22383.

    Progress on `WP_Network` and `WP_Site`:

    • Tickets: #31985, #32450
    • chat log
    • second chat log
    • Initial brief conversation. @earnjam is going to take a closer look at the existing patches. We need to start brainstorming where `WP_Network_Query` starts.
    • Continued this conversation with @johnjamesjacoby later in the day. He’ll be working on the patches a bit more this weekend as well.
    • #25293 was brought up to consider so that the correct network ID is available after `switch_to_blog`. Also #14867 to ensure the correct scheme is attached to the site object.

    Thoughts on how to track scheme for a site:

    • Tickets: #14172
    • chat log
    • @johnbillion agreed that `wp_blogs` seemed like the right place to track scheme. We’ll need to worry some about the upgrade process, though larger networks should be able to handle something like this.
    • Some more discussion on the ticket would be great. We should get a patch going sooner than later. This is up for grabs, claim it in the comments! :)

    More flows for Make/Flow:

    • chat log
    • @ubernaut is almost done with iPhone 5s videos.
    • @johnbillion mentioned trying some recordings with Android.
    • @jeremyfelt is still claiming that he’ll do an iPad capture one night.
    • We need to get more of these up on Make/Flow to capture a good visual record. As they go up, please create tickets for things that look off. Even if you haven’t posted a flow of your own, please browse through the existing ones and look for issues.

    Thanks to everyone in office hours today! Chime in with any comments, tickets, etc… or join us in #core-multisite. :)

     
  • Nick Halsey 3:53 pm on May 25, 2015 Permalink |
    Tags: , ,   

    Customize Component Update – 5/25/15 

    The Customizer team has been busy working on some major user-facing and behind-the-scenes changes targeting WordPress 4.3. This update will provide an overview of our goals, current status, and pathways for contributors to get involved.

    We’re planning on holding an extra meeting in #core-customize at 5pm PDT today, 5/25, (May 26, 00:00 UTC) to discuss progress and assignments/plans for the coming week-plus before the feature-plugin merge window opens. This time won’t work for our European contributors but hopefully more of us can make it than can make the old Friday time. (cc @westonruter, @valendesigns, @voldemortensen, @ocean90, @folletto).

    Redesigned Customizer Flow/UX

    Customizer mobile flow redesign walkthrough gif

    New Customizer flow introduced in #31336, on a mobile viewport with a recent (not latest) patch.

    #31336 introduces a re-imagined Customizer experience that clarifies the flow, distinguishes navigation from control UI, and improves design through careful adjustments to colors, contrast, and spacing. The primary changes are centered around removing the accordion UI in favor of panel-like horizontal sliding for sections, allowing us to introduce consistent headers across panels and sections to build on the work that was started in 4.2 with the new themes section. Design work for this change was started at the end of 4.0 last August, and @folletto has continued refining the flows since then while I’ve done most of the patching work.

    At this stage, we’re trying to get a first-pass patch committed as soon as possible as it’s holding up some of our other priorities including #30737 and Menu Customizer work. We need help testing the patch on different browsers & devices, as well as for any further usability feedback. Once the initial patch is committed, it will be easier to contribute via additional smaller patches.

    In addition to this broad UI/UX change, we have several other proposed UI changes being considered for 4.3. Icons for Customizer sections and panels are ready to go pending feedback ( #28504). If time allows and there is enough interest, we could also potentially introduce an improved collapsed mode ( #29949) and device-size preview for the Customizer preview ( #31195) in 4.3. We may also do a full accessibility audit and make fixes accordingly later in the release, per recent discussion on #31336.

    Menu Customizer

    I just pushed version 0.4, which includes:

    • In-Customizer previewing of “original” menu item links
    • A redesign of the screen options popup
    • The addition of theme location checkboxes within menu sections (which fully cross-sync with the menu locations section)
    • Theme locations listed within menu section names
    • Menus can only be deleted when they aren’t assigned to any locations
    • Available menu item searching, and a first-pass redesign of the available menu items panel to match the new look for core in #31336 (more to come here)
    • Integration of the existing theme location controls into the plugin
    • Also notable, I compiled a list of ~10 (and counting) core tickets that Menu Customizer fixes; most notably, #14134

    Big thanks to @valendesigns, @folletto, and @voldemortensen for helping out with these changes. We have several major issues to fix still, so please jump in on GitHub if you’re interested in helping out.

    Now is also the time for an extensive review process to begin on all fronts, so that we can address any issues in time to make core merge in just a few short weeks. We need several kinds of feedback:

    • General usability feedback
    • Usability testing
    • Accessibility review/feedback
    • Design/UI/UX feedback (test with #31336)
    • Inline documentation review (should be mostly there, but needs a thorough review and cleanup)
    • Code review/cleanup
    • Lead dev/committer review for additional issues

    Note that testing should be done with the Menu Customizer plugin and WordPress 4.3 alpha, and that the patch on #31336 is currently a dependency for everything design-related. The plugin can be tested on 4.2 right now, but some pieces of the UI may be a bit off, and we’ll be breaking 4.2-compat in the near future as critical dependencies are merged into core. The most urgent dependencies are #31336 and #30737 (both of which require updates in the plugin and prevent key functionality from working). #30738 and #30741 would be really nice to have, but we can more comfortably hack around those issues at the time of core merge if we have to.

    Partial Refresh

    @westonruter has finished integrating partial refresh into Menu Customizer (it already worked for widgets), and is now abstracting it one layer further to be available for general use via the API. Partial refresh is an in-between option for setting previewing between doing a full refresh of the preview and fully implementing setting changes in JS via postMessage; settings are previewed by refreshing only part of the preview window.

    Other Updates

    We’ve made some changes to our component page. Customize is no longer a sub-component of Themes (note the URL change). I also added a summary of our major projects over the past several releases, as well as a brief roadmap/wishlist for future-release projects, and a few routes for getting involved in contributing. @valendesigns and I also triaged the roughly-20 tickets needed a response yesterday, as well as triaging a good chunk of the enhancement tickets in the component that haven’t had activity in more then 4 months. @valendesigns has also stepped up as another component maintainer, joining @westonruter, @voldemortensen, and myself.

     
    • Emil Uzelac 4:26 pm on May 25, 2015 Permalink | Log in to Reply

      Great job all! I am personally super excited about the update 👍

    • Matthew 4:28 pm on May 25, 2015 Permalink | Log in to Reply

      Looks great!

    • Omaar Osmaan 4:47 pm on May 25, 2015 Permalink | Log in to Reply

      Awesome! Thanks for the hard works-

    • Ryan Boren 5:55 pm on May 25, 2015 Permalink | Log in to Reply

      Nice. I’m looking forward to using it.

      If you’re interested in testing, check out the core handbook. If applying and testing patches is too inconvenient, there is still plenty of testing to do once patches land. Once #31336 is committed, any site using the beta tester plugin to automatically update to the latest nightly build will get the new customizer ui. Between these daily core updates and the regularly updated customizer plugins mentioned in the post above, the latest 4.3 has to offer will be delivered to you daily. The customizer is an important interface. Many flows traverse it. We need to test it continuously on every device we have.

      Aside: Auto-update of feature plugins would make beta testing even easier. Auto-updates for core have been a valuable testing convenience.

    • jameskoster 6:47 pm on May 25, 2015 Permalink | Log in to Reply

      This looks great. One of the biggest complaints I see regarding the Customizer is the amount of scrolling required when there are lots of sections. It’s easy to become disoriented, this solves that quite elegantly!

      The other complaint I see a lot of the time is about the width. I wonder if it would be useful to allow the user to drag the Customizer edge to a width of their preference.

    • Shaped Pixels 8:45 pm on May 25, 2015 Permalink | Log in to Reply

      I’d like to try this out because there’s always room for improvements, and it sounds like there are some added here. I’ve just set it up and will check it out.

      As a side note, I’d like to see the Theme Changer, Widgets, Navigation, Header, Background, Site Title and Tagline, and the Static Front Page options removed and put back under “Appearance” and “Settings” because in my opinion, these really are not related to a theme’s “customizer options” setup. The customizer should be in place of using a third party theme options panel or one that is coded into a theme. Right now it seems like core WP settings are being thrown into the customizer on top of what a theme provides.

      Actually, what would be nice is to have add_theme_support(‘customizer’) if a theme needs it for it’s own options, otherwise leave it out.

      • Nick Halsey 9:03 pm on May 25, 2015 Permalink | Log in to Reply

        The purpose of the Customizer is to customize all aspects of a site, not just theme options. If you’d like your theme’s options to be consolidated to one place within it, I’d suggest using a panel and calling it “Theme Options” or something along those lines.

        In the future you’ll see menus (soon) as well as potentially a front-end-editing integration among other projects in the Customizer, with more of core moving there from the admin. The broader idea is than anything on the front-end should be able to be changed with the Customizer, with live-previewing functionality before publishing.

  • Konstantin Obenland 9:45 pm on May 20, 2015 Permalink |
    Tags: ,   

    Dev Chat Summary, May 20 

    Agenda, Slack log.

    Committers Update (#)
    @nacin
    New guest committers: @iseulde, @westonruter, and @obenland, renewed guest committers: @jorbin, @jeremfelt, permanent committers: @pento, @boone, and @johnbillion
    Also see https://make.wordpress.org/core/2015/05/20/new-committers-for-4-3/

    Editor (#)
    @azaozz@iseulde
    No update here. Will discuss goals for this week and next week outside of dev chat.

    Admin UI (#)
    @helen
    @helen is plugging away at some groundwork for the CSS roadmap, @stephdau should be taking a look at the first steps for list tables in the next day or so. Will discuss goals for next week in tomorrow’s UI meeting.

    Network Admin UI (#)
    @jeremyfelt
    They talked through aspects of the Edit Site and Add Site flows yesterday to help @hugobaeta with mock-ups. Hopeful to see a mock up of these soon. They have a couple flows in Make/Flow with more on the way. The 5s flow highlighted an issue with text inputs overflowing. There’s also an updated `WP_Network` patch.

    Things they want to have done by next week:

    • Android and iPad flows.
    • Conversation around updated `WP_Network` patch and a first attempt at `WP_Site`.

    Partial Refresh (#)
    @westonruter
    Now has support for refreshing menus changed by Menu Customizer: https://github.com/xwp/wp-customize-partial-refresh/pull/12/files
    It’s much simpler than partial refresh for widgets, and @westonruter thinks that maybe it could safely be on by default, instead of requiring opt-in as is currently done for widgets. The concern with on-by-default would be if menus get some dynamic behaviors added to them with JS, so maybe it’s just something that theme authors would need to account for.
    Also waiting on feedback and testing from the Menu Customizer, merging the corresponding PR for Menu Customizer, to then merge the PR for Customize Partial Refresh and do a new plugin release.

    Goals for next week: Take what was done for Menus and then abstract a level again to facilitate plugins easily adding their own partial-refreshing.

    Menu Customizer (#)
    @voldemortensen, @celloexpressions
    Lazy loading and error handling were committed. Will discuss goals for next week outside of dev chat.

    Better Passwords (#)
    @markjaquith
    They’ve been working on a mockup of the password UI: http://codepen.io/markjaquith/pen/GJjZbJ
    Probably best to create a temporary hook in core for the password-set UI in the profile, to allow the team to work on this as a plugin. @markjaquith can take care of that core change, and start the plugin on GitHub.
    #32428 is on hold until the Password UI is usable. @voldemortensen started work on expiring reset keys #32429, but hopes to get it showcase-able by the end of the week. @rmarks made a first pass at #32430 but it needs more work.

    Goals for next week:
    1. Hook in core to enable plugin for PW change UI.
    2. Working version of PW change UI on the Profile screen (that is, you can change your password with it… show/hide… back compat for the pw confirmation field… not promising the strength hint stuff yet).
    3. #32430 ready for commit.
    4. Working patch for #32429.

    Favicons (#)
    @johnbillion
    @johnbillion made a start on the site favicon manager. As discussed during dev chat last week and in #16434 it has an API so plugins/themes can register new sizes for favicons/touch icons/etc if the need arises. I’ll be pushed to a GitHub repo by tomorrow. The main thing that will need to be discussed is whether this should just be a customizer setting or not. @johnbillion will post about the repository location and meeting times on this blog.

    Other:
    @ocean90 is looking for feedback on #29783!

    Next chat will be on May 27 2015, 20:00 UTC

     
  • Konstantin Obenland 4:20 am on April 30, 2015 Permalink |
    Tags: ,   

    Dev Chat Summary, April 29th 

    Agenda, Slack log.

    Editor (#)
    @azaozz@iseulde
    Want to concentrate on mobile improvements, especially the toolbar, other buttons around the editor, and ajax saving. @iseulde will publish a list of all items they’ll work on. We will need to test on many mobile devices in couple of weeks, so please join them in the #core-editor Slack channel where they’ll also have weekly chats on Tuesday, 20:00 UTC.

    Admin UI (#)
    @helen

    1. Better responsive list tables – this involves some PHP-side API changes as well as UI work. The base thought here is that a narrow screened device is also often a mobile device, which may have limited bandwidth. That’s exactly the situation in which you don’t want to have to load more pages to see important information, and our current strategy of truncation is in direct conflict with that.
    2. Getting rid of media-new.php and exploring what a better list table+upload experience might be, both for JS and no-JS.
    3. Getting started on the admin CSS clean up roadmap @helen will be spinning up a kick off for that as well.
    4. Screen-by-screen sweep on touch and small screen devices, grabbing low-hanging fruit like “the spacing is off here” or “font sizes are inconsistent”.

    UI chats are going to be spun up again to further this effort, stay tuned for when and where.

    Network Admin UI (#)
    @jeremyfelt

    • Piggyback on other Admin UI improvements. The network admin often seems quite a bit behind everything else. Responsive list tables would be fantastic.
    • Start looking at network admin screens on mobile. There are many places where workflow can be reimagined. @boren has shared some great thoughts previously, let’s have more conversation around that.
    • It may be possible to start working on what a future site switcher would look like. Especially on mobile, providing context can be tough when working on a network of many sites.
    • #22383-core and #31240-core for nicer ways of creating and editing sites. Might lead to some domain/path validation, which could be useful elsewhere and help address older tickets.
    • Under the hood, significant progress on WP_NetworkWP_Site, WP_Site_Query, and maybe WP_Network_Query would be nice.

    @jeremyfelt will come up with a consumable list of 4.3 priorities by next week. Regular multisite office hours are Tuesday, 20:00 UTC in #core-multisite.

    Partial Refresh (#)
    @westonruter
    This greatly improves performance of previewing changes in the Customizer for non-postMessage transport settings (JS-applied changes) by just refreshing the area of the page that has been changed. As such it eliminates some of the need to do postMessage in the first place, while also reducing the amount of duplicated logic that would have to be implemented in JS to mirror what is being done in PHP. This resurrects some code from the old Widget Customizer feature plugin developed for 3.9. Writeup and feature plugin are available at https://wordpress.org/plugins/customize-partial-refresh/

    Customizer Transactions (#)
    @westonruter
    A low-level re-architecture of the Customizer plumbing that has a lot of side benefits and bugfixes, introducing some exciting possibilities for future feature plugins like scheduled settings, setting revisions, and drafted/pending settings. Partial Refresh is a dependency for this. Pull request available, but needs refresh. See proposal at https://make.wordpress.org/core/2015/01/26/customizer-transactions-proposal/. This was previously worked on for 4.2.

    Customizer office hours are on Friday, 18:00 UTC in #core-customize.

    Better Passwords (#)
    @markjaquith

    1. Make “user chooses own password” non-default. We can generate better passwords than they can, and writing as secure password down on a sticky note is in general more secure than memorizing a weak password. So the default should be “give me a new password”, and “let me choose” should be something they specifically choose.
    2. When the use is generating their own password, we should encourage strong passwords more forcefully. Right now we just have a meter. We don’t tell them why it’s “weak”. We don’t tell them how to fix that. Simple feedback like “too short — add more characters!”, “Try adding some numbers and symbols!”. Not only that, we could actually make the addition for them. Show them their password attempt with some additions that would make it better.
    3. In order to help the user modify their chosen password, we need it to be visible. If they click “hide”, they can input it hidden for an “over shoulder” situation. Also gets rid of the annoying “enter twice” thing.
    4. Let’s not send passwords via e-mail anymore, it’s insecure. We’re not getting around “full access to e-mail means you can reset”, but we can stop passwords from sitting around in e-mail accounts forever.

    Discussions will happen in #core-passwords. Time and day for regular meetings TBA.

    Open Floor (#)

    @jorbin has set up a Call for Tickets. Please feel free to add the tickets you want to work in the comments there.

     
    • tronic69 7:12 am on April 30, 2015 Permalink | Log in to Reply

      Because I have no invite for wordpress@slack I will write my comments for #core-passwords here. Maybe someone can move it to Slack.

      1) Making a system-generated password default looks like paternalism for me and many people 😉
      A lot of people use strong passwords and password safes (e.g. KeePass or Lastpass).

      2) It would be nice to have settings for password complexity (like which classes have to be used, 3 out of 4 classes).

      3) The reverse option would be better and more secure: password is invisible during input and then you can check no one is watching you before you click “show”!
      More and more Apps, browser extensions or website do it this way in the last months.

      4) I see here two well-known procedures which are known and used by users since years for password reset:
      A: A “one time password” (valid only some hours) is send to the user and he has to change it on next login.
      B: A “password reset link” is send to the user which allows just setting a new password and nothing else!
      Both ways should be valid only for some hours to secure only the user can check them quickly.

      Just my 2 cent 😉
      Tom

    • Ryan Boren 5:17 pm on April 30, 2015 Permalink | Log in to Reply

      Better passwords: I really like having show/hide, but it can interfere with password manager form filling since enabling show/hide changes the input type from password to text. Is there a way to show/hide that gets along with password manager password filling?

      https://discussions.agilebits.com/discussion/24053/password-generator-doesnt-fill-new-password-on-wordpress-com-change-password-in

  • Drew Jaynes 5:44 pm on April 21, 2015 Permalink |
    Tags:   

    4.2 Scrub 

    We’ll be scrubbing report 6 in the #core channel on Slack in about 20 minutes at Tuesday 18:00 UTC 2015. Join us!

    @azaozz @dd32 @nacin @helen @sergeybiryukov @ocean90 @wonderboymusic @mark @johnbillion @jorbin @boone @jeremyfelt @pento

     
  • Morgan Estes 12:43 pm on April 19, 2015 Permalink |
    Tags: ,   

    WordPress Core Weekly 

    Howdy! Sorry, I dropped the ball last week so this week’s Weekly Roundup is a double issue — it covers April 4, 2015 [32003] to April 18, 2015 [32140].

    This week marks the release of RC1, which is the first release that many plugin authors and beta testers will test heavily. If you don’t already, now is a good time to check out the Alpha/Beta forums for any issues that crop up during this testing cycle.

    We’re only days away from the release of 4.2; let’s finish strong! 🏃👏 Here’s the rundown of recent changes:

    TinyMCE

    • Update to 4.1.9+. Changes:
      • Fixed bug where extra empty paragraphs would get deleted in WebKit/Blink due to recent Quriks fix.
      • Fixed bug where the editor wouldn’t work properly on IE 12 due to some required browser sniffing.
      • Fixed bug where formatting shortcut keys where interfering with Mac OS X screenshot keys. [32058] #31895
    • Disable the wp-autoresize plugin in iOS. All iframes there are already expanded to the height of the content document. [32095] #31937
    • Update the “Keyboard Shortcuts” modal. [32060] #29558
    • Fix our shortcuts on Mac, use Ctrl + Opt + letter. [32059] #29558
    • Use window.twemoji directly in the wpemoji plugin. Gives a chance to the browser to lazy load twemoji.js when reloading the page. [32142] #31901
    • Remove the empty paragraph that sometimes is left over after adding an image caption. [32141] #32003

    wpView

    • Remove selected views when inserting content but not when loading all content, and remove the ref. to the selected view node on resetting the views. [32140] #31998
    • Resize sandbox iframes on load. [32056] #31480
    • Empty the content in the timeout, so it doesn’t render iframes twice. [32022] #31669

    Build/Test Tools

    • During PHPUnit tests, don’t autodetect permalink structure during WP installation. [32139] #31994
    • Move the built media JS files up a directory to their previous location and naming convention. [32125] #31912 (see [31373])
    • Don’t reference underscore.js source map. [32065] #31477

    General/Misc.

    • WordPress 4.2-RC1 [32137] [32138]
    • Use HTTPS URLs for codex.wordpress.org. [32116] #27115
    • Explain all placeholders in translator comment, not just the first one. [32111] #31675
    • Ensure post title input is not shortened for non-public post types. [32071] #30968
    • Improve handling of incomplete From and Content-Type headers in wp_mail(). [32070] #30266
    • wpLink: always show the URL field at the top. [32017] #28206
    • Force default avatar for HiDPI avatars on Discussion Settings. [32129] #31972

    Translation and Strings

    • Merge strings that describe the same command. [32078] #31776
    • Update placeholder for FTP credentials. [32077] #31922
    • After [31941], use the decoupled strings from wp-admin/network/themes.php in wp-admin/network/site-themes.php as well. [32029] #28502
    • Correct grammar when referring to “a user” vs “an user” in several places. [32025] #31894

    Administration

    Emoji and Smilies

    • Tweak which smiley matches which emoji. [32105] [32107] #31709
    • Update our few remaining smilies to better align with Twemoji, and add frownie.png until Twemoji provides a build containing it. [32104] #31709
    • The emoji JS files should be run through the script_loader_src filter, as they would be if they were registered scripts. [32097] #31938
    • Tidy up the wp_encode_emoji() regex, and clarify the function comment on Unicode 8 support. [32096]
    • Remove an errant / in Twemoji URLs. [32024] #31893
    • Remove executable bit from smilies. [32109] #31709

    Themes

    • Twenty Fourteen: update editor styles to better account for adaptive images in small screens. [32094] #31934
    • Twenty Fifteen: update editor styles to better account for adaptive images in small screens. [32090] #31934
    • Theme Compat: Make string translatable and add translator comments. Added in [31941]. [32084] #28502, #31921
    • Move initialization of $customizeSidebar to api.ThemesSection.initialize() to prevent cases where the result can be undefined. [32119] #31793
    • Translator comment should just reference placeholder numbers, not the actual placeholders. [32112] #31675
    • Tell developers how to correctly silence register_sidebar() notices. [32110] #31675

    Customizer

    Theme Switcher

    • Fix some esoteric breakage in iOS Safari. [32103] #31794
    • Don’t deactivate section on empty search results. [32083] #31889
    • Remove “Add New” reference from customize-controls.js. [32004] #31837
    • Use text input for the search field to prevent double tap issues for Preview and Customize buttons on iOS. [32127] #31794
    • Don’t re-render a theme control if it has already been rendered.
    • Lazy load theme screenshots. [32088] #31793
    • Fix tabbing order if section is open. [32087] #31289
    • Fix preview URL for subfolder installs. [32086] #31896

    Shiny Updates

    • Disable shiny updates from modal based on parent window [32082] #31739
    • Fix logic for details based shiny updates. [32080] #31739
    • Disable modal initiated shiny updates on wp-admin/update-core.php. [32067] #31739
    • Use dashes instead of dots as separator for jQuery events in shiny updates . is used for namespaces, so better to use dashes. [32063] #31819
    • Trigger events upon the completion of a shiny update. [32061] #31819
    • Remove Shiny Bulk Updates. Bulk updates don’t need to be ajaxified so let’s revert. [32053] #31770, #29820
    • Conditionally add AYS to leaving shiny updates. [32052] #31769
    • Enable users to initiate a shiny update from plugin detail modal. [32062] #31739

    Media

    • Don’t allow whitespace-only image captions from the Media modal. [32079] #21848
    • Fix focus and selected state for the selected attachments set. [32072] #31898
    • Rename get_media_embedded_in_content_allowed filter tomedia_embedded_in_content_allowed_types. [32113] #26675
    • Bring back spinners, now without bouncing select elements. [32101] #22839, #30725
    • Fix the media modal Insert into post button on narrow screens by limiting the width of .media-toolbar-primary and .media-toolbar-secondary only inside .attachments-browser (the top toolbar). [32121] #31908
    • Insert from URL: Make sure the link text is actually used. [32055] #29476
    • Make sure the spinner in the media modal is visible on narrow screens (without affecting the media grid). [32120] #30725

    Build Tools

    • Don’t override minified libraries included in core. [32066] #31477

    Docs

    • Remove unnecessary inline @see tags from a variety of parameter and return descriptions in wp-includes/wp-db.php. [32050] #31888
    • Remove unnecessary inline @see tags from the wpdb::process_field_charsets()DocBlock. [32049] #31888
    • Add a missing return description for has_header_image(). [32048] #31888
    • Fix a variety of inline documentation syntactical issues in wp-includes/taxonomy.php. [32047] #31888
    • Add a missing @access tag to the DocBlock for the WP_Meta_Query->$clauses property. Also adds a missing return description for WP_Meta_Query::get_clauses(). [32044] #31888
    • Add a variety of missing descriptions and fix syntax for wp_scripts(),_wp_scripts_maybe_doing_it_wrong(), and wp_script_add_data(). [32040] #31888
    • Remove an unnecessary inline @see tag and document the $wpdb global in two WP_Comment_Query methods. [32038] #31888
    • Add missing parameter and return descriptions to WP_Customize_Widgets->filter_customize_dynamic_setting_args(). [32036] #31888
    • Add parameter and return descriptions for WP_Customize_Widgets->get_setting_type(). [32035] #31888
    • Add missing @access tags to two DocBlocks in WP_Customize_Setting. [32034] #31888
    • Document the $theme property in WP_Customize_Themes_Section. Also adds a missing@access tag to the DocBlock for WP_Customize_Themes_Section->render(). [32033] #31888
    • Cleanup DocBlock syntax, add a missing parameter description for WP_Customize_Manager->set_post_value(). [32031] #31888
    • Add inline doc syntax fixes for WP_Customize_Manager->doing_ajax(). Also adds a return description. [32030] #31888
    • Add documentation for the $type and $theme properties in WP_Customize_Theme_Control. Also add some missing @access tags to various DocBlocks. [32028] #31888
    • Fix description alignment for the category_css_class filter docs. [32026] #31888
    • Add documentation for the $type, $mime_type, and $button_labels properties in WP_Customize_Media_Control. [32023] #31888
    • Clarify the DocBlock summary and parameter description forwp_edit_attachments_query_vars(). [32019] #31888
    • Add proper descriptions for the @global and @param tags in the wp_media_attach_action() DocBlock. [32018] #31888
    • Clarify the DocBlock description for wp_print_request_filesystem_credentials_modal(). [32016] #31888
    • Clarify 4.2.0 changelog entry, add global description to the DocBlock for WP_Users_List_Table->single_row(). [32015] #31888
    • Add missing @since versions from a variety of methods in WP_Press_This. [32014] #31888
    • Add missing DocBlocks for the _limit_array(), _limit_string(), _limit_url(),_limit_img(), _limit_embed(), and _process_meta_entry() utility methods in WP_Press_This. [32013] #31888
    • Add a return description to the DocBlock for WP_Posts_List_Table->is_base_request(). [32009] #31888
    • Add an @see mention for Plugin_Upgrader, plus spacing to the wp_ajax_update_plugin()delcaration. [32006] #31888
    • Add a more descriptive function summary for options_discussion_add_js(). [32005] #31888
    • Fix Docblock syntax for the taxonomy_parent_dropdown_args filter. [32003] #31888
    • Add a missing return description for wp_styles(). [32041] #31888
    • wp_install_maybe_enable_pretty_permalinks() should have a consistent @return value. [32027] #6481, #31888

    Help/About

    • All strings are available for translation. [32132] [32135] [32136] #31929
    • Change the subhead strings on credits.php and freedoms.php to match about.php.
    • Link the Emoji Codex article in the emoji blurb.
    • Add a second sentence to the JavaScript Accessibility blurb.
    • Switch positions for the JavaScript Accessibility and Complex Query Ordering sections for balance. [32131] #31929
    • Update about page for 4.2. [32118] [32123] [32130] #31929

    Upgrade/Install

    • Move wp-plugin-update-success event to after lock is released [32133] #31978, #31819
    • Use named function instead of anonymous function, making it testable and replaceable. [32126] #31964
    • When dbDelta() is checking whether an index is defined in a CREATE TABLE statement, don’t worry if MySQL has a subpart defined on an index, but the CREATE TABLE doesn’t. [32108] #31869

    Script Loader

    Press This

    • Do not show the bookmarklet upgrade notice when accessing directly press-this.php. [32122] #31968
    • Add mb_strlen() compatibility function. Works the same way as the existing mb_substr() compatibility function. [32114] #31951
    • Check the bookmarklet version and add the update notice from PHP. [32106] #31942
    • Add ARIA attributes to the alerts container. [32102] #31942
    • Fix focusing the Standard Editor link after saving draft, if the user has not focused another element. [32098] #31923
    • Change the link text to Standard Editor. [32093] #31923
    • When saving a draft change the text of the Save Draft button to “Saving…” [32092] #31923
    • Update documentation for press_this_save_redirect filter after [31992]. [32143] #31996

    Taxonomy

    • wp_update_term() should check if get_term() returned null. [32117] #31954
    • Avoid an unexpected object error when syncing global terms. Pass the expected single value, rather than object, when recursively calling global_terms(). [32064] #31914, #31149

    Editor

    Thanks to @adamsilverstein, @afercia, @awbauer, @azaozz, @boonebgorges, @DavidAnderson, @dimadin, @dlh, @DrewAPicture, @ericlewis, @hauvong, @helen, @hugobaeta, @iseulde, @jamescollins, @jeremyfelt, @joemcgill, @joen, @johnbillion, @jorbin, @kraftbj, @lancewillett, @markjaquith, @mattheu, @Michael-Arestad, @mindrun, @morganestes, @nacin, @nitkr, @obenland, @ocean90, @pavelevap, @pento, @peterwilsoncc, @samuelsidler, @SergeyBiryukov, @siobhan, @sirbrillig, @slobodanmanic, @swissspidy, @tmatsuur, @Tmeiste, @tyxla, @valendesigns, @westonruter, and @wonderboymusic for their contributions!

     
  • Drew Jaynes 10:00 am on April 13, 2015 Permalink |
    Tags: ,   

    This Week in 4.2: April 13 – 19 

    This is the jump-start post for the thirteenth week of the WordPress 4.2 release cycle.

    Last week, we missed tagging RC1 after losing momentum on our ticket goals toward the end of the week. We also missed hitting the “hard” string freeze.

    Core Meetings this week:

    Priorities this week:

    Committers: please follow up on any tickets you own. We’re running out of time to hit our release date goal. We need to freeze strings and actually tag RC1, in that order, as soon as possible

    Remaining tickets on Report 6 that must be closed or punted to tag RC1 are as follows:

    • #26111wp_localize_script array from callback for performance
      The recommendation is for @wonderboymusic to revert [31030] and [31033] and regroup in 4.3.
    • #31793Theme Switcher: Lazy load theme screenshots
      Waiting for a followup from @westonruter on the latest patch
    • #30725Add media modal – different select width
      Looking for direction from @helen on what an MVP fix would look like
    • #31794Theme Switcher: Improve mobile experience
      Latest patch needs to be reviewed and committed, and we should decide if the rest is worth tackling in 4.2.
    • #31908Insert into post button runs off the side of the screen on small devices
      The recommendation is to commit the latest patch and handle #30725 following that
    • #31912Media splitting: don’t copy the media folder to the build directory
      The latest patch from @ocean90 needs to be reviewed and committed by either @wonderboymusic or @jorbin
    • #319294.2 About Page
      The initial patch needs to be committed so we can keep design separate from content. The About page strings need to be finalized in order to institute “hard” string freeze. @melchoyce and @ryelle are in the process of engineering and designing around the content

    Recent notable updates:

     
  • Pascal Birchler 11:18 am on April 4, 2015 Permalink |
    Tags: ,   

    WordPress Core Weekly 

    Here we go again! It’s time to look at what’s going on in WordPress core. This edition of WordPress Core Weekly covers March 28, 2015 [31916] through April 4, 2015 [32002].

    Note: If you want to write the next WordPress Core Weekly summary, check out the schedule over at make/docs and get in touch in the #core-weekly-update Slack channel.

    Highlights from this week

    This week WordPress 4.2 Beta 4 got released. This hopefully last beta saw lots of accessibility improvements and added the ability to make admin notices dismissible. Emoji support in core is now pretty stable – maybe the next weekly post is written in emojis only? Also, there were some notes posted on utf8mb4 and the term splitting in WordPress 4.2.

    Last but not least, @obenland and @wonderboymusic were announced as release leads for WordPress 4.3 and 4.4, respectively. Congrats! 🎉

    Code Updates

    Posts, Post Types

    • After [31114] and [31323], ‘View Post’ generated in get_sample_permalink_html() should go to pretty permalink. [32002] #30910
    • Avoid duplicate classes for different terms with UTF–8 slugs in post_class() and body_class(). [31979] #30883
    • In WP_Posts_List_Table::get_views(), don’t add the current class to the all status link if ->user_posts_count has a value, which triggers the additional mine status. [31959] #24869

    Users

    • WP_User_Query: When querying users with fields=all, ensure that caps and roles are filled for the current site. [32001] #31878
    • When updating the email address for an existing user, make sure the email address is not already in use. [31963] #30647

    Comments

    General

    Emoji

    • Enhance twemoji.js to support passing of additional attributes for the replacement images. [31948] #31627
    • When encoding emoji into HTML entities, 0 was being incorrectly trimmed from the right side of the hex string, causing some characters to be encoded incorrectly. [31926]
    • When staticizing emoji into <img> tags, include an alt attribute of the original Emoji, to match both Smiley and Twemoji <img> tags. [31924]
    • Change the emoji CDN to w.org, from wp.com. [31938][31977] #31651

    Themes

    • Accessibility improvements for Themes screen: fix keyboard events and callbacks for the Search field, increase trigger timeout a bit, improve Esc. key handling. [31994] #26600
    • Improve focus styling of add-new-theme link. [31952] #31203
    • Add a filter to short-circuit wp_prepare_themes_for_js(). [31943] #31789

    Administration

    • Accessibility improvements for Options general screen: add missing labels and aria attributes. [31993] #31144
    • Accessibility: Add landmark roles to WordPress admin areas. [31955] #31450
    • Make sure the update button in “At a Glance” dashboard widget does not overlap with long strings. [31928] #30766

    Press This

    • Prevent pasting of HTML in the title H2. Insert the clipboard text instead. [31987] #31768
    • Use more accurate wording on Tools screen. [31980] #31836
    • Use the error message returned by wp_update_post() instead of a generic one. [31930] #31808
    • Fix accessibility for the post options “sidebar”. Fix size of the Add Category button. [31925] #31575

    Upgrade/Install

    • Introduce a string representing bulk plugin update success, ready for string freeze. Not used yet. [31991] #31770
    • Plugins Browser: Replace the download count with the number of Active installs of the plugin. [31990] #31865
    • Add beforeunload string for shiny updates. [31989] #31769
    • Update aria-label when doing a shiny plugin update [31982] #31722
    • Add some logic into wp_tempnam to prevent it creating ‘falsey’ directory names that might get used elsewhere within WordPress. [31936] #31811

    I18N

    • Merge title strings on Edit Site screens. [31962] #31844
    • Remove unused printf() on network setup screen. [31961] #31841
    • Decouple strings where the singular and plural form are not just the same string with different numbers, but essentially two different strings. [31941][31951] #28502

    Customize

    • Theme Switcher: Navigation streamlining. [31975] #31289
    • Theme Switcher: Remove “Add New” references. [31968] #31837
    • Theme Switcher: Switch the details/live preview buttons. [31954] #31791
    • Theme Switcher: Use the global panel back button instead of adding a new one. [31918] #31794
    • Theme Switcher: Fix invalid HTML markup when New Theme control is added. [31950] #31203
    • Make the available widgets overlay closable on narrow screens. [31974] #28784
    • Defer rendering theme controls until the section is displayed. [31944] #31793
    • Revert [31911]. We want to preserve url and return URL parameters to make the experience smoother. [31933] #31782
    • Increase size of search field and disable text size adjustment to prevent auto zooming. [31917] #31794
    • Increase initial-scale viewport specification to 1.0. [31921] #31794, #28784
    • Fix selector for container which includes the controls. Broken since [30102]. [31916] #31794, #31014

    XML-RPC

    • Correctly set the post author in wp_xmlrpc_server::mw_editPost() when the current user is not the author of the post. [31983] #24916

    Networks and Sites

    Administration

    • Admin notices: Make (most) core notices dismissible. These no longer return upon refreshing the page when JS is on and working, so users should be able to dismiss them. [31973] #31233, #23367

    Bundled Theme

    • Twenty Eleven: add postMessage support for header_textcolor to improve the user experience in the Customizer. [31971] #24128
    • Twenty Fifteen: adjust scroll behavior to make sure sidebar height is calculated during scroll events, not just resize events. [31934] #31734
    • Twenty Thirteen: make sure submenu links work correctly on small screens with touch events. [31932] #31762

    Formatting

    • Alter the regex in wptexturize() to properly handle input like: <> "Hello world" <>. [31965] #30344

    Permalinks

    • When shifting WP_Rewrite::flush_rules() to a later action if it was called too early, make sure to do a hard flush if requested. [31964] #30501

    Media

    • When editing an image from the editor, and the image has a value for alignment (but not for width or caption), don’t bail without first checking that the alignment’s value is not alignnone. If so, add the class to the <a> before bailing. [31958] #21848
    • Media Library: Add a label for attachment type select in list mode. [31942] #31795

    Editor

    Database

    • When we check the character set of a column, and find that it’s utf8mb4, we should also check that the current connection supports utf8mb4. It’s possible that the environment may have changed since upgrading the DB, so we can fall back to utf8 when that happens. [31947] #31771
    • When we’re checking to see if the MySQL client library supports utf8mb4, we need a separate check for mysqlnd versions, which using different version numbering to libmysqlclient. [31939] #31644

    Login and Registration

    • Disable body scrolling when session expired log in modal is open. [31945] #31610

    Media

    • Revert using require for JS modules because that made them read-only for the public. [31935] #31684, #28510

    Menus

    • Fix duplicate ID for Save Menu button on Menus screen. [31927] #31803

    Thanks to @A5hleyRich, @adamsilverstein, @afercia, @azaozz, @boonebgorges, @cdog, @celloexpressions, @davideugenepratt, @dd32, @deconf, @Denis-de-Bernardy, @designsimply @dllh, @DrewAPictur, @DrewAPicture, @ericlewis, @evansolomon, @folletto, @helen, @iseulde, @jeremyfelt, @joedolson, @johnbillion, @jorbin, @jorbin, @kraftbj, @lancewillett, @markoheijnen, @mattheu, @mattwiebe, @MattyRob, @mehulkaklotar, @MikeHansenMe, @miqrogroove, @mordauk, @mrahmadawais, @ocean90, @paulwilde, @pento, @ramiy, @redsweater, @rittesh.patel, @sagarjadhav, @SergeyBiryukov, @sgrant, @stephdau, @swissspidy, @tyxla, @valendesigns, @westonruter, and @wonderboymusic for their contributions!

     
  • Drew Jaynes 6:05 pm on April 1, 2015 Permalink |
    Tags: ,   

    Dev Chat Agenda, April 1, 2015 

    Here’s the agenda for Wednesday’s Dev Chat in the #core channel on Slack.

    • Beta 3 was tagged last week as scheduled and we’re heading toward tagging Beta 4 this week.
    • The soft string freeze is targeted to coincide with tagging Beta 4 this week, so we need to wrap any tickets with string changes (save for the About page).

    Time/Date: Wednesday 21:00 UTC 2015:

    DST reminder: The dev chat time has moved up an hour to 20:00 UTC following the European DST change.

    Agenda

    1. Congrats if you got ’em for @obenland and @wonderboymusic, release leads for WordPress 4.3 and 4.4!
    2. Task/Enhancements Review [List]
    3. String Ticket Scrub [List]
      One string:

      • #29958 – collapse menu keyboard accessibility
      • #31233 – Dismissable admin notices
      • #31769 – Prevent navigating away while plugins are updating via shiny updates
      • #31836 – Press This: Clean up text on tools.php

      Two or more strings:

      • (2) #31144 – Options general screen, accessibility improvements
      • (2) #31770 – Better feedback after bulk updating plugins via shiny updates
      • (3) #31722 – Shiny Updates: the aria-label should be updated to reflect the current status

      Various string changes:

      • #26600 – Search installed themes input has no submit button – New help text, one string split into two, new strings
      • #31832 – Add an Emoji section to the Help tab on post edit screen – New help text, replaced string
      • #27115 – HTTPS links to wordpress.org – Strings adjusted for links, may not need re-translating

    No Open Floor this week – Due to time constraints, we won’t be holding an open floor period during the regularly-scheduled dev chat this week. If you have a ticket on the 4.2 milestone you’d like to get dev feedback on, leave a note in the comments.

    Testing Stages Progress
    • Beta 1
      • Punt/convert all non-essential enhancements to tasks
    • Beta 2 (120 tickets on Report 6)
      • Get first run of FTP credentials modal in trunk
    • Beta 3 (90 tickets on Report 6)
      • Start finishing up tickets with string changes
      • Start About page
    • Beta 4 (50 tickets on Report 6)
      • Soft string freeze (all string changes completed save for the About page)
      • Start finishing up the About page
    • RC 1 (0 tickets on Report 6)
      • About page finished
      • Hard string freeze
     
  • Pascal Birchler 9:48 am on March 28, 2015 Permalink |
    Tags: ,   

    WordPress Core Weekly 

    Hi Everyone!

    It’s time for another run-down of what’s going on in WordPress core. This edition covers March 20, 2015 [31845] through March 28, 2015 [31915].

    If you want to write the next WordPress Core Weekly summary, check out the schedule over at make/docs and get in touch in the #core-weekly-update Slack channel.

    This week’s highlight is WordPress 4.2 Beta 3, which was released on Thursday. There were many accessibility and emoji improvements and bug fixes. Also, shiny installs functionality was removed.

    I18N

    • Improve newly added strings for i18n. [31905] #31776
    • Remove <code> tags from translatable strings. Uncomment deprecation notice for get_bloginfo( 'text_direction' ). [31899] #30614

    Customize

    • Theme Switcher: Opening themes details modal shouldn’t require two clicks on touch devices. [31914] #31794
    • Theme Switcher: Reset font size of theme names in overlay. Apply left position only to themes section. [31892] #31303
    • Theme Switcher: Don’t hide action buttons on narrow screens. [31912] #31794
    • Use proper preview URL for Live Preview links. [31911] #31782
    • Avoid SecurityErrors when the Customizer is embedded in an origin other than wp-admin. [31885] [31893] #31687
    • Use responsive button styles if screen is max-width 640px. [31913] #31794, #28784

    Emoji

    • [31864] changed emoji image’s inline style from height to max-height. Unfortunately, anything using feedparser.py (for example, NewsBlur) strips out max-height, which gives us massive emoji in feeds. This re-adds height, and also reminds us why we can’t have nice things. [31909] #31719
    • When we’re replacing emoji with <img>s in email, we can only do that if the Content-Type is text/html – otherwise, they’ll show up in the email as the HTML string. [31860] #31720
    • Instead of loading the emoji JS files automatically, we now include a small JS shim in the header, to test if the user’s browser needs Twemoji. It then loads the emoji JS files only if they’re needed. [31875] [31877] [31879] #31701
    • Set the emoji image protocol with set_url_scheme(), instead of defaulting to HTTPS. [31861] #31735

    Press This

    • Remove role="application" from the Categories list wrapper. This doesn’t make it work better in screen readers. [31907] #31443
    • On sites that support oEmbed, if the user has selected some text, quote it below the embed. [31894] #31763
    • Fix the links on inserted images to point to the source site. Fix inserting of images above the blockquote when the editor has not been focused. [31868] #31745

    Upgrade/Install

    General

    • Remove ambiguity in the time display format in core, switches to using 24hr notation where am/pm isn’t specified. [31862] #31121
    • Comments List: Don’t let “Quick Edit” break on smaller screens. [31889] #31482
    • Admin menu: Revert [31720] for swipe open/closed. This is problematic on any device that uses swipe for history navigation, particularly iOS. [31910] #31187
    • Do not output empty name and id HTML attributes in get_submit_button(). [31880] #31749
    • When altering the admin URL to reflect the canonical location, keep the existing hash (if present) in the URL. [31882] #31758, #23367
    • WordPress 4.2-beta3 [31902] [31903]

    Taxonomy

    • When saving post, ensure that non-hierarchical taxonomy input is defined before attempting to parse it. [31895] #30859
    • Taxonomy List Tables: On mobile devices, hide the slug column, to avoid cramping the action links into two rows. [31865] #29992
    • Supplement hook documentation for the get_terms_fields filter to more clearly explain the expected consequences of using it to modify the fields to select in a terms query. [31855] #31174

    TinyMCE

    • Make sure the editor is not completely empty before checking if the user clicked above or below a wpView. [31888] #31765
    • Pad empty paragraphs with <br> in Chrome to stop it from inserting non-breaking spaces in them. [31878] #31255
    • Fix error and PHP warning when adding more than one instance in RTL mode. [31874] #31578
    • Fix the icon for the wp_code button. [31858] #31733
    • When pasting an URL, check if the node it is pasted at is empty and remove any empty inline child elements. [31856] #31158

    Script Loader

    • Avoid a PHP notice in wp_enqueue_script() if $handle is an array. Calling wp_enqueue_script() with an array as the first argument is a “hidden feature” and should be avoided. Use dependencies instead. [31887] #31636, #14488

    Widgets

    • Text Widget: Use !empty() for checking if the filter setting is set. [31886] #31690
    • Trigger _doing_it_wrong() if register_sidebar() is not passed an id. [31850] #31675

    Login and Registration

    • Implement an aria-describedby attribute for login screen errors, and improve the “Forgot password?” anchor text. [31871] #31143

    Media

    • Introduce attachment_url_to_postid filter to let plugins manage the uploads location better. [31867] #31717
    • Show filename instead of extension in the list table. [31857] #30943

    Bundled Theme

    • Update editor styles to better display images and captions in small screens. [31849] #31250

    Build/Test Tools

    Thanks to @A5hleyRich, @afercia, @aferica, @atimmer, @azaozz, @boonebgorges, @Cheffheid, @dd32, @dkotter, @DrewAPicture, @ericlewis, @extendwings, @HarishChaudhari, @helen, @ianmjones, @iseulde, @jacklenox, @janhenckens, @johnbillion, @johneckman, @jorbin, @kraftbj, @lamosty, @lancewillett, @magicroundabout, @maimairel, @markjaquith, @mattheu, @mattwiebe, @MikeNGarrett, @nerrad, @obenland, @ocean90, @pento, @ramiy, @rianrietvel, @SergeyBiryukov, @sorich87, @stephdau, @swissspidy, @tschutter, @tyxla, @valendesign, @valendesigns, and @westonruter for their contributions!

     
    • Piet Bos 10:27 am on March 28, 2015 Permalink | Log in to Reply

      There is another open ticket for Emojis and that is #31651 with the request to switch the CDN from the .com domain to the .org domain

c
compose new post
j
next post/next comment
k
previous post/previous comment
r
reply
e
edit
o
show/hide comments
t
go to top
l
go to login
h
show/hide help
shift + esc
cancel
Skip to toolbar