WordPress.org

Make WordPress Core

Updates from June, 2015 Toggle Comment Threads | Keyboard Shortcuts

  • Konstantin Obenland 8:58 am on June 11, 2015 Permalink |
    Tags: ,   

    Dev Chat Summary, June 10 

    Agenda, Slack log.

    Menu Customizer Status Update (#)
    @westonruter
    The a11y review did not unveil any blockers, although it wasn’t done on the feature branch the team is currently working on. Introduction of a blocker there was deemed unlikely however. A new plugin version can’t be released since it’s now dependent on some core patches being applied.

    For the rest of the requirements: The biggest blockers are almost complete, Customizer setting re-architecture and sub-menu drag & drop. The settings re-architecture has been integrated into JS for the nav menu items, allowing nav menus to be edited, added, removed all with 100% previewability and not making any changes to the DB. Once Save & Publish is done, any newly created nav menu items get inserted at that time. Same goes for nav menu deletion. The submenu drag & drop has been merged into the same branch and it is all working together now.

    The biggest outstanding pieces are:

    • adding back the ability to add/remove entire menus
    • updating keyboard-accessible reordering to work with new menu settings
    • more unit testing for PHP, and write tests for JS

    Estimated time of completion is June 11, which leaves 5 – 6 days to merge.

    Admin UI (#)
    @helen
    Even more prep work has gone into list tables, now working on the responsive part on #32395. They have gotten some feedback so far, would love more even on the rough cuts. Helen will be at wordcamp philly’s contributor day this weekend, looking to knock through a bunch of the low hanging fruit on the screen sweep spreadsheet, and find takers for some make-flow tickets (#29906 in particular). She has some catch up to do with other contributors on visual regression testing and media-new, which will happen at tomorrow’s meeting.

    Network Admin UI (#)
    @jeremyfelt

    Objectives from last week:

    • #32434 is in. Jeremy is still poking at #22383 and #32503 with a target of this evening.
    • They had no additional iterations on WP_Network and WP_Network_Query, but @jjj is working on having something this week.
    • Did not yet generate discussion around HTTPS. Moving this objective along to this week.
    • They made quite a bit of progress with flows. @kraft added Nexus and @earnjam has iPad screencaptures he will be publishing shortly. Their next push is to start creating tickets. Jeremy wrote a post to try and drum up support – https://make.wordpress.org/core/2015/06/05/help-test-and-capture-the-network-admin-ui/ – and they had a handful of people hop in. Pretty optimistic that they’ll start making progress here, especially with a couple contributor days this weekend.

    Objectives for this week:

    • New tickets to address found issues in flow. These issues logged in the screen sweep spreadsheet.
    • Iterations on WP_Site and WP_Network. Discussion around iterations.
    • #22383 and #32503 committed.
    • Write post, generate discussion around HTTPS in multisite.

    Better Passwords (#)
    @markjaquith
    Mark turned the plugin into a patch for the new UI. After a cleanup, that can land, and we can iterate a bit, as well as tackle the new user password flow, which is different. The expiration of reset links (#32429) needs testing (human and unit), before that lands. And the “notify users of password and email changes” patch (#32430) needs a review on the hooks in it. I’m not sure we’re passing the right things along. Like, email instead of the whole user array.

    Favicons (Site Icon) (#)
    @johnbillion
    There’s been a status update on make/core. It’s looking like #29211 would be a better approach to a reusable control with image cropping functionality. So John is wondering whether we should aim for 29211 for 4.3 and site icon for 4.4. On the topic of using the Customizer or not: much of the image cropping control for the header image is also used on the old header image screen (it’s mostly media library and ajax functionality), so it’s not necessarily tied to being a customizer control.
    Let’s meet today June 11 2015, 20:00 UTC to discuss what a good approach could look like.

    Next chat will be on June 17 2015, 20:00 UTC

     
  • John Blackbourn 2:29 pm on June 10, 2015 Permalink |  

    Site icon and image cropping controls 

    A couple of weeks later than intended, a brief update on the site icon functionality which has been touted as a potential feature for 4.3. The site icon functionality aims to provide an admin UI (via the Customizer, at least initially) for users to upload an icon which is then output as a favicon and associated touch icons, while also allowing themes or plugins to re-use the icon in other places as they see fit.

    The existing header image control in the Customizer (and its corresponding functionality on the old custom-header screen) provides a means for uploading a header image and then cropping it to the desired size. Unfortunately this control is fairly tightly coupled with the header image functionality, and therefore extending it for use with the site icon control has meant duplicating a lot of code.

    It’s looking more and more like #29211 should be tackled before the site icon functionality, in order to avoid this duplication and in order to allow other controls to provide a croppable image upload (such as for background images in #32403).

    Due to my limited availability to work on the site icon feature in the coming weeks, I think it would be worthwhile instead focusing on #29211 and the introduction of an abstracted control that supports image cropping, which can then be used for the site icon and custom background controls.

    The current non-working site icon feature plugin can be found in this repo on GitHub. It uses considerable code from the custom header image control. If someone wants to take that and run with it that would be great, or if someone wants to tackle #29211 instead, that would be great too.

     
    • Marko Heijnen 2:44 pm on June 10, 2015 Permalink | Log in to Reply

      I’m more then happy to help out. Image cropping etc is what I did before.

    • Greg Ross 2:48 pm on June 10, 2015 Permalink | Log in to Reply

      I spent quite a bit of time working on this problem when I built my OS Integration plugin (https://wordpress.org/plugins/os-integration/), but I didn’t integrate it in to the customize.

    • Ciprian 3:11 pm on June 10, 2015 Permalink | Log in to Reply

      Would this replace the Jetpack favicon feature? Would they be developed/maintained in parallel?

    • Mel Choyce 5:14 pm on June 10, 2015 Permalink | Log in to Reply

      Are there any plans to support .ico?

      • Samuel Wood (Otto) 5:45 pm on June 10, 2015 Permalink | Log in to Reply

        ICO files are somewhat difficult to do. Supporting them should be an optional thing, I think, not necessarily a blocker for implementing the underlying support for favicons as png-only to start with.

        A few ICO producing libraries were mentioned in #16434, and if something like this is created as PNG first, then adding on code to also save ICO files would not be difficult if the right library to do so can be found or created.

    • Nick Halsey 1:40 am on June 11, 2015 Permalink | Log in to Reply

      A note regarding #29211 – that was originally written before 4.1, when we redid the other core media controls. So the best approach would probably to make a cropped-image control that extends WP_Customize_Media_Control, using header images as inspiration, then update the header image control to leverage it. Header images no longer use the latest and greatest in the Customizer, so it’s worth a bit more of a rethink than generalizing their functionality I think.

    • imath 5:29 pm on June 23, 2015 Permalink | Log in to Reply

      Hi @johnbillion thanks a lot for your great work about this feature, i’ve been exploring the plugin on the github repo and just posted some suggestions into a pull request :)

  • Konstantin Obenland 5:59 am on June 5, 2015 Permalink |
    Tags: ,   

    Dev Chat Summary, June 3 

    Agenda, Slack log.

    Menu Customizer Merge Proposal (#)
    @westonruter, @celloexpressions
    We went through the feature plugin checklist and discussed if the plugin was fit for core. It was approved for merge, pending the following conditions:

    Items that should be done before merge:

    • Complete a11y audit.
    • Address possible blockers.
    • Merge php tests.
    • Add JS tests.

    Then with/after merge:

    • Killswitch for plugin.
    • An outline for a fieldguide post.

    Better Passwords (#)
    @markjaquith
    New password UI on Profile screen, via GH plugin. Generates and shows by default. Lets the user hide, or click into the field and type (in show/hide modes). Also, the strength meter has been more closely integrated. The color wraps around the field, and it is integrated as one “unit” instead of being this button-like thing that floats below it. Mark would like to get the current state turned into a patch and merged, as he thinks it’s a fine inflection point, even if the next steps aren’t ready in time.

    Admin UI (#)
    @helen
    Got a lot of a11y fixes in play for list tables. A fair number of small/low-hanging fruit issues being noted, which aren’t crucial to hit before beta, so they’ll keep focusing on the bigger items for now. They also started to sync up with #core-flow issues and getting those into the patch and review queue.

    Network Admin UI (#)
    @jeremyfelt
    Last week’s objectives and progress:

    • Wrap work on the edit site flow and MS sites list table and then take a look at the add site flow and validation in `update_blog_details()`. We made progress on the edit site flow and are nearing commit readiness for a few patches.
    • Continued progress on WP_Network, WP_Site, WP_Network_Query, and WP_Site_Query. We had quite a bit of discussion on the WP_Network ticket and in Slack. Not much ticket progress, but we’re doing good at continuing to pay attention.
    • More thoughts on tracking scheme in wp_blogs for sites. We discussed this in the meeting yesterday and need to do some more research on impact. There’s some info in the recap, but we’ll also have a call for info/thoughts soon.
    • More flows and network admin UI tickets from those flows. We have iPhone 5s flows from @ubernaut. We need to do more creating of tickets and generating of additional flows.

    Objectives for next week:

    • Have all 3 tickets related to the edit site flow closed and committed.
    • Additional iterations on WP_Network and WP_Network_Query. Please watch this.
    • Generate discussion around tracking site scheme. @jeremyfelt will gather a list of HTTPS related tickets and share.
    • Nexus (@kraft) and iPad (@earnjam) flows. Tickets created for bugs found in existing flows. Volunteers needed!

    And the recap has all the juicy details: https://make.wordpress.org/core/2015/06/03/multisite-office-hours-recap-june-2-2015/

    Favicons (#)
    @johnbillion
    Site Icon progress has been slow due to him being too busy, but he has a working implementation now which he will put up in a repo on GitHub tomorrow, then he’ll see about liaising with contributors to get feedback, and basically go from there.

    Next chat will be on June 10 2015, 20:00 UTC

     
  • Konstantin Obenland 6:21 am on June 3, 2015 Permalink |
    Tags: ,   

    Dev Chat Agenda for June 3 

    Here’s the agenda for today’s Dev Chat in the #core channel on Slack.

    Time/Date: June 3 2015 20:00 UTC:

    1. Consider the Menu Customizer plugin for merge [Proposal] [Plugin]
      If you haven’t looked at either of the merge proposals yet, please spend some time today before the meeting. Please comment on the post if you haven’t already.
    2. Feature Updates
      1. Admin UI – @helen
      2. Multisite Admin UI – @jeremyfelt
      3. Passwords – @markjaquith
      4. Site Icon – @johnbillion
    3. Component Updates (if time permits)

    Feature Leads: Let’s review last weeks goals and set new ones for next week.

    Recommended reading: Features as Plugins.

     
  • Konstantin Obenland 12:59 pm on May 27, 2015 Permalink |
    Tags: ,   

    Dev Chat Agenda for May 27 

    Here’s the agenda for today’s Dev Chat in the #core channel on Slack.

    Time/Date: May 27 2015 20:00 UTC:

    1. #32396: Settings Reduction for 4.3
    2. Feature Updates
      1. Admin UI – @helen
      2. Multisite Admin UI – @jeremyfelt
      3. Partial Refresh – @westonruter
      4. Menu Customizer – @celloexpressions / @westonruter / @voldemortensen
      5. Passwords – @markjaquith
      6. Site Icon – @johnbillion
    3. Component Updates

    Feature Leads: Let’s review last weeks goals and set new ones for next week.

     
  • Jeremy Felt 3:33 am on May 27, 2015 Permalink |
    Tags:   

    Multisite Office Hours Recap (May 26, 2015) 

    Multisite office hours are held every Tuesday at 20:00 UTC in #core-multisite.

    Today’s chat log

    Overall 4.3 Release Objectives

    Last week’s objectives for dev chat:

    • Continued work on mock-ups, discussion around edit site and add site flows.
    • Android and iPad flows posted to Make/Flow.
    • Conversation around and updated `WP_Network` patch and a first attempt at `WP_Site`.

    Today’s meeting agenda:

    • Arbitrary domain/path combinations. #22383 (and now #32434)
    • `WP_Network` #31985 and `WP_Site` #32450
    • Thoughts on how to track scheme for a site. #14172
    • More flows (and tickets) needed. :)

    Topic Details:

    Arbitrary domain/path combinations in edit site:

    • Tickets: #22383, #32434, #32503
    • chat log
    • @hugubaeta explored things some more and left some good feedback on #22383. We agreed to push ahead with the single entry for scheme, domain, and path in #22383.
    • During that discussion, we started to address the question of the checkbox for updating home and siturl. This resulted in #32503. After some further discussion there, we’re going to try removing that checkbox entirely and using some logic to determine when to update home and siturl. @earnjam is working on the patch for this.
    • @ocean90 is working on updating a patch for #32434 after discussion there and in #22383.

    Progress on `WP_Network` and `WP_Site`:

    • Tickets: #31985, #32450
    • chat log
    • second chat log
    • Initial brief conversation. @earnjam is going to take a closer look at the existing patches. We need to start brainstorming where `WP_Network_Query` starts.
    • Continued this conversation with @johnjamesjacoby later in the day. He’ll be working on the patches a bit more this weekend as well.
    • #25293 was brought up to consider so that the correct network ID is available after `switch_to_blog`. Also #14867 to ensure the correct scheme is attached to the site object.

    Thoughts on how to track scheme for a site:

    • Tickets: #14172
    • chat log
    • @johnbillion agreed that `wp_blogs` seemed like the right place to track scheme. We’ll need to worry some about the upgrade process, though larger networks should be able to handle something like this.
    • Some more discussion on the ticket would be great. We should get a patch going sooner than later. This is up for grabs, claim it in the comments! :)

    More flows for Make/Flow:

    • chat log
    • @ubernaut is almost done with iPhone 5s videos.
    • @johnbillion mentioned trying some recordings with Android.
    • @jeremyfelt is still claiming that he’ll do an iPad capture one night.
    • We need to get more of these up on Make/Flow to capture a good visual record. As they go up, please create tickets for things that look off. Even if you haven’t posted a flow of your own, please browse through the existing ones and look for issues.

    Thanks to everyone in office hours today! Chime in with any comments, tickets, etc… or join us in #core-multisite. :)

     
  • Konstantin Obenland 9:45 pm on May 20, 2015 Permalink |
    Tags: ,   

    Dev Chat Summary, May 20 

    Agenda, Slack log.

    Committers Update (#)
    @nacin
    New guest committers: @iseulde, @westonruter, and @obenland, renewed guest committers: @jorbin, @jeremfelt, permanent committers: @pento, @boone, and @johnbillion
    Also see https://make.wordpress.org/core/2015/05/20/new-committers-for-4-3/

    Editor (#)
    @azaozz@iseulde
    No update here. Will discuss goals for this week and next week outside of dev chat.

    Admin UI (#)
    @helen
    @helen is plugging away at some groundwork for the CSS roadmap, @stephdau should be taking a look at the first steps for list tables in the next day or so. Will discuss goals for next week in tomorrow’s UI meeting.

    Network Admin UI (#)
    @jeremyfelt
    They talked through aspects of the Edit Site and Add Site flows yesterday to help @hugobaeta with mock-ups. Hopeful to see a mock up of these soon. They have a couple flows in Make/Flow with more on the way. The 5s flow highlighted an issue with text inputs overflowing. There’s also an updated `WP_Network` patch.

    Things they want to have done by next week:

    • Android and iPad flows.
    • Conversation around updated `WP_Network` patch and a first attempt at `WP_Site`.

    Partial Refresh (#)
    @westonruter
    Now has support for refreshing menus changed by Menu Customizer: https://github.com/xwp/wp-customize-partial-refresh/pull/12/files
    It’s much simpler than partial refresh for widgets, and @westonruter thinks that maybe it could safely be on by default, instead of requiring opt-in as is currently done for widgets. The concern with on-by-default would be if menus get some dynamic behaviors added to them with JS, so maybe it’s just something that theme authors would need to account for.
    Also waiting on feedback and testing from the Menu Customizer, merging the corresponding PR for Menu Customizer, to then merge the PR for Customize Partial Refresh and do a new plugin release.

    Goals for next week: Take what was done for Menus and then abstract a level again to facilitate plugins easily adding their own partial-refreshing.

    Menu Customizer (#)
    @voldemortensen, @celloexpressions
    Lazy loading and error handling were committed. Will discuss goals for next week outside of dev chat.

    Better Passwords (#)
    @markjaquith
    They’ve been working on a mockup of the password UI: http://codepen.io/markjaquith/pen/GJjZbJ
    Probably best to create a temporary hook in core for the password-set UI in the profile, to allow the team to work on this as a plugin. @markjaquith can take care of that core change, and start the plugin on GitHub.
    #32428 is on hold until the Password UI is usable. @voldemortensen started work on expiring reset keys #32429, but hopes to get it showcase-able by the end of the week. @rmarks made a first pass at #32430 but it needs more work.

    Goals for next week:
    1. Hook in core to enable plugin for PW change UI.
    2. Working version of PW change UI on the Profile screen (that is, you can change your password with it… show/hide… back compat for the pw confirmation field… not promising the strength hint stuff yet).
    3. #32430 ready for commit.
    4. Working patch for #32429.

    Favicons (#)
    @johnbillion
    @johnbillion made a start on the site favicon manager. As discussed during dev chat last week and in #16434 it has an API so plugins/themes can register new sizes for favicons/touch icons/etc if the need arises. I’ll be pushed to a GitHub repo by tomorrow. The main thing that will need to be discussed is whether this should just be a customizer setting or not. @johnbillion will post about the repository location and meeting times on this blog.

    Other:
    @ocean90 is looking for feedback on #29783!

    Next chat will be on May 27 2015, 20:00 UTC

     
  • Andrew Nacin 8:02 pm on May 20, 2015 Permalink |
    Tags: ,   

    New committers for 4.3! 

    Please join me in welcoming three new guest committers for WordPress 4.3 — Ella Van Dorpe (@iseulde), Konstantin Obenland (@obenland), and Weston Ruter (@westonruter)!

    Ella has been one of our very top contributors of late. She started with a front-end editor plugin, which parlayed into substantial core editor contributions, including inline image editing in 3.9, inline oEmbed previews and improved editor scrolling (“focus”) in 4.0, distraction-free writing (“focus v2”) in 4.1, and a few dozen other things I am sure I am missing (like this). She’s a powerhouse.

    Obenland, well, is also wearing the release lead hat for 4.3. I said plenty of nice things about him there. 😄 While there’s no requirement for a release lead to be a committer, a) it does help with housekeeping, and b) Konstantin has unquestionably earned this in his own right, regardless of his other role.

    Weston has been essentially leading the customizer component since his work last year on bringing widgets into the customizer. His body of work there is nothing short of incredible and we’re lucky to have had him spearheading this important work.

    The lead developers review and appoint new committers to serve each release cycle, often to work on a particular component or feature. This guest commit access comes up for review after each release and can be renewed — Aaron Jorbin and Jeremy Felt have both been renewed for 4.3.

    We (well, I) neglected to announce that John Blackbourn (@johnbillion), Boone B. Gorges (@boonebgorges) and Gary Pendergast (@pento) were made full, permanent committers at the start of 4.2. John, Boone, and Gary all destroyed it in 4.1 (which is perhaps more obvious now that some of Gary’s work has been trickling out into the open).

    Congrats all! 🎉

     
  • Konstantin Obenland 3:52 pm on May 20, 2015 Permalink |
    Tags: ,   

    Dev Chat Agenda for May 20 

    Here’s the agenda for today’s Dev Chat in the #core channel on Slack.

    Time/Date: May 20 2015 20:00 UTC:

    1. Feature Updates
      1. Editor – @azaozz / @iseulde
      2. Admin UI – @helen
      3. Multisite Admin UI – @jeremyfelt
      4. Partial Refresh – @westonruter
      5. Menu Customizer – @celloexpressions / @westonruter / @voldemortensen
      6. Passwords – @markjaquith
      7. Site Icon – @johnbillion
    2. Component Updates

    Feature Leads: Let’s review last weeks goals and set new ones for next week.

    Recommended reading:

     
  • Konstantin Obenland 6:14 pm on May 14, 2015 Permalink |
    Tags: ,   

    Dev Chat Summary, May 13 

    Agenda, Slack log.

    Editor (#)
    @azaozz@iseulde
    @azaozz has been looking at the “WordPress integration” parts the last couple of days, a lot of things that can be improved there. It removes some of the oddities, like running the post content through wpautop() before outputting it in the textarea, but only when TinyMCE is expected to be loaded, etc. @iseulde is working on the mobile toolbar and is hopeful she can get a patch ready this week. By next week’s meeting they want to have the mobile toolbar working (except in iOS), as well as #31655, #30949, and maybe #31441 in.

    Admin UI (#)
    @helen
    @helen has largely been working on prepping things (tickets, examples, links, etc.) for Thursday’s UI meeting. More about the meeting (including agenda) can be found here: https://make.wordpress.org/core/2015/05/11/weekly-core-ui-meetings-for-4-3/

    Network Admin UI (#)
    @jeremyfelt
    Recap of Multisite office hours: https://make.wordpress.org/core/2015/05/12/multisite-office-hours-recap-may-12-2015/
    Things they want to have done by next week:

    • Mockups for the Edit Site / Add New Site improvements by @hugobaeta.
    • Having more flows posted to Make Flow for the network admin, via @sofiarose @kraft, and @ubernaut.
    • Get some decent progress on `WP_Site` and `WP_Network` with @jjj.

    Partial Refresh (#)
    @westonruter
    Weston hopes to add initial integration between Menu Customizer and Partial Refresh this weekend. Due to client projects he’ll have to work on Concurrency _concurrently_ with Partial Refresh so he doesn’t hold up Menu Customizer. By next week Partial Refresh should be abstracted enough for the Menu Customizer to work with.

    Menu Customizer (#)
    @voldemortensen, @celloexpressions
    Now that it’s object-oriented they’re ready to start ramping up work. They’ll be going through github issues and come up with the next milestone for possibly the end of the week. By next week they’re planning on getting lazy-loading of both all menu item controls and the add-menu-item panel done, as well as better error handling for duplicate menu names and the like.

    Better Passwords (#)
    @markjaquith
    By next week, Mark wants a HTML, CSS, JS working demo of the password setting UI, and tickets for that and all other items on their hitlist. If there’s time beyond that, they could knock off one of the easier ones like notifying users of their password/e-mail changes.

    Accessibility component update (#)
    @joedolson
    There’s been a ton of work done on the List Table class and associated areas. Joe has a set of 10 tickets with patches that he’d like to see committed by next week: #32150, #32254, #32255, #32028, #32152, #32147, #32189, #31654, #32253, #32170.

    Build tools component update (#)
    @jorbin
    QUnit update seems to have gone off without a hitch. There are 7 npm dependencies that need to be updated. 6 are ready to go. grunt-sass needs a bit more digging in. This week, @jorbin is going to update the build tools roadmap he wrote up after WCSF and then pester a lead (likely @helen) to give it a read so that it can finally be published.
    Not exactly build related, but test related: Bug scrub identified that we don’t have any tests for nav menus, especially around the classes we add. @johnbillion has agreed to write some tests there so that we can fix all the bugs around that.

    Favicons (#)
    @obenland
    Support for managing favicons seems like a rudimentary thing, and its absence in core does seem odd to some. We still need plugins to handle favicon and other media icons in the admin, there is currently no good way for users to do that. We’ve been talking about adding support for a favicon manager for a long time ( #16434 ), let’s make 4.3 the release that finally adds it. @johnbillion volunteered to lead the feature for 4.3, with help from @brandondove, @kraftbj, @sofiarose, and possibly @dh-shredder.

    Next chat will be on May 20, 2000 UTC

     
c
compose new post
j
next post/next comment
k
previous post/previous comment
r
reply
e
edit
o
show/hide comments
t
go to top
l
go to login
h
show/hide help
shift + esc
cancel
Skip to toolbar