Make WordPress Core

Updates from May, 2016 Toggle Comment Threads | Keyboard Shortcuts

  • Helen Hou-Sandi 8:50 pm on May 23, 2016 Permalink |

    May 20 toolbar and admin menu meeting summary 

    This is a summary of the May 20 toolbar and admin menu meeting, which was held to jump start toolbar changes proposed in #32678 (chat log). The next meeting will be held May 27 at 16:00 UTC.

    The biggest component of this initial phase of changes is bringing the entire admin menu to the toolbar on the front-end. Given that this involves the admin menu “API”, we need to bite the bullet and dive into what it takes to give it a real API and fix #12718 (among others). In order to complete this for 4.6, work needs to move quickly.

    Participants: @helen, @celloexpressions, @folletto, @emathison, @deshack, @morganestes, @rdall, @boonebgorges, @thomasplevy, @jeremyfelt, @clorith

    Key points

    • Action item: A document outlining strategy, documenting the current API, and describing the design of a new API has been started. Sections that are empty/marked for help are in need of owners. This is to be completed by the next meeting.
    • While there are many interaction changes that need exploring, and a few included in the current proposal, the focus for this cycle is content changes.
    • The links currently in the W menu will be relocated/reproduced in other places, e.g. About in the Dashboard submenu and as the link for the version number in the footer of the admin.
    • @boone helpfully provided some background on BuddyPress’s very similar changes to its navigation API last week. This is also documented in the Google Doc above.
    • Jon Brown 9:24 pm on May 23, 2016 Permalink | Log in to Reply

      These looks _really_ good and double props for including multi-site _with_ lots of sub-sites.

      One thought that has been bouncing around in my head is moving the network menu (key) to the far right, right of the user avatar. At least in my use, it’s very few users who actually have the need to switch sites or get to the network admin. It’s more akin to switching users than navigating the backend of a single site.

      It’s not a well thought out thought, just one that seemed worth floating for discussion.

  • voldemortensen 4:29 pm on May 19, 2016 Permalink |
    Tags: , ,   

    Dev Chat Summary: May 18, 2016 

    This post summarizes the weekly dev chat held on May 18, 2016 at 14:00 MDT.

    Update on WordPress 4.5.3

    • Target date for release is in 2-3 weeks.
    • Only 7 tickets remain in the minor milestone.
    • #36749, #36590, and #36748 all need some additional help. Please look into them if you can.

    New Trac keyword for Dev Notes:

    • Dev notes are make/core posts which are about new features/APIs or API changes. The goal is to have a field guide which summaries all the changes of a release.
    • If you think a ticket needs a make/core post, please add the needs-dev-notes keyword so these can be tracked. (needs-dev-note won’t be in the keyword dropdown, however you can manually add it.)
    • Current tickets with needs-dev-note can be found here: https://core.trac.wordpress.org/query?keywords=~needs-dev-note&milestone=4.6&group=component
    • Historically, the ticket owner or committer writes the post, but anyone can author a dev note.
    • Please contact @ocean90 if you have a dev note ready to publish.
    • Reminder: The handbook has a Post & Comment Guidelines page.

    Feature project updates

    Font Natively

    • This week a bug with the font shortcut property was fixed.
    • Currently there are no blockers noted.
    • More screenshots across operating systems/browsers/resolutions/devices would be greatly appreciated.
    • Screenshots should be uploaded directly to ticket #36753 if possible. Otherwise, a link to them will suffice.
    • The dashboard with the welcome panel active, the discussion settings page, and the customizer all good for screenshots.
    • @helen has pinged @mattmiklic about the font weight differences that were noted. (Answer)

    Customizer transactions/Customize Posts

    • Transactions: setting validation (#34893) is the part of transactions that has been worked on this last week. It is ready for commit from @westonruter‘s point of view.
    • It was proposed to punt Customize Posts from 4.6 for now and to focus on the underlying API instead.
    • #36879 allows post data to be filtered if is_customize_preview().
    • Work continues on the feature plugin, primarily thanks to @valendesigns, with work focusing on being able to create new posts from within the Customizer.
    • There has been some confusion regarding the scope of the feature plugin vs. the scope of what’s being worked on for 4.6, @westonruter and @celloexpressions will work on separating the two to reduce confusion.

    Shiny Updates

    Open question: Should `update-core.php` changes be part of the merge proposal? Initially it has not been part of the proposal because it was far from finished. Pros for making it part of the proposal would be that it would completely eliminate The Bleak Screen Of Sadness from there, con would be that it wasn’t ready at the beginning of the cycle and still needs a good amount of testing.

    If you have any thoughts on the matter, please chime in.

    Toolbar Experiments

    Component announcements

    Open discussion

    • @voldemortensen proposed that core adopt some prerendering and prefetching by default. He and @swissspidy believe there are some big performance gains to be had. However, prerendering can have some bandwidth impacts that need to be researched/discussed further.
    • @tfrommen would like some feedback on #26511. The basic concept of the ticket is to introduce the ability to switch between locales. He will be making a patch so it can be tested directly with core. Discussion will continue in #core-i18n.
    • @mrwweb would like feedback on #36809. After a healthy discussion about the problems surrounding the removal of the feature, the general consensus is that it would stay for now and be revisited in the future.
    • Nick Halsey 6:16 pm on May 19, 2016 Permalink | Log in to Reply

      Re: customize posts, it was never intended to be proposed for 4.6. The only piece currently proposed for core is #34923, adding the ability to create page stubs from the nav menus interface to eliminate a dead-end experience. Pieces of the customize posts plugin’s internals will be used to facilitate this.

  • Eric Binnion 2:39 pm on May 18, 2016 Permalink |
    Tags: ,   

    Week In Core, May 11 – May 18 2016 

    Welcome back the latest issue of Week in Core, covering changes [37417-37457]. Here are the highlights:

    • 40 commits
    • 31 contributors
    • 74 tickets created
    • 12 tickets reopened
    • 78 tickets closed

    Ticket numbers based on trac timeline for the period above. The following is a summary of commits, organized by component.


    • Make the tab order match the visual order in the Edit terms screens. [37439] #35664


    • System font: The stack does not work with the font shorthand property. [37442] #36753
    • Credits: Add a missing closing tag. [37434] #35911
    • Admin font: Remove a redundant sans-serif declaration. [37419] #36753


    Build/Test Tools


    • Add $data parameter to include the comment data in the edit_comment action. [37423] #36427


    • Change attachment condition in the site icon control to prevent errors. [37456] #36749
    • Include shortcut button in Custom Menu widget to edit the selected menu in the Customizer. [37437] #32683
    • Remove use of reserved word default in Underscore template which breaks IE8. Fixes #36793. [37450] [37417] #36793
    • Handle filtering sidebars_widgets when the underlying option is non-existent. Merge of [37352] to the 4.5 branch. Fixes #36660. [37453] #36389, #36660
    • Clean up media control CSS. Removes unnecessary wrapper elements and refactors class names to eliminate duplication of rule selectors. [37426] #30618


    • TinyMCE: prevent showing the placeholder URL when adding a link and clicking more than once on the Insert Link button. Merge of [37301] to the 4.5 branch. [37454] #36637
    • Editor: Merge two strings. [37441] #27756


    Filesystem API

    • Don’t add '.' to the list of directories which need to be checked/created when extracting a file. [37421] #36570


    • Docs: Standardize on ‘backward compatibility/compatible’ nomenclature in core inline docs. [37431] #36835


    • Use prepared JSON data correctly. This was modifying a variable that was never used. Oops. [37444] #36358
    • Pass array-like object to http_api_debug. This was mistakingly passing the Requests_Response object, which caused fatal errors with debugging tools. [37436] #33055
    • Fix compatibility with cURL < 7.22. [37430] #33055
    • Add browser compatibility hook for 3xx redirects. [37428] used the wrong method of adding this hook, now corrected. [37429] #33055
    • Replace internals with Requests library. [37428] #33055


    • In get_translations_for_domain() check if the global $l10n was set by _load_textdomain_just_in_time() before accessing it. [37440] #34114


    Networks and Sites

    • Tests: Set public to 1 in the default blog factory. [37418] #36566
    • Tests: Use factory method to generate fixtures for wp_unique_post_slug() tests. [37443] #20419

    Posts, Post Types

    • Fire a post_action_{$action} action for a custom post action request. [37424] #27056



    • Add changelog entries for when the classes were moved to its own file. [37432] #36618


    • List Tables: Pass the $which parameter to restrict_manage_posts and restrict_manage_users. [37422] #35307


    • Create WP_Widget_Mock as a mock of WP_Widget which can be used for widget tests. You cannot instantiate an abstract class. Not even in WordPress world. [37427] #35981
    • Make WP_Widget a real abstract class. [37425] #35981

    Thanks to @adamsilverstein, @afercia, @boonebgorges, @brianvan, @celloexpressions, @danielhuesken, @DrewAPicture, @dshanske, @helen, @iseulde, @jeremyfelt, @jfarthing84, @joemcgill, @johnbillion, @jorbin, @jrf, @martin.krcho, @mintindeed, @Mte90, @neverything, @ocean90, @pavelevap, @rachelbaker, @ramiy, @rmccue, @samantha-miller, @SergeyBiryukov, @sudar, @swissspidy, @tfrommen, and @westonruter for their contributions!

  • voldemortensen 10:02 pm on May 11, 2016 Permalink |
    Tags: , ,   

    Dev Chat Summary: May 11, 2016 

    Update on WordPress 4.5.3

    Triage of tickets with the “early”” keyword and “class tickets”

    • 9 tickets are still listed
    • @iseulde was unavailable for comment on #25387
    • @swissspidy is working on patches for WP_Post_Type and WP_Taxonomy.
    • @jeremyfelt is planning on commiting WP_Site_Query this week.
    • @boonebgorges will provide feedback for patch on #36492
    • A patch for #34391 was submitted this week. This patch also fixes #34344 and #35947 (both early tickets).

    Feedback on bug scrubs/weekly chats/office hours

    The general consensus is that having frequent meetings for each component is a positive thing that promotes contributions.

    @helen: I don’t think having a lot of scheduled meetings is a problem when they’re not mandatory, it helps people schedule and structure their time.
    @jorbin: It also helps people be involved since they have plenty of options for when they can interact live with others
    @voldemortensen: Live feedback helped me a ton when starting with WordPress.

    A link to https://make.wordpress.org/meetings will be added to the sidebar.

    Feature project updates

    Font Natively

    • There is a bug with MSEdge. @helen will try get in touch with them about it.

    Customizer Transactions

    Customize Posts

    • @valendesigns has been improving the underlying framework for themes to add support for how they vary in how they use template parts to represent the various post fields (e.g. title, author, and content).
    • Also regarding #34923, @valendesigns has done an initial PR for adding the ability to create new posts/pages in the Customizer, with an Add New button appearing at the top of the panel for the given post type.
    • The Customize team will then be able to integrate this same button into the available nav menu items pane for menus in the Customizer.

    Shiny Updates

    • @swissspidy continued working on update-core.php. See https://cloudup.com/cIh02KWWwey
    • @mapk conducted another user test (which went a lot smoother after we updated the test site to WP 4.5.1). That can be found here: https://cldup.com/yHfETI5gdE.mp4
    • All flow documentation for shiny updates can be found here: https://make.wordpress.org/flow/tag/shiny-updates/
    • The Shiny Updates team still needs reviews from various groups (i.e. a11y, i18n, etc).
    • So far the Shiny Updates team has done a total of five recorded user tests plus a few in-person ones at WordCamps. They’d like to do one more with themes install/update/delete to see if there are any quirks that have been missed.
    • @afercia would like a user review done with the tester using assistive technologies.

    Fields API

    • The Fields API team is seeking feedback on an ongoing discussion surrounding #35658, where they’re proposing extending register_meta() to accept an $args array which would provide much needed information about the meta field to both the REST API and the Fields API.
    • The Fields API team and the REST API team are at odds about which schema should be used.
    • A explanation of the issue, as well as proposed solutions, can be found here: https://docs.google.com/document/d/1ZMKt_PIcy0fTTQAjE1THeG-MRPTUHVVSSyZs5dk7TIc/edit
    • Action items: Further define the pros/cons of each schema option and meet with REST API team to hash out an agreeable solution

    Toolbar Experiments

    • No further progress.

    Component updates

    Please see: https://make.wordpress.org/core/tag/4-6/

    Open discussion

    • @joemcgill would like to get another set of eyes on #36531, particularly as it relates to possibly fixing broken options via an upgrade routine.
    • @afercia would appreciate a review of the post draft for make/core about the changes in the Terms screens, see ticket #35664.
    • @brianvan would like a review of #27056
    • The workflow part of the Handbook isn’t clear on what to do after a ticket is tagged with “has-patch”. Getting another contributor or a committer to review the patch is the best thing to do. This should be updated in the Handbook.
  • Andrew Rockwell 8:07 pm on May 11, 2016 Permalink |
    Tags: ,   

    Week in Core, May 3 – May 10 2016 

    Welcome back the latest issue of Week in Core, covering changes [37355-37416]. Here are the highlights:

    Ticket numbers based on trac timeline for the period above.

    Code Changes

    Build/Test Tools


    • Ensure that wp_setup_nav_menu_item filter applies consistently on nav_menu_item setting values. [37405] #35203


    External Libraries




    Options, Meta APIs

    • After [33738], consistently pass option name as the second parameter to the 'default_option_' . $option filter in add_option() and update_option(). [37367] #36761

    Rewrite Rules

    • Add self-describing variables to rewrite matcher. [37356] #36674


    • Drop Open Sans in the admin in favor of system fonts. [37361] #36753



    • The ‘who‘ parameter should not interfere with ‘meta_key‘ + ‘meta_value‘ in WP_User_Query. [37360] #36724


    Thanks to @achbed, @adrianosilvaferreira, @boonebgorges, @borgesbruno, @celloexpressions, @dlh, @DrewAPicture, @ericlewis, @flixos90, @helen, @Ipstenu, @jeremyfelt, @jorbin, @mattmiklic, @nbachiyski, @netweb, @ocean90, @sebastianpisula, @SergeyBiryukov, @swissspidy, @welcher, and @westonruter for their contributions!

  • voldemortensen 8:05 pm on May 5, 2016 Permalink |
    Tags: , ,   

    Dev Chat Summary – May 4, 2016 

    This post summarizes the dev chat meeting from May 4.

    Update on WordPress 4.5.2

    • Lead for 4.5.2 still undecided.
    • 8 potential tickets for 4.5.2, only one has been committed.
    • #36534 is a serious issue that has had little activity. The issue is a bug between Imagick and OpenMP in certain configurations. @mike has reached out to a few major hosts who have fixed their configuration. @joemcgill and team are continuing the investigation into how to handle these errors.
    • The goal is to have as many 4.5.2 tickets committed to trunk by next week as possible.

    Triage of tickets with the “early” keyword

    Call for designers/reviving the chats

    • Since the beginning of this cycle a few contributors requested help from the team in #design. This channel has currently 813 members but the responses are only sporadic. There is also a meeting scheduled which should happen every week on Thursday at 17:00 UTC. But last one was in January.
    • @karmatosed and @hugobaeta will take charge of reviving chats in #design on Slack.
    • @hugobaeta will have an agenda posted by end of day today.
    • @zetaraffix volunteered to join the design team.

    Feature Project Updates

    Shiny Updates

    Fields API


    • Recap post of the last office hours: https://make.wordpress.org/core/2016/05/04/customize-office-hours-recap-2016-05-02/
    • #30937 (transactions) and #35210 (notification area) are the highest priorities.
    • A make/core post for Customizer setting validation (#34893) in the works.
    • @westonruter has also initiated a new feature plugin “JS Widgets” that will greatly improve the performance of widgets in the Customizer. An alpha state plugin can be found here: https://github.com/xwp/wp-js-widgets

    Decision time for: #36753 Use system fonts for a faster, more native-feeling admin (Font Natively)

    • Background information and rationale can be found here: https://make.wordpress.org/core/features/font-natively/
    • @helen mentioned that there is a patch on #36753 and that lots of screenshots across OSes and window sizes of current state and new state are needed. Help is appreciated.
    • Because this project is already in a committable state, @helen proposed to commit this patch now.
    • Even the final decision time is still a month away no objections were called.
    • @helen will commit the patch.

    Discussion: How to name new functions? get_sites/networks() vs wp_get_sites/networks()

    This came up during the last multisite chat. @jeremyfelt gave a short introduction:

    WP_Site_Query should have a function similar to get_posts(), get_users(), or get_comments() that allows for the simple return of results from a query.

    wp_get_sites() was introduced quite a bit ago. It returns an array of arrays rather than the desirable array of WP_Site objects.

    get_sites() is proposed as part of the WP_Site_Query patch to align better with the naming of posts, users, comments… and to allow for the return of an array of objects.

    We need to make a decision: Does it make sense to introduce get_sites() and deprecate wp_get_sites()

    I guess a broader question is do we push for more wp_ prefixed functions in situations like this or do we go with what we’ve been doing.

    A similar question exists for get_networks()

    • @tfrommen objects, that introducing a new unprefixed function might be a collision with some (also unprefixed) plugin function. He proposes that the slurping the plugin repo would be a good idea.
    • @boonebgorges states a rule: Prefer prefix as a rule of thumb, but exceptions seem fine in cases like this, when DX will be improved by being internally consistent.
    • @helen: Generally I would base these kinds of decisions on what wouldn’t trip you up (or at least you trip you up less) as a developer.
    • @ipstenu will help with slurping the plugin repo for get_sites() and report the findings in #core-multisite.
    • There is currently not a consensus on prefixing functions with wp_.

    Component Updates




    • Bug scrub scheduled for Monday May 9th, 2016 at 13:00 MDT in #core Slack.
    • Watch for a Make/Core post regarding Custom Comment Types
    • With 104 open tickets, the Comments team would love help confirming bugs still exist, are actually bugs, or patches 🙂
    • #33717 (Send Notification Email When a Comment is Approved From Moderation) needs some extra review and feedback.


    • The media component could use a lot of love, and a bug-fix focussed release is just the sort of thing that could help.
    • @joemcgill  is planning to put out a call for volunteers on the make/core blog and then begin using our weekly dev chat time to focus on bug-scrubs.
    • There are currently 268 open tickets in that component, so extra hands will be helpful.

    Open Discussion

    • @helen brought a concern about removing the Open Sans style registration and people who might be using it as a dependency, etc. The decision was to leave the registration and move the line to the // Deprecated CSS section..
    • @ronalfy asked for a new owner of #33932 (Filters for Plugin/Theme Update Email Notifications).
    • @zstepek brought #34848 (Add support for updating post meta in bulk) up. @boonebgorges will be responding to the ticket soon.
    • @spacedmonkey would like to get more eyes on #35381 (Introduce WP_Term_Query)


    The full dev chat logs can be found here: https://wordpress.slack.com/archives/core/p1462392004003183

  • Boone Gorges 5:15 pm on May 5, 2016 Permalink |
    Tags: , ,   

    Taxonomy bug scrub summary, 2016-05-05 

    We had a taxonomy component bug scrub today. Slack archive: https://wordpress.slack.com/archives/core/p1462464023003714

    Present: @boonebgorges, @helen, @barryceelen, @wonderboymusic. @swissspidy and @jans-1 voiced their opinions via emoji reactions.

    We cleared 8 items from the Awaiting Review queue, bringing it down to 35 tickets.

    Let’s do this again real soon!

  • voldemortensen 10:51 pm on April 27, 2016 Permalink |
    Tags: , 4.5.2, , ,   

    Dev Chat Summary – April 27, 2016 

    This post summarizes the dev chat meeting from April 27.

    4.5.1 / 4.5.2

    • Released April 26, 2016.
    • Exact time of release wasn’t announced, which left places like #forums on Slack and hosts in the dark. Going forward an exact timeframe should be announced, the handbook will be updated to be more clear on this requirement.
    • Two proposals about minor release leads came forth. One being that a set of “maintainers” be established to be on top of minor releases, the other being @ocean90 and @voldemortensen do 4.5.2 as a dry-run for 4.6.0. No decision has been made at this time.

    Status of the wish-list post

    There are currently 124 tickets, 4 of which are complete with about 15 in progress.

    Feature plugin/project proposals for 4.6

    • Contributors to the proposed projects should attend the feature plugins/projects meetings. The next one will be held on May 3, 2016 15:00 UTC.
    • Parts of the Shiny Updates v2 plugin are ready for core and have been proposed for merge. This fits in with the goals of the 4.6 release cycle.
    • Any one who would like to try the Shiny Updates plugin can find it here: https://wordpress.org/plugins/shiny-updates/
    • The Fields API team would like to propose their changes to register_meta() and a datalayer for metadata REST API endpoints.
    • @helen is looking at #32678 (Audit toolbar links and content) for items that can be brought into 4.6.0. No meetings are currently being held, but times are being considered.
    • @westonruter proposed #34923 (Introduce basic content authorship in the Customizer) and #30937 (Add Customizer transactions). Anyone who has questions or is looking to contribute should join #core-customize on Slack.

    Triage of tickets with the “early” keyword

    Component Maintainer Updates/Reminders

    • Please post notes from weekly meetings and bug scrubs on make/core. Release leads will try get weekly posts on upcoming meetings.
    • Weekly meeting times can be found here: https://make.wordpress.org/meetings/
    • Components which should definitely have a bug scrub soon: Posts, Post Types; Comments, Taxonomy, Themes, and Widgets.



    • @iseulde has started working on using the TinyMCE APIs for wpView and inline toolbars
    • @azaozz is still chasing after couple of rare editor bugs and will start on the wishlist (https://make.wordpress.org/core/2016/04/12/editor-wish-list-4-6/) probably by the end of the week.
    • If somebody have questions or like to get involved/help, please join us at the regular editor chats on Wednesday two hours before this chat in #core-editor

    Pings and Trackbacks

    • @dshanske is a new maintainer. He closed/consolidated several tickets however reading the code caused him to open some more. 🙂



    • The Customizer Transactions patch got a refresh for trunk.


    • Bug scrub time will be announced next week.



    Open Discussion

    The REST API team is seeking direction and clarity on the path forward. A more in depth summary will be posted separately. Read the conversation here: https://wordpress.slack.com/archives/core/p1461791901002328

    @tfrommen would really love to see (more) feedback on #36335, especially by (but of course not restricted to) Core Committers. Both targeted at the ticket’s core (i.e., a central autoloader) and the parts directly related to WordPress (e.g., split up files with multiple classes, or classes and functions, etc.). Things that might be tackled in the scope of WordPress 4.6, or in general, some day/release. https://wordpress.slack.com/archives/core/p1461795636002501

    The full dev chat logs can be found here: https://wordpress.slack.com/archives/core/p1461787203002129

  • Eric Binnion 2:39 pm on April 27, 2016 Permalink |
    Tags: ,   

    Week in Core, Apr 19– Apr 26 2016 

    Welcome back the latest issue of Week in Core, covering changes [37254-37314]. Here are the highlights:

    Ticket numbers based on trac timeline for the period above.

    Code Changes

    Build/Test Tools

    • Build/Test Tools: Reset the PHPMailer mock in Tests_Mail::tearDown(). [37307] #36609
    • Tests: Use the same incrementor for all fields belonging to a given text fixture. [37299] #35199
    • Don’t announce PR builds in Slack. People may submit a PR to our travis build repo, we shouldn’t notify slack when that happens. [37268] #36607
    • Tests: Allow override of MULTISITE and SUBDOMAIN_INSTALL constants [37266] #36567


    • Use get_the_terms() to verify that a post belongs to the requested %category%. The get_the_terms() wrapper provides cache support, and saves a database hit
      on sites with a persistent cache backend. [37262] #36602
    • Tests: After [37260], use WP’s setUpBeforeClass() wrappers. This ensures no leakage between tests of fixture IDs. [37261] #36602
    • Add tests for permastruct containing /%category%/. [37260] #36602


    •  Add a $comment parameter to get_comment_author_url_link(). Add unit tests (none exist). [37305] #36573
    • Add unordered list styling to Comments List Table rows and Moderate Comment screen. [37304] #36160
    • Keep comments safe in the Edit Post screen. Warns users that have added a new Comment or began editing an existing without saving their changes, before they press the “update” button which would wipe out their comment changes. [37303] #32818
    • Dashboard: toggle the “View” link for comments when Approving / Unapproving from the Dashboard widget. [37302] #35518


    • Suppress connection error messages when WP_DEBUG isn’t enabled. This is a partial revert of [35860], which has been causing un-catchable warnings to be generated on some server configurations. [37293] [37292] #36629, #21870


    • Tests: Pre-declare the $year_url property before initialization in Tests_Get_Archives::setUp(). [37271] #36611


    • Add missing return descriptions for WP_Filesystem_SSH2::chown() and WP_Filesystem_SSH2::run_command(). [37270] #30989
    • Clarify the return descriptions for get_the_time(), get_post_time(), and get_post_modified_time() to specify when an integer in the form of a Unix timestamp should be expected. [37265] #30989
    • Clarify return descriptions in the DocBlocks for set_user_setting() and delete_user_setting(). [37264] #30989
    • Clarify parameter and return descriptions in the DocBlock for wp_set_all_user_settings(). [37263] #30989
    • Capitalize URL – an acronym for Uniform Resource Locator – when used in the context of inline docs in wp-includes/link-template.php. [37259] #30406
    • Notate more optional parameter defaults for a variety of function DocBlocks in wp-includes/link-template.php. [37258] #30406
    • Notate optional parameter defaults for a variety of function DocBlocks in wp-includes/link-template.php. [37254] #30406


    • TinyMCE: prevent showing the placeholder URL when adding a link and clicking more than once on the Insert Link button. [37301] #36637


    • Smilies: Move convert_smilies to happen later in the the_content filter. [37298] #36306
    • The :roll: smiley is now an emoji. [37296] #36365
    • The diversity support test was incorrectly passing on all browsers. [37257] [37256] #36604


    • Revert [36230] which removed the rss-http feed content type. Removing this means that any feeds which are using this feed content type are now being served as application/octet-stream instead of text/xml. [37284] [37282] #36620


    • Customize/Formatting: Move sanitize_hex_color(), sanitize_hex_color_no_hash(), and maybe_hash_hex_color() from class-wp-customize-manager.php into formatting.php. Adds missing braces. [37283] #33413, #27583
    • Administration: Introduce admin_print_footer_scripts-$hook_suffix", a dynamic version of the admin_print_footer_scripts hook. This is now more consistent with the generic admin_print_scripts and the dynamic admin_print_scripts-$hook_suffix hooks fired in wp-admin/admin-header.php. [37279] #34334


    Networks and Sites

    • Tests: Account for flexible IDs in main network deletion test. [37300] #36566
    • Tests: Exclude ms-files test group from default PHPUnit config. [37269] #36566
    • Tests: Add speedTrapListener to multisite’s PHPUnit config [37267] #36566, #30017

    Posts, Post Types

    • Add parameter documentation for ‘post_category’ to wp_insert_post(). [37255] #36601

    Post Thumbnails

    • Fix logic bug and tests from [37308] where post-thumbnails support wasn’t added if there were no previous post_types with support already. [37313] #22080
    • When using add_theme_support( ‘post-thumbnails’, array( $post_types) ) merge the supported post_types. [37308] #22080


    • Tests: More explicit fixture content when testing s=0 query string. After [36647], the unit test generator sequence can put a 0 into the
      ‘post_excerpt’ field of a post fixture, causing false positives. [37280] #36622

    Rewrite Rules


    • Docs: Move the clarification of is_tax() and WP_Query::is_tax() return value added in [37235] to @return description. [37281] #36331

    Text Changes



    • Clear plugin/theme caches directly after a plugin/theme has been updated. This is a follow-up to [34751]. [37272] #34029, #36383


    • Remove the “Name” column of the Users table from appearing sortable. [37314] #28064
    • Docs: Reflect the new 'user' option for wp_new_user_notification()‘s $notify parameter added in [37276] in wp_send_new_user_notifications() docs as well. [37278] #36009
    • Add a unit test for [37276]. [37277] #36009
    • In wp_new_user_notification(), sdd 'user' option for the $notify parameter, which allows for sending notification only to the user created. [37276] #36009

    Thanks to @akibjorklund, @alexkingorg, @flixos90, @rachelbaker, @azaozz, @boonebgorges, @davewarfel, @downstairsdev, @DrewAPicture, @flixos90, @grapplerulrich, @helen, @iseulde, @jeremyfelt, @jesin, @jmichaelward, @joemcgill, @johnbillion, @jorbin, @juanfra, @Latz, @mpol, @ocean90, @pbearne, @pento, @polevaultweb, @rachelbaker, @rmccue, @SergeyBiryukov, @spacedmonkey, @swissspidy, @tfrommen, @tollmanz, @Unyson, @welcher, @westonruter, @WiZZarD_, and @wonderboymusic for their contributions!

  • voldemortensen 10:08 pm on April 20, 2016 Permalink |
    Tags: , , ,   

    Dev Chat Summary, April 20th 2016 

    This post summarizes the dev chat meeting from April 20.

    Update on WordPress 4.5.1

    • #36510 and #36545 are large bugs that are prompting an earlier release than was anticipated.
    • #36510: a ‘singular’ class was added for singular items, but some existing themes -including Twentyeleven – already used ‘singular’ in a different way leading to unexpected result.
    • #36545: is a potentially bad TinyMCE bug with chrome vs. 50 (now stable) is fixed in TinyMCE upstream; although testers have been unable to reproduce this bug, the point upgrade MCE squashes some known bugs and seems worthwhile to include.

    Other items remaining

    • #26506: Press This: “Add Photos” box doesn’t have enough height
    • #36578: wp_ajax_send_attachment_to_editor() bug

    Discussion about release date

    Several people raised concerns about rushing out an early point release. In an effort to encourage testing before release, 4.5.1-RC will be tagged either today or tomorrow (April 20th, 2016 or April 21st, 2016). A make/core post about changes in 4.5.1 will also be posted.


    • All committers will have their commit access renewed.
    • @voldemortensen will be the release deputy for 4.6.
    • @ebinnion, @rockwell15, and @grantpalin will continue their superb Week in Core posts.
    • WordPress 4.6 will focus on fixing bugs and refining existing features.
    • Other goals include increasing collaboration between features/components, increasing communication via make/core, and give user testing and UX a bigger focus.

    Release Schedule

    Community Wish List

    • @helen gave an update on feature projects (https://make.wordpress.org/core/features/). Feature projects have a bi-weekly meeting (every two weeks) at variable times to allow more contributors to attend. Next meeting is on May 3, 15:00 UTC in the #core Slack channel. More feature projects will be added to the page as their statements of purpose are refined.
    • @ocean90 and @voldemortensen will be tracking the wish list of tickets for 4.6 and providing updates here: https://make.wordpress.org/core/4-6/. (Component maintainers can help up by updating the list as well.)

    Component Maintainers

    General Discussion

    • The Two-Factor feature plugin needs a UX designer. Please reach out to @georgestephanis directly or in #core-passwords on Slack if interested.
    • #34941 (Make the main bootstrap process in ms-settings.php testable) needs some eyes. Please leave comments on the ticket or in #core-multisite if you have questions, comments, or concerns.
    • PHPMailer has decided to drop support for anything lower than PHP 5.5. Security updates will be backported, but there will be no new feature development. Reference.

    Full meeting logs: https://wordpress.slack.com/archives/core/p1461182382001002

compose new post
next post/next comment
previous post/previous comment
show/hide comments
go to top
go to login
show/hide help
shift + esc
Skip to toolbar