Make WordPress Core

Updates from September, 2016 Toggle Comment Threads | Keyboard Shortcuts

  • Helen Hou-Sandi 7:04 pm on September 28, 2016 Permalink |
    Tags: , ,   

    Dev Chat Agenda for September 28 (4.7 week 6) 

    This is the agenda for the weekly dev meeting on September 28, 2016 at 20:00 UTC:

    If you have anything to propose to add to the agenda or specific items related to the above, please leave a comment below. See you there!

  • Jeff Paul 8:06 pm on September 22, 2016 Permalink |
    Tags: , ,   

    Dev Chat Summary: September 21 (4.7 week 5) 

    This post summarizes the dev chat meeting from September 21st (agenda, Slack archive).


    • Schedule: As of this meeting, we are 4 weeks from the final chance to merge in major features. This includes Twenty Seventeen.

    Bug Scrubs

    Components & Features

    • Twenty Seventeen (@davidakennedy, @melchoyce)
      • Announcement post, latest update
      • Maintainers are out travelling today, but #core-themes is active and they will be holding a meeting on Friday at 18:00 UTC
    • REST API (@krogsgard, @kadamwhite )
      • Latest update
      • API discussion is at 7 am Pacific on Mondays
      • Settings endpoints and meta support both have first-passes on them, which need internal review and some more testing before we ship
      • We have a path forward for passworded posts (password in the query string, eww, but only viable option), there really isn’t a way we can see to avoid sending them as a query param
      • Meeting tomorrow in #core-restapi at 21:00 UTC to go through open issues around non-trivial, conceptual issues in WordPress. REST API team will prepare summary of issues for component maintainers and/or lead devs to review, question, and help guide discussion towards consensus.
    • Media (@mikeschroder, @joemcgill)
      • Latest update
      • Moving our weekly meetings up to Fridays at 17:00 UTC starting this week
      • Unexpected change to media title behavior in WP 4.6.1 (#37989) – The main issue here was resolved, but there seems to still be some odd behavior affecting words being chopped off filenames with international characters. Could use extra eyes from anyone (along with @sergey) more versed in i18n. Regression on the attachment titles that we generate on upload all became URL encoded instead of reading like a normal title.
      • Media search doesn’t include file name (#22744) – Committed earlier this week. Please report any issues that come as a result.
      • Next step in improving the organization of the media library is to assess both the infrastructure and UI improvements that need to be made here. Prefer to include #design early in this process, rather than asking for UI feedback on development driven decisions, hope to be part of the #design chat agenda tomorrow
    • Customize (@westonruter, @celloexpressions)
      • Latest update
      • In this week’s meeting we developed a schedule for publishing make/core feature proposals/dev notes for the remaining primary 4.7 customize projects, working backward from anticipated time to commit after the proposal and current readiness:
        • Week of 9/19: Improving sliding panels UI (34391, @delawski)
        • Week of 9/26: A new experience for themes in the customizer (37661, @celloexpressions). Please review soon for any requested changes in direction or design.
          • Summary: The existing themes section in the customizer is replaced with a full-screen theme browser and installer… The UI is nearly identical to wp-admin/theme-install.php… The .org-based theme-install previewer is not accessible here because it is likely to cause confusion with its customizer-like interface and the resulting need to switch contexts back and forth… An overarching goal is to avoid switching in and out of the admin/frontend/customize contexts during theme installation and previewing, instead staying in the hybrid customizer context that provides a combination of frontend plus controls… On the technical side, this heavily leverages JS-templated customizer controls and scales nicely to hundreds of themes.
          • Visual:
          • Please comment on the ticket with your feedback as soon as possible, preferably with specific concerns/ideas and reasons.
          • @celloexpressions to check in with @karmatosed on user testing ahead of posting final feature proposal
        • Week of 9/26: Customize transactions (30937, @westonruter evaluating this week and might punt again)
        • Week of 10/3: Code-editing gateways, via CSS (35395, @johnregan3/@celloexpressions). Awaiting approval/feedback on the acceptability/ability to bundle the two proposed libraries in core, with feedback particularly needed from committers and anyone familiar with the Jetpack fork of CSSTidy.
        • Week of 10/10: Customizer browser history (28536, @westonruter)
    • I18n (@swissspidy)
      • User Admin Language (#29783) – almost ready, another review this week and will commit if no blocker pops up
      • Introduce a locale-switching function (#26511) – @ocean90 to do some benchmarking
      • Introduce some JavaScript i18n functions (#20491) – GlotPress side has a solid plugin for exporting translations as JSON files (assistance on testing would be helpful). Still tinkering with the WordPress side and would love to get some additional feedback there.
    • Editor (@azaozz, @iseulde)
      • No updates, but would love to figure out a way to get more user feedback that helps us set direction for the editor. Will look to add some Core questions to annual survey on WordPress.org. Otherwise will start with something in the beta tester plugin, biased audience but it’s one that exists, is more likely to opt-in, and will be more flexible.
    • HTTPS (@johnbillion)

    Open Floor

    • @pbearne on Add filters to wp_new_user_notification and wp_password_change_notification (#38068) – added a set of filters to allow us to override email messages send by the wp_new_user_notification and wp_password_change_notification functions. @johnbillion to review as it relates to work on notifications.
    • @danieliser checking for interest for core in a set of reusable templates, models & functionality for forms, tabs & modals
    • @ericlewis on Bulk actions: Reactivate bulk actions hook + add hander hook for all admin screens (#16031) – could use a review of the latest patch, looking to commit sometime in the next week
    • @dshanske still working through the Pings and Trackbacks component
  • Aaron Jorbin 3:30 am on September 21, 2016 Permalink |
    Tags: , ,   

    Dev Chat Agenda for September 21 (4.7 week 5) 

    This is the agenda for the weekly dev meeting on September 21, 2016 at 20:00 UTC:

    If you have anything to propose to add to the agenda or specific items related to the above, please leave a comment below. See you there!

  • Aaron Jorbin 2:40 pm on September 15, 2016 Permalink |
    Tags: , ,   

    Dev Chat Summary: September 14 (4.7 week 4) 

    This post summarizes the dev chat meeting from September 14th (agenda, Slack archive).


    As of this meeting, we are 5 weeks from the final deadline to merge major features.
    There are a lot of tickets in the milestone and owners / people who milestoned them need to make sure they are active and moving, or else punt. You can use this report see tickets in the milestone grouped by who moved it there:https://core.trac.wordpress.org/report/61.

    Components and features

    Twenty Seventeen (@davidakennedy, @melchoyce)

    Make sure to checkout both the Announcement post and the latest update. There is no formal meeting this week. Development has started on GitHub. Like many feature projects, it will live on GitHub until it is ready to come into SVN (within the next 5 weeks).

    REST API (@krogsgard, @kadamwhite, @joehoyle, @rmccue)

    Core patches, documentation, and reducing the issue backlog have been the primary focuses. There is a settings registry up (https://github.com/WP-API/wp-api-site-endpoints/pull/13) with a corresponding core patch (https://core.trac.wordpress.org/ticket/37885).

    Feedback is needed on #37885.  Please take a look.

    #38056 is needed for password posts. (update: it has landed).

    The next dev chat is Monday September 19 1400 UTC.

    Media (@mikeschroder, @joemcgill)

    • Still looking for feedback/testing on #22744, but planning to commit soon.
      • If you have a large media library, your help in testing would be particularly helpful.
    • @paaljoachim continued researching UI flows in other platforms and posted a bunch of screenshots in #core-images.
    • Joe shared an outline of what we’re trying to accomplish longer term here in#core-images and would like to talk more about it design side of things during the #design meeting tomorrow, if possible.
    • Still waiting to hear back from folks who were involved in starting up the Core Media Widget #32417 work, but travel has been an issue. Hopefully we’ll have a better update there next week.

    Customize (@westonruter, @celloexpressions)

    • @boone is thinking about/investigating ⁠⁠⁠⁠term_status⁠⁠⁠⁠ for #38015. We have some time to think about it, and could potentially use shadow/draft taxonomies as a workaround for #38014 in 4.7 if needed.
    • tracking the ability to add page stubs or create pages directly from the static front page controls along with this project to facilitate creating pages for initial site setup within the customizer. @westonruter is leading the way on #38013.
    • #34391 is a significant refactoring of code that themes and plugins are encouraged to extend. A corresponding make/core post will follow soon after.
      • Already working with some plugin, theme, and framework authors to minimize breakage.
    • We need some feedback now on #35395 – Custom CSS – @johnregan3 is making great progress.  Please check out the ticket.

    i18n (@swissspidy)

    • #29783 (User Admin Language): in good shape, but not much testing happening so far. We could do much more when #26511 is in core though…
    • #26511 (switch_to_locale()): needs some much needed performance testing. If anyone runs a large WordPress site, I could use your help!
      Also since there are some similarities with switch_to_blog(), I’ll open a new ticket to suggest adding a WP_State interface for such switching functions. Think WP_Site_State, WP_Locale_State, WP_Post_State (see #19572), etc. Not a blocker, but worth keeping in mind for future compatibility.
    • #20491 (JS i18n): I documented the current state in the tasks with responsibilities etc. As of tomorrow I’ll have more time to work on it (mainly on the GlotPress side of things). Also have been thinking about a switch_to_locale() function in JS via Ajax…

    Editor (@azaozz, @iseulde)

    • Post your wishlist items for the editor.

    HTTPS (@johnbillion)

    • Plan of attack for HTTPS work will be published on Make/Core.

    Open floor for tickets and any lingering 4.7 ideas.

    Please review and comment on these tickets:

  • Helen Hou-Sandi 5:25 pm on September 14, 2016 Permalink |
    Tags: , ,   

    Dev Chat Agenda for September 14 (4.7 week 4) 

    This is the agenda for the weekly dev meeting on September 14, 2016 at 20:00 UTC:

    If you have anything to propose to add to the agenda or specific items related to the above, please leave a comment below. See you there!

    • Pascal Birchler 6:11 pm on September 14, 2016 Permalink | Log in to Reply

      I might not be able to attend today’s dev chat, so here’s an update on i18n:

      #29783 (User Admin Language): in good shape, but not much testing happening so far. We could do much more when #26511 is in core though…

      #26511 (`switch_to_locale()`): needs some much needed performance testing. If anyone runs a large WordPress site, I could use your help!
      Also since there are some similarities with `switch_to_blog()`, I’ll open a new ticket to suggest adding a `WP_State` interface for such switching functions. Think `WP_Site_State`, `WP_Locale_State`, `WP_Post_State` (see #19572), etc. Not a blocker, but worth keeping in mind for future compatibility.

      #20491 (JS i18n): I documented the current state in the tasks with responsibilities etc. As of tomorrow I’ll have more time to work on it (mainly on the GlotPress side of things). Also have been thinking about a `switch_to_locale()` function in JS via Ajax…

    • Ronald Huereca 6:24 pm on September 14, 2016 Permalink | Log in to Reply

      I’d like https://core.trac.wordpress.org/ticket/38024 discussed as I believe it to be a fairly major bug in regard to automatic updates for plugins and themes.

  • Jeff Paul 2:24 pm on September 12, 2016 Permalink |
    Tags: , ,   

    Dev Chat Summary: September 7 (4.7 week 3) 

    This post summarizes the dev chat meeting from September 7th (agenda, Slack archive).

    Update on 4.6.1

    Updates on Components and Features

    • Media via @joemcgill
      • #22744 – a few approaches on this ticket that are pretty close, but some feedback that would be helpful
        • To enable searching for filenames, we have to add a JOIN for the meta table, which has performance implications
        • so a) we could use more eyes/testing and b) I want to make sure we’re ok to add this if we limit it to only the media library
        • We have a couple approaches in patches. The latest limits it only to the media modal and WP_Media_List tables.
        • on a site with ~14k attachments and ~18k posts, this change increased the main query time from 60.7ms to 187.6ms
        • Plan is to drop it in for including titles in library searches and see how that goes
      • Looking for interest in getting the media widget started back up
        • @sheri has expressed interest and it seems like previous efforts got fairly close. Would love to see folks interested jump back onto that project during this release.
        • discussion will be in our weekly meeting in #core-images on Fridays at 19:00 UTC. There is a jump-start post so people can comment there or jump into the #core-images channel.
    • Customize via @celloexpressions
      • Two items needing review:
        • 1) ability to preview terms in the customizer, which would enable users to build menus incorporating their new taxonomy term structure on initial site setup in the customizer. See #37914 and #37915. We need to come up with a plan with those interested in the taxonomy component, and @boone in particular. First step there is to decide if we want to try to target 4.7 for first steps there.
        • 2) #37661 needs feedback. Working on a user testing plan together with @karmatosed soon. Looking for specific feedback or testing.
    • REST API via @krogsgard
      • Notes from Monday’s meeting
      • Calls for help would be participation in our next weekly meeting, 1400 UTC on Monday, and a bug scrub 1400 UTC on Thursday, both via #core-restapi
      • some in-flight work this week that’s being a bit delayed by the participation of Ryan and Joe in A Day of REST
      • We have big documentation needs in the v2 docs repo if anyone wants to play along, especially anybody who wants to set up a multi-language-code-snippet thing that we could use
      • meta and options are both moving well but we’ll need to start getting beyond theory and into code pretty soon
      • We really, really want to talk to component maintainers! It’s my job to reach out to you all, and you can also reach out to me (@krogsgard).
    • I18N via @swissspidy
      • #26511 (switch_to_locale()) and #29783 (User Admin Language)
        • Those are currently in development and after I upload new patches today/tomorrow, I’d love to see some testing.
        • Think of possibilities like: The admin bar is shown in Dutch while the rest of the site is shown in English.
      • #20491 (Introduce some JavaScript i18n functions)
        • We want to make translating strings in JavaScript files easier. Like in PHP files, one should be able to use gettext functions to translate strings. This involves changes to the translate.wordpress.org platform and therefore requires thorough discussion, planning, and testing.
        • After tackling this topic many times and attending the GlotPress meeting yesterday, it’s clear that it’s a task covering not just 1 release. Thus, we’ll likely have to do regular meetings here in Slack to get there.
    • Fields API via @sc0ttkclark
      • looking into slimming down our Fields API proposal into a MVP form for our core proposal
      • blocked by lack of time because i’m also lead organizing WCDFW this month
      • I could use lots of eyes on it, we want to identify anything that might be out of scope, as well as look into what our plan will be for the Javascript side of things for fields like the Media modal
    • #36964 (Show/hide the tag-cloud on `edit-tags.php` admin pages using a filter) via @ramiy
      • it has a patch, ready to be commited
    • #17817 (do_action/apply_filters/etc. recursion on same filter kills underlying call) via @ocean90
      • Landed!
    • #37198 (Use `WP_Term_Query` for `wp_get_object_terms()`) via @flixos90
      • Would like some eyes on this.
      • The patch is two months old now, but generally worked and passed unit tests when I did it – I think feedback is needed before this moves forward though.
    • Topics & folks with no updates this week:

    Twenty Seventeen

    • Announcement post is up
    • This will be a call for help on both the theme and theme API fronts as noted last week, and thoughts on what sorts of theme API things will be needed to support the theme (there will be a number noted in the post).
    • For a little bit of a preview, some of the things that should be looked at are better page-on-front flows, making it easier to figure out where to edit something while live previewing (aka customizer), and how we can help people see how the theme can really serve their needs well (when relevant).
    • There will be *a lot* of opportunity for UX and UI when it comes to the core side of things, and of course front-end development with the theme itself. And lots and lots of our traditional PHP and JS development.
  • Grant Palin 6:19 am on September 9, 2016 Permalink |
    Tags: ,   

    Week in Core, August 31 – September 7, 2016 

    Welcome back the latest issue of Week in Core, covering changes [38456-38570]. Here are the highlights:

    Ticket numbers based on trac timeline for the period above. The following is a summary of commits, organized by component.

    Code Changes






    • Fix php warning due to WP_Customize_Manager::prepare_setting_validity_for_js() incorrectly assuming that WP_Error will only ever have arrays in its $error_data. [38513] #37890
    • Introduce paneVisible state and ensure pane is visible when a construct is expanded (or focused). Fixes #36678. [38492] #27403, #36678
    • Fix i18n by re-using the add_new_item post type label instead of using a post type name in a generic string. [38479] #34923, #37895
    • Use new $status_code parameter for wp_send_json_error() instead of calling status_header() separately. [38478] #35666, #37897
    • Improve handling of active state for dynamically-created controls/sections/panels. [38464] #37270


    • Find the correct table names in DELETE queries with table aliases [38507] #37660


    • Update the $message parameter for _default_wp_die_handler() to notate that it can also accept a WP_Error object. [38518] #37770
    • Correct @since entry for the smilies filter added in [38504]. [38505] #35905
    • Move term_description() reference from filter docblock to get_the_archive_description() function docblock. [38495] #37259


    • fix jumpiness on pressing backspace and delete in the Text editor. Merge of [38426] to the 4.6 branch. [38487] #37690


    • Clarify some assertion failure messages and correct a test URL for Twitter timelines. [38514] #32360
    • Update the oEmbed provider test suite. [38512] #32360



    • Handle an edgecase within the URI parsing library included in Requests, where if a double slash exists at the start of the path the URL is passed to cURL malformed. Merge of [38429] to the 4.6 branch. [38485] #37733
    • Accept non-string values in cookies, fixing a regression since 4.5. Merges [38430] to the 4.6 branch. [38461] #37768


    • Revert changes to wp_parse_url() while PHP 5.2 errors are investigated. [38456] #36356


    • revert [38386], functions.php was probably too tempting for some people to not load by itself. [38469] #36335
    • revert [38467], wp_is_IE() should not exist. [38468] #37699
    • use a new function, wp_is_IE(), instead of the $is_IE global in a number of places. [38467] #37699
    • use get_bloginfo( 'version' ) instead of global $wp_version in several locations – excluding those locations which reload version.php mid-flight. [38459] #37699


    • Remove an outdated help sentence on “My Sites” screen. [38474] #37896


    • Add translator comments for XML-RPC strings with placeholders. [38510] #37792

    Login and Registration

    • Change login label to Username or Email Address for clarity. [38477] #37871


    • Sanitize upload filename. [38538] #



    • Deprecate wp_get_network(). [38515] #37553
    • use get_current_site() instead of $GLOBALS['current_site'] (stop yelling!) in a few remaining spots. [38458] #37699
    • use get_current_blog_id() where applicable, in lieu of plucking the $blog_id global from outer space. [38457] #37699

    Post Thumbnails

    • Prevent post thumbnail previews from spilling into other images. Merge of [38433] to the 4.6 branch. [38476] #37697

    Press This

    • don’t check for already-hoisted global in press-this.php. [38466] #37699
    • in wp_ajax_press_this_save_post() and wp_ajax_press_this_add_category(), don’t check for a global instance. WP_Press_This is a Controller, but not really a Singleton. This also keeps it from being a pluggable class, which it is right now. [38465] #37699
    • in get_shortcut_link(), just check a class constant on WP_Press_This instead of instantiating the object and reading an instance prop. [38462] #37699


    • ‘orderby=include’ should support comma-separated lists. [30052] assumed that ‘include’ would be an array. [38500] #37904
    • Use AND in a SQL query rather than &&. [38491] #37903
    • r38356, you were not long for this world. [38471] #37830
    • in wp_old_slug_redirect(), use get_query_var() instead of importing and touching the global $wp_query directly. [38463] #37699


    Script Loader




    • Introduce some taxonomy capability tests in preparation for introducing more fine grained capabilities for terms. [38516] #35614
    • Introduce wp_insert_term_data and wp_update_term_data filters for altering term data before it is inserted/updated in the database. [38484] #22293
    • Correct the function description for wp_ajax_add_link_category(). [38490] #37770
    • Update various docs for parameters which are now WP_Term objects. See #14162 [38489] #37770, #14162


    • After [38486], actually use the $description variable in get_the_archive_description(). [38493] #37259
    • In get_the_archive_description(), add support for author archives. [38486] #37259

    Text Changes

    • Improve Error messages in XML-RPC [38509] #37792
    • Improve the timezone setting description in General Settings. Makes more clear users can set either a city or a UTC timezone offset. [38483] #34789


    • fix toolbars alignment in RTL. Merge of [38349] to the 4.6 branch. [38488] #37760
    • change the default font for the vi locale to the same stack as he_IL. Merge of [38427] to the 4.6 branch. [38472] #37755



    • After [37687], fix the number of params passed to the upgrade hooks. Merge of [38415] to the 4.6 branch. [38475] #37731
    • Sanitize file name in File_Upload_Upgrader. [38524] #



    • After [33766], don’t reset the password when clicking “Show Password” and then “Cancel” on Add New User screen. [38494] #37902, #33419

    Pass $profileuser parameter to user_profile_picture_description filter on “Edit User” screen. [38481] #37379


    • Make the Delete/Remove links red. For consistency and accessibility, all the UI controls that perform destructive actions should be red. [38536] #35622, #37016

    ## Props

    Thanks to @afercia, @Akeif, @akibjorklund, @andrewp, @atimmer, @azaozz, @batmoo, @boonebgorges, @celloexpressions, @Chaos, @curdin, @dd32, @deremohan, @dlh, @DrewAPicture, @Engine, @flixos90, @Frank, @fronaldaraujo, @GaryJ, @geminorum, @gitlost, @GrantDerepas, @henrywright, @ibachal, @ideag, @ionutst, @jeremyfelt, @joemcgill, @johnbillion, @johnjamesjacoby, @johnpgreen, @jorbin, @Klein, @lukecavanagh, @monikarao, @mte90, @netweb, @nmt90, @patilswapnilv, @pento, @peterwilsoncc, @PieWP, @Presskopp, @ramiy, @Rarst, @sayedwp, @scrappy@…, @SergeyBiryukov, @smerriman, @swissspidy, @TimothyBlynJacobs, @turtlepod, @westonruter, and @wonderboymusic for their contributions!

  • Joe McGill 4:11 pm on September 8, 2016 Permalink |
    Tags: ,   

    Media Weekly Update 

    This post serves to jump-start discussion before our weekly check in, which takes place weekly in #core-images on Slack. Our next meeting is Friday, September 9 at 19:00 UTC and the agenda for these meetings include moving priority tasks forward, providing feedback on issues of interest and reviewing media focused tickets on Trac.

    Agenda for our next meeting

    This week, we will continue discussion on our priority projects for the 4.7 release. If you have specific tickets that you want to have discussed, feel free to leave a comment on this post or reach out on Slack in the #core-images channel.

    Recap of our last meeting

    Our last meeting was Friday, September 2. You can read the conversation log in #core-images on Slack.

    Attendees: @joemcgill, @mike, @kkoppenhaver, @lukecavanagh,@paaljoachim, @markoheijnen, @swissspidy, and @azaozz.

    Media library organization improvements

    • @joemcgill and @swissspidy are working on adding the ability to search the media library by filename (#22744).
    • @paaljoachim compiled a lists of WordPress plugins that exist to extend/improve media management and a document comparing features of these plugins.
    • Next step will be to compare the list of current plugins and decide on an initial approach for adding a default taxonomy structure for attachments.
    • Separately, we would like to engage members of the design team in initial conversations about what UI/UX improvements can be made to the media library to make it easier for people to organize and find their media. It’s likely that any UI changes in 4.7 would be relatively light, but we want to begin planning now and focus work during this release on getting as much infrastructure in place as we can.

    Improved full size image optimizations (#37840)

    No real update this week, should pick up once filename search is finished.

    Core Media Widget (#32417)

    @designsimply was traveling. We’ll plan on an update at the next meeting.

    HTTPS fixes

    @johnbillion is planning a make/core post outlining the plan for this release. In the mean time, the list of HTTPS related issues can be found in this report.

    PDF Thumbnails (#31050)

    @markoheijnen is reviewing the issue and looking into how plugins have addressed some of the remaining bugs.

    Accents in attachment filenames should be sanitized (#22363)

    @mike is reviewing feedback on this issue, but is planning on committing an initial fix soon.

    Rotate full size images on upload (#14459 and related #33051)

    @markoheijnen is looking at this issue for 4.7.

    • djsteveb 10:16 pm on September 14, 2016 Permalink | Log in to Reply

      No idea where best place to post about these issues.. let me know and I’ll add details.

      Attachments / media view crashes a lot for some of my wp sites when there is a lot of media.. think pages of images and video thumbnails loading when click on media -> library or whatever. Wish I could show you how painful it is to do this with a buddypress install, and a few users who upload – especially with rtmedia plugin making it easy to add media. sometimes the page takes forver to load, sometimes it fails.

      We need a way to limit how many media gets displayed by default, how much browser memory gets used when sucking in the thumbnails and such on these views.. and the tabs could be used to choose only to show media by certain users, etc.

      It’s also a major pain point in that in many cases users are able to see other user’s uploads when using buddypress. I used one setting with ‘press permit core’ plugin to fix this – but that’s overkill – and many don’t know about this and freak out when it comes to light.

      PASSWORD work around

      Recently discovered that having a secret image added to a page that is set as not public / passwrod required.. these are easily found when clicking next / next via themes’ image / media view.. certainly something should be done that says “if image is attached to page or post that is not public” – require password or admin account to view or something?

  • Joe McGill 4:01 am on September 2, 2016 Permalink |
    Tags: ,   

    Media kickoff meeting recap (August 26) 

    This is a recap from the the Media Component kickoff meeting last Friday, August 26. The main goal of this meeting was to discuss potential focus areas for 4.7. Read the conversation log in #core-images on Slack. Our next meeting is Friday, September 2 at 19:00 UTC. The agenda will be to continue discussion on priority projects and review media focused tickets on Trac.

    Attendees: @joemcgill, @bravokeyl, @mike, @azaozz, @nonproftechie, @designsimply, @johnbillion, @iseulde, and @paaljoachim.

    Media library organization improvements

    Defining scope for this project is important in order to make meaningful progress. Here is an outline of the plan that was discussed:

    • Start simple by addressing #22744
    • Begin discussing a default taxonomy structure for media in Core
    • Research existing plugins that address media organization and review approaches to taxonomy/data structure and UX/UI (@paaljoachim volunteered to put together an initial list in this Google Doc)
    • Research non-WP apps for UX/UI inspiration

    We may only do bits of this in 4.7, but the research should result in an initial proposal/road map for the media library including any recommendations about data structure, API, or UI changes that may be required.

    PDF thumbnails (#31050)

    @markoheijnen is leading this effort. People can get involved with testing and knocking out the final bugs/edge cases. Assistance from people with existing PDF/ImageMagick experience would be grand.

    Add WP_Image and/or WP_Attachment (#23424)

    Core could benefit from a standard way of modeling attachment data, including methods for generating/retrieving pieces of that data without redundant calls to lower level functionality. However, as @johnbillion pointed out, this should start with a well defined set of use cases which demonstrates the problems we would be addressing by adding new classes.

    This is probably a lower priority for this release unless there is increased interest.

    Better full size image optimization (#37840)

    Many authors upload and embed unoptimized full size images in their content. We may be able increase front end performance by optimizing full size uploads. Some initial suggestions to this end include:

    • Look into creating an official ‘full’ or ‘master’ size which would replace uncompressed uploads on the front end and could potentially be used to speed up additional edit operations.
    • It’s important that the original upload be stored as is and not affected at all so we always retain a “gold standard” backup.
    • We would need to account for times where users are optimizing their images before uploading, i.e., this new method shouldn’t add page weight.
    • If adding a new size is required for this, it will likely require optimizing the time and memory it takes to resize to avoid the dreaded “HTTP Error” (#37853)
    • Additionally, could we be smarter about creating intermediate sizes and only do so when an intermediate size would reduce file size and not just dimensions?
    • We may want to define maximum dimensions for the “full” size.

    Core media widget (#32417)

    A lot of progress has already been made on this feature, but it seems to have gotten stuck in a complexity/decision rut. The media component team may be able to help shepherd this project in 4.7 by supporting those already working on it.

    @designsimply suggests simplifying the approach to only support images for a V1 may help move things forward. Either way, decisions need to be made about what should be supported in an MVP and a plugin should probably created for testing.

    HTTPS issues

    We fixed many HTTPS bugs in 4.4 and 4.5, but there are still many remaining issues.

    @johnbillion is planning on leading a working group to pick this effort back up fo 4.7, with a focus on:

    1. Fixing HTTPS bugs, and
    2. Aiding users switching from HTTP to HTTPS, in whatever form that takes.

    Copy/paste images directly into the editor (#27970)

    This request gained some interest in the wishlist post. @azaozz and @iseulde have looked into this in the past and it seems the concerns outlined in the original ticket remain, so this is probably still a wontfix for now.

    • FolioVision 12:34 pm on September 2, 2016 Permalink | Log in to Reply

      Thanks for this very comprehensive summary Joe.

      You wrote:

      Look into creating an official ‘full’ or ‘master’ size which would replace uncompressed uploads on the front end and could potentially be used to speed up additional edit operations. It’s important that the original upload be stored as is and not affected at all so we always retain a “gold standard” backup.

      I really like the idea of a standard master size maximum (with potential for special case override even if it has to be done in wp-config.php).

      I disagree strongly about not touching the original upload. WordPress is not a raw file image archiving system and should not be used as such. It’s not fair to webhosts (remember WordPress is supposed to play well in shared hosting) or in the end to users as it leaves users with absurdly large media folders.

      What could help is if we build in best practice image optimisation so that these masters are stored properly but without excess weight.

      Those who do want to build an image archiving system with WordPress should be able to override these defaults to store the original image but not easily. This would benefit 90%+ of the people running WordPress to run smoother faster sites which are more easily migrated. I don’t see a good reason for the 10% usage case to slow sites all over the world and create crazy storage issues for hosts.

      Perhaps I’m missing something here. I’m making one side of the case, but from experience. We host clients with very image intensive and high traffic sites. We also deal with neophyte clients who upload large quantities huge images with zero need to store originals on their server. Setting up each site to behave in a sane way is a big time drain. I can’t imagine the nightmare for hosts who run normal shared hosting businesses.

  • Jeff Paul 1:02 am on September 2, 2016 Permalink |
    Tags: , ,   

    Dev Chat Summary: August 31 (4.7 week 2) 

    This post summarizes the dev chat meeting from August 31st (agenda, Slack archive).

    Holidays & Scheduling

    • Reminder to announce meeting moves or cancellations (e.g., Monday is US Labor Day holiday, Monday after is Eid al Adha)

    Update on 4.6.1

    #36335: Autoloader and #37699: Globals

    • Discussion framing: see these as being feature projects in their own right, examples of when features can’t be actual plugins and why it’s better to think of them as projects. How can these be worked on effectively?
    • Discussion:
      • New project on GitHub that’s a clone of the WP Git repo
      • grunt patch allows you to use GitHub PR URLs, which can help facilitate testing for people that prefer using SVN or are using SVN for their trunk installs.
      • Trac + SVN workflow seems to work best when we’re dealing with patches and discussion leading to an individual commit; is probably a pretty poor option without some additional tools.
      • Creating feature branches for wide-ranging work seems to be a better fit and allows for less churn of the code in trunk at the same time as other major work.
      • Nice to review & collaborate on a big feature on a GitHub feature branch as opposed to wrangling conflicting and amending patches on Trac
    • Suggestion to @wonderboymusic: fork @jorbin‘s GitHub mirror, use GH issues and develop in various branches as makes sense (or even separate forks entirely if issues become unwieldy across very different projects), and use PRs to run existing CI setup. PRs can then be used as patches in grunt patch
      • If treated as a feature project, all of that project’s management happens wherever the lead feels best serves that project. There should also be weekly meetings with updates posted on Make/Core. @wonderboymusic to determine a meeting time and post about it next week.
      • @wonderboymusic@helen in agreement on approach; GitHub repo created
    • Related question: How do we determine what sort of tasks should be feature projects? Who decides that? And when?
      • Some things to think about – is it a lot of churn? Does it need to span multiple releases and/or is it a “done when it’s done” process? Is there a lot of design and user testing involved? They exist whenever somebody has a thing they believe belongs in core and wants to run with it in that way. Getting feedback is an evolving process.

    4.7 Project/Feature Proposals

    • Goal: come out of this with the start of a list of projects and a point person for that project, to be fleshed out with more participants and meeting times over the next week.
    • @johnbillion – HTTPS
    • @celloexpressions – Customize component project & owner
      • Create page-based nav menus without leaving live preview – #34923@celloexpressions (follow up tickets forthcoming)
      • A new experience for themes in the customizer – #37661@celloexpressions
      • Code-editing gateways, via CSS – #35395@johnregan3
      • Customizer browser history – #28536@westonruter
      • Refactoring sliding panels UI – #34391@delawski
      • (maybe) Customize transactions (with no UI) – #30937@westonruter
      • will track all of the Customize projects with the weekly Customize component meetings and Make/Core posts usually posted on Thursdays starting this week
    • @krogsgard – REST API
      • had a productive start on Monday and will have a summary up shortly
    • @boonebgorges – #20875
      • work with cache drop-in authors so that we can start leveraging across WP
    • @davidakennedy – #19627
    • @helen – there needs to be a dedicated theming API/support team because there will be a Twenty Seventeen; actual details on that next week. There will need to be really robust teams on both the theme and theme support pieces, likely with subteams even.
      • @karmatosed: splitting core themes as a bucket for all theme into, core themes and theme functionality
      • @helen: noting that theme functionality will spill over into other components (media seems incredibly likely)
      • @themiked: interested in theming work, on the API/support side if that’s whats needed
    • @joemcgill – Media focus candidate & owner; will shepherd these through regular #core-images meetings
    • @azaozz – will publish “4.7 editor wishlist” by the end of the week
      • to include Nonce refresh/saving without page reload, and few others
    • @sc0ttkclark – Fields API

    Ways YOU Can Help!

    • Please comment below if there are things that didn’t get mentioned that you’d like to lead.
    • Design help and user test coordination (alongside @karmatosed) desired on #37661 by @celloexpressions, please respond if you’re open to help on this.
compose new post
next post/next comment
previous post/previous comment
show/hide comments
go to top
go to login
show/hide help
shift + esc
Skip to toolbar