Make WordPress Core

Updates from Erick Hitter Toggle Comment Threads | Keyboard Shortcuts

  • Erick Hitter 9:45 pm on February 19, 2013 Permalink
    Tags: ,   

    Revisions Update, 2/19 

    Following two consecutive days of office hours, we’ve reached a consensus on what the UI should be for comparing a single revision to the current version of a post:


    Based on the above mockup from @karmatosed, @adamsilverstein is continuing development of the new revisions interface on ticket #23497.

    Once we have an acceptable, working prototype, we’ll revisit how to present the interface for comparing two different revisions. @nacin suggested, and we generally agreed, that a single slider with two grabbers would likely be a workable approach, but we’ll discuss that further once the above interface is implemented.

    No progress to report on the other tickets scoped for 3.6 as we’ve been focused on UI lately.

    [IRC log]

    • Ben Tremblay 9:58 pm on February 19, 2013 Permalink | Log in to Reply

      1st thought: the chunks appear w/o context. (I imagine it with a snippet of before and after.) You okay with that?

      • Grant Palin 10:50 pm on February 19, 2013 Permalink | Log in to Reply

        Agreed, context is important. Just where in the document the shown snippet is located can make a dig difference.

      • adamsilverstein 11:27 pm on February 19, 2013 Permalink | Log in to Reply

        yes, for sure.

        although the mockup doesn’t make it clear, you will actually see your full document content, showing what has been removed, added (and what stayed the same), so the context is shown.

      • Peter Westwood 3:23 pm on February 21, 2013 Permalink | Log in to Reply

        The chunks appear without context because the mockup happens to show a full post rewrite 🙂

    • RENAUT 7:19 am on February 20, 2013 Permalink | Log in to Reply

      no more “follow the white rabbit !” ? snif !

    • aldo.roman 7:11 pm on February 20, 2013 Permalink | Log in to Reply

      I follow the GIT (or others) DIFF as the mockup shows a ‘ + ‘ and a ‘ – ‘ signs, but I don’t think the end user will need them. Maybe the colours is enough and we can have a cleaner screen.

  • Erick Hitter 5:22 pm on February 18, 2013 Permalink
    Tags: ,   

    Revisions Update, 2/18 

    We’ve scheduled an additional office hours for Tuesday, February 19, at 2000 UTC in #wordpress-dev.

    During today’s meeting, we reviewed @adamsilverstein‘s prototype on #23497, which led to a lengthy discussion about how the prototype related to our mockups, specifically https://core.trac.wordpress.org/attachment/ticket/23396/revisions9.png.

    @karmatosed will prepare a revised mockup for tomorrow that incorporates the slider introduced in #23497, and @adamsilverstein will tweak the prototype as well so that comparing a revision to the current version is the default behaviour.

    The feeling is that we’re straying from our intended goals, and I didn’t want to wait until our Thursday office hours to refocus. After tomorrow’s meeting, I’ll post a more detailed recap of where the Revisions team stands.

    [IRC log]

  • Erick Hitter 4:47 pm on February 13, 2013 Permalink
    Tags: ,   

    Revisions Update, 2/11 

    As has been the case for many sessions now, Monday’s revisions office hours focused on changes to the UI. @karmatosed provided new mockups, influenced by a thread on the Accessibility blog. @adamsilverstein also posted a series of patches on #23396 that begin to implement the general direction we’ve chosen for UI updates (aside: we’ll do our best to keep future mockups on this ticket, for easier discovery; until now, most have been posted in the comments on these update threads). We are certainly approaching a consensus on the new design, but have held off on any significant UI-specific coding until we’re confident that our efforts won’t be wasted.

    Beyond UI, there are patches on three tickets that could use testing: #16215, #22289, and #19932. @adamsilverstein and @westi are working on unit tests, which should help move the patch review along.

    We should have new mockups to review during tomorrow’s office hours at 1500 UTC in #wordpress-dev.

    [IRC log]

  • Erick Hitter 4:39 pm on February 7, 2013 Permalink
    Tags: ,   

    Revisions Update, 2/7 

    We started today’s office hours by reviewing @karmatosed‘s latest mockups for the revisions screen. We’re in agreement that these reflect the direction we’ll take, so @adamsilverstein will begin coding the changes in preparation for Monday’s meeting. As some concerns have been raised about the use of red and green, @karmatosed will post to the Accessibility group’s P2 asking for feedback on the current mockups. She will also explore the use of patterns to differentiate additions and deletions, as suggested by @helen.

    @westi made a few suggestions, based on his recent experiences with Revisions, which we’ve agreed to incorporate. For clarity, the current version will be included in the revisions list to provide a stronger connection with the overall revisions workflow. Second, we decided that when first landing on the revision screen for a given post, we should show the diff of the current version and its immediate predecessor revision; since most users are probably looking for this anyway, why not save them a step?

    Lastly, we chatted about the status of code-oriented tickets scoped for 3.6. A few (#16215, #22289, and #19932) have patches, which we’ll be reviewing and providing feedback on before Monday’s meeting. With any luck, we can land at least one in Core before the next dev chat. Beyond that, development on the remaining tickets should progress over the weekend, with the aim of having more patches to review for our next office hours.

    For reference, the tickets that are in scope for 3.6 (at least at this point), can be found here.

    [IRC Log]

  • Erick Hitter 7:43 pm on February 5, 2013 Permalink
    Tags: ,   

    Revisions Update, 2/5 

    Yesterday’s meeting focused on revisions to the revisions interface :). @lessbloat joined us to ask some great questions, and helped refocus the UI changes that have been proposed and mocked up so far. We started off by trying to identify the major uses of revisions, and settled on two primary cases: undoing mistakes by finding the last correct revisions, and reviewing changes as part of an editorial workflow.

    In light of those focuses, we’ve decided to revisit the UI mockups we’ve (namely, @karmatosed and @adamsilverstein) worked on so far. The general consensus is that they’ve become overly complicated, and led to feature creep (looking at you, line-by-line accept/reject capabilities). @karmatosed is working on some new mockups for Thursday’s office hours. One possible source of inspiration may be @benbalter‘s post forking plugin.

    On the code side, @mdawaffe worked out a pretty comprehensive patch for the display of incorrect authors on revisions (#16215). We’ll be reviewing that, along with the patches added to the other tickets we’ve scoped for 3.6. As was the case when I last posted, progress is slow at this point due to travel and the ongoing UI discussions.

    [IRC log]

    • adamsilverstein 8:47 pm on February 5, 2013 Permalink | Log in to Reply

      i posted patches for testing that implement some of the mockup concepts we talked about during our meeting here – #23396

    • karmatosed 2:56 pm on February 7, 2013 Permalink | Log in to Reply

      I’ve got some more mockups for discussion in the meeting today here:

      I spent some time with @benbalter‘s plugin and merged that with some of the ideas that seemed ‘easy wins’ from a UI view. It’s mainly a tidy up in a lot of respects. I did one with notes but understand this feature probably will not be included – I just wanted to see what it looked like.

      I felt the picking in the post forking plugin worked well for that instance but may be overly complicating for us as the ‘new’ would always be the newer version so that’s what I was keeping to by you just picking 2. I didn’t add a submit or confirm as figured if you picked 2 it could reload – we may want to reconsider this as perhaps a pause through clicking something could be useful.

  • Erick Hitter 11:21 pm on January 25, 2013 Permalink
    Tags: ,   

    Revisions Update, 1/25 

    Yesterday, the revisions team had its second scheduled office hours chat in #wordpress-dev at 1600 UTC. @karmatosed and I were both afk, and our first chat was earlier this week, so it was a short meeting [IRC log].

    @nacin popped in to mention that he’ll be working on the API for draft changes to published content. This will overlap with, but shouldn’t take away from, the revisions efforts our team is working on. For reference, the ticket’s we’ve scoped for 3.6 are listed here.

    Overall, progress this week has been tentative, mostly focused around #16215 and #16847; thanks to @adamsilverstein for his efforts on those tickets thus far. A big area of focus in the near-term will be the UI improvements—there’s been a fair bit of discussion on this front in the comments here and here.

    Our next meeting is Monday, January 28, at 1600 UTC. At the moment, our office hours on Thursdays conflict with the Post Formats team, so one of us will have to move. We’ll keep the hours listed in the sidebar updated as we move forward.

compose new post
next post/next comment
previous post/previous comment
show/hide comments
go to top
go to login
show/hide help
shift + esc
Skip to toolbar