WP_Query used internally in get_pages()

Welcome!

The WordPress coreCore Core is the set of software required to run WordPress. The Core Development Team builds WordPress. development team builds WordPress! Follow this site for general updates, status reports, and the occasional code debate. There’s lots of ways to contribute:

Found a bugbug A bug is an error or unexpected result. Performance improvements, code optimization, and are considered enhancements, not defects. After feature freeze, only bugs are dealt with, with regressions (adverse changes from the previous version) being the highest priority.? Create a ticket in the bug tracker.

Want to contribute? Get started quickly with tickets marked as good first bugs for new contributors or join a bug scrub. There’s more on the reports page, like patches needing testing, and on feature projects page.

Other questions? Here is a detailed handbook for contributors, complete with tutorials.

In WordPress 6.3, the function get_pages() has been updated to utilize WP_Query internally, resolving a 13-year-old ticketticket Created for both bug reports and feature development on the bug tracker. (#12821). This modification significantly reduces the complexity of the get_pages() function by offloading the burden of querying databases and handling the cache to WP_Query. The change builds upon the previous enhancementenhancement Enhancements are simple improvements to WordPress, such as the addition of a hook, a new feature, or an improvement to an existing feature. introduced in #22176, which introduced query caching to WP_Query.

As a result, this update eliminates redundant code and ensures that all filters running in WP_Query are now also applied during the call to get_pages(). Users who leverage filters like posts_pre_query or posts_results to customize the behavior of WP_Query, such as retrieving data from alternative sources like cache or another database (e.g., elastic search), will benefit from this change.

Additionally, based on feedback from the glotpress team, a new filterFilter Filters are one of the two types of Hooks https://codex.wordpress.org/Plugin_API/Hooks. They provide a way for functions to modify data of other functions. They are the counterpart to Actions. Unlike Actions, filters are meant to work in an isolated manner, and should never have side effects such as affecting global variables and output. named get_pages_query_args has been added. This filter enables developers to modify the parameters passed to WP_Query, maintaining compatibility with the original parameter arguments.

See #56586 and #55806 for additional context.

Props to @flixos90 for peer review, to @stevenlinx and @leonnugraha for review.

#6-3, #dev-notes, #dev-notes6-3

$args = [ 'parent' => $post_id, 'meta_key' => '_wp_page_template', // We need this meta_key elsewhere 'post_type' => 'course', 'post_status' => 'publish', ]; $posts = get_pages($args);

$all_published_decendants_args = [ 'child_of' => $parent_post_id, 'post_type' => 'course', 'post_status' => 'publish', 'sort_column' => 'menu_order', ]; $posts = get_pages($all_published_decendants_args);

$all_published_decendants_args = [ 'child_of' => $parent_post_id, 'post_type' => 'course', 'post_status' => 'publish', 'sort_column' => 'menu_order', 'meta_key' => '_wp_page_template', 'meta_value' => COURSE_TEMPLATE ]; $posts = get_pages($all_published_decendants_args);

todditron 4:11 pm on August 10, 2023
I think get_pages used to return a meta_key if we requested one, is that no longer the case?
```
    $args = [
      'parent' => $post_id,
      'meta_key' => '_wp_page_template', // We need this meta_key elsewhere
      'post_type' => 'course',
      'post_status' => 'publish',
    ];

    $posts = get_pages($args);
```
In that case, the posts returned would have the meta_key available. That doesn’t seem to work anymore, does it?
- todditron 4:17 pm on August 10, 2023
  
  This is the scenario I was using this for
  
  https://wordpress.stackexchange.com/a/403764
todditron 5:05 pm on August 10, 2023
Sorry for bombing on this thread, but it seems like the meta filter no longer works on get_pages either. The documentation suggests that metaMeta Meta is a term that refers to the inside workings of a group. For us, this is the team that works on internal WordPress sites like WordCamp Central and Make WordPress. filterFilter Filters are one of the two types of Hooks https://codex.wordpress.org/Plugin_API/Hooks. They provide a way for functions to modify data of other functions. They are the counterpart to Actions. Unlike Actions, filters are meant to work in an isolated manner, and should never have side effects such as affecting global variables and output. should work still.

Example I am battling with
```
    $all_published_decendants_args = [
      'child_of' => $parent_post_id,
      'post_type' => 'course',
      'post_status' => 'publish',
      'sort_column' => 'menu_order',
    ];
    $posts = get_pages($all_published_decendants_args);
```
= 26 posts, which is correct
```
    $all_published_decendants_args = [
      'child_of' => $parent_post_id,
      'post_type' => 'course',
      'post_status' => 'publish',
      'sort_column' => 'menu_order',
      'meta_key' => '_wp_page_template',
      'meta_value' => COURSE_TEMPLATE
    ];
    $posts = get_pages($all_published_decendants_args); 
```
= 0 posts which is incorrect and should equal 21, which is a subset of the unfiltered count.

Comments are closed.

Welcome!

Communication

Share this: