WordPress 5.5.1 Bug Scrubs

Welcome!

The WordPress coreCore Core is the set of software required to run WordPress. The Core Development Team builds WordPress. development team builds WordPress! Follow this site for general updates, status reports, and the occasional code debate. There’s lots of ways to contribute:

Found a bugbug A bug is an error or unexpected result. Performance improvements, code optimization, and are considered enhancements, not defects. After feature freeze, only bugs are dealt with, with regressions (adverse changes from the previous version) being the highest priority.? Create a ticket in the bug tracker.
Want to contribute? Get started quickly with tickets marked as good first bugs for new contributors or join a bug scrub. There’s more on the reports page, like patches needing testing, and on feature projects page.
Other questions? Here is a detailed handbook for contributors, complete with tutorials.

The following bugbug A bug is an error or unexpected result. Performance improvements, code optimization, and are considered enhancements, not defects. After feature freeze, only bugs are dealt with, with regressions (adverse changes from the previous version) being the highest priority. scrubs have been scheduled on tickets milestoned for 5.5.1, the conversations will take place in #core, and all are welcome to attend and take part in these meetings (requires registration).

Friday, August 21, 2020 at 16:00 UTC hosted by @davidbaumwald
Monday, August 24, 2020 at 20:00 UTC hosted by @audrasjb

As a refresher, here’s a post by @jorbin from the 4.7 release cycle answering questions about bug scrubs.

Reminder that the timeline for 5.5.1 will be determined after these bug scrubs and during the devchat on Wednesday, August 26, 2020 at 20:00 UTC in #core.

#5-5-1, #bug-scrub

hmabpera 3:26 am on August 22, 2020

I updated to WordPress 5.5 and the new twentyeleven theme tonight. I sometimes have to edit some of the php files to use in our twentyeleven Child ThemeChild theme A Child Theme is a customized theme based upon a Parent Theme. It’s considered best practice to create a child theme if you want to modify the CSS of your theme. https://developer.wordpress.org/themes/advanced-topics/child-themes/.. I didn’t expect there would be any changes in the theme php files with 5.4 and those with 5.5 but I always check. Here’s what I noticed:
Comparing files 5-4-showcase.php and ..\NEWFILES\SHOWCASE.PHPPHP The web scripting language in which WordPress is primarily architected. WordPress requires PHP 5.6.20 or higher
***** 5-4-showcase.php
35: */
36: if ( ” != get_the_content() ) {
37: get_template_part( ‘content’, ‘intro’ );
***** ..\NEWFILES\SHOWCASE.PHP
35: */
36: if ( ” !== get_the_content() ) {
37: get_template_part( ‘content’, ‘intro’ );
*****
and
Comparing files 5-4-header.php and ..\NEWFILES\HEADER.PHP
***** 5-4-header.php
50:
51:
52: <link rel="stylesheet" type="text/css" media="all" href="?ver=20190507″ />
***** ..\NEWFILES\HEADER.PHP
50:
51:
52: <link rel="stylesheet" type="text/css" media="all" href="?ver=20190507″ />
*****

***** 5-4-header.php
135: // Has the text been hidden?
136: if ( ‘blank’ == get_header_textcolor() ) :
137: $header_image_class = ”;
***** ..\NEWFILES\HEADER.PHP
135: // Has the text been hidden?
136: if ( ‘blank’ === get_header_textcolor() ) :
137: $header_image_class = ”;
*****

***** 5-4-header.php
135: // Has the text been hidden?
136: if ( ‘blank’ == get_header_textcolor() ) :
137: $header_image_class = ”;
***** ..\NEWFILES\HEADER.PHP
135: // Has the text been hidden?
136: if ( ‘blank’ === get_header_textcolor() ) :
137: $header_image_class = ”;
*****
You see the use of !==, httpsHTTPS HTTPS is an acronym for Hyper Text Transfer Protocol Secure. HTTPS is the secure version of HTTP, the protocol over which data is sent between your browser and the website that you are connected to. The 'S' at the end of HTTPS stands for 'Secure'. It means all communications between your browser and the website are encrypted. This is especially helpful for protecting sensitive data like banking information. and === in the newfiles twentyeleven theme. I used the code from 4.5 twentyeleven theme which uses !=, httpHTTP HTTP is an acronym for Hyper Text Transfer Protocol. HTTP is the underlying protocol used by the World Wide Web and this protocol defines how messages are formatted and transmitted, and what actions Web servers and browsers should take in response to various commands. and == in its files. I don’t know if this is serious but there you have it.
I’m confident that != and == are correct but should I use http or https in that path?
thanks.
- hmabpera 3:27 am on August 22, 2020
  
  I forgot to ask to be notified of Reply.
  - Kevin Hagerty 3:48 am on August 22, 2020
    
    Regarding header.php:
    Line 51 changed to use httpsHTTPS HTTPS is an acronym for Hyper Text Transfer Protocol Secure. HTTPS is the secure version of HTTP, the protocol over which data is sent between your browser and the website that you are connected to. The 'S' at the end of HTTPS stands for 'Secure'. It means all communications between your browser and the website are encrypted. This is especially helpful for protecting sensitive data like banking information. for the link to gmpg .org/xfn/11
    
    That was intentional. Use https there.
    
    Also the changes to === and !== were intentional, its okay to allow those change to your theme files.
hmabpera 2:50 pm on August 22, 2020

Thank you. I will make the changes in my twentyeleven-child files. I appreciate your explanation. I did some research and now I understand. My mistake.
Identical Operator ===

The comparison operator called as the Identical operator is the triple equal sign “===”. This operator allows for a much stricter comparison between the given variables or values.
This operator returns true if both variable contains same information and same data types otherwise return false.

Comments are closed.

Welcome!

Communication

Share this: