Below is a summary of the discussion from this week’s JavaScript JavaScript or JS is an object-oriented computer programming language commonly used to create interactive effects within web browsers. WordPress makes extensive use of JS for a better user experience. While PHP is executed on the server, JS executes within a user’s browser. https://www.javascript.com/. chat (agenda, Slack Transcript). Thanks to @cbravobernal for compiling these notes!
Have a topic for discussion for the next meeting? Leave a suggested edit on next week’s agenda.
Visual Testing Revisited
(Slack conversation)
@aduth talks about taking a look to the tool Chromatic. It is integrated with Storybook and seems to be capable of making visual regression A software bug that breaks or degrades something that previously worked. Regressions are often treated as critical bugs or blockers. Recent regressions may be given higher priorities. A "3.6 regression" would be a bug in 3.6 that worked as intended in 3.5. tests of isolated components.
Team talks about how important it is to focus and give a little more love to Storybook.
Q comments that will be more important as they focus on
Chromatic turns your stories into visual test baselines. Each story is rendered in Chrome, Firefox, and Internet Explorer 11 simultaneously then compared to a screenshot of the “last known good state”. Whenever there are UI User interface differences you get notified.
We have to notice that there is already a pull request for end-to-end testing with browserstack for old browsers.
There is a “sponsorship” for Chromatic with Open Source Open Source denotes software for which the original source code is made freely available and may be redistributed and modified. Open Source **must be** delivered via a licensing model, see GPL. projects. See link
Action:
- Follow-up on this, or to start experimenting. (needs champion)
Coding Guidelines Documentation
(Slack conversation)
@aduth asks for opinion about these pull requests:
@aduth observed some relation to “language support” and “React React is a JavaScript library that makes it easy to reason about, construct, and maintain stateless and stateful user interfaces. https://reactjs.org/. components”, since there’s been a handful of requests recently that “X” JavaScript feature be supported in order to make writing class components easier. He is going to merge them in a near future (some are already merged).
Also, the team has committed that Gutenberg The Gutenberg project is the new Editor Interface for WordPress. The editor improves the process and experience of creating new content, making writing rich content much simpler. It uses ‘blocks’ to add richness rather than shortcodes, custom HTML etc. https://wordpress.org/gutenberg/ will only support TC39 Stage 4 (“Finished”) ECMAScript (JavaScript) language features.
Action:
Open Floor
Block Block is the abstract term used to describe units of markup that, composed together, form the content or layout of a webpage using the WordPress editor. The idea combines concepts of what in the past may have achieved with shortcodes, custom HTML, and embed discovery into a single consistent API and user experience. IDs
(Slack conversation)
@sageshilling has an issue: when looking at blocks in the post ,they don’t have an id associated with them. Images and reusable blocks have the post_id, but the post_id updates with the page edits. Also, the block attributes has no identifier- that’s unique and constant throughout. With tables we have the unique key, so it’s something that we’re used to having to use as a reference.
Action:
- Continue the discussion in a pull request or issue.
Auth Check Interval
(Slack conversation)
@dsix asks for review at #49573 . The issue is that the server-side code was updated to ignore auth_check_interval parameter in the heartbeat request, so that value has no effect.
His assumption, based on the fact that the server-side code was changed to return the auth_check data on every heartbeat, was that the interval was no longer needed.
Action:
- Invest more time for testing / feedback. Ping The act of sending a very small amount of data to an end point. Ping is used in computer science to illicit a response from a target server to test it’s connection. Ping is also a term used by Slack users to @ someone or send them a direct message (DM). Users might say something along the lines of “Ping me when the meeting starts.” the people involved in the original change.
#core-js, #javascript
