Have a topic for discussion for the next meeting? Leave a suggested edit on next week’s agenda.
@davilera mentions in the pull request issues a developer might face when using the date package and proposed how to solve them. Namely, source timezone, target timezone, and possible translation The process (or result) of changing text, words, and display formatting to support another language. Also see localization, internationalization. of the final date. People noticed that the package is not considering timezone.
Regarding PHP The web scripting language in which WordPress is primarily architected. WordPress requires PHP 5.6.20 or higher side, date_i18n() is remarked to be “illogical, incompatible with Unix timestamps, and in order to be deprecated”.
- Identifying the minimum changes required to fix the original issue that PR tried to solve
- Open a new issue where a discussion on if and how to refactor the package
- Look at the current PHP implementation and trying to reconcile the two
Dropdown rendering with modals
At first, the dropdown wasn’t rendering properly. But once the positioning was fixed, two more issues arose:
- In a dropdown with multiple fields (such as, for instance, the one you get when using DateTimePicker), tabbing from one field to the other doesn’t work, as the focus moves away from the dropdown, back to the modal. This is an accessibility Accessibility (commonly shortened to a11y) refers to the design of products, devices, services, or environments for people with disabilities. The concept of accessible design ensures both “direct access” (i.e. unassisted) and “indirect access” meaning compatibility with a person’s assistive technology (for example, computer screen readers). (https://en.wikipedia.org/wiki/Accessibility) issue.
- Dropdowns should be closed when one clicks outside of them. But this only works if you click outside of both the dropdown and the modal. Clicking on the modal doesn’t close the dropdown. Dunno what kind of issue this one is.
The mechanism that are affecting this behaviour is the SlotFill system
@itsjonq says that the mechanism that are affecting this behaviour is the SlotFill system, and currently @hazdiego is working on an (unrelated) PR to start refactoring it:
After a little discussion about how hard is to work on focus, modals, dropdowns…
Open Floor: Markdown linter
@mkaz announce that he introduced a lint-md script that lints code blocks inside markdown. This uses a new
.eslintrc-md.js config in scripts package to turn down some of the noise due to documentation being snippets of code.
Right now you need to run manually, we can fine tune and adjust the config before automating further. Try it out using:
npm run lint-md [your-file] or if no file specified it runs across all markdown documents.
Removing ES5 snippets is discussed also.
- Try out the new script lint-md especially if writing or updating any markdown and source and we can see how it goes
Open Floor: NPM publishing
@gziolo propose to grant npm permissions to @jonsurrell and Bernie Reiter so they could help with releases. Also talk about automate CHANGELOG file updates on the release day.
- Grant NPM accesses (owned by @aduth)
- Keep working on improving release workflow.