Omar Reiss 3:11 pm on July 2, 2019
Tags: core-js ( 131 ), corejs ( 8 ), javascript ( 129 ), meeting notes ( 227 )

JavaScript chat summary, June 25th + July 2nd, 2019

Below is a summary of the discussion from the JavaScriptJavaScript JavaScript or JS is an object-oriented computer programming language commonly used to create interactive effects within web browsers. WordPress makes extensive use of JS for a better user experience. While PHP is executed on the server, JS executes within a user’s browser. https://www.javascript.com/. chat of the last two weeks (agenda June 25th, Slack Transcript June 25th, agenda July 2nd, Slack Transcript July 2nd)

Have a topic for discussion for the next meeting? Leave a suggested edit on next week’s agenda.

Agenda: E2E Test infrastructure for CoreCore Core is the set of software required to run WordPress. The Core Development Team builds WordPress.

Slack Conversation June 25th

A ticketticket Created for both bug reports and feature development on the bug tracker. was created by @youknowriad which seeks to incorporate Gutenberg’s end-to-end test setup into WordPress core: https://core.trac.wordpress.org/ticket/45165. The patch has been reviewed by multiple members of the Core JS team and was eventually committed. @youknowriad wrote a devnotedev note Each important change in WordPress Core is documented in a developers note, (usually called dev note). Good dev notes generally include a description of the change, the decision that led to this change, and a description of how developers are supposed to work with that change. Dev notes are published on Make/Core blog during the beta phase of WordPress release cycle. Publishing dev notes is particularly important when plugin/theme authors and WordPress developers need to be aware of those changes.In general, all dev notes are compiled into a Field Guide at the beginning of the release candidate phase. here:

Introducing the WordPress e2e tests

Agenda: E2E Tests – next steps

Slack Conversation July 2nd

With the e2e framework now in core, we can start adding testcases. A few good next steps were raised:

Encouraging people to write tests, anytime we notice a regressionregression A software bug that breaks or degrades something that previously worked. Regressions are often treated as critical bugs or blockers. Recent regressions may be given higher priorities. A "3.6 regression" would be a bug in 3.6 that worked as intended in 3.5. or an important feature. Some coordination would probably help. Who could help lead/organize it?
Try to run the GutenbergGutenberg The Gutenberg project is the new Editor Interface for WordPress. The editor improves the process and experience of creating new content, making writing rich content much simpler. It uses ‘blocks’ to add richness rather than shortcodes, custom HTML etc. https://wordpress.org/gutenberg/ e2e tests (maybe not all of them) in Core’s CI as well. This would allow upgrading the npm packages from Gutenberg in Core with more confidence.
Extending the framework to be able to run tests across PHPPHP The web scripting language in which WordPress is primarily architected. WordPress requires PHP 7.4 or higher versions could definitely be helpful for smoke testing pages, checking there are no warnings, etc.
Improving the documentation with regard to e2e test would also be valuable.

These points could best be raised in Devchat as well, as they transcend the realm of Core JSJS JavaScript, a web scripting language typically executed in the browser. Often used for advanced user interfaces and behaviors..

Agenda: Build all Core JS with WebPack

Slack Conversation

A new patchpatch A special text file that describes changes to code, by identifying the files and lines which are added, removed, and altered. It may also be referred to as a diff. A patch can be applied to a codebase for testing. was uploaded by @herregroen to build all core JavaScript with Webpack: https://core.trac.wordpress.org/ticket/43731. Building all JS in core with WebPack means we can have a single consistent build process for all JS, rather than having different build tools for Gutenberg and the media library versus everything else. It also allows us to start reusing WordPress packages in the JavaScript that is already present in core. Some more review and testing is needed.

Open Floor: Request for feedback

Slack Conversation

There is some exploration going on around possible solutions for interpolating ReactReact React is a JavaScript library that makes it easy to reason about, construct, and maintain stateless and stateful user interfaces. https://reactjs.org/. elements in strings in this Gutenberg issue: https://github.com/WordPress/gutenberg/issues/9846. @nerrad has requested some feedback to some recent considerations he’d proposed in that issue. Input is welcome!

#core-js, #corejs, #javascript, #meeting-notes

binarymoon 6:24 pm on July 2, 2019

Regarding the e2e tests – I think improving the documentation is essential, it should be top of the list. e2e testing will be new to a lot of people, so if you want people to write tests you will need to explain how to do it. I am interested in using it to test themes, but since there’s no docs (I am aware of) I’ve been unable to get started with it.
- Riad Benguella 8:19 pm on July 2, 2019
  
  That’s fair and I’m confident documentation will be added and iterated on.
  
  I’d like to ask if this post help in any way?
  
  https://make.wordpress.org/core/2019/06/27/introducing-the-wordpress-e2e-tests/
  
  What are the things missing from that post? (if you consider it documentation)
  - binarymoon 10:08 pm on July 2, 2019
    
    I have read that post but I’m afraid I couldn’t work out how to get started.
    
    I’ve not used Docker before, which doesn’t help, but it looks like I can just install it. I’ve used npm. However I’m not sure what I am running. It says to run `npm run env:start` but where’s the package.jsonJSON JSON, or JavaScript Object Notation, is a minimal, readable format for structuring data. It is used primarily to transmit data between a server and web application, as an alternative to XML.? What should I install to be able to run that command?
    
    Based on the comments on that post I feel like I have missed something obvious since everyone else seems to understand what they’re doing, but I just don’t get it I’m afraid.
  - Ipstenu (Mika Epstein) 11:39 pm on July 2, 2019
    
    I think the right start would be to assume the reader has no idea what any of the terms are. The documentation is starting from a place of “Assuming you know Docker and NPM…” which means anyone who doesn’t is SOL.
    The current setup relies on Docker to provide a built-in environment.
    
    This should have “To create a Docker setup you need to….” If there’s official Docker docs to explain it in a way that will work for WP, we can point to that. Otherwise we’ll need to provide a baseline of a setup needed. But just looking at the link, I wouldn’t know if I need the Docker Engine or the client.
    
    Do I need to install WordPress on Docker? That too should be explained.
    You can run the environment locally by using:
    
    What is “locally” in this context? Is this “Once you have created a Docker Thingy, you need to log in and run this command…”
    
    If we want to keep WP accessible to everyone, we have to be gentler in our onboarding 🙂
    - Riad Benguella 12:16 pm on July 3, 2019
      
      Thanks all for the feedback this is all very helpful.
      I’ve not used Docker before, which doesn’t help, but it looks like I can just install it. I’ve used npm. However I’m not sure what I am running. It says to run `npm run env:start` but where’s the package.jsonJSON JSON, or JavaScript Object Notation, is a minimal, readable format for structuring data. It is used primarily to transmit data between a server and web application, as an alternative to XML.? What should I install to be able to run that command?
      
      Oh gotcha, so the post is about introducing e2e tests to WordPress CoreCore Core is the set of software required to run WordPress. The Core Development Team builds WordPress., so the package.json is the “package.json” at the root of WordPress Core repository. So the intent is to document how to add e2e tests to Core and not third-party plugins/themes. While it would be great to haves docs for these use-cases as well, I think the priority is for Core at the moment.
      I think the right start would be to assume the reader has no idea what any of the terms are.
      
      That’s a good point and I think once this becomes an official documentation in DevHub, we should add links to the documentation of these tools and a small intro maybe.
      
      That said, knowing docker or npm is not a requirement to write these tests or run them, the idea is that it’s all abstracted. you just clone the repo, build it and run those commands.
      To create a Docker setup you need to….
      
      Again, the intent is not to create a docker setup but just to use the CLICLI Command Line Interface. Terminal (Bash) in Mac, Command Prompt in Windows, or WP-CLI for WordPress. command that does everything for us. The only requirement is having Docker installed. (I’ll add a note about this 👍)
      What is “locally” in this context?
      
      Locally means in your own computer in that context.
      
      Thanks again for the feedback, I’ll make some updates to the post to clarify things.
      - Ipstenu (Mika Epstein) 3:30 pm on July 3, 2019
        
        That said, knowing docker or npm is not a requirement to write these tests or run them, the idea is that it’s all abstracted. you just clone the repo, build it and run those commands.
        
        That seems a little odd. The link you provided starts with “The current setup relies on Docker to provide a built-in environment.”
        
        So either that doc is incorrect or you’re trying to say “you don’t have to know a lot about Docker.” But it’s a contradiction from the outside to say you don’t need to know Docker whilst saying the setup relies on it.
        
        Having people use a tool without understand what the tool is and what it’s for is a recipe for everyone to be ticked off when something breaks. You get testers with no comprehension and no ability to debug, and devs who have to waste valuable time debugging.
        
        The only requirement is having Docker installed.
        
        Right that’s actually what I mean. You need to know:
        
        1) What the heck is Docker in this context — saying ‘it’s an environment to run the tests’ won’t help since if I go to the webpage I see it’s an app and I have OPTIONS top install 🙂
        2) What I, a tester, need to install (if anything)
        3) What Docker’s going to be used for — again saying ‘running the tests’ isn’t really going to help a newbie
        4) How I set it up properly for testing
        5) THEN how I run the tests
        
        “We use Docker to [create an environment for testing]. You can install Docker by [going to the Docker webpage and installing Thing X]. Once Docker is installed, you can configure it for testing by [installing WP/logging in via Docker CLICLI Command Line Interface. Terminal (Bash) in Mac, Command Prompt in Windows, or WP-CLI for WordPress. and running this command].”
        
        You’ll never get people to write tests if they don’t understand the structure of what they’re writing or the environment.
        
        I’m concerned we’re abstracting too far for someone new (or semi-knowledgeable but unfamiliar with this specific thing) to be able to help, which will have an adverse impact on the project as a whole.
      - binarymoon 4:39 pm on July 3, 2019
        
        Thanks for the extra info. I never knew there was a package.jsonJSON JSON, or JavaScript Object Notation, is a minimal, readable format for structuring data. It is used primarily to transmit data between a server and web application, as an alternative to XML. included in coreCore Core is the set of software required to run WordPress. The Core Development Team builds WordPress.. That’s something new I have learnt today.
        
        I’m in the “I know some things, but not this thing” group that Mika mentioned.
        
        The tests look like something I could write, but the initial setup is confusing.

Comments are closed.

Welcome!

Communication

JavaScript chat summary, June 25th + July 2nd, 2019

Agenda: E2E Test infrastructure for CoreCore Core is the set of software required to run WordPress. The Core Development Team builds WordPress.

Agenda: E2E Tests – next steps

Agenda: Build all Core JS with WebPack

Open Floor: Request for feedback

Welcome!

Communication

Agenda: E2E Test infrastructure for CoreCore Core is the set of software required to run WordPress. The Core Development Team builds WordPress.

Agenda: E2E Tests – next steps

Agenda: Build all Core JS with WebPack

Open Floor: Request for feedback

Share this:

Site resources