Below is a summary of the discussion from last week’s JavaScript JavaScript or JS is an object-oriented computer programming language commonly used to create interactive effects within web browsers. WordPress makes extensive use of JS for a better user experience. While PHP is executed on the server, JS executes within a user’s browser. https://www.javascript.com/. chat (agenda, Slack Transcript) Please excuse the delay!
Have a topic for discussion for the next meeting? Leave a suggested edit on this week’s agenda.
Agenda: Changelogs
Slack Conversation
In a previous discussion a need surfaced to improve Semver for JS JavaScript, a web scripting language typically executed in the browser. Often used for advanced user interfaces and behaviors. packages and better understand the changes we are syncing into WordPress core Core is the set of software required to run WordPress. The Core Development Team builds WordPress. when we update the JS packages. For this, better changelogs are needed. @aduth has been working on a PR to enforce better changelog management. It explores adding a pre-commit githook which verifies that the contents of the pending commit include a CHANGELOG.md revision if applicable.
Some concerns were raised about the potential unwanted friction a githook could give and false positives that could occur when ie. committing typo fixes. A possible alternative is to make the check part of the Travis build for PR’s. On the other hand, the direct feedback gotten through the githook contains higher educational value and minimizes loss of context.
We agreed the current githook proposal was worth exploring further in order to see if false positives can be prevented.
Agenda: Code owners
Slack Conversation
A pull request which adds an initial implementation of a CODEOWNERS file in Gutenberg was merged.
You can use a CODEOWNERS file to define individuals or teams that are responsible for code in a repository.
Github Help
Contributors are invited to PR the file if they feel they would like to be added as a code owner for specific paths in the Gutenberg The Gutenberg project is the new Editor Interface for WordPress. The editor improves the process and experience of creating new content, making writing rich content much simpler. It uses ‘blocks’ to add richness rather than shortcodes, custom HTML etc. https://wordpress.org/gutenberg/ repository. When accepted, they will receive pull request notifications and review requests for these parts of the codebase.
The main goal is to alleviate some review pressure for the Gutenberg team and help distribute notifications and help requests better over more contributors. It was argued it could be good to have some guidelines for approving / merging PRs in order to allow new contributors and code owners to review with more confidence. The use is expected to further evolve and be evaluated in the coming weeks.
Agenda: Registry selectors
Slack Conversation
For a while now we’ve had the option to register multiple stores across multiple registries using the core/data package. But how can we create selectors which derive data across multiple stores / registries? A PR to tackle selecting data over multiple stores has been created by @youknowriad. Input and feedback is requested.
An effort that depends on this is a PR which tries to make the editor module more generic so it can be reused outside of WordPress. We need to be able to respect backwards-compatibility while moving selectors and action dispatchers from one module to another. See also: https://github.com/WordPress/gutenberg/pull/13088
Open floor: React React is a JavaScript library that makes it easy to reason about, construct, and maintain stateless and stateful user interfaces. https://reactjs.org/. hooks In WordPress theme and development, hooks are functions that can be applied to an action or a Filter in WordPress. Actions are functions performed when a certain event occurs in WordPress. Filters allow you to modify certain functions. Arguments used to hook both filters and actions look the same.
Slack Conversation
React hooks has been included in the latest release of React. There is a PR on Gutenberg which explores the possible advantages of this new API An API or Application Programming Interface is a software intermediary that allows programs to interact with each other and share data in limited, clearly defined ways.: https://github.com/WordPress/gutenberg/pull/11161. Since Gutenberg relies heavily on React, it could be worthwile checking out the API and the ways it could be leveraged in Gutenberg.
#core-js, #javascript, #meeting-notes
