Overview
This post is a summary of the latest weekly Media component meeting, which took place in the #core-media Slack Slack is a Collaborative Group Chat Platform https://slack.com/. The WordPress community has its own Slack Channel at https://make.wordpress.org/chat/. channel, on Thursday, October 25, 2018 at 18:00 UTC The purpose of these meetings are to move priority tasks forward, provide feedback on issues of interest, and review media focused issues. Due to a conflict A conflict occurs when a patch changes code that was modified after the patch was created. These patches are considered stale, and will require a refresh of the changes before it can be applied, or the conflicts will need to be resolved. in bug A bug is an error or unexpected result. Performance improvements, code optimization, and are considered enhancements, not defects. After feature freeze, only bugs are dealt with, with regressions (adverse changes from the previous version) being the highest priority. scrub scheduling, we did not have a Media meeting last week. Lets get into it!
Attendees:
@joemcgill @mikeschroder @desrosj @antpb
Transcript: Read on Slack
WordPress 5.0
The meeting focused entirely on the WordPress 5.0 milestone Gutenberg Issues. There are 20 remaining Media issues in the 5.0 milestone. There are 8 labeled backwards-compatibility:
Let’s get right into the issues discussed!
3672 “upload_files” capability and Image relative blocks
https://github.com/WordPress/gutenberg/pull/9301 brings this very close to completion. @joemcgill mentioned “That PR is pretty close. My only problem with it is that there was no way to allow a contributor to open the dialogue even if they couldn’t upload media.” Which we don’t currently support, but it’s easier to override outside of Gutenberg The Gutenberg project is the new Editor Interface for WordPress. The editor improves the process and experience of creating new content, making writing rich content much simpler. It uses ‘blocks’ to add richness rather than shortcodes, custom HTML etc. https://wordpress.org/gutenberg/. I think for 5.0, the PR as it stands is probably ok, but then we should quickly create a ticket Created for both bug reports and feature development on the bug tracker. that adds capabilities that distinguish uploading files from reading/inserting files”
1451 Gallery: figure out way to fallback to shortcode
5972 Gallery Block doesn’t apply the ‘post_gallery’ filter, causing incompatibility with WP Gallery Custom Links
The two above issues will be solved if we move forward on a classic-gallery
block Block is the abstract term used to describe units of markup that, composed together, form the content or layout of a webpage using the WordPress editor. The idea combines concepts of what in the past may have achieved with shortcodes, custom HTML, and embed discovery into a single consistent API and user experience. that allows a fallback to the gallery shortcode A shortcode is a placeholder used within a WordPress post, page, or widget to insert a form or function generated by a plugin in a specific location on your site. function. @antpb has built a POC classic-gallery
block that can be tested here: https://github.com/antpb/gutenberg/tree/add/classic-gallery
Note: there are some pending CSS Cascading Style Sheets. issues that @antpb has to work through but largely the block reaches parity with the < 5.0 implementation. The existing gallery shortcode options are exposed in the block inspector. The classic-gallery-block is not a solid decision yet, just an option worth the proof of concept.
Thinking here is that we can allow a transform to ensure that the gallery shortcode is hit which also allows the post_gallery
filter Filters are one of the two types of Hooks https://codex.wordpress.org/Plugin_API/Hooks. They provide a way for functions to modify data of other functions. They are the counterpart to Actions. Unlike Actions, filters are meant to work in an isolated manner, and should never have side effects such as affecting global variables and output. to be respected.
@joemcgill mentioned “I would much rather a theme add theme support for Gutenberg galleries or something.” which is currently one option going forward on this issue. This has historically been done. An example shared was: https://make.wordpress.org/core/2014/04/15/html5-galleries-captions-in-wordpress-3-9/
We have closed 5972 to keep focus an conversation moving in 1451
4612 Media Library doesn’t update after dragging image onto Image block
@antpb re-opened a PR that fixes the issue and there were some recommendations to it that have been revised. PR is currently awaiting another review. Super close.
5936 Avoid race conditions between media upload and autosave
8935 Issues when uploading images to a Gallery block: The response is not a valid JSON response.
We have an issue with race conditions and also with large image uploads that take a while. 8935 has clear reproduction steps on the gallery large image issues.
1520 Images alt attribute in an editing context
This one is very close to completion. @antpb has made the final requested changes to only store default alt text in the editing context. Should be wrapped up soon.
<img/> tags missing attribute filter 2258
@joemcgill did some research around this since the meeting as it was discussed that this was a critical issue needing investigation. We’ve closed this issue in favor the other filter related issues already open. Joe’s discovery work there is worth the read Also mentioned by Joe in the meeting: “I do think we might want to deprecate that filter after 5.0, but we should definitely support it.”
6824 Video Block doesn’t work when inserting YouTube URL
Users will likely expect to be able to paste a youtube/vimeo/etc. video into the video block. @antpb asked: “how do y’all feel about it? The scope of this issue is not just youtube. Should the video block know what to do with all of our embed types?” @joemcgill responded “I wonder if we could be smart and auto-switch blocks based on some kind of URL A specific web address of a website or web page on the Internet, such as a website’s URL www.wordpress.org regex? Or at least provide a helpful error message that guides people to the correct block.”
7504 Consider feature parity for “Image Details” TinyMCE functionality
@mikeschroder mentioned that this issue needs to be split out due to https://github.com/WordPress/gutenberg/pull/7771
@mikeschroder mentioned “I think it’s missing a PR, and a decision on whether title should be included. The other thing, that isn’t addressed is attachment_fields_to_edit
Which should definitely have its own ticket. Mike is continuing to work to bring an existing PR up to date.
Next Meeting
The next #core-media meeting is set for Thursday, November 1, 2018 at 20:00 UTC See you there!
#core-media, #media, #summary