Javascript Chat Summary – October 16, 2018

Welcome!

The WordPress coreCore Core is the set of software required to run WordPress. The Core Development Team builds WordPress. development team builds WordPress! Follow this site for general updates, status reports, and the occasional code debate. There’s lots of ways to contribute:

Found a bugbug A bug is an error or unexpected result. Performance improvements, code optimization, and are considered enhancements, not defects. After feature freeze, only bugs are dealt with, with regressions (adverse changes from the previous version) being the highest priority.? Create a ticket in the bug tracker.

Want to contribute? Get started quickly with tickets marked as good first bugs for new contributors or join a bug scrub. There’s more on the reports page, like patches needing testing, and on feature projects page.

Other questions? Here is a detailed handbook for contributors, complete with tutorials.

Below is a summary of the discussion from this week’s JavaScriptJavaScript JavaScript or JS is an object-oriented computer programming language commonly used to create interactive effects within web browsers. WordPress makes extensive use of JS for a better user experience. While PHP is executed on the server, JS executes within a user’s browser. https://www.javascript.com/. chat (agenda, Slack Transcript)

Have a topic for discussion for the next meeting? Leave a suggested edit on next week’s agenda.

Agenda: “Props” for GutenbergGutenberg The Gutenberg project is the new Editor Interface for WordPress. The editor improves the process and experience of creating new content, making writing rich content much simpler. It uses ‘blocks’ to add richness rather than shortcodes, custom HTML etc. https://wordpress.org/gutenberg/ Merge

Slack Conversation

How are props being handled for the merge of Gutenberg code?

consensus was mostly reached on GithubGitHub GitHub is a website that offers online implementation of git repositories that can easily be shared, copied and modified by other developers. Public repositories are free to host, private repositories require a paid subscription. GitHub introduced the concept of the ‘pull request’ where code changes done in branches by contributors can be reviewed and discussed before being merged be the repository owner. https://github.com/ profile attribution for any involved in a pull request.
There were not concrete plans for technical process implementation of props yet.

Actions

Discussion can continue in the meeting notes, or revisited in a future meeting.

Agenda: “Internationalization”

Slack Conversation

Proposal for language packs
for v1, utilize `wp_localize_script` for loading/queuing translations.
for v1, generate translationtranslation The process (or result) of changing text, words, and display formatting to support another language. Also see localization, internationalization. file (po,mo,jsonJSON JSON, or JavaScript Object Notation, is a minimal, readable format for structuring data. It is used primarily to transmit data between a server and web application, as an alternative to XML.…) for every single JSJS JavaScript, a web scripting language typically executed in the browser. Often used for advanced user interfaces and behaviors. file

Actions

split this out into a metaMeta Meta is a term that refers to the inside workings of a group. For us, this is the team that works on internal WordPress sites like WordCamp Central and Make WordPress. tracTrac An open source project by Edgewall Software that serves as a bug tracker and project management tool for WordPress. ticketticket Created for both bug reports and feature development on the bug tracker. and create tickets/issues on different projects as necessary. (owned by @herregroen)

Agenda: PluginPlugin A plugin is a piece of software containing a group of functions that can be added to a WordPress website. They can extend functionality or add new features to your WordPress websites. WordPress plugins are written in the PHP programming language and integrate seamlessly with WordPress. These can be free in the WordPress.org Plugin Directory https://wordpress.org/plugins/ or can be cost-based plugin from a third-party and BlockBlock Block is the abstract term used to describe units of markup that, composed together, form the content or layout of a webpage using the WordPress editor. The idea combines concepts of what in the past may have achieved with shortcodes, custom HTML, and embed discovery into a single consistent API and user experience. Scaffolding

Slack Conversation

There are some recently released projects designed to aid developer experience around plugins and blocks for Gutenberg:

https://github.com/youknowriad/wp-js-plugin-starter
Work also started on a solution based on the above which is purely JS based.

Action:

continue feedback/evaluation on the pull request

Agenda: Pending bump of Node’s LTS version from 8.x to 10.x

Slack Conversation | Context

Action:

probably only request a bumping of the relevant files with node version in them.
possibly some docs updating needed.
revisit in a following meeting.

#javascript

Greg Ross 3:34 pm on October 16, 2018

Is there any particular reason not to create a GlotPress sub/project per JSJS JavaScript, a web scripting language typically executed in the browser. Often used for advanced user interfaces and behaviors. file?

That would negate the need to create a patchpatch A special text file that describes changes to code, by identifying the files and lines which are added, removed, and altered. It may also be referred to as a diff. A patch can be applied to a codebase for testing. to GlotPress to do the exports as you would be able to pull them using the existing interfaces and your already extracting them on a per file basis anyway.

I agree with some of the comments that there are going to be a lot of files, but that is probably the price that needs to be paid so we don’t load a pile of translations that aren’t required on any given page.
- herregroen 9:10 am on October 17, 2018
  
  My main consideration on this part was that this would mean that if the same translatable string occurs in multiple files it would have to be translated separately for every file ( unless I’m mistaken about translations not being shared between projects? ).
  
  This is especially relevant considering a pluginPlugin A plugin is a piece of software containing a group of functions that can be added to a WordPress website. They can extend functionality or add new features to your WordPress websites. WordPress plugins are written in the PHP programming language and integrate seamlessly with WordPress. These can be free in the WordPress.org Plugin Directory https://wordpress.org/plugins/ or can be cost-based plugin from a third-party may ship both source and dist files in which the same translations would obviously occur. You’d have one translationtranslation The process (or result) of changing text, words, and display formatting to support another language. Also see localization, internationalization. with a translator’s comment and a clear readable context and a second separate translation without any comments and a completely unreadable context.
  
  As opposed to a single translation with a translator’s comment which occurs in 2 or more files, one of which might be minified.
  - Greg Ross 7:30 pm on October 17, 2018
    
    That is true, translations are not shared between projects so there would be some duplication of effort.
    
    On the flip side though, the context between two files may be very different and separate translations would then be required.
    
    I’m not sure which is the bigger issue 😉
    
    Having said that, if the plan moves forward as it is, I don’t believe there will be any patchpatch A special text file that describes changes to code, by identifying the files and lines which are added, removed, and altered. It may also be referred to as a diff. A patch can be applied to a codebase for testing. required for GP as you can export based on the filterFilter Filters are one of the two types of Hooks https://codex.wordpress.org/Plugin_API/Hooks. They provide a way for functions to modify data of other functions. They are the counterpart to Actions. Unlike Actions, filters are meant to work in an isolated manner, and should never have side effects such as affecting global variables and output. and the upcoming release of GP 3.0 will support limiting the term search scope to the references field only.
    - herregroen 8:39 am on October 18, 2018
      
      I agree that it shouldn’t be necessary to patchpatch A special text file that describes changes to code, by identifying the files and lines which are added, removed, and altered. It may also be referred to as a diff. A patch can be applied to a codebase for testing. GP. Having looked at the metaMeta Meta is a term that refers to the inside workings of a group. For us, this is the team that works on internal WordPress sites like WordCamp Central and Make WordPress. setup more I think if #Meta3876 were to be resolved we’d have the necessary files ready without any further changes to GP needed.
      
      I’d love to have your input on that issue.
Stephen Edgar 10:04 pm on October 16, 2018

Apologies for not being able to attend, time zones 😞

I do think we will need to figure out how to track props going forward with the various JSJS JavaScript, a web scripting language typically executed in the browser. Often used for advanced user interfaces and behaviors. libraries since they are going to be largely managed externally. Might be something #coreCore Core is the set of software required to run WordPress. The Core Development Team builds WordPress.-js should discuss during its next chat

The above from the agenda relates to how to handle props going forward, i.e. with packages being constantly updated on GitHubGitHub GitHub is a website that offers online implementation of git repositories that can easily be shared, copied and modified by other developers. Public repositories are free to host, private repositories require a paid subscription. GitHub introduced the concept of the ‘pull request’ where code changes done in branches by contributors can be reviewed and discussed before being merged be the repository owner. https://github.com/ how do we plan on attributing users in core on TracTrac An open source project by Edgewall Software that serves as a bug tracker and project management tool for WordPress..

I’m going to look again into how we implement and maintain changelog.md files, we should be able to automate adding the PR title, issue and pull request number and author to the changelog.md files.

With that in mind, when a package is bumped in core, e.g. `wordpress/hooksHooks In WordPress theme and development, hooks are functions that can be applied to an action or a Filter in WordPress. Actions are functions performed when a certain event occurs in WordPress. Filters allow you to modify certain functions. Arguments used to hook both filters and actions look the same.` then props are given in that commit to each user who contributed to this `wordpress/hooks` release.

Comments are closed.

Welcome!

Communication

Actions

Agenda: “Internationalization”

Actions

Action:

Agenda: Pending bump of Node’s LTS version from 8.x to 10.x

Action:

Share this: