Office Hours Recap
The agenda for this office hours meeting was to prepare remaining open enhancements for the 4.9 release.
The meeting’s chat log
Attendees: @flixos90, @spacedmonkey, @jeremyfelt
Chat Summary:
- #40228 – Review the latest patches for using
get_site_by()
in get_blog_details()
.
- #40201 – Review the latest patches for using
get_site()
in clean_blog_cache()
. @flixos90 and @jeremyfelt agreed that requiring a site ID is okay for clean_blog_cache()
, moving the refresh_blog_details
hook into clean_blog_cache()
is appropriate, and deprecating the refresh_blog_details
hook in favor of clean_site_cache
is good.
- @flixos90 committed to committing #40201 and #40228 before 4.9 beta A pre-release of software that is given out to a large group of users to trial under real conditions. Beta versions have gone through alpha testing in-house and are generally fairly close in look, feel and function to the final product; however, design changes often occur as part of the process..
- #42072 and #42073 – Discussed both of these, which involve limiting
get_sites()
calls to 1 result when only 1 result is used. @jeremyfelt took ownership of these for 4.9.
- #41762 – Agreed to use
WP_Network_Query
in ms_load_current_site_and_network()
, but to keep the current-network
cache key for now.
Next meeting
The next office hours will take place on October 4, 2017, 16:00 UTC. Its agenda will be to go over remaining bugs for 4.9 and the progress of this cycle’s dev notes Each important change in WordPress Core is documented in a developers note, (usually called dev note). Good dev notes generally include a description of the change, the decision that led to this change, and a description of how developers are supposed to work with that change. Dev notes are published on Make/Core blog during the beta phase of WordPress release cycle. Publishing dev notes is particularly important when plugin/theme authors and WordPress developers need to be aware of those changes.In general, all dev notes are compiled into a Field Guide at the beginning of the release candidate phase..
Ticket Created for both bug reports and feature development on the bug tracker. Scrub Recap
The agenda for this ticket scrub was to review remaining enhancements for the 4.9 release.
The meeting’s chat log
Attendees: @ramiy, @sergey, @afragen, @flixos90, @spacedmonkey, @jeremyfelt, @johnjamesjacoby, @desrosj
Chat Summary:
- #40180 – Discussion on some of the remaining details for
get_site_by()
.
- #40228 – Agreed to finish and commit #40180 so that the patches for
get_site_by()
in get_blog_details()
would be easier to review.
- #40201 – Discussion if
clean_blog_cache()
should support an empty argument as a replacement for refresh_blog_details()
. Agreement that it’s okay to continue requiring that a site be specified.
- Discussion on when or whether to deprecate
refresh_blog_details()
or its hook refresh_blog_details
, which is now a part of clean_blog_cache()
. It seems that it’s okay to postpone this until get_site_by()
and clean_blog_cache()
are more widely used.
Next meeting
@jeremfelt did not clarify early enough whether or not a ticket scrub will take place on October 3, 2017, 17:00 UTC. 🙈 A loose agenda would be to cover remaining bugs for the 4.9 cycle.
If you were unable to attend one of these meetings but have feedback, please share your thoughts in the comments on this post. In case there’s a need for further discussion we will ensure to make time for it in one of next week’s chats. See you next week!
#4-9, #multisite, #network-sites, #summary