Office Hours Recap
No office hours meeting took place this week.
Next meeting
The next office hours will take place on October 3rd, 2017, 16:00 UTC. Its agenda will be to get the 4.9 enhancements ready to be merged before Beta, and then coordinate remaining work on 4.9 bug tickets.
Ticket Scrub Recap
The agenda for this ticket scrub was to look through the multisite tickets without a response.
The meeting’s chat log
Attendees: @afragen, @flixos90, @schlessera, @spacedmonkey
Chat Summary:
- The issue with the suggestion in #41443 is that
wpmu_validate_blog_signup()
is supposed to validate new sites submitted by regular users, not by administrators, so that function would not be applicable for usage on the New Site network admin page. However, some restrictions for new user-submitted sites do not apply to admin-created sites, so these restrictions should be reviewed and possibly adjusted to work more similarly to each other.
-
#41685 is a very early ticket, since it requires the site meta API and related
blogmeta
database table in order to be worked on. It was agreed on that it would generally make sense to store site database versions in the new table instead of an entirely separate table. However, since these versions are not used anywhere in core and since it is questionable whether the blog_versions
table can be removed for backward-compatibility reasons, this still needs a deeper discussion once site meta is actually part of core.
-
#41936 was figured out to be a minor bug with the new
get_main_site_id()
not taking the possibly already set WP_Network::$blog_id
property into account. This should definitely be fixed for 4.9. The current patch by @spacedmonkey moves the logic from the function to the WP_Network
class method, which is not preferable, but might end up being the only way to accomplish the goal without running into an infinite loop issue. @flixos90 will try to find a better way to fix the issue, but if nobody finds one, the current patch is solid enough to go in. This can happen last minute though, as this will be a bug-fix and does not need to be merged before beta.
Next meeting
The next ticket scrub will take place on October 2nd, 2017, 17:00 UTC. Its agenda will be reviewing the 4.9 enhancements and coordinating who works on the possibly required changes so that another review can happen during the office hours a day later.
If you were unable to attend one of these meetings but have feedback, please share your thoughts in the comments on this post. In case there’s a need for further discussion we will ensure to make time for it in one of next week’s chats. See you next week!
#4-9, #multisite, #networks-sites, #summary