Week In Core, May 11 – May 18 2016

Welcome back the latest issue of Week in Core, covering changes [37417-37457]. Here are the highlights:

  • 40 commits
  • 31 contributors
  • 74 tickets created
  • 12 tickets reopened
  • 78 tickets closed

Ticket numbers based on trac timeline for the period above. The following is a summary of commits, organized by component.


  • Make the tab order match the visual order in the Edit terms screens. [37439] #35664


  • System font: The stack does not work with the font shorthand property. [37442] #36753
  • Credits: Add a missing closing tag. [37434] #35911
  • Admin font: Remove a redundant sans-serif declaration. [37419] #36753


Build/Test Tools


  • Add $data parameter to include the comment data in the edit_comment action. [37423] #36427


  • Change attachment condition in the site icon control to prevent errors. [37456] #36749
  • Include shortcut button in Custom Menu widget to edit the selected menu in the Customizer. [37437] #32683
  • Remove use of reserved word default in Underscore template which breaks IE8. Fixes #36793. [37450] [37417] #36793
  • Handle filtering sidebars_widgets when the underlying option is non-existent. Merge of [37352] to the 4.5 branch. Fixes #36660. [37453] #36389, #36660
  • Clean up media control CSS. Removes unnecessary wrapper elements and refactors class names to eliminate duplication of rule selectors. [37426] #30618


  • TinyMCE: prevent showing the placeholder URL when adding a link and clicking more than once on the Insert Link button. Merge of [37301] to the 4.5 branch. [37454] #36637
  • Editor: Merge two strings. [37441] #27756


Filesystem API

  • Don’t add '.' to the list of directories which need to be checked/created when extracting a file. [37421] #36570


  • Docs: Standardize on ‘backward compatibility/compatible’ nomenclature in core inline docs. [37431] #36835


  • Use prepared JSON data correctly. This was modifying a variable that was never used. Oops. [37444] #36358
  • Pass array-like object to http_api_debug. This was mistakingly passing the Requests_Response object, which caused fatal errors with debugging tools. [37436] #33055
  • Fix compatibility with cURL < 7.22. [37430] #33055
  • Add browser compatibility hook for 3xx redirects. [37428] used the wrong method of adding this hook, now corrected. [37429] #33055
  • Replace internals with Requests library. [37428] #33055


  • In get_translations_for_domain() check if the global $l10n was set by _load_textdomain_just_in_time() before accessing it. [37440] #34114


Networks and Sites

  • Tests: Set public to 1 in the default blog factory. [37418] #36566
  • Tests: Use factory method to generate fixtures for wp_unique_post_slug() tests. [37443] #20419

Posts, Post Types

  • Fire a post_action_{$action} action for a custom post action request. [37424] #27056



  • Add changelog entries for when the classes were moved to its own file. [37432] #36618


  • List Tables: Pass the $which parameter to restrict_manage_posts and restrict_manage_users. [37422] #35307


  • Create WP_Widget_Mock as a mock of WP_Widget which can be used for widget tests. You cannot instantiate an abstract class. Not even in WordPress world. [37427] #35981
  • Make WP_Widget a real abstract class. [37425] #35981

Thanks to @adamsilverstein, @afercia, @boonebgorges, @brianvan, @celloexpressions, @danielhuesken, @DrewAPicture, @dshanske, @helen, @iseulde, @jeremyfelt, @jfarthing84, @joemcgill, @johnbillion, @jorbin, @jrf, @martin.krcho, @mintindeed, @Mte90, @neverything, @ocean90, @pavelevap, @rachelbaker, @ramiy, @rmccue, @samantha-miller, @SergeyBiryukov, @sudar, @swissspidy, @tfrommen, and @westonruter for their contributions!

#4-6, #week-in-core