Botched the commit message for: http://bbpress.trac.wordpress.org/changeset/4914/
Can it be changed to:
In bbp_search_query(), change default value of $new_args to empty array()
Updates from John James Jacoby Toggle Comment Threads | Keyboard Shortcuts
-
John James Jacoby
-
John James Jacoby
Can I please get read access setup to the buddypress.org repository for the following dotorg usernames:
- boonebgorges
- djpaul
They’ll be starting by making edits to the buddypress.org theme, and will evolve over time into taking more active roles in maintaining and enhancing the site under my watchful and enchanting eyes.
-
Andrew Nacin
+1. A few things: Boone will need proxy for this. Also, because of various (private) externals used for buddypress.org in general, it would make sense if this access was specifically to wp-content (which is where everything is anyway). Eventually that directory will be committed publicly to meta.svn anyway, though it needs an audit and some work.
-
John James Jacoby
Access to wp-content is perfect. Ping if I need to introduce anyone to get proxy access handled.
-
Andrew Nacin
Gonna need Boone’s SSH key. He can email it to me or Barry.
-
-
-
Barry
I think Nacin can take care of this – nothing for me to do
-
Andrew Nacin
Done.
-
John James Jacoby
Can we please add rez-bot (IRC logging) to the following Freenode channels:
- #buddypress
- #bbpress-dev
- #wordcamp
-
stankea
Added rez-bot to these 3 channels
-
John James Jacoby
Just getting around to saying thanks.
So, thanks!
-
-
John James Jacoby
Seeing mixed reports over the past few days of 500 responses when visiting codex.buddypress.org.
Most informative report so far:
Others report it maybe specific to Firefox on Windows; I have not been able to reproduce.
Thoughts?
-
Barry
That particular report was caused by this fatal error –
[13-Dec-2012 02:53:42] PHP Fatal error: Call to undefined function get_editable_roles() in (redacted)/wp-content/mu-plugins/codex-hacks.php on line 88
There are some other fatals though. Maybe @nacin can hook you up with the custom error handler used on WP.org so you can see these in real time?
-
John James Jacoby
Thanks for that. I’ll ping him and get it sorted.
-
Andrew Nacin
Done, I’ve turned error handling on for bbpress.org and buddypress.org (including profiles).
-
-
-
John James Jacoby
Can I please have commit access granted to bbpress.svn.wordpress.org for the username ‘jmdodd’?
We’ve had ye olde Uncle Ben/Spiderman talk, and I’ll take care of getting her situated.
cc @matt
-
Andrew Nacin
done
-
John James Jacoby
Thanks!
-
Andrea Rennick
SWEET.
-
-
-
arielmeadow
*applause*
-
-
John James Jacoby
bbPress.org still has its legacy /plugins-downloads/ directory present in the repository. This was for bbPress 1.1 plugins, and is no longer used. Is it safe to remove this?
Also, are we still using the .htaccess in bbPress.org for anything? Was going to clean out some old rules, and realized it might not be necessary at all anymore.
-
Andrew Nacin
All .htaccess files are historical, as everything is now nginx. They can safely be removed, and were simply left around for easy reference.
The file /usr/local/etc/conf.d/wporg-bbpress.org holds the nginx rules. If any of them can be removed, let me know.
The /plugins-downloads/ directory is used by the old plugin directory code as a place to svn export then build zips. As long as /plugins-plugins/ and all of that infrastructure remains (including nginx rules, cron jobs, etc.), so should this.
-
John James Jacoby
Thanks. I’m going to remove the .htaccess file now.
On bbPress.org, the /plugins-plugins/ directory was removed shortly after migrating the site to bbPress 2.1. What exists now is only a landing page of links to each Subversion repository, here: http://bbpress.org/plugins/legacy/
Going forward, all bbPress plugins exist on WordPress.org Extend, and there is no need to support /plugins-plugins/ infrastructure to build those zips.
-
Andrew Nacin
My bad. /plugins-plugins/ still existed on my sandbox, but untracked by SVN (due to local modifications at time of deletion).
We can probably unmount /dl-archive/ at this point as well, as dl.php was removed four months ago and apparently no one complained. Indeed, /legacy/ simply links to the zip download link on Trac.
-
John James Jacoby
Great. Thanks for the help.
-
-
-
-
-
John James Jacoby
Last night I updated bbPress.org’s pinned bbPress external to trunk, and now none of bbPress’s custom rewrite rules are working.
- Unable to edit topics/replies/users.
- User profiles pages 404: http://bbpress.org/forums/users/johnjamesjacoby/
- Topic views 404: http://bbpress.org/forums/view/no-replies/
- The rewrite_rules option has been flushed, and includes the correct rules.
Back during the initial 1.1 to 2.x conversion, @stankea had to do some rule tweaks in nginx. Does this need to be updated too, or is this an issue on my end?
-
John James Jacoby
Appears to have just silently fixed itself.
-
John James Jacoby
Only broken rule now is: http://bbpress.org/forums/users/johnjamesjacoby/topics/
Ends up redirecting to a topic in the forums. Looks like the specific topic is not the root cause; I changed the post_status of it, and it still redirected to a different topic.
-
Andrew Nacin
Looking.
-
stankea
Definetly not nginx rewrites as they aren’t there anymore. Probably something in WP itself – maybe cache?
-
John James Jacoby
Talked with @nacin via Skype. Came to the conclusion that rewrites being broken was a cache issue. We think the one remaining broken rewrite rule (for user topics) is a query string conflict in bbPress trunk using ‘topics’ as a chunk (though ‘replies’ works fine.)
Was traveling to Vancouver all day yesterday with no on-plane WIFI, so will look at this today.
-
John James Jacoby
Can I get stats on how many checkouts happen out of bbPress’s /branches/plugin/ directory? I suspect many of them are from me.
Now that /branches/plugin/ is copied to /trunk/ I’d like an idea of when will be best to delete /branches/plugin/
-
stankea
Apologies for a late response.
Grep’ed the logs and i don’t see any checkouts for /branches/plugin from anyone except you in the last month. But this does not include checkouts which where made for / or /branches/. Are you interested in checkouts for / and/or /branches too?-
John James Jacoby
Nope that’s all I needed to know, and matches what I assumed.
Thanks!
-
hummvee
bro i need your blog online! it would be very helpful to me atleast!
-
-
-
John James Jacoby
Could someone (nacin?) please update the default version on bbPress’s trac from 2.0 to 2.1?
Thanks!
-
Andrew Nacin
Sure, this can be done, but note that core currently keeps this field blank, which then allows people to specify what version they are using. Since the current version is 2.0.x and dev is 2.1, you’d probably rather have people explicitly mark that they are using 2.1-dev, rather than it just auto-populating things.
What do you want the default component to be?
-
John James Jacoby
I’d like it to be 2.1. It shipped this morning, and it saves me from needing to change it constantly.
I just made a “General” component, which is fine as the default. Most of them currently end up as “Actions/Filters” since it’s alphabetically first.
-
-
Andrew Nacin
Deploy repo revisions 3762 and 3763 are ready for deploy.
-
stankea
deployed
-
-
-
John James Jacoby
Can I get stats on how many checkouts happen out of bbPress’s /trunk directory?
I’d like to move bbPress’s /branches/plugin/ to /trunk/. I develop the bbPress plugin out of /branches/plugin, which is confusing for devs that want to look at the most recent code, and are used to seeing that code in /trunk.
Obviously, this will break installs for anyone running a stand-alone /trunk checkout.
My thought is to empty out /trunk for a few days/weeks, and eventually move the plugin into it. Before doing this, I’d like to know how many people checkout code from /trunk, to better understand the potential impact of this change.
-
Barry
109 requests in the past 30 days compared to 30122 for /branches/plugin.
-
John James Jacoby
Thanks Barry!
-
-
stankea are discussing. 
hummvee, 
Andrew Nacin 10:26 pm on May 18, 2013 Permalink | Log in to Reply
What usually happens in core when there is a mistake is the cross-referenced ticket can be updated with proper information. We have *.svn.wordpress.org set up to reject property changes.
Barry 3:20 am on May 20, 2013 Permalink | Log in to Reply
This sounds like a good idea. Going to mark this one resolved.