It seems a word “or” is omitted between “Drop files anywhere to upload” and “Select Files” button in the insert media pop-up window, while it exist in the media upload page under media.
There isn’t also in the line 1554 in wp-includes/media.php. Is it intended?
Tagged: omitted Toggle Comment Threads | Keyboard Shortcuts
-
martian36
martian36 9:36 am on December 5, 2012 Permalink | Log in to Reply
I inserted the missing
tag –>
and it worked.
martian36 9:40 am on December 5, 2012 Permalink | Log in to Reply
I inserted the missing p tag which is in the line 1543 of wp-admin/includes/media.php,
and it worked.
bhadresh.ganjawala 10:50 am on December 5, 2012 Permalink | Log in to Reply
can u plz wp 3.5 RC3 version use this bug is solved
bhadresh.ganjawala 10:45 am on December 5, 2012 Permalink | Log in to Reply
i think so this work great there no bug in to the insert media post & page
thanks,
bhadresh ganjawala
Ze Fontainhas 10:32 am on December 5, 2012 Permalink | Log in to Reply
Problem is this: on adding a new media item to the media library, the text is:
Drop files here
or
Select Files
While on adding a new media item to a post or page, the text is:
Drop files anywhere to upload
Select Files
No “or” and the text is different. It seems to me that both should read
Drop files anywhere to upload
or
Select Files
@nacin, can you confirm that this is a bug before I open a ticket? I understand that there is very little chance of it making it to 3.5
martian36 10:45 am on December 5, 2012 Permalink | Log in to Reply
Without the “or” between “Drop files anywhere to upload” and “Select Files” button, it looks awkward. I don’t think it is a bug. In the current WP version there is “or”.
Ze Fontainhas 10:49 am on December 5, 2012 Permalink | Log in to Reply
If it’s a bug, it’s on 3.5, not the current version as there is no “new” media manager there.
martian36 3:21 pm on December 5, 2012 Permalink | Log in to Reply
The three strings, “Drop files here or Select Files” are from \wp-admin\includes\media.php(line 1542~1544) and the two strings, “Drop files anywhere to upload Select Files” are from \wp-includes\media.php(line 1544, 1555).
So the strings are very different. As you see, there are only two strings in the latter media.php. It means “or” is omitted.
pavelevap 3:24 pm on December 5, 2012 Permalink
Yes, there are 3 different strings which could be the same in the end. Reported also here: http://core.trac.wordpress.org/ticket/22623#comment:12
Andrew Nacin 3:41 pm on December 5, 2012 Permalink | Log in to Reply
Omitting the “or” isn’t a bug. We just didn’t think it was necessary UI. Drop files anywhere. Select files. Simple, easy.
Yeah, we’ll have to do a string cleanup come 3.6. We’ll have to do a *lot* of cleanup come 3.6.
Ze Fontainhas 3:47 pm on December 5, 2012 Permalink | Log in to Reply
In which case it should be omitted on the first instance, too. By the way, and for us unqualified pt_PT minions to avoid a Trac UI war, we’ve simply translated “Drop files anywhere to upload” with the equivalent “Drop files anywhere to upload, or“, in both instances. Not because of our (non-existant) degree in UI, but simply because it makes more sense.
martian36 3:48 pm on December 5, 2012 Permalink | Log in to Reply
OK, so it is intented. I was thinking of inconsistency between the two.