WordPress.org

Making WordPress.org

Updates from Samuel Wood (Otto) Toggle Comment Threads | Keyboard Shortcuts

  • Samuel Wood (Otto) 11:27 pm on April 3, 2013 Permalink | Log in to leave a Comment
    Tags: , , shortcode, time   

    Time Shortcode for Make P2s 

    A couple of weeks ago, Siobhan pointed out to me the difficulties in talking about times for IRC meetups on the various P2 blogs. She suggested a shortcode to make it easier to specify times.

    So I wrote a first draft of a shortcode to make this a bit easier. It’s not perfect, but I figured to go ahead and tell people now, so that you all could go ahead and start banging on it and telling me what the problems are.

    Usage: [time] some-time-format-here [/time]

    By “some-time-format-here”, I’m being a bit generous. You can use pretty much any time format you can think of and it will attempt to figure it out. With extra emphasis on “attempt”.

    Stuff like this all works:

    • March 30, 2013 1pm UTC
    • April 4th at 1pm
    • April 4th around 1pm
    • April 4th 2012 1pm
    • next monday 1pm CDT
    • 1pm UTC

    Now, a few important points:

    • If you don’t specify a timezone, you’ll probably get UTC. This is just for now, until I work out a better way.
    • If it can’t figure it out, you’ll notice no change in your text. Hopefully.
    • If it gets really confused, it’ll probably say January 1st, 1970. :)
    • “Absolute” times are more likely to work than “relative” ones. Give a date, and year, and time, and timezone, and you’ll probably be good.
    • Timezones matter in terms of daylight savings. GMT is not the same as BST (British Summer Time).

    So, what’s the point? Well, if it can figure out what time you meant, then it’ll encode that and a bit of Javascript will then localize that time to the viewer of the make P2 in question on load, assuming their browser knows what timezone they’re in.

    So when I post “April 3rd, 2013 6:30pm CDT” (my current time) in the time shortcode, it’ll show this instead: April 3rd, 2013 6:30pm CDT. What you see there depends on where you live.

    Hopefully this will make it somewhat easier to schedule IRC meetups and such. Let me know when (not if) you break it. Happy to iterate.

     

    • Jerry Bates (JerrySarcastic) 11:37 pm on April 3, 2013 Permalink | Log in to Reply

      Awesome! Thanks Otto!

    • GaryJ 1:23 am on April 4, 2013 Permalink | Log in to Reply

      GMT isn’t scientifically defined, but glad to see a move to UTC output, the world standard for time since 1972…

    • Paul 10:40 am on April 4, 2013 Permalink | Log in to Reply

      you don’t know how helpful this is! thanks

    • Edward Caissie 1:27 pm on April 4, 2013 Permalink | Log in to Reply

      … and where do we get a chance to look at the code directly? Sorting out the reader’s time is something that is haunting me in a plugin I have that uses dates extensively.

      Being able to present different “content” based on the reader’s time would be extremely useful code to “borrow” ;-)

      • Samuel Wood (Otto) 1:33 pm on April 4, 2013 Permalink | Log in to Reply

        Ain’t nothing magical to it. I’ll send you a copy if you want.

        But basically, it first runs the time you give it through strtotime() with the post-date used as the “now” parameter, for handling of relative times. If that fails, then it uses date_parse() to try to figure out what time info you gave it, and the post-date to fill in the gaps. This lets it handle more types of relative times. Eventually, it gets an absolute time, hopefully. Then it returns the string with a time microformat wrapped around it, that looks like this: abbr class=”date” title=”2013-04-03T23:30:00+00:00″. It also returns it with the link to timeanddate.com.

        Next, it inserts some javascript code into the footer of that page that searches for those abbr date items, parses that title into components, and uses the javascript Date object to convert that from UTC into the browser’s local time. The JS does the replacement of the string in the abbr into the localized time string. The plugin never needs to know the browser’s time, the JS code handles that.

    • Jen Mylo 1:10 am on April 20, 2013 Permalink | Log in to Reply

      This sounds so scary to me after 5 years of dealing with time zones and travelers and proxies in the wordpress community. Will there be any indication that the time being displayed is a magic shortcode-determined time, or will it look like plain text? Maybe we could style it differently so it’s clear when it’s in use?

      • Samuel Wood (Otto) 2:39 am on April 20, 2013 Permalink | Log in to Reply

        It is styled differently. Look at use of it in the post above. It’s got those dotted lines under it because of the abbr tag, it links to the timeanddate.com automatically.. When you hover over it, you’ll see the UTC version of the time. It’s fairly obvious, I’d say.

        Also, it’s totally optional. If you don’t want to use it, don’t use the shortcode. I made it non-automatic for just this sort of reason. But I think it’s pretty robust, honestly. Try it out if you like. It works in comments too. :)

    • Ulrich 9:01 pm on April 22, 2013 Permalink | Log in to Reply

      This time is being shown wrong in my timezone. I think it is to due with the daylight saving time. It should be 22:00.
      http://pix.am/nk6c.png
      http://make.wordpress.org/docs/2013/04/18/dont-forget-that-due-to-daylight-savings-the/

      • Samuel Wood (Otto) 9:07 pm on April 22, 2013 Permalink | Log in to Reply

        No, it’s correct given what she wrote. She actually wrote the time in the shortcode as “18th April, 20:00 BST”. Thing is, “BST” (British Summer Time) is not the same as “UTC”.

        It’s a quirk of people in England, I think. They always seem to call their time “UTC”, even when it’s not.

        But it is converting correctly, given the time in the shortcode itself. Gotta put the right time in it to start with.

      • Samuel Wood (Otto) 9:15 pm on April 22, 2013 Permalink | Log in to Reply

        A simpler way of dealing with timezones is simply to learn what “Zoneinfo” style timezone you’re in and use that all the time. Then it deals with daylight savings automatically.

        I’m in the “America/Chicago” timezone. So I can do this:

        Original: April 22, 2013 4:14pm America/Chicago

        Shortcode: April 22, 2013 4:14pm America/Chicago

        Much easier.

  • Samuel Wood (Otto) 10:00 pm on October 29, 2012 Permalink | Log in to leave a Comment
    Tags: , meta, plugin, , theme   

    Welcome to Meta (with a feature!) 

    During the WordPress Community Summit pre-planning sessions, it became obvious that there’s not a lot of good communication about what we do, plan, and code for the WordPress.org website itself. So, after a bit of chatter, Make-Meta was born. This is where we plan on talking about changes to the WordPress.org site, as well soliciting feedback for feature ideas. Consider it a community site; we don’t always know what the best way to make the website work is, so feedback is not just welcome, but encouraged.

    In order to kick things off properly, I figured I’d announce a new feature: Reviews!

    After a lot of discussion, it became clear that a “plugin review” concept was very much desired by the community in general. So we implemented reviews, but didn’t bother to limit it to just plugins. So now, plugins and themes can have reviews.

    In order to keep things straight, reviews are tied to ratings. In order to rate a plugin, you must write a review as well. All the old ratings are still there and won’t be going away (we use those, after all), but if you want to change your rating in the future, well, explain it. Tell your side of the story. What’s broken? What works? What’s the best and the worst of the code? How can the plugin or theme author improve it?

    Communication is important, and “support” is only half of the equation. Feedback is critical, and hopefully, the new Reviews system will go a long way to improving communication between the many millions of users of code we host on WordPress.org and the many thousands of contributors who write the themes and plugins that we all use every day. And all reviews go into our forums and can be commented on by everybody, just in case somebody needs some extra help.

    (Note to Plugin/Theme authors: You can subscribe to your reviews alone via RSS feed, but the email subscription is cross-tied to the support-forum email subscriptions. If you’re subscribed to those, you will get review emails as well.)

    There won’t be a lot of reviews at first, but hey, that’s where you come in! Just to get everybody started, I went ahead and wrote a couple of reviews to kick things off. So if you want to see it in action immediately, you can see them here:

    http://wordpress.org/support/view/theme-reviews/twentytwelve

    http://wordpress.org/support/view/plugin-reviews/hotfix

    These are accessible for any plugin or theme through the “Reviews” tab. Alternately, try to rate a plugin or theme and you’ll be sent to the review form as well.

    Note that this is “iteration 1″ of the feature. I expect to make many visual and stylistic changes over the next couple of weeks, and perhaps add a few new features. If you have a great idea for a feature or enhancement, feel free to comment and let me know. (Don’t bother me with the visual-only stuff yet, I know the CSS needs some love. Also, reviews don’t really display all that well on profiles yet; I know, working on it.)

    BTW, the majority of the code to power the reviews came from our own Scott Reilly, who is, frankly, a genius. Give him mega props. :)

     

    • Rarst 10:26 pm on October 29, 2012 Permalink | Log in to Reply

      For some reason review form on those example links is filled with text of your review, which doesn’t quite make sense?..

    • Mert Yazicioglu 10:56 pm on October 29, 2012 Permalink | Log in to Reply

      Great news!

      By the way, there is a textbox right after the text “Select the version of WordPress you are using”.

    • Austin Passy 11:16 pm on October 29, 2012 Permalink | Log in to Reply

      Props Scott.

    • nofearinc 11:29 pm on October 29, 2012 Permalink | Log in to Reply

      It’s an awesome feature that would prevent plugin/theme authors from getting anonymous 1-star ratings with no elaboration. Not sure if that’s implemented, but a minimum review length might be handy as well (for the same reason).

      The email communication is always good to have, if possible, as an extra extension to the other notification system.

      And welcome to Meta as well :)

    • Shane Pearlman 12:15 am on October 30, 2012 Permalink | Log in to Reply

      just wrote a ton of feedback and it vanished – checking to see if i am on pending status or if I should just sigh and feel sad.

      • Shane Pearlman 12:22 am on October 30, 2012 Permalink | Log in to Reply

        oh balls. ok the short version:

        This is EPIC. So Glad to see it.

        • add “7 reviews” somewhere on description right rail http://cl.ly/KYh1 – wonder if we filter by version like the apple store?
        • would be nice to show the version of WP reviewed on the theme: http://cl.ly/KY1W (I don’t see it) and the version of the theme / plugin the review is based upon. Bad version can happen and it is nice to know.
        • love that we can reply to reviews (thank you thank you), from a simple ux perspective, might be nice to have a “reply” link next to “0 comments”
        • look forward to seeing a hint of “credibility” added to the reviewer. Something which tells you what they have contributed without having to click on their name – maybe badges or just simple text with “37 reviews | 4 plugins | 2 themes | 18 core patches | core contributor | 108 relevant articles” – although I have no idea how to do the last one, I do believe that is a form of credibility that would be nice to track.

        that all I can remember with the time I have.

        Go team!

        • Mike Schinkel 5:24 am on October 30, 2012 Permalink | Log in to Reply

          One concern about version ratings is that most plugins have very few ratings across version, splitting them across versions makes their ratings even less valid. And it’s relevant if a plugin has had bad ratings all it’s prior versions but the new version is posted that gets high ratings from a handful of friends. Not suggesting version ratings are bad but that they will have unintended consequences which need to be considered before diving in with another change.

          Frankly I’d like to see multiple dimensional ratings that not only indicate rating but indicate a confidence level based on the number of ratings. 4.5 stars from 500 people means a lot more to me than 5 stars from 3 people. Maybe this could be accomplished with color, from dull gray to bright yellow and several levels between on an exponential scale. A small number of 5 star ratings get you a dull grey 5 stars and 500 four stars get you bright yellow stars?

          As far as credibility, I wish they’d factor in StackExchange’s WordPress Answers rep. Just saying… :)

    • Matt Mullenweg 2:48 am on October 30, 2012 Permalink | Log in to Reply

      Should we zero out all the old ratings, they don’t have any context.

      You should be able to click a review number bar (under the stars) and see all the reviews at that level.

      http://cl.ly/image/0u0S03043P05/content

      • Shane Pearlman 4:09 am on October 30, 2012 Permalink | Log in to Reply

        There is a wealth of plugins & themes that have earned a strong (or mixed or poor) reputation over the years. Until this new feature matures it would leave .org users with little guidance.

        Maybe we could do something like apple did with app version?

      • Samuel Wood (Otto) 4:33 am on October 30, 2012 Permalink | Log in to Reply

        Lets give it some time before dumping the old ratings data, see how well it works.

        The bars link is a good idea, I’ll look into it.

    • Ray 3:30 am on October 30, 2012 Permalink | Log in to Reply

      Question about moderating reviews. What if someone is trolling a plugin author or plugin? It’s bound to happen. Is a report mechanism in the works?

      • Shane Pearlman 4:07 am on October 30, 2012 Permalink | Log in to Reply

        +1 on this.

        There are comments on reviews, but last thing we need is ungentlemanly behavior being encouraged.

      • Samuel Wood (Otto) 7:48 pm on October 31, 2012 Permalink | Log in to Reply

        BTW, regarding reporting, the “modlook” tag should be added to any reviews that need attention.

    • Michael Torbert 3:34 am on October 30, 2012 Permalink | Log in to Reply

      This is very awesome. Imagine if for every one star rating one of my plugins has ever received, I got some useful feedback that could turn it into a 5 star.
      Great work Otto!

    • Mike Little 6:53 am on October 30, 2012 Permalink | Log in to Reply

      This is great. Looking forward to it maturing.

      BTW: There’s no Subscribe form in the sidebar. So I had to comment to be able to tick the notify box.

    • scribu 2:26 pm on October 30, 2012 Permalink | Log in to Reply

      Works pretty well. One thing I would like is if the star rating showed up somewhere while viewing the review in the support forums. For example, when I go here:

      http://wordpress.org/support/topic/great-plugin-8

      It would be nice to have the rating given by that user in the sidebar or on the left, under the user details.

      • Samuel Wood (Otto) 3:45 pm on October 31, 2012 Permalink | Log in to Reply

        I decided to make it a little more obvious and put it under the topic title.

        Note that I wasn’t saving the data correctly before to implement this, but I am now. So ratings made starting now (including edits to existing reviews) will show the stars from now on.

        Check out my original 2 review topics to see the stars on them.

    • Joost de Valk 6:06 pm on October 30, 2012 Permalink | Log in to Reply

      Awesomness! This blog is not in the feed list on http://make.wordpress.org/ yet :)

      • Samuel Wood (Otto) 7:47 pm on October 30, 2012 Permalink | Log in to Reply

        There’s a reason for that. Looking at redoing that in a different way.

        • Ryan McCue 3:20 am on October 31, 2012 Permalink | Log in to Reply

          I don’t have posting privileges here, but I’m willing to work on this as mentioned at #wpcs. Should I file this on Trac?

          • Samuel Wood (Otto) 5:00 am on October 31, 2012 Permalink | Log in to Reply

            You know, I personally don’t like wp.org refinements being on the core trac. I think it’s additional clutter. Some may disagree.

            Maybe we need to come up with a better way and/or a separate trac. Regardless, let’s sort out some ideas before putting anything on trac about it. Like we discussed, a simple design would be good, just a way to sort of showcase what’s going on everywhere, sort of thing.

            • Shane Pearlman 2:34 pm on November 2, 2012 Permalink

              We’re probably down to contribute some code for .org as well. My support team let me have it yesterday with issues they are facing that could be truly easily resolved with less than a day of code. I told them to write me a blog post and then I’d share it with the community. If you buy off, then we can discuss contributing.

              Example:

              A simple message at the top of the support tab would be a serious tool. There is no easy way to set expectations for users. We have had 2 people this week complain that the plugin is unsupported and write a bunch of vitriol when no one replied to their post on .org in 24 hours on a weekend. We need a way to let people know how much support we can offer, and when we are out on holiday etc.

              A quick comp example: http://cl.ly/KceM

            • Jane Wells 9:35 pm on November 25, 2012 Permalink

              I also think they should not be on core trac, but a separate trac or whatever.

              I did a sketch a while back for a make landing page, then revised it at wpcs. Will look for it and post as a proposal. I think we didn’t move on it at the time bc it wasn’t perfect, but it was a good example of letting perfect be the enemy of the better. Almost anything would be better than the RSS collection we have now. I went and looked at a bunch of other FLOSS projects’ Get Involved landing pages today (list at http://make.wordpress.org/community/floss-community-programs/ ), and think what we talked about doing at wpcs is still a good idea.

              Side note: as all the new groups get going, there will be a lot of crossover with the Meta group as feature requests and or design/content work comes out of the new groups. We should figure out how/where to handle that, so improvements aren’t worked on in parallel/vacuums, but together.

            • Samuel Wood (Otto) 12:59 am on November 26, 2012 Permalink

              I’m perfectly okay with changing the base make site, we just need a design or an idea of one.

    • Samuel Wood (Otto) 7:48 pm on October 30, 2012 Permalink | Log in to Reply

      For reference, ratings were acting weird and wonky. I think I’ve finally sorted out the issues there though. If your rating didn’t appear to save properly, or isn’t showing up, just re-save your review with the fixed rating, and it should sort itself out.

    • Dougal Campbell 6:07 pm on November 2, 2012 Permalink | Log in to Reply

      Buglet? Can’t seem to login directly from a review page view. Redirects back to same page, but not logged in.

      • Samuel Wood (Otto) 4:22 am on November 6, 2012 Permalink | Log in to Reply

        Login appears to work fine for me on the review view pages. No reason I can think of for them to be special in that respect, actually, the view is just a view like any other there, with no special login handling code on them.

    • Samuel Wood (Otto) 4:23 am on November 6, 2012 Permalink | Log in to Reply

      Bug fix: it is now possible for a person to actually review more than one theme and have it saved. If you tried and found your old review removed, whoops. Sorry about that. It works okay now.

    • Marko Heijnen 4:40 pm on November 6, 2012 Permalink | Log in to Reply

      I just received my first review and the mail wasn’t clear for me. The Subject only has the title of the review and not showing about which plugin it is

c
compose new post
j
next post/next comment
k
previous post/previous comment
r
reply
e
edit
o
show/hide comments
t
go to top
l
go to login
h
show/hide help
shift + esc
cancel