We started today’s office hours by reviewing @karmatosed’s latest mockups for the revisions screen. We’re in agreement that these reflect the direction we’ll take, so @adamsilverstein will begin coding the changes in preparation for Monday’s meeting. As some concerns have been raised about the use of red and green, @karmatosed will post to the Accessibility group’s P2 asking for feedback on the current mockups. She will also explore the use of patterns to differentiate additions and deletions, as suggested by @helen.
@westi made a few suggestions, based on his recent experiences with Revisions, which we’ve agreed to incorporate. For clarity, the current version will be included in the revisions list to provide a stronger connection with the overall revisions workflow. Second, we decided that when first landing on the revision screen for a given post, we should show the diff of the current version and its immediate predecessor revision; since most users are probably looking for this anyway, why not save them a step?
Lastly, we chatted about the status of code-oriented tickets scoped for 3.6. A few (#16215, #22289, and #19932) have patches, which we’ll be reviewing and providing feedback on before Monday’s meeting. With any luck, we can land at least one in Core before the next dev chat. Beyond that, development on the remaining tickets should progress over the weekend, with the aim of having more patches to review for our next office hours.
For reference, the tickets that are in scope for 3.6 (at least at this point), can be found here.
[IRC Log]
Ben Tremblay 9:58 pm on February 19, 2013 Permalink | Log in to Reply
1st thought: the chunks appear w/o context. (I imagine it with a snippet of before and after.) You okay with that?
#JustSayin’
Grant Palin 10:50 pm on February 19, 2013 Permalink | Log in to Reply
Agreed, context is important. Just where in the document the shown snippet is located can make a dig difference.
adamsilverstein 11:27 pm on February 19, 2013 Permalink | Log in to Reply
yes, for sure.
although the mockup doesn’t make it clear, you will actually see your full document content, showing what has been removed, added (and what stayed the same), so the context is shown.
Peter Westwood 3:23 pm on February 21, 2013 Permalink | Log in to Reply
The chunks appear without context because the mockup happens to show a full post rewrite
aldo.roman 7:11 pm on February 20, 2013 Permalink | Log in to Reply
I follow the GIT (or others) DIFF as the mockup shows a ‘ + ‘ and a ‘ – ‘ signs, but I don’t think the end user will need them. Maybe the colours is enough and we can have a cleaner screen.