Impromptu 3.5.1 meeting in 30 minutes (19:00 UTC) in #wordpress-dev. Still upwards of 16 tickets to lock down. Would like to hit 3.5.1 beta by the end of the week.
Tagged: 3.5 Toggle Comment Threads | Keyboard Shortcuts
-
Andrew Nacin
-
Andrew Nacin
For Wednesday, let’s plan on a 3.5.1 ticket triage meeting at 19:00 UTC (2 p.m. Eastern). Please be around if you can (#wordpress-dev of course), especially if you have something in progress for 3.5.1, so we can hammer things out and start thinking about timing.
The dev chat is normally two hours later, at 2100 UTC. I won’t be available, and will leave that to @markjaquith and co. I expect it will be a light meeting again. 3.5.1 timing should be discussed, which should be easier with the triage session happening earlier.
-
Andrew Nacin
-
Mike Schroder
I don’t suspect #22899 is the source of the mod_pagespeed issues, since encoding the brackets doesn’t solve the problem. We’re reaching out to the mod_pagespeed guys on this, and adding a temporary rule to avoid mod_pagespeed optimizing wp-admin’s JavaScript (which it arguably shouldn’t be doing anyway).
-
Robert Chapin (miqrogroove)
#23041 needs review for 3.5.1 milestone.
-
-
Andrew Nacin
And as alluded to in the previous comment, is there anything we can offer a hotfix for? This should be based on both severity and impact. Is forcing out a fix for load-scripts.php (that involves either encoding
[]or chunking <script> tags) enough to fix most JS issues? If not, is there anything else we can do to avoid a lot of JS conflict/error issues people are having? Is there a common pattern in the support forums that suggest there is something we can target? etc.
-
-
Andrew Nacin
Post-3.5 IRC meeting
Here’s the agenda for the December 12 developer chat in IRC. That’d be #wordpress-dev on freenode at 21:00 UTC. Should be a fairly low-key meeting:
- Congratulations on WordPress 3.5, everyone.
- Fallout of 3.5. How’s the support forums? Any common issues? What can we learn from plugins that broke?
- Can we help with any common issues? Can documentation (like field guide posts) help?
- Triage 3.5.1 tickets. What does our timeline currently look like?
- Discuss plans for the month of December, and 3.6.
- Stare at the download counter.
Thank you so much for a great release. Really proud of what we accomplished. — @nacin, @koop
-
George Stephanis
Considering the abundance of script-loader.php reports we’re getting in on the forums, we may want to reevaluate how we’re chopping and array-izing things from http://core.trac.wordpress.org/ticket/22757 — for example, http://wordpress.org/support/topic/quick-edit-not-working-after-35-update
-
Andrew Nacin
I don’t know if this is specific to our chopping in #22757, or something else. Anecdotally, I too have seen a number of bug reports, but We need to isolate the individual issues and figure out what things exactly are causing things to break for these users.
-
George Stephanis
Agreed. I’m hoping to accumulate some example URLs to a variety of problematic load-scripts.php instances before the meeting tomorrow, so we can sort out what varieties are cropping up.
-
-
-
Clifford Paulick
Faster Insert broke: http://wordpress.org/support/topic/doesnt-workdisplay-on-wp-35
I setup a custom write panel that has meta boxes but no ‘editor’ so Faster Insert was a good way to still allow WP native uploads and [ gallery ], so I’m missing it. Maybe that’ll help you out.
Thanks for 3.5!
-
sourceforge
thank you @nacin, @koop do they pay you extra for all the front end work and contributions?
-
Maor Chasen
Well done guys! This version is definitely a solid one. Hope to see you all then and there.
-
nofearinc
Any plans on setting some order in Trac? There are probably hundreds of tickets with patches with no end resolution, as well as other corner cases.
Some of them require simple gardening which is not a core dev job, but setting priorities to open tickets or closing open discussions that just won’t ever get to Core is a lead decision.
-
Amy Hendrix (sabreuse)
There’s been some talk about doing some Trac cleanup post-3.5 — bringing in new bug gardeners, cleaning up old tickets/reports/workflows, and so on. It’s definitely true that we have way too many open tickets for too long. If you’re interested in helping out with that, I’m sure it would be very welcome!
-
-
Ipstenu (Mika Epstein)
If you guys are seeing more crazy on the forums, don’t assume I saw everything! Please email the WP-forums list
-
Lance Willett
Would like to briefly discuss the Twenty Twelve hotfix and #22856
-
John Blackbourn (johnbillion)
It was briefly mentioned in #wordpress-dev a few days ago that 3.6 could be a one-feature release, concentrating on media again, possibly with a short release cycle. Discuss?
-
John Blackbourn (johnbillion)
Actually, it’s probably too early for 3.6 chat. Feel free to punt for now.
-
-
Paddleman
OMG @ Download counter
Thanks (esp Nacin and Lance) for taking note of my bug reports from RC3 and fixing it in 3.5.
This is my first experience with WordPress upgrade and cant believe how smooth it went. Well done to everyone.
I got a wish list for 3.6. What is the procedure for communicating it?
-
Tom Lynch
I have been doing a bit of digging and I think the Settings API and use of it in Dashboard might be worth a look, I have pulled out a number of tickets to look at:
Looks like the key issues are implementing Settings API in Dashboard, tweaking Settings API and allowing for priority, and removal of Settings.
From a UI perspective implementing a table less css design and reviewing the settings layout for consistency.
-
Andrew Nacin
PHP Warning: Missing argument 2 for wpdb::prepare()
Hello plugin or theme author! You possibly found this post after searching the Internet for the error above: “PHP Warning: Missing argument 2 for wpdb::prepare().”
So, this is a new warning in 3.5. No sites are broken, everything is fine as before. But, this is indeed something you need to look at, because you may be exposing your users to a possible SQL injection vulnerability. Now that’s no fun!
First, if you’re a user and you want to get rid of these errors, you should turn off the displaying of errors in PHP. There are many ways to do this, such as in php.ini, .htaccess, etc. For this, you can just put this in wp-config.php. (Note that hiding errors on production sites is good practice anyway.)
@ini_set('display_errors', 0);If you’re a user, you can stop here. (If you need more help, please don’t comment here, try the helpful Support Forums.) Just be sure to send a link to this post to the developer of the theme or plugin referenced in the error.
Now, developers: Here’s how $wpdb->prepare() is supposed to work:
$wpdb->prepare( "SELECT * FROM table WHERE ID = %d AND name = %s", $id, $name );
See how $id — an integer, presumably — was passed as the second argument? That corresponds to the first placeholder, %d. Then, $name (a string) was passed as the third argument, thus the second placeholder, %s. This makes sure your query is safe, and prevents something like little bobby tables. (Note: the comic is wrong, don’t sanitize — always prepare your queries.)
The problem is, a number of people were calling $wpdb->prepare() with only one argument, like so:
$wpdb->prepare( "SELECT COUNT(*) FROM table" );
See, there’s no parameter (%d, %s, or for floats, %f) in this query. This happens to work fine, but the prepare call isn’t doing anything. You should instead the query directly, as there are no inputs.
But here’s where the problem lies:
$wpdb->prepare( "SELECT * FROM table WHERE id = $id" );
See the problem? That query isn’t secure! You may think you are “preparing” this query, but you’re not — you’re passing $id directly into the query, unprepared. And this, right here, is why $wpdb->prepare() now issues a warning if it isn’t called with more than one argument. Because you can’t prepare a query without more than one argument. Here’s a correct example:
$wpdb->prepare( "SELECT * FROM table WHERE id = %d", $id );
This wasn’t a decision done lightly. We don’t like shoving PHP warnings into the faces of users and developers. But given the potential security risks, we wanted everyone to immediately look at how they are running queries. And, of course, always prepare them properly.
For more: wpdb Codex reference, #22262, and [22429].
-
Samuel Wood (Otto)
Dangit. Stole my ottopress post for tomorrow. Now I have to come up with fresh, original content.
-
Pippin (mordauk)
Damn, stole my Pippin’s Plugins post for tomorrow. Seriously
-
Andrew Nacin
Find something else, suckers.
Lots of juicy stuff in 3.5! Also, make/plugins and make/core could both use content!-
Ipstenu (Mika Epstein)
And he updated the forums… Well hell, I’m having a drink and going to bed!
-
Justin Sternberg
We need comment “like” buttons.
-
tmontg2
lol! too funny. Thanks for the post!
-
-
-
Emil Uzelac
Good one, just submitted this http://wordpress.org/support/topic/warning-missing-argument-2-for-wpdbprepare-3 15 minutes ago. Let me link to this post as well, to help author out
Thanks,
Emil -
chacha102
Because you can’t prepare a query with more than one argument. Here’s a correct example:
I think you mean, you can’t prepare a query without more than one argument.
-
Andrew Nacin
Updated, thanks.
-
-
Brian Layman
Interesting.. So the rule of “Always use prepare on queries” is simply wrong.
It should be “Always use prepare on queries that built with variable arguments.”I’d always thought it did further sanitization of the query string itself, but I suppose that would be really hard to do without blocking some valid query people would inevitably want.
-
Samuel Wood (Otto)
The *vast* majority of problems with this I’ve seen today had variable arguments, but were putting them directly in the strings, like the third code example there. Which basically means that prepare did nothing to protect them.
Previously, prepare(‘string’) returned ‘string’. Now it returns ‘string’ and a warning that you are doing-it-wrong.
-
chacha102
If you check out the source code for wpdb::prepare it really isn’t that interesting.
-
-
Vitor Carvalho
Fantastic explanation Nacin
-
Joost de Valk
Had to chuckle a bit when I found this:
Missing argument 2 for wpdb::prepare(), called in /home/example/public_html/wp-content/plugins/akismet/admin.php
-
rfair404
Thanks Nacin, I started seeing these notices in the last few weeks on several plugins that I use. glad to know what’s going on here.
-
a6april
Thanks Huge Andrew, I had no idea! I am always glad to learn something everyday! I appreciate the quick followup and all of the responses. Have a great day all!
-
Josh
Extremely useful… and “juicy”! Thanks Andrew! Saved me tons of time. Nice to know you guys are on top of security. Thanks again!
-
nomadentech
This is works perfectly, i think similar error will found in another plugins, so we dont need to fear for updating WordPress core.
Thank you,Teguh
-
properwp
Thank you very much! We’re using a modified version of a clunky plugin in the repo and we keep finding new, wonderful problems. Another one of those “probably should have started from scratch” situations!
-
Mark de Scande BlogLines
The only thing here is that it should have been noted some were or it was and i did not see it or i did not read i had the same problem on my Wife site SuperBlogs.co.za but on BlogLines.co.za it all was perfect on SB i just added some dirty code to make it go away
http://wordpress.org/support/topic/err-after-upgrade-to-35?replies=9
But thx for posting it here for us all to see
-
Nashwan Doaqan
Thank You Andrew Nacin , I see many plugins have this PHP warning .
I hope a good life for all plugins authors
-
-
Justin Sternberg
WordPress 3.5 admin columns for custom taxonomies
WordPress 3.5 is here!! If you haven’t played with it yet, go get it!
I’m proud to be listed as a contributor on this release and want to highlight a new feature geared towards developers that I helped work on. If you have checked the register_taxonomy() codex page recently, you may have noticed a new optional argument, ‘show_admin_column.’From the codex:
show_admin_column
(boolean) (optional) Whether to allow automatic creation of taxonomy columns on associated post-types.
Default: falseAs stated, this new argument allows easy registration of taxonomy columns on post (and custom post type) list table screens much like the default tags’ and categories’ columns.
This should make plugin and theme developers happy as they’ll no longer need to build these columns manually.
The new argument in action:
// hook into the init action and call create_activity_taxonomies when it fires add_action( 'init', 'create_activity_taxonomies' ); // create taxonomy, "fitness-type" for the post type "activity" function create_activity_taxonomies() { // Add new taxonomy, make it hierarchical (like categories) $labels = array( 'name' => _x( 'Fitness Types', 'taxonomy general name' ), 'singular_name' => _x( 'Fitness Type', 'taxonomy singular name' ), 'search_items' => __( 'Search Fitness Types' ), 'all_items' => __( 'All Fitness Types' ), 'parent_item' => __( 'Parent Fitness Type' ), 'parent_item_colon' => __( 'Parent Fitness Type:' ), 'edit_item' => __( 'Edit Fitness Type' ), 'update_item' => __( 'Update Fitness Type' ), 'add_new_item' => __( 'Add New Fitness Type' ), 'new_item_name' => __( 'New Fitness Type Name' ), 'menu_name' => __( 'Fitness Type' ), ); register_taxonomy( 'fitness-type', array( 'activity' ), array( 'hierarchical' => true, 'labels' => $labels, 'show_ui' => true, 'show_admin_column' => true, 'query_var' => true, 'rewrite' => array( 'slug' => 'fitness-type' ), ) ); }Another key addition is the “
manage_taxonomies_for_{$post_type}_columns” filter. This allows developers to add a taxonomy column to a post type outside of theregister_taxonomy()function:Example:
add_filter( 'manage_taxonomies_for_activity_columns', 'activity_type_columns' ); function activity_type_columns( $taxonomies ) { $taxonomies[] = 'activity-type'; return $taxonomies; }-
Jon Brown
Cool addition, I had no idea this was coming, thanks for highlighting it.
-
Justin Sternberg
It’s been a bit under the radar with all the amazing new features dropped in 3.5, but I’m glad to give it a bit of a push.
-
-
Frank Bültge
Very usefull; time to dont use the custom class for doing this. Thanks.
-
cdils
Yes! Thank you for highlighting this. Was just winging these columns this week with some Yoast code. Digging this!
-
Lisa Sabin-Wilson
This is really good stuff Justin! show_admin_column makes life a bit easier and cleaner.
-
Justin Sternberg
Thanks a lot Lisa! Any code that makes life easier and cleaner is fine by me.
-
-
cdils
Was playing with this and thought I’d share…If you want to add more than one taxonomy column, add another line with syntax:
$taxonomies[] = ‘second-taxonomy’;
Where {$post_type} is your CPT name
/**Add columns to CPT admin page */
add_filter( ‘manage_taxonomies_for_{$post_type}_columns’, ‘{$post_type}_type_columns’ );
function {$post_type}_type_columns( $taxonomies ) {
$taxonomies[] = ‘first-taxonomy’;
$taxonomies[] = ‘second-taxonomy’;
return $taxonomies;
}Thanks again, Justin. Awesome stuff. Is there a filter for includling a custom field as a column?
-
Justin Sternberg
No there is not. Post meta can take on many forms, so to try to pin down a specific column use-case would undoubtably rule out a large portion of users. But honestly building custom columns for simple forms of post-meta is not too difficult.
-
-
mor10
Excellent! The old way was so verbose and clunky. This looks much cleaner and more approachable.
-
Alex Mills (Viper007Bond)
This is great, thanks! Time to rip a bunch of manually added columns out of my plugins that use custom taxonomies!
-
RiccardoB.
Less code, same result. Useful!
-
Maor Chasen
Lovely! Can’t wait to give it a spin!
-
-
Andrew Nacin
WordPress 3.5 RC6 is out. Please, if you can (and earlier the better), hammer on TinyMCE with the most ridiculous object and embed tags you can find, and anything HTML5. (Here’s a zip for the nightly build.)
What’s important in RC6? After a good first attempt last week (#22790), we took another stab (#22842) at fixing TinyMCE’s handling of, well, ridiculous object and embed tags. Our goal right now is to ensure that nothing breaks in 3.5 that worked in 3.4.2. So, go find your best embed spaghetti* and make sure nothing breaks.**
- Very easy to test: Go to the “Text “tab, paste something in, head to the Visual tab, confirm things don’t look broken, head back to the “Text” tab, see if it looks mangled, head back to Visual, confirm things don’t look broken. Remember, we are looking for regressions, so also check 3.4.2 to see if it occurs there.
** Breaks means the embed disappears in whole or part, or there’s a JavaScript error, or your computer starts smoking. Whitespace and other HTML changes do/will happen (contents may settle during shipping). Of course, your content should never be damaged, as that’s just no fun.
What happened to the last two RCs? We generally try to do a “soft” or “silent” RC at the very end of a cycle. We’re confident we’ve gotten the testing it needs, but we’d like to enter a 24-hour period where there are no more changes to trunk. Having a cleaner version number provides for a good line in the sand, and can help in case some blocker bug report comes in. Of course this time, we’ve stuttered a few times. TinyMCE hell was RC4. A few final changes on Friday (after we decided to not release) resulted in RC5. And the second round of TinyMCE hell is RC6.
This also means our new target is Tuesday, December 11. We’ll again convene at 10 a.m. Eastern to see if the winds are blowing in our direction. (Even NASA needs good weather.)
And hey, on the bright side:
WordPress 3.5 now runs a custom TinyMCE schema tailored to the HTML5 living standard. We audited the whole spec to keep your content intact.
— Daryl Koopersmith (@koop) December 10, 2012
-
Nick
Just updated to WordPress 3.5 RC6 and conducted the above mentioned test… Nothing broken. Looks fine for me!
-
Xavier Borderie
Insane work you’ve all accomplished again, guys! Congratulations and thank you!
-
Ryan Markel
Casual thought: we need HTML-mangle unit tests so we aren’t caught off-guard by TinyMCE weirdness in future releases.
-
Andrew Nacin
Absolutely. We should start thinking about real unit-testing from this angle.
-
Ryan Markel
I would be happy to help with this in the 3.6 cycle.
-
-
-
Jane Wells
I’m thinking that @nacin and @koopersmith should submit a speaking proposal about this experience to the O’Reilly Fluent Conference. Proposals are due today, conference is May in San Francisco. http://fluentconf.com/fluent2013
-
mordauk
Works perfectly for me so far.
-
Ipstenu (Mika Epstein)
Banging on it without any errors so far. I’ve even gone to test my psycho code posts on halfelf. While it doesn’t work when I switch between posts that have a mondo amount of code (like I quote a whole MU plugin), it works better than it did on 3.4.2, so (1) not a regression (2) improvement!
(The tl;dr of “If you have lots and lots of code in posts, tinyMCE is not your friend” remains, and that ain’t us, it’s them.)
-
paolal
Tried to break it with many embeds, but it worked flawlessly. Thanks for all the work you are doing!
-
michaelha
@nacin thanks for the update
-
tjsix
Trying out various combinations I found that if a nested tag inside a parent with attributes will be removed if it is empty, even if it has attributes of it’s own. I’ve tried this with just about every tag I could think of that would potentially be an empty element, i.e. divs, spans, i’s (for icon fonts), anchors all of which could conceivably be an element element and styled with a background image/font via css.
-
Robert Chapin (miqrogroove)
If it also happens in 3.4.2 it is not relelvant to this RC6. Sounds like it was working as expected!
-
helen
Yep, happens in 3.4.2.
-
-
Eric Hoanshelt
Looking good so far!
-
memuller
Tested with some crazy posts from members on my WP Network. There are issues, but I’m pretty sure there are no regressions.
-
Andrew Nacin
The new target for WordPress 3.5′s release is Monday, December 10, at 11 a.m. Eastern time.
I badly wanted to release today, just as I did yesterday, and the day before. I want this thing kicked out to the curb as much as you want it running on your sites. But the entire core team is exhausted, and we’ve made too many changes this week on too little sleep to risk dropping 3.5 without an adequate code freeze and a few days of quiet. #22803 was downright frightening to see, while #22790 was just absurd on a number of levels. I wanted to go to bed at 11 p.m. last night and instead four of us worked until 7 a.m. The responsible voice in my head says without a doubt, that code needs to soak longer (and should probably sit in a corner with a dunce hat on).
Plus, let’s face it, it’s late Friday afternoon on the east coast of the United States. I don’t want to do that to support teams, hosting companies, or translators. In the end, the extra few days can only help.
So: we’re going to branch 3.5 now. I’m currently aiming for a code freeze that lasts 65 hours and fifty-five minutes in length. We will reconvene on Monday at 10 AM Eastern time (1500 UTC) and start working our way through the release checklist.
Tomorrow evening, a few of us will touch base to see if anything has come up we need to deal with. By Sunday morning, we will know whether anything needs to change. Until then, we rest. I know, it’s lame we’re not shipping 3.5 yet. But a few more days will be forgotten sooner than potential egg on our face if we ship it without clear heads.
In the meantime: Go update your WordPress.org profile with your full name so it can make it on the credits page. And enjoy the weekend!
I’ll leave you with this:
Woke up this morning to find @nacin @koop & others still working. Heard they punched a duck? I’m glad I wasn’t awake to witness this.
— Keri Kae Almstead (@kerikaeindc) December 7, 2012
-
Mike Schroder
Heavy hearts is indeed the proper tag for this. Thanks for being willing to make the decision, but even more for your (and the rest of everyone who has been up for nights) sleepless effort.
-
Alex King
A wise (and I’m sure, hard and frustrating) choice.
-
Andrew Nacin
And the rational choice, for sure.
-
Gabriel Reguly
Congratulations on the wise decision of choosing rationaly.
-
-
-
Amy Hendrix (sabreuse)
Mad props to you and the whole 7am crew — take care of both yourselvesa and the release.
-
Matthew Richmond
Sounds like a wise move. Props to you and all the contributors on the incredible work so far!
-
Alex Mills (Viper007Bond)
But a few more days will be forgotten sooner than potential egg on our face if we ship it without clear heads.
Hear hear. Users aren’t going to care if 3.5 is a few days late compared to serious bugs.
-
Matt Wiebe
/me salutes the lead developers and wishes them dreams of, well, just dreams. Because sleep.
-
Shane Pearlman
Dude, thank you for applying common sense. No one will actually remember if it is really today or monday in the scheme of things, but they will always remember when bad things happen.
-
Jeremy Felt
Fantastic job getting it here. Smart call to wait. Thanks to all the 7am-ers!
-
quicoto
Good choice, thanks for all the hard work guys!
-
Luis Rull
Good choice. We need good code, not early one. Keep up with the good work.
-
Syed Balkhi
Can’t wait for it
Keep up the good work. -
Joey Kudish
Great rational and responsible choice. Kudos and mad props for all the long nights!
-
BobDunn-Trainer
Makes total sense… and all I can say is thank you and everyone else for all this hard work!
-
Birgit Olzem
Thank you, for your announcement, Andrew. I know, it was a critial decision for you, but really reasonable! Have a good rest at weekend.
-
jcastaneda
Completely reasonable. It would be like serving uncooked food.
-
Michael Beckwith
Go enjoy the weekend everyone, business can resume Monday.
-
joelwills
Thanks for all your hard wok everyone, much appreciated!
-
Jerry Bates (JerrySarcastic)
Spock would say that this is “…the only logical conclusion.”
-
Richard Tape
“I know, it’s lame we’re not shipping 3.5 yet.”
No. Just no.
It’s not lame. It’s the right choice. It’s the only choice. Thank you, Andrew and everyone else for the ridiculous hours of work you’ve put in to this and all releases. Enjoy your weekend. You’ve deserved it.
-
cjc1867
no pressure but make it perfect as can be but release it when you are ready guys
-
Tony Scott
Better late and right, rather than ontime and wrong (not my phrase, can’t remember from whom)!
-
Philip Arthur Moore
Echoing the sentiments of everyone who has commented before me. Watching #wordpress-dev the last several days has made me realize the sheer amount of work that you guys are putting into getting this out the door. It’s impressive, to say the least.
When it’s all said and done no one will remember a few missed days or deadlines. What they will remember is how much of yourself you’ve given to this release and everyone will applaud you for it and be thankful.
Get some sleep.
-
Jason Spatola
Looks like I’m the lone voice of dissent here. Horrible decision, guys. (Just kidding. Can’t wait until Monday!)
-
marcopako
Thank you guys!
-
Jon Brown
I’ve been keeping track of irc and trac… and my god you guys have been gone HARD for a LONG time. Take a few minutes this weekend to breathe and enjoy… you deserve that and WAY more. Thanks for all the hard work.
-
FAT Media
This was definitely the right call. Anyone who is upset by this decision needs to have their heads examined. Keep up the great work guys and get some freakin sleep!
-
jasontucker
Just remember, beer fixes most things!
HAve a drink and a relaxing weekend all. -
Samuel Wood (Otto)
Too much niceness here.
THIS IS BAD AND YOU SHOULD FEEL BAD.
Also, have a good weekend, and if you happen to mention where you’re going, I may call in a shot for you. Be careful out there folks!
-
Ryan McCue
Heard they punched a duck?
Poor @duck_, he never stood a chance.
-
Dan
A wise decision. High-five to all the core devs, thanks for all your hard work.
-
George Stephanis
I fully support this decision. Unless Keri is reading, in which case OH GOD DON’T BLAME ME, BLAME JORBIN, IT’S ALL HIS FAULT.
And RE: duck punching, no mallards were harmed in the making of WordPress 3.5
-
Konstantin Kovshenin
Good move! Besides, whoever really needs 3.5 are running RC4 anyway.
-
Frank Bültge
Good decision! The people need to test early and the RC is available, who wants to use 3.5.
-
Jonas Bolinder (jond3r)
Anybody else pondering about duck punching and monkey patching? Here’s what Wikipedia has to say.
-
cdils
I am beyond impressed with you guys and the efforts you’re taking to release solid code to the community. Take a big nap and thanks for your hard work.
-
Maor Chasen
Great call. Better be a stable version rather than a buggy one.
-
markroth
This was a very good call. I commend you for that. And I thank you immensely for all the work you’ve done and are doing on WordPress!
-
Abhishek Ghosh
Great move.
`I know, it’s lame we’re not shipping 3.5 yet. But a few more days will be forgotten sooner than potential egg on our face if we ship it without clear heads.’
It is carefulness to make the perfect.
-
-
Andrew Nacin
All hands on deck! Within the next few hours, we need to get http://core.trac.wordpress.org/report/6 to basically zero tickets.
Some of these patches will have a bit of a learning curve, but you can help with testing! And are there a lot of things to test — a near constant stream of patches. We will be in #wordpress-dev for the rest of the day.
We are hoping to do a soft RC4 early evening (so, five or six hours), which still means we can release tomorrow if the stars align. Cross your fingers. Actually, if you can help while crossing your fingers, you can improve the success rate of your own finger-crossing! Woo.
-
pavelevap
Why is so important to hurry and release 3.5 on Wednesday? Trunk is really live, there were many changes which should be tested. One more week would be helpfull, I guess…
-
Andrew Nacin
Software will always have bugs. There will always be one more thing. At some point, you need to ship. If we waited until there were no bugs reported for X number of hours/days, we would never release anything. We have maintenance releases for good reason.
A decision to release is not arbitrary either, and will only be made if we are confident with the stability and current state of trunk. That is not an easy decision to come to, but it eventually needs to happen. “Confidence,” of course, is inherently subjective. But, this is my sixth major release on the core team, and a number of individuals have been around far longer. If the feeling is right and consensus is there, we will launch.
The only stuff we are currently shoring up is media, which is getting stress tested on WordPress.com. Even the changes we make today are getting live-deployed as we go. A team of people are looking through both WP.com support tickets and support forums, not to mention others looking at the WordPress.org support forums. Nothing major is coming up. We’re only dealing with edge cases.
As I said, it’s a feeling. We can get a very good sense of where we are at based on the volume, type, consistency, and repetition of bug reports. Right now, we are only dealing with well-defined edge cases.
We can also quantify this in any number of ways. For example, at this point in the release cycle compared to the same point in 3.4, there are twice the number of installs with the WordPress Beta Tester plugin active and set to “bleeding edge”. There have also been more raw downloads of beta and RC candidates of 3.5 than 3.4, over about the same amount of time (two months and a week or two). Notwithstanding that 3.4 had four betas and 3 RCs (plus a quiet RC4), while we’ve had only 2 betas and 3 RCs.
And so, Wednesday remains our target. Might we slip a day or more? Yes, as of right now it is still possible. A lot of things need to happen — and a lot of other things need to not happen — for us to hit tomorrow. But I would rather it be because of something out of my control — like a suddenly discovered critical bug. So I’m going to do everything in my power to see that we can.
-
Andrew Nacin
We will decide in IRC tomorrow whether we are good to go to release WordPress 3.5. Worth noting we actually recorded this last time:
-
Andrew Nacin
One more note — we do have a fairly strong rule that trunk should sit untouched for a day before release. So, we’ll be stopping commits in a few hours, and won’t have any activity tonight or in the morning in order to make a judgment tomorrow.
-
Peter Westwood
Well said!
-
-
-
Robert Chapin (miqrogroove)
Basically zero tickets. Congrats!
-
Cyndi
Where do we report bugs found? I found one re privacy settings disappeared after having it set not to allow and taking site live can’t change it and I deactivated all plugins. I don’t see privacy anywhere unless I click on Yoast’s plugin to take me there.
-
Andrew Nacin
The old “privacy” setting can be found under Settings > Reading.
-
-
-
-
Andrew Nacin
The short road to 3.5
Good dev chat today. The plan is for RC1 tonight (more on that in a moment). Here’s the current assignments for who is working on what, based on the main 3.5 report. Feel free to help with testing and patching across the board.
- A number of IE7/8/9 issues with media, of varying severity. A number of people are working on this, and more are welcome. The focus is currently IE9 and IE8. Until those are fully working, IE7 should be untouched, as we may just severely degrade the media UI in IE7. #22446
- Mark Jaquith is working on the SimplePie/DOMDocument/kses ticket. #21990
- Dion was to work on the get_home_path() ticket, which is now fixed. #20449
- The general IE audit for 3.5 was done with one more commit. #22467
- The about page and feature pointers need an initial commit. #22455, #22454
- The help text changes need a final review and commit. #22451
- The WP_Image_Editor architecture ticket is still an ongoing conversation between scribu, Marko, and Mike Schroeder. #22356
- Dominik (ocean90) has a patch ready to close out the attachment post type UI ticket. #21391
- Koop is working on the media upload tickets. #22243, #22480
Ongoing things:
- The Tumblr Importer needs beta testers! It now uses their OAuth API, which requires you to create a (simple) app. Link to the beta version. #22422
- Want to test WordPress 3.5? Consider testing the more interesting scenarios: mobile devices, desktop browsers (IE!), right-to-left languages.
Lower priority tickets:
- westi is working on the _wp_translate_postdata() ticket. #22417
- The media tickets here will be worked on over the next few days. #22524, #22282, #22494, #22532, #22512, #22517
- The child theme installation bug is now fixed in trunk. There is a patch with some additional error handling. #22515
Decisions reached:
- Twenty Ten will not be shipped with fresh downloads of WordPress 3.5. It will still be supported (and still reside in core SVN) and will continue to receive updates through the themes directory. #22500
Schedule from here on out:
- Release Candidate 1 today, once we have no more tickets of major severity open.
- Eat turkey tomorrow. I won’t be opening my computer tomorrow. If you’re with family, you shouldn’t either.
- Release Candidate 2 on Monday. At this point, report/6 should ideally be empty (no tickets). WordPress.com is also planning to merge 3.5 on Monday, which should significantly increase our test coverage (and bug reports) for media come next week.
- Release Candidate 3 (assuming there are major bugs fixed after 2) no later than Monday, December 3.
- Which sets us up for a December 5 release, assuming we don’t reach a critical mass of critical issues next week.
[IRC logs]
-
pavelevap
Hmm, what about string freeze? I saw some HUGE i18n commits last night and also About page is not ready. If I remember correctly, there should be at least 3 weeeks available for translators?
-
Andrew Nacin
I tried to go easy on the i18n commits. About page is nearly ready. Strings will be formally frozen in the next 24-36 hours. You’ll have 12 days of freeze including two weekends (which is about our standard time for string freeze).
-
-
Andrew Nacin
Countdown to 3.5 Beta 1
As I covered at the end of the dev chat yesterday (logs), we’re planning for 3.5 Beta 1 next week. This gives us a week to land a lot of things.
I’ve updated the teams and tasks page. Everything is moving along nicely! Solid pace everywhere. There’s also a UI-specific progress report from @lessbloat on make/ui.
Ship early, ship often. This is expected to be a very rough cut beta. I called it “scrappy,” and not in the pugnacious way. After that, the plan is for a new beta every week. By beta 3 or so, major features should be pretty well shored up.
Some background on this: As I mentioned during the chat, I really want to make sure we have strong pre-release participation. After studying the last five release cycles, I noticed that earlier and less stable betas can encourage this. When we ship more polished betas, it seems people pick up on that, and it feels like less testing occurs. Additionally, we’ve sometimes gone a month or more between the first and second beta. Rather than slowing down, beta should be the time we speed up!
So, by week 6 or so, we should be ready to transition out of bug-fix mode and into RC mode. I’m excited! Who’s with me?
-
DaveofDC
I’m sorry — I know I left two posts last weekend and now I can’t find it. Both are same issue. This is in regard of post-by-email — on-going problems. Now my posts seems to disappeared or I’m looking for them in wrong place — I’m positive it was in this page. Anyway, do you have status or view on my problems? Of course, if only know where my posts are.
Thanks.
Dave-
Andrew Nacin
Dave, you posted here: #19960. I have a follow-up question there. (You also posted a comment here, which I’ve deleted now that we’ve chatted here and I’ve pointed you back to #19960.)
-
DaveofDC
I didn’t get any notification email you replied. Will do. I”m traveling now. When I have a few hours, I’ll run one or two tests to make copy of the source codes.
-
-
-
Japh
I’m excited! Hoping to have ImageMagick done for Beta 1 as well if possible.
-
Japh
By “ImageMagick” I’m referring to
convert
-
-
Rev. Voodoo
I’m ready to dive in! – I just hope I have some free time to actually do some testing!
-
Pippin Williamson
Very excited for the first beta!
-
Paddleman, 
tmontg2, 
markroth, 
pavelevap are discussing. 
DaveofDC, 
I’m currently feeling January 2 for a 3.5.1, which gives us a few weeks to fix everything in the pipeline. We could offer a hotfix now for #22985 and #22944, which both screw with data.
Specific 3.5.1 tickets to discuss:
Additional notes on remaining tickets: